[INFO] cloning repository https://github.com/27justin/harpy [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/27justin/harpy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F27justin%2Fharpy", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F27justin%2Fharpy'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 77860326a1fd830e7b72409281c49be18de6e5fd [INFO] checking 27justin/harpy/77860326a1fd830e7b72409281c49be18de6e5fd against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F27justin%2Fharpy" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/27justin/harpy on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/27justin/harpy [INFO] finished tweaking git repo https://github.com/27justin/harpy [INFO] tweaked toml for git repo https://github.com/27justin/harpy written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/27justin/harpy already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 37f0540f703b825074c2d459a0235f33a85102e7cb6a7a97be61e0f7c878cd89 [INFO] running `Command { std: "docker" "start" "-a" "37f0540f703b825074c2d459a0235f33a85102e7cb6a7a97be61e0f7c878cd89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "37f0540f703b825074c2d459a0235f33a85102e7cb6a7a97be61e0f7c878cd89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37f0540f703b825074c2d459a0235f33a85102e7cb6a7a97be61e0f7c878cd89", kill_on_drop: false }` [INFO] [stdout] 37f0540f703b825074c2d459a0235f33a85102e7cb6a7a97be61e0f7c878cd89 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b504215f3978bfb6843b660cfec3f6dcb6aa233010f36912417513c27715caec [INFO] running `Command { std: "docker" "start" "-a" "b504215f3978bfb6843b660cfec3f6dcb6aa233010f36912417513c27715caec", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.96 [INFO] [stderr] Compiling regex-syntax v0.6.26 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Checking no-std-net v0.6.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Checking pnet_base v0.31.0 [INFO] [stderr] Compiling libloading v0.6.7 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking pnet_macros_support v0.31.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Compiling rustls v0.20.6 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling pnet v0.31.0 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking os_str_bytes v6.1.0 [INFO] [stderr] Compiling rlua v0.19.2 [INFO] [stderr] Compiling indexmap v1.8.2 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking clap_lex v0.2.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking spmc v0.3.0 [INFO] [stderr] Compiling hex-literal v0.3.4 [INFO] [stderr] Checking errno v0.2.8 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking pnet_sys v0.31.0 [INFO] [stderr] Compiling aho-corasick v0.7.18 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling rlua-lua54-sys v0.1.2 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking ipnetwork v0.19.0 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Compiling clap_derive v3.1.18 [INFO] [stderr] Compiling pcap v0.9.2 [INFO] [stderr] Compiling pnet_macros v0.31.0 [INFO] [stderr] Checking pnet_datalink v0.31.0 [INFO] [stderr] Checking pnet_packet v0.31.0 [INFO] [stderr] Checking clap v3.1.18 [INFO] [stderr] Checking pnet_transport v0.31.0 [INFO] [stderr] Checking harpy v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sink.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 20 | let (bus_tx, bus_rx) = spmc::channel(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let (internal_tx, internal_rx) = channel(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | Ok(match pnet::datalink::channel(&interface, options)? { [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | Channel::Ethernet(tx, rx) => Sink { [INFO] [stdout] 29 | | network: Mutex::new((tx, rx)), [INFO] [stdout] 30 | | channel: (Mutex::new(internal_tx), Mutex::new(internal_rx)), [INFO] [stdout] ... | [INFO] [stdout] 34 | | _ => panic!("'Tis impossible"), [INFO] [stdout] 35 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine.rs:76:26 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn context(&self, f: F) -> R where F: FnOnce(Context<'_>) -> R { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | self.lua.context(|lua_ctx| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 77 | | f(lua_ctx) [INFO] [stdout] 78 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/types/tcp.rs:77:103 [INFO] [stdout] | [INFO] [stdout] 77 | ...ter().map(|pair| pair.map(|p| p.1).unwrap_or(0)).collect::>(); [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/types/binary.rs:31:64 [INFO] [stdout] | [INFO] [stdout] 31 | let v = table.pairs::().map(|r| r.unwrap().1).collect::>(); [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sink.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 20 | let (bus_tx, bus_rx) = spmc::channel(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let (internal_tx, internal_rx) = channel(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | Ok(match pnet::datalink::channel(&interface, options)? { [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | Channel::Ethernet(tx, rx) => Sink { [INFO] [stdout] 29 | | network: Mutex::new((tx, rx)), [INFO] [stdout] 30 | | channel: (Mutex::new(internal_tx), Mutex::new(internal_rx)), [INFO] [stdout] ... | [INFO] [stdout] 34 | | _ => panic!("'Tis impossible"), [INFO] [stdout] 35 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine.rs:76:26 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn context(&self, f: F) -> R where F: FnOnce(Context<'_>) -> R { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | self.lua.context(|lua_ctx| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 77 | | f(lua_ctx) [INFO] [stdout] 78 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/types/tcp.rs:77:103 [INFO] [stdout] | [INFO] [stdout] 77 | ...ter().map(|pair| pair.map(|p| p.1).unwrap_or(0)).collect::>(); [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/types/binary.rs:31:64 [INFO] [stdout] | [INFO] [stdout] 31 | let v = table.pairs::().map(|r| r.unwrap().1).collect::>(); [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `harpy` (bin "harpy") due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `harpy` (bin "harpy" test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "b504215f3978bfb6843b660cfec3f6dcb6aa233010f36912417513c27715caec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b504215f3978bfb6843b660cfec3f6dcb6aa233010f36912417513c27715caec", kill_on_drop: false }` [INFO] [stdout] b504215f3978bfb6843b660cfec3f6dcb6aa233010f36912417513c27715caec