[INFO] updating cached repository https://github.com/22shubh22/Pong-Tetra [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9c1f82f9108b4f78cddbf2856866c4b17a5f3bcd [INFO] checking 22shubh22/Pong-Tetra/9c1f82f9108b4f78cddbf2856866c4b17a5f3bcd against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F22shubh22%2FPong-Tetra" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/22shubh22/Pong-Tetra on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/22shubh22/Pong-Tetra [INFO] finished tweaking git repo https://github.com/22shubh22/Pong-Tetra [INFO] tweaked toml for git repo https://github.com/22shubh22/Pong-Tetra written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/22shubh22/Pong-Tetra already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1259a696956b2fe19403f62b22f47fc4c0e11bb87d42acdade6f0867823931b2 [INFO] running `Command { std: "docker" "start" "-a" "1259a696956b2fe19403f62b22f47fc4c0e11bb87d42acdade6f0867823931b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1259a696956b2fe19403f62b22f47fc4c0e11bb87d42acdade6f0867823931b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1259a696956b2fe19403f62b22f47fc4c0e11bb87d42acdade6f0867823931b2", kill_on_drop: false }` [INFO] [stdout] 1259a696956b2fe19403f62b22f47fc4c0e11bb87d42acdade6f0867823931b2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 382aa3ca3b54e857a2e81d688eaae936f9039749441e344dc27f7eeaec6c9548 [INFO] running `Command { std: "docker" "start" "-a" "382aa3ca3b54e857a2e81d688eaae936f9039749441e344dc27f7eeaec6c9548", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling libc v0.2.69 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.10 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.4 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling alsa-sys v0.1.2 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling sdl2-sys v0.33.0 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Compiling xml-rs v0.8.2 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling proc-macro-hack v0.5.15 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling gl_generator v0.13.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Compiling minimp3-sys v0.3.2 [INFO] [stderr] Checking ordered-float v1.0.2 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking stb_truetype v0.3.1 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Compiling const-random-macro v0.1.8 [INFO] [stderr] Compiling num-iter v0.1.40 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking linked-hash-map v0.5.2 [INFO] [stderr] Compiling cpal v0.11.0 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Checking rusttype v0.8.3 [INFO] [stderr] Checking const-random v0.1.8 [INFO] [stderr] Compiling vek v0.9.12 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling glow v0.4.0 [INFO] [stderr] Checking slice-deque v0.3.0 [INFO] [stderr] Checking ogg v0.7.0 [INFO] [stderr] Checking deflate v0.8.4 [INFO] [stderr] Compiling hashbrown v0.7.1 [INFO] [stderr] Checking miniz_oxide v0.3.6 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking tinyvec v0.3.3 [INFO] [stderr] Compiling sdl2 v0.33.0 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking xi-unicode v0.2.0 [INFO] [stderr] Checking png v0.16.2 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Checking glyph_brush_layout v0.1.9 [INFO] [stderr] Checking tiff v0.4.0 [INFO] [stderr] Checking twox-hash v1.5.0 [INFO] [stderr] Checking lewton v0.10.1 [INFO] [stderr] Checking minimp3 v0.3.5 [INFO] [stderr] Checking ahash v0.3.2 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking approx v0.1.1 [INFO] [stderr] Checking bytemuck v1.2.0 [INFO] [stderr] Checking static_assertions v0.2.5 [INFO] [stderr] Checking hound v3.4.0 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking claxon v0.4.2 [INFO] [stderr] Checking glyph_brush v0.6.3 [INFO] [stderr] Checking jpeg-decoder v0.1.18 [INFO] [stderr] Checking image v0.23.3 [INFO] [stderr] Compiling thiserror-impl v1.0.15 [INFO] [stderr] Checking thiserror v1.0.15 [INFO] [stderr] Checking rodio v0.11.0 [INFO] [stderr] Checking tetra v0.3.4 [INFO] [stderr] Checking pong v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:151:11 [INFO] [stdout] | [INFO] [stdout] 151 | if(self.ball.position.y <= 0.0 || self.ball.position.y + self.ball.height() >= WINDOW_HEIGHT) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 151 - if(self.ball.position.y <= 0.0 || self.ball.position.y + self.ball.height() >= WINDOW_HEIGHT) [INFO] [stdout] 151 + if self.ball.position.y <= 0.0 || self.ball.position.y + self.ball.height() >= WINDOW_HEIGHT [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 72 | let player1_texture = Texture::new(ctx, "./resources/player1.png")?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let player2_texture = Texture::new(ctx, "./resources/player2.png")?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let ball_texture = Texture::new(ctx, "./resources/ball.png")?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | Ok(GameState { [INFO] [stdout] | ____________^ [INFO] [stdout] 93 | | player1: Entity::new(player1_texture, player1_position), [INFO] [stdout] 94 | | player2: Entity::new(player2_texture, player2_position), [INFO] [stdout] 95 | | ball: Entity::with_velocity(ball_texture, ball_position, ball_velocity), [INFO] [stdout] 96 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pong` (bin "pong") due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:151:11 [INFO] [stdout] | [INFO] [stdout] 151 | if(self.ball.position.y <= 0.0 || self.ball.position.y + self.ball.height() >= WINDOW_HEIGHT) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 151 - if(self.ball.position.y <= 0.0 || self.ball.position.y + self.ball.height() >= WINDOW_HEIGHT) [INFO] [stdout] 151 + if self.ball.position.y <= 0.0 || self.ball.position.y + self.ball.height() >= WINDOW_HEIGHT [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 72 | let player1_texture = Texture::new(ctx, "./resources/player1.png")?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let player2_texture = Texture::new(ctx, "./resources/player2.png")?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let ball_texture = Texture::new(ctx, "./resources/ball.png")?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | Ok(GameState { [INFO] [stdout] | ____________^ [INFO] [stdout] 93 | | player1: Entity::new(player1_texture, player1_position), [INFO] [stdout] 94 | | player2: Entity::new(player2_texture, player2_position), [INFO] [stdout] 95 | | ball: Entity::with_velocity(ball_texture, ball_position, ball_velocity), [INFO] [stdout] 96 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pong` (bin "pong" test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "382aa3ca3b54e857a2e81d688eaae936f9039749441e344dc27f7eeaec6c9548", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "382aa3ca3b54e857a2e81d688eaae936f9039749441e344dc27f7eeaec6c9548", kill_on_drop: false }` [INFO] [stdout] 382aa3ca3b54e857a2e81d688eaae936f9039749441e344dc27f7eeaec6c9548