[INFO] cloning repository https://github.com/21re/rust-geo-booleanop [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/21re/rust-geo-booleanop" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F21re%2Frust-geo-booleanop", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F21re%2Frust-geo-booleanop'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b9bbdbb34ebfa2aaeb99665842e64ede1696ed65 [INFO] checking 21re/rust-geo-booleanop/b9bbdbb34ebfa2aaeb99665842e64ede1696ed65 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F21re%2Frust-geo-booleanop" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/21re/rust-geo-booleanop on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/21re/rust-geo-booleanop [INFO] finished tweaking git repo https://github.com/21re/rust-geo-booleanop [INFO] tweaked toml for git repo https://github.com/21re/rust-geo-booleanop written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 116 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding geo v0.26.0 (latest: v0.28.0) [INFO] [stderr] Adding hash32 v0.2.1 (latest: v0.3.1) [INFO] [stderr] Adding heapless v0.7.17 (latest: v0.8.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding itertools v0.11.0 (latest: v0.13.0) [INFO] [stderr] Adding rstar v0.11.0 (latest: v0.12.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b832050efe0b43393cf6ccc2067ade250839dda803ca7dd9acede9189e6b52a9 [INFO] running `Command { std: "docker" "start" "-a" "b832050efe0b43393cf6ccc2067ade250839dda803ca7dd9acede9189e6b52a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b832050efe0b43393cf6ccc2067ade250839dda803ca7dd9acede9189e6b52a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b832050efe0b43393cf6ccc2067ade250839dda803ca7dd9acede9189e6b52a9", kill_on_drop: false }` [INFO] [stdout] b832050efe0b43393cf6ccc2067ade250839dda803ca7dd9acede9189e6b52a9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5ca65b12543e419a5060d1c1eafba7692bef2a28d4ec09b25b327770b990c2f0 [INFO] running `Command { std: "docker" "start" "-a" "5ca65b12543e419a5060d1c1eafba7692bef2a28d4ec09b25b327770b990c2f0", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking robust v1.1.0 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking float_next_after v1.0.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking geographiclib-rs v0.2.4 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking rstar v0.11.0 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking earcutr v0.4.3 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking geo-types v0.7.13 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking geo-booleanop v0.3.2 (/opt/rustwide/workdir/lib) [INFO] [stderr] Checking geo v0.26.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/boolean/sweep_event.rs:65:17 [INFO] [stdout] | [INFO] [stdout] 61 | other_event: Weak>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Rc::new(SweepEvent { [INFO] [stdout] | _________________^ [INFO] [stdout] 66 | | mutable: RefCell::new(MutablePart { [INFO] [stdout] 67 | | left, [INFO] [stdout] 68 | | other_event, [INFO] [stdout] ... | [INFO] [stdout] 80 | | is_exterior_ring, [INFO] [stdout] 81 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/splay/node.rs:11:18 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn new_boxed(k: K, v: V, l: Option>>, r: Option>>) -> Box> { [INFO] [stdout] | ---- ---- -------------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | Box::new(Node { [INFO] [stdout] | __________________^ [INFO] [stdout] 12 | | key: k, [INFO] [stdout] 13 | | value: v, [INFO] [stdout] 14 | | left: l, [INFO] [stdout] 15 | | right: r, [INFO] [stdout] 16 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/splay/set.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(comparator: C) -> SplaySet { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | SplaySet { [INFO] [stdout] 18 | tree: SplayTree::new(comparator), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/splay/set.rs:74:20 [INFO] [stdout] | [INFO] [stdout] 72 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | IntoIter { [INFO] [stdout] 74 | inner: self.tree.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/splay/tree.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(comparator: C) -> SplayTree { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | root: UnsafeCell::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/splay/tree.rs:299:18 [INFO] [stdout] | [INFO] [stdout] 297 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | IntoIter { [INFO] [stdout] 299 | cur: self.root_mut().take(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `geo-booleanop` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/boolean/sweep_event.rs:65:17 [INFO] [stdout] | [INFO] [stdout] 61 | other_event: Weak>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Rc::new(SweepEvent { [INFO] [stdout] | _________________^ [INFO] [stdout] 66 | | mutable: RefCell::new(MutablePart { [INFO] [stdout] 67 | | left, [INFO] [stdout] 68 | | other_event, [INFO] [stdout] ... | [INFO] [stdout] 80 | | is_exterior_ring, [INFO] [stdout] 81 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/splay/node.rs:11:18 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn new_boxed(k: K, v: V, l: Option>>, r: Option>>) -> Box> { [INFO] [stdout] | ---- ---- -------------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | Box::new(Node { [INFO] [stdout] | __________________^ [INFO] [stdout] 12 | | key: k, [INFO] [stdout] 13 | | value: v, [INFO] [stdout] 14 | | left: l, [INFO] [stdout] 15 | | right: r, [INFO] [stdout] 16 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/splay/set.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(comparator: C) -> SplaySet { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | SplaySet { [INFO] [stdout] 18 | tree: SplayTree::new(comparator), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/splay/set.rs:74:20 [INFO] [stdout] | [INFO] [stdout] 72 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | IntoIter { [INFO] [stdout] 74 | inner: self.tree.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/splay/tree.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(comparator: C) -> SplayTree { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | root: UnsafeCell::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/splay/tree.rs:299:18 [INFO] [stdout] | [INFO] [stdout] 297 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | IntoIter { [INFO] [stdout] 299 | cur: self.root_mut().take(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `geo-booleanop` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "5ca65b12543e419a5060d1c1eafba7692bef2a28d4ec09b25b327770b990c2f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ca65b12543e419a5060d1c1eafba7692bef2a28d4ec09b25b327770b990c2f0", kill_on_drop: false }` [INFO] [stdout] 5ca65b12543e419a5060d1c1eafba7692bef2a28d4ec09b25b327770b990c2f0