[INFO] cloning repository https://github.com/0xprames/succinctlabs-circuit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/0xprames/succinctlabs-circuit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0xprames%2Fsuccinctlabs-circuit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0xprames%2Fsuccinctlabs-circuit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d0ef063b96cea1cf76eacbbc0b6f14cb3dfa5e3f [INFO] checking 0xprames/succinctlabs-circuit/d0ef063b96cea1cf76eacbbc0b6f14cb3dfa5e3f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0xprames%2Fsuccinctlabs-circuit" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/0xprames/succinctlabs-circuit on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/0xprames/succinctlabs-circuit [INFO] finished tweaking git repo https://github.com/0xprames/succinctlabs-circuit [INFO] tweaked toml for git repo https://github.com/0xprames/succinctlabs-circuit written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/0xprames/succinctlabs-circuit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f3eb7cadbc8f6d7acbe6bf9d714f8931537abc247e5c89abb959faa92cde07ba [INFO] running `Command { std: "docker" "start" "-a" "f3eb7cadbc8f6d7acbe6bf9d714f8931537abc247e5c89abb959faa92cde07ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f3eb7cadbc8f6d7acbe6bf9d714f8931537abc247e5c89abb959faa92cde07ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f3eb7cadbc8f6d7acbe6bf9d714f8931537abc247e5c89abb959faa92cde07ba", kill_on_drop: false }` [INFO] [stdout] f3eb7cadbc8f6d7acbe6bf9d714f8931537abc247e5c89abb959faa92cde07ba [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c2450fcb9b157b09b8ed4f420289950957142373b05e9825138f41a86ef68c22 [INFO] running `Command { std: "docker" "start" "-a" "c2450fcb9b157b09b8ed4f420289950957142373b05e9825138f41a86ef68c22", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking uuid v1.5.0 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Checking tokio v1.33.0 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking succinct-circuit v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> src/node.rs:89:16 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(a: Node, b: Node, op: GateOp) -> Self { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `b` [INFO] [stdout] --> src/node.rs:89:25 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(a: Node, b: Node, op: GateOp) -> Self { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Builder` is never constructed [INFO] [stdout] --> src/builder.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Builder { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Builder` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/builder.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 30 | impl Builder { [INFO] [stdout] | ------------ associated items in this implementation [INFO] [stdout] 31 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 43 | pub async fn init(&mut self) -> Arc> { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 52 | pub async fn constant(&mut self, value: u64) -> Node { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 60 | pub async fn add(&mut self, a: Arc>, b: Arc>) -> Arc> { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 88 | pub async fn mul(&mut self, a: Arc>, b: Arc>) -> Arc> { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 117 | pub async fn assert_equal(&mut self, a: Arc>, b: Arc>) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 122 | pub async fn set_input(&mut self, input: Arc>, val: u64) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 142 | pub async fn fill_nodes(&mut self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 158 | fn evaluate(&mut self, children: Vec>>) -> BoxFuture<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 329 | pub async fn check_constraints(&mut self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Input`, `Constant`, and `Dependent` are never constructed [INFO] [stdout] --> src/node.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub enum NodeType { [INFO] [stdout] | -------- variants in this enum [INFO] [stdout] 9 | Input, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 10 | Constant, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 11 | Dependent, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NodeType` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Add` and `Mul` are never constructed [INFO] [stdout] --> src/node.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub enum GateOp { [INFO] [stdout] | ------ variants in this enum [INFO] [stdout] 15 | Add(Uuid, Uuid), [INFO] [stdout] | ^^^ [INFO] [stdout] 16 | Mul(Uuid, Uuid), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GateOp` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Gate` and `Static` are never constructed [INFO] [stdout] --> src/node.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub enum NodeValue { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] 29 | Gate(GateOp), [INFO] [stdout] | ^^^^ [INFO] [stdout] 30 | Static(Option), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NodeValue` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `next` is never read [INFO] [stdout] --> src/node.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 45 | pub struct Node { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 48 | pub next: Vec>>, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Node` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `input`, `constant`, `new`, and `set_next` are never used [INFO] [stdout] --> src/node.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 70 | impl Node { [INFO] [stdout] | --------- associated items in this implementation [INFO] [stdout] 71 | pub fn input() -> Self { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 80 | pub fn constant(val: u64) -> Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 89 | pub fn new(a: Node, b: Node, op: GateOp) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 99 | pub async fn set_next(&mut self, next: Arc>) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 32 | let val_map = Arc::from(RwLock::from(HashMap::new())); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let waiter_map = HashMap::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Builder { [INFO] [stdout] 35 | inputs: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 158 | fn evaluate(&mut self, children: Vec>>) -> BoxFuture<()> { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | / async move { [INFO] [stdout] 160 | | for node in children { [INFO] [stdout] 161 | | // self is behind a (mut) shared ref - thus the clone/capture of these attributes into the tokio task closure [INFO] [stdout] 162 | | let captured_val_map = self.val_map.clone(); [INFO] [stdout] ... | [INFO] [stdout] 322 | | } [INFO] [stdout] 323 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `succinct-circuit` (lib) due to 3 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> src/node.rs:89:16 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(a: Node, b: Node, op: GateOp) -> Self { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `b` [INFO] [stdout] --> src/node.rs:89:25 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn new(a: Node, b: Node, op: GateOp) -> Self { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 32 | let val_map = Arc::from(RwLock::from(HashMap::new())); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let waiter_map = HashMap::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Builder { [INFO] [stdout] 35 | inputs: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 158 | fn evaluate(&mut self, children: Vec>>) -> BoxFuture<()> { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | / async move { [INFO] [stdout] 160 | | for node in children { [INFO] [stdout] 161 | | // self is behind a (mut) shared ref - thus the clone/capture of these attributes into the tokio task closure [INFO] [stdout] 162 | | let captured_val_map = self.val_map.clone(); [INFO] [stdout] ... | [INFO] [stdout] 322 | | } [INFO] [stdout] 323 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `succinct-circuit` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c2450fcb9b157b09b8ed4f420289950957142373b05e9825138f41a86ef68c22", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2450fcb9b157b09b8ed4f420289950957142373b05e9825138f41a86ef68c22", kill_on_drop: false }` [INFO] [stdout] c2450fcb9b157b09b8ed4f420289950957142373b05e9825138f41a86ef68c22