[INFO] cloning repository https://github.com/0xAdk/mm2_tool [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/0xAdk/mm2_tool" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0xAdk%2Fmm2_tool", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0xAdk%2Fmm2_tool'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7cf255b1fbeb994ad0b905c45087e09371f7024f [INFO] checking 0xAdk/mm2_tool/7cf255b1fbeb994ad0b905c45087e09371f7024f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2F0xAdk%2Fmm2_tool" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/0xAdk/mm2_tool on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/0xAdk/mm2_tool [INFO] finished tweaking git repo https://github.com/0xAdk/mm2_tool [INFO] tweaked toml for git repo https://github.com/0xAdk/mm2_tool written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/0xAdk/mm2_tool already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6ae867a1f788635c53436dd882522663e6753bd341b1ab81cec35e0a837a0ee5 [INFO] running `Command { std: "docker" "start" "-a" "6ae867a1f788635c53436dd882522663e6753bd341b1ab81cec35e0a837a0ee5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6ae867a1f788635c53436dd882522663e6753bd341b1ab81cec35e0a837a0ee5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6ae867a1f788635c53436dd882522663e6753bd341b1ab81cec35e0a837a0ee5", kill_on_drop: false }` [INFO] [stdout] 6ae867a1f788635c53436dd882522663e6753bd341b1ab81cec35e0a837a0ee5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1ca2aa03e1be714e5b95fdda0f35d0eafc8e275612cf85cdbb2c35eace75baf7 [INFO] running `Command { std: "docker" "start" "-a" "1ca2aa03e1be714e5b95fdda0f35d0eafc8e275612cf85cdbb2c35eace75baf7", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking bytemuck v1.16.1 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking winnow v0.6.13 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking ordered-float v4.2.1 [INFO] [stderr] Checking vecmap-rs v0.2.1 [INFO] [stderr] Checking serde_json v1.0.120 [INFO] [stderr] Checking mm2_tool v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/haxe/de.rs:162:8 [INFO] [stdout] | [INFO] [stdout] 162 | Ok(Value::Date(date_str.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/haxe/de.rs:203:8 [INFO] [stdout] | [INFO] [stdout] 196 | let mut map = Map::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | Ok(Value::ObjectMap(map)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/haxe/de.rs:291:8 [INFO] [stdout] | [INFO] [stdout] 291 | Ok(object_cache.get(index).unwrap().clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/savetool.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 140 | let version = repeat(1.., alt((one_of('0'..='9'), '.'))); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | delimited('[', version, ']').parse_next(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/haxe/de.rs:162:8 [INFO] [stdout] | [INFO] [stdout] 162 | Ok(Value::Date(date_str.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/haxe/de.rs:203:8 [INFO] [stdout] | [INFO] [stdout] 196 | let mut map = Map::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | Ok(Value::ObjectMap(map)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/haxe/de.rs:291:8 [INFO] [stdout] | [INFO] [stdout] 291 | Ok(object_cache.get(index).unwrap().clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/haxe/tests.rs:232:25 [INFO] [stdout] | [INFO] [stdout] 230 | fn make_struct<'a, const N: usize>(fields: [(&'static str, Value<'a>); N]) -> Value<'a> { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | Value::Struct { [INFO] [stdout] 232 | fields: fields [INFO] [stdout] | _________________________^ [INFO] [stdout] 233 | | .into_iter() [INFO] [stdout] 234 | | .map(|(name, value)| (name.into(), value)) [INFO] [stdout] 235 | | .collect(), [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/haxe/tests.rs:269:25 [INFO] [stdout] | [INFO] [stdout] 265 | fields: [(&'static str, Value<'a>); N], [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 269 | fields: fields [INFO] [stdout] | _________________________^ [INFO] [stdout] 270 | | .into_iter() [INFO] [stdout] 271 | | .map(|(name, value)| (name.into(), value)) [INFO] [stdout] 272 | | .collect(), [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mm2_tool` (bin "mm2_tool") due to 5 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/haxe/tests.rs:312:25 [INFO] [stdout] | [INFO] [stdout] 307 | fields: [Value<'a>; N], [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | fields: fields.into(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/haxe/tests.rs:623:25 [INFO] [stdout] | [INFO] [stdout] 621 | fn make_struct<'a, const N: usize>(fields: [(&'static str, Value<'a>); N]) -> Value<'a> { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 622 | Value::Struct { [INFO] [stdout] 623 | fields: fields [INFO] [stdout] | _________________________^ [INFO] [stdout] 624 | | .into_iter() [INFO] [stdout] 625 | | .map(|(name, value)| (name.into(), value)) [INFO] [stdout] 626 | | .collect(), [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/haxe/tests.rs:660:25 [INFO] [stdout] | [INFO] [stdout] 656 | fields: [(&'static str, Value<'a>); N], [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 660 | fields: fields [INFO] [stdout] | _________________________^ [INFO] [stdout] 661 | | .into_iter() [INFO] [stdout] 662 | | .map(|(name, value)| (name.into(), value)) [INFO] [stdout] 663 | | .collect(), [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/haxe/tests.rs:703:25 [INFO] [stdout] | [INFO] [stdout] 698 | fields: [Value<'a>; N], [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 703 | fields: fields.into(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/savetool.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 140 | let version = repeat(1.., alt((one_of('0'..='9'), '.'))); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | delimited('[', version, ']').parse_next(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mm2_tool` (bin "mm2_tool" test) due to 11 previous errors [INFO] running `Command { std: "docker" "inspect" "1ca2aa03e1be714e5b95fdda0f35d0eafc8e275612cf85cdbb2c35eace75baf7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ca2aa03e1be714e5b95fdda0f35d0eafc8e275612cf85cdbb2c35eace75baf7", kill_on_drop: false }` [INFO] [stdout] 1ca2aa03e1be714e5b95fdda0f35d0eafc8e275612cf85cdbb2c35eace75baf7