[INFO] fetching crate rgy 0.1.0... [INFO] checking rgy-0.1.0 against master#ab869e094a907cc5d19b4080f22eccaf347f1f95 for pr-129604 [INFO] extracting crate rgy 0.1.0 into /workspace/builds/worker-3-tc1/source [INFO] validating manifest of crates.io crate rgy 0.1.0 on toolchain ab869e094a907cc5d19b4080f22eccaf347f1f95 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rgy 0.1.0 [INFO] finished tweaking crates.io crate rgy 0.1.0 [INFO] tweaked toml for crates.io crate rgy 0.1.0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate crates.io crate rgy 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rustyline v4.1.0 [INFO] [stderr] Downloaded core_affinity v0.5.9 [INFO] [stderr] Downloaded gdi32-sys v0.1.2 [INFO] [stderr] Downloaded user32-sys v0.1.3 [INFO] [stderr] Downloaded x11-dl v2.14.0 [INFO] [stderr] Downloaded minifb v0.11.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4486f1e9dd4dc384bc593fcb1595ca2bdf7566d8c8c5470d5dc351165698d7f4 [INFO] running `Command { std: "docker" "start" "-a" "4486f1e9dd4dc384bc593fcb1595ca2bdf7566d8c8c5470d5dc351165698d7f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4486f1e9dd4dc384bc593fcb1595ca2bdf7566d8c8c5470d5dc351165698d7f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4486f1e9dd4dc384bc593fcb1595ca2bdf7566d8c8c5470d5dc351165698d7f4", kill_on_drop: false }` [INFO] [stdout] 4486f1e9dd4dc384bc593fcb1595ca2bdf7566d8c8c5470d5dc351165698d7f4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 34e2b7043cfb83d65e29a589a5c59e2d07ce40dda584405b772dea6aa4f2ad51 [INFO] running `Command { std: "docker" "start" "-a" "34e2b7043cfb83d65e29a589a5c59e2d07ce40dda584405b772dea6aa4f2ad51", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling getrandom v0.1.13 [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.11 [INFO] [stderr] Compiling ppv-lite86 v0.2.6 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling cc v1.0.48 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Compiling nix v0.13.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking arc-swap v0.4.4 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Compiling hashbrown v0.6.3 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking utf8parse v0.1.1 [INFO] [stderr] Checking termcolor v1.0.5 [INFO] [stderr] Compiling c2-chacha v0.2.3 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Compiling x11-dl v2.14.0 [INFO] [stderr] Compiling alsa-sys v0.1.2 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling minifb v0.11.2 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking num_cpus v1.11.1 [INFO] [stderr] Checking signal-hook v0.1.12 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Checking core_affinity v0.5.9 [INFO] [stderr] Checking cpal v0.8.2 [INFO] [stderr] Compiling rand_chacha v0.2.1 [INFO] [stderr] Compiling rand v0.7.2 [INFO] [stderr] Compiling structopt-derive v0.2.18 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Checking structopt v0.2.18 [INFO] [stderr] Checking rustyline v4.1.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.11 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Compiling const-random-macro v0.1.6 [INFO] [stderr] Checking const-random v0.1.6 [INFO] [stderr] Checking ahash v0.2.18 [INFO] [stderr] Checking rgy v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/mbc.rs:751:13 [INFO] [stdout] | [INFO] [stdout] 751 | (addr < 0x100 || (addr >= 0x200 && addr < 0x900)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 751 - (addr < 0x100 || (addr >= 0x200 && addr < 0x900)) [INFO] [stdout] 751 + addr < 0x100 || (addr >= 0x200 && addr < 0x900) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/sound.rs:491:18 [INFO] [stdout] | [INFO] [stdout] 491 | 2 => (amp >> 1), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 491 - 2 => (amp >> 1), [INFO] [stdout] 491 + 2 => amp >> 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/sound.rs:492:18 [INFO] [stdout] | [INFO] [stdout] 492 | 3 => (amp >> 2), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 492 - 3 => (amp >> 2), [INFO] [stdout] 492 + 3 => amp >> 2, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/mbc.rs:751:13 [INFO] [stdout] | [INFO] [stdout] 751 | (addr < 0x100 || (addr >= 0x200 && addr < 0x900)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 751 - (addr < 0x100 || (addr >= 0x200 && addr < 0x900)) [INFO] [stdout] 751 + addr < 0x100 || (addr >= 0x200 && addr < 0x900) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/sound.rs:491:18 [INFO] [stdout] | [INFO] [stdout] 491 | 2 => (amp >> 1), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 491 - 2 => (amp >> 1), [INFO] [stdout] 491 + 2 => amp >> 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/sound.rs:492:18 [INFO] [stdout] | [INFO] [stdout] 492 | 3 => (amp >> 2), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 492 - 3 => (amp >> 2), [INFO] [stdout] 492 + 3 => amp >> 2, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/system.rs:202:29 [INFO] [stdout] | [INFO] [stdout] 202 | run_inner(cfg, rom, hw, Debugger::empty()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 202 | run_inner(cfg, rom, hw, ::empty()) [INFO] [stdout] | ++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/system.rs:202:29 [INFO] [stdout] | [INFO] [stdout] 202 | run_inner(cfg, rom, hw, Debugger::empty()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 202 | run_inner(cfg, rom, hw, ::empty()) [INFO] [stdout] | ++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `freq` is never read [INFO] [stdout] --> src/sound.rs:513:5 [INFO] [stdout] | [INFO] [stdout] 501 | struct Noise { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 513 | freq: usize, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Noise` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `freq` is never read [INFO] [stdout] --> src/sound.rs:513:5 [INFO] [stdout] | [INFO] [stdout] 501 | struct Noise { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 513 | freq: usize, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Noise` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> examples/pc/hardware.rs:286:33 [INFO] [stdout] | [INFO] [stdout] 286 | ... ((s.next(sample_rate) as u64 * 100 / s.max() as u64) as f32 / 100.0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 286 - ((s.next(sample_rate) as u64 * 100 / s.max() as u64) as f32 / 100.0) [INFO] [stdout] 286 + (s.next(sample_rate) as u64 * 100 / s.max() as u64) as f32 / 100.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.45s [INFO] running `Command { std: "docker" "inspect" "34e2b7043cfb83d65e29a589a5c59e2d07ce40dda584405b772dea6aa4f2ad51", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "34e2b7043cfb83d65e29a589a5c59e2d07ce40dda584405b772dea6aa4f2ad51", kill_on_drop: false }` [INFO] [stdout] 34e2b7043cfb83d65e29a589a5c59e2d07ce40dda584405b772dea6aa4f2ad51