[INFO] fetching crate qwiic-lcd-rs 0.1.11... [INFO] checking qwiic-lcd-rs-0.1.11 against master#ab869e094a907cc5d19b4080f22eccaf347f1f95 for pr-129604 [INFO] extracting crate qwiic-lcd-rs 0.1.11 into /workspace/builds/worker-7-tc1/source [INFO] validating manifest of crates.io crate qwiic-lcd-rs 0.1.11 on toolchain ab869e094a907cc5d19b4080f22eccaf347f1f95 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate qwiic-lcd-rs 0.1.11 [INFO] finished tweaking crates.io crate qwiic-lcd-rs 0.1.11 [INFO] tweaked toml for crates.io crate qwiic-lcd-rs 0.1.11 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding i2cdev v0.4.4 (latest: v0.6.1) [INFO] [stderr] Adding nix v0.14.1 (latest: v0.29.0) [INFO] [stderr] Adding num-traits v0.1.43 (latest: v0.2.19) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded i2cdev v0.4.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f17215ac5e2bf5a28e148e4b5d7340a445bfbd9a74066a2cc8434ca88552ad0c [INFO] running `Command { std: "docker" "start" "-a" "f17215ac5e2bf5a28e148e4b5d7340a445bfbd9a74066a2cc8434ca88552ad0c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f17215ac5e2bf5a28e148e4b5d7340a445bfbd9a74066a2cc8434ca88552ad0c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f17215ac5e2bf5a28e148e4b5d7340a445bfbd9a74066a2cc8434ca88552ad0c", kill_on_drop: false }` [INFO] [stdout] f17215ac5e2bf5a28e148e4b5d7340a445bfbd9a74066a2cc8434ca88552ad0c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bca8ffa6446462b38a204c714c96ed1821558ee580b3c3f79ecc6024e8d6c505 [INFO] running `Command { std: "docker" "start" "-a" "bca8ffa6446462b38a204c714c96ed1821558ee580b3c3f79ecc6024e8d6c505", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking i2cdev v0.4.4 [INFO] [stderr] Checking qwiic-lcd-rs v0.1.11 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/lib.rs:188:26 [INFO] [stdout] | [INFO] [stdout] 188 | self.write_block((Command::SettingCommand as u8), block) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 188 - self.write_block((Command::SettingCommand as u8), block) [INFO] [stdout] 188 + self.write_block(Command::SettingCommand as u8, block) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/lib.rs:210:23 [INFO] [stdout] | [INFO] [stdout] 210 | let command = ((Command::SetDDRamAddr as u8) | ((col + row_offsets[row]) as u8)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 210 - let command = ((Command::SetDDRamAddr as u8) | ((col + row_offsets[row]) as u8)); [INFO] [stdout] 210 + let command = (Command::SetDDRamAddr as u8) | ((col + row_offsets[row]) as u8); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/lib.rs:273:40 [INFO] [stdout] | [INFO] [stdout] 273 | self.dev.smbus_write_byte_data((Command::SettingCommand as u8), command)?; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 273 - self.dev.smbus_write_byte_data((Command::SettingCommand as u8), command)?; [INFO] [stdout] 273 + self.dev.smbus_write_byte_data(Command::SettingCommand as u8, command)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/lib.rs:279:40 [INFO] [stdout] | [INFO] [stdout] 279 | self.dev.smbus_write_byte_data((Command::SpecialCommand as u8), command)?; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 279 - self.dev.smbus_write_byte_data((Command::SpecialCommand as u8), command)?; [INFO] [stdout] 279 + self.dev.smbus_write_byte_data(Command::SpecialCommand as u8, command)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/lib.rs:286:24 [INFO] [stdout] | [INFO] [stdout] 286 | return usize::from(((x-in_min) * (out_max-out_min) / (in_max-in_min) + out_min)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 286 - return usize::from(((x-in_min) * (out_max-out_min) / (in_max-in_min) + out_min)); [INFO] [stdout] 286 + return usize::from((x-in_min) * (out_max-out_min) / (in_max-in_min) + out_min); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `max_rows` [INFO] [stdout] --> src/lib.rs:117:16 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn new(max_rows: u8, max_columns: u8) -> ScreenConfig { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_max_rows` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `max_columns` [INFO] [stdout] --> src/lib.rs:117:30 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn new(max_rows: u8, max_columns: u8) -> ScreenConfig { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_max_columns` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/lib.rs:188:26 [INFO] [stdout] | [INFO] [stdout] 188 | self.write_block((Command::SettingCommand as u8), block) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 188 - self.write_block((Command::SettingCommand as u8), block) [INFO] [stdout] 188 + self.write_block(Command::SettingCommand as u8, block) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/lib.rs:210:23 [INFO] [stdout] | [INFO] [stdout] 210 | let command = ((Command::SetDDRamAddr as u8) | ((col + row_offsets[row]) as u8)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 210 - let command = ((Command::SetDDRamAddr as u8) | ((col + row_offsets[row]) as u8)); [INFO] [stdout] 210 + let command = (Command::SetDDRamAddr as u8) | ((col + row_offsets[row]) as u8); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/lib.rs:273:40 [INFO] [stdout] | [INFO] [stdout] 273 | self.dev.smbus_write_byte_data((Command::SettingCommand as u8), command)?; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 273 - self.dev.smbus_write_byte_data((Command::SettingCommand as u8), command)?; [INFO] [stdout] 273 + self.dev.smbus_write_byte_data(Command::SettingCommand as u8, command)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/lib.rs:279:40 [INFO] [stdout] | [INFO] [stdout] 279 | self.dev.smbus_write_byte_data((Command::SpecialCommand as u8), command)?; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 279 - self.dev.smbus_write_byte_data((Command::SpecialCommand as u8), command)?; [INFO] [stdout] 279 + self.dev.smbus_write_byte_data(Command::SpecialCommand as u8, command)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/lib.rs:286:24 [INFO] [stdout] | [INFO] [stdout] 286 | return usize::from(((x-in_min) * (out_max-out_min) / (in_max-in_min) + out_min)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 286 - return usize::from(((x-in_min) * (out_max-out_min) / (in_max-in_min) + out_min)); [INFO] [stdout] 286 + return usize::from((x-in_min) * (out_max-out_min) / (in_max-in_min) + out_min); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 192 | self.write_setting_cmd(Command::ClearDisplay as u8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 192 | let _ = self.write_setting_cmd(Command::ClearDisplay as u8); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/lib.rs:203:49 [INFO] [stdout] | [INFO] [stdout] 203 | if row > self.config.max_rows.into() || row < 0 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/lib.rs:206:52 [INFO] [stdout] | [INFO] [stdout] 206 | if col > self.config.max_columns.into() || col < 0 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `max_rows` [INFO] [stdout] --> src/lib.rs:117:16 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn new(max_rows: u8, max_columns: u8) -> ScreenConfig { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_max_rows` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `max_columns` [INFO] [stdout] --> src/lib.rs:117:30 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn new(max_rows: u8, max_columns: u8) -> ScreenConfig { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_max_columns` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 192 | self.write_setting_cmd(Command::ClearDisplay as u8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 192 | let _ = self.write_setting_cmd(Command::ClearDisplay as u8); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/lib.rs:203:49 [INFO] [stdout] | [INFO] [stdout] 203 | if row > self.config.max_rows.into() || row < 0 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/lib.rs:206:52 [INFO] [stdout] | [INFO] [stdout] 206 | if col > self.config.max_columns.into() || col < 0 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.49s [INFO] running `Command { std: "docker" "inspect" "bca8ffa6446462b38a204c714c96ed1821558ee580b3c3f79ecc6024e8d6c505", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bca8ffa6446462b38a204c714c96ed1821558ee580b3c3f79ecc6024e8d6c505", kill_on_drop: false }` [INFO] [stdout] bca8ffa6446462b38a204c714c96ed1821558ee580b3c3f79ecc6024e8d6c505