[INFO] fetching crate prettytable 0.10.0... [INFO] checking prettytable-0.10.0 against master#ab869e094a907cc5d19b4080f22eccaf347f1f95 for pr-129604 [INFO] extracting crate prettytable 0.10.0 into /workspace/builds/worker-4-tc1/source [INFO] validating manifest of crates.io crate prettytable 0.10.0 on toolchain ab869e094a907cc5d19b4080f22eccaf347f1f95 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate prettytable 0.10.0 [INFO] finished tweaking crates.io crate prettytable 0.10.0 [INFO] tweaked toml for crates.io crate prettytable 0.10.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate crates.io crate prettytable 0.10.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rustversion v1.0.11 [INFO] [stderr] Downloaded cc v1.0.78 [INFO] [stderr] Downloaded thiserror-impl v1.0.38 [INFO] [stderr] Downloaded proc-macro2 v1.0.49 [INFO] [stderr] Downloaded thiserror v1.0.38 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c661fc67c09de1799686df5cc8a227d0afc5611f53ac1a69c0faf274105d683f [INFO] running `Command { std: "docker" "start" "-a" "c661fc67c09de1799686df5cc8a227d0afc5611f53ac1a69c0faf274105d683f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c661fc67c09de1799686df5cc8a227d0afc5611f53ac1a69c0faf274105d683f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c661fc67c09de1799686df5cc8a227d0afc5611f53ac1a69c0faf274105d683f", kill_on_drop: false }` [INFO] [stdout] c661fc67c09de1799686df5cc8a227d0afc5611f53ac1a69c0faf274105d683f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 91b5a8e61b6af9e756f5d4eec30577fa722c8d68cf363bfe3827f6102cfbf55c [INFO] running `Command { std: "docker" "start" "-a" "91b5a8e61b6af9e756f5d4eec30577fa722c8d68cf363bfe3827f6102cfbf55c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling serde v1.0.152 [INFO] [stderr] Compiling io-lifetimes v1.0.3 [INFO] [stderr] Compiling rustix v0.36.6 [INFO] [stderr] Checking linux-raw-sys v0.1.4 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking ryu v1.0.12 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking encode_unicode v1.0.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking is-terminal v0.4.2 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking prettytable v0.10.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/csv.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 20 | for title in self.titles { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 20 | while let Some(title) = self.titles { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 20 | if let Some(title) = self.titles { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/csv.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 20 | for title in self.titles { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 20 | while let Some(title) = self.titles { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 20 | if let Some(title) = self.titles { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.08s [INFO] running `Command { std: "docker" "inspect" "91b5a8e61b6af9e756f5d4eec30577fa722c8d68cf363bfe3827f6102cfbf55c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91b5a8e61b6af9e756f5d4eec30577fa722c8d68cf363bfe3827f6102cfbf55c", kill_on_drop: false }` [INFO] [stdout] 91b5a8e61b6af9e756f5d4eec30577fa722c8d68cf363bfe3827f6102cfbf55c