[INFO] fetching crate parse-js 0.24.0... [INFO] checking parse-js-0.24.0 against master#ab869e094a907cc5d19b4080f22eccaf347f1f95 for pr-129604 [INFO] extracting crate parse-js 0.24.0 into /workspace/builds/worker-0-tc1/source [INFO] validating manifest of crates.io crate parse-js 0.24.0 on toolchain ab869e094a907cc5d19b4080f22eccaf347f1f95 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate parse-js 0.24.0 [INFO] finished tweaking crates.io crate parse-js 0.24.0 [INFO] tweaked toml for crates.io crate parse-js 0.24.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 22 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.7.20 (latest: v1.1.3) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9fd1c41249abb71acf97fdb8bd13b19e2b2861e55f742edec8146b19e2bf6752 [INFO] running `Command { std: "docker" "start" "-a" "9fd1c41249abb71acf97fdb8bd13b19e2b2861e55f742edec8146b19e2bf6752", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9fd1c41249abb71acf97fdb8bd13b19e2b2861e55f742edec8146b19e2bf6752", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9fd1c41249abb71acf97fdb8bd13b19e2b2861e55f742edec8146b19e2bf6752", kill_on_drop: false }` [INFO] [stdout] 9fd1c41249abb71acf97fdb8bd13b19e2b2861e55f742edec8146b19e2bf6752 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bce2263a40ad214296c36eb62f5702091baf9d7694112d803434ab4b7c46a05f [INFO] running `Command { std: "docker" "start" "-a" "bce2263a40ad214296c36eb62f5702091baf9d7694112d803434ab4b7c46a05f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking parse-js v0.24.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/parse/expr.rs:248:36 [INFO] [stdout] | [INFO] [stdout] 248 | pub fn parse_jsx_name(&mut self, ctx: ParseCtx) -> SyntaxResult { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/parse/expr.rs:264:40 [INFO] [stdout] | [INFO] [stdout] 264 | pub fn parse_jsx_tag_name(&mut self, ctx: ParseCtx) -> SyntaxResult> { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/parse/expr.rs:248:36 [INFO] [stdout] | [INFO] [stdout] 248 | pub fn parse_jsx_name(&mut self, ctx: ParseCtx) -> SyntaxResult { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/parse/expr.rs:264:40 [INFO] [stdout] | [INFO] [stdout] 264 | pub fn parse_jsx_tag_name(&mut self, ctx: ParseCtx) -> SyntaxResult> { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/parse/literal.rs:140:56 [INFO] [stdout] | [INFO] [stdout] 140 | pub fn parse_and_normalise_literal_string(&mut self, ctx: ParseCtx) -> SyntaxResult { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/parse/literal.rs:140:56 [INFO] [stdout] | [INFO] [stdout] 140 | pub fn parse_and_normalise_literal_string(&mut self, ctx: ParseCtx) -> SyntaxResult { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `direct_key_name` [INFO] [stdout] --> src/parse/pattern.rs:118:15 [INFO] [stdout] | [INFO] [stdout] 118 | let direct_key_name = match &key { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_direct_key_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `direct_key_name` [INFO] [stdout] --> src/parse/pattern.rs:118:15 [INFO] [stdout] | [INFO] [stdout] 118 | let direct_key_name = match &key { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_direct_key_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/parse/stmt.rs:23:45 [INFO] [stdout] | [INFO] [stdout] 23 | fn parse_import_or_export_name(&mut self, ctx: ParseCtx) -> SyntaxResult { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/parse/stmt.rs:23:45 [INFO] [stdout] | [INFO] [stdout] 23 | fn parse_import_or_export_name(&mut self, ctx: ParseCtx) -> SyntaxResult { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/parse/stmt.rs:102:38 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn parse_stmt_empty(&mut self, ctx: ParseCtx) -> SyntaxResult { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/parse/stmt.rs:102:38 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn parse_stmt_empty(&mut self, ctx: ParseCtx) -> SyntaxResult { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/parse/stmt.rs:151:41 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn parse_stmt_debugger(&mut self, ctx: ParseCtx) -> SyntaxResult { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/parse/stmt.rs:151:41 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn parse_stmt_debugger(&mut self, ctx: ParseCtx) -> SyntaxResult { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `node` [INFO] [stdout] --> src/visit.rs:24:32 [INFO] [stdout] | [INFO] [stdout] 24 | fn on_syntax_down(&mut self, node: &Node, ctl: &mut JourneyControls) {} [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_node` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctl` [INFO] [stdout] --> src/visit.rs:24:45 [INFO] [stdout] | [INFO] [stdout] 24 | fn on_syntax_down(&mut self, node: &Node, ctl: &mut JourneyControls) {} [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `node` [INFO] [stdout] --> src/visit.rs:26:30 [INFO] [stdout] | [INFO] [stdout] 26 | fn on_syntax_up(&mut self, node: &Node) {} [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_node` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `node` [INFO] [stdout] --> src/visit.rs:24:32 [INFO] [stdout] | [INFO] [stdout] 24 | fn on_syntax_down(&mut self, node: &Node, ctl: &mut JourneyControls) {} [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_node` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctl` [INFO] [stdout] --> src/visit.rs:24:45 [INFO] [stdout] | [INFO] [stdout] 24 | fn on_syntax_down(&mut self, node: &Node, ctl: &mut JourneyControls) {} [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `node` [INFO] [stdout] --> src/visit.rs:26:30 [INFO] [stdout] | [INFO] [stdout] 26 | fn on_syntax_up(&mut self, node: &Node) {} [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_node` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `node` [INFO] [stdout] --> src/visit.rs:473:32 [INFO] [stdout] | [INFO] [stdout] 473 | fn on_syntax_down(&mut self, node: &mut Node, ctl: &mut JourneyControls) {} [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_node` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctl` [INFO] [stdout] --> src/visit.rs:473:49 [INFO] [stdout] | [INFO] [stdout] 473 | fn on_syntax_down(&mut self, node: &mut Node, ctl: &mut JourneyControls) {} [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `node` [INFO] [stdout] --> src/visit.rs:475:30 [INFO] [stdout] | [INFO] [stdout] 475 | fn on_syntax_up(&mut self, node: &mut Node) {} [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_node` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `node` [INFO] [stdout] --> src/visit.rs:473:32 [INFO] [stdout] | [INFO] [stdout] 473 | fn on_syntax_down(&mut self, node: &mut Node, ctl: &mut JourneyControls) {} [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_node` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctl` [INFO] [stdout] --> src/visit.rs:473:49 [INFO] [stdout] | [INFO] [stdout] 473 | fn on_syntax_down(&mut self, node: &mut Node, ctl: &mut JourneyControls) {} [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `node` [INFO] [stdout] --> src/visit.rs:475:30 [INFO] [stdout] | [INFO] [stdout] 475 | fn on_syntax_up(&mut self, node: &mut Node) {} [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_node` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `through_char` and `while_not_char` are never used [INFO] [stdout] --> src/lex/mod.rs:148:6 [INFO] [stdout] | [INFO] [stdout] 73 | impl<'a> Lexer<'a> { [INFO] [stdout] | ------------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 148 | fn through_char(&self, c: u8) -> SyntaxResult { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 154 | fn while_not_char(&self, a: u8) -> Match { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `check` is never used [INFO] [stdout] --> src/lex/tests/mod.rs:8:4 [INFO] [stdout] | [INFO] [stdout] 8 | fn check(code: &str, expecteds: &[TokenType], expected_err: Option) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `through_char` and `while_not_char` are never used [INFO] [stdout] --> src/lex/mod.rs:148:6 [INFO] [stdout] | [INFO] [stdout] 73 | impl<'a> Lexer<'a> { [INFO] [stdout] | ------------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 148 | fn through_char(&self, c: u8) -> SyntaxResult { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 154 | fn while_not_char(&self, a: u8) -> Match { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `MaybeToken` that must be used [INFO] [stdout] --> src/parse/class_or_object.rs:45:7 [INFO] [stdout] | [INFO] [stdout] 45 | self.consume_if(TokenType::Semicolon)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 45 | let _ = self.consume_if(TokenType::Semicolon)?; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `MaybeToken` that must be used [INFO] [stdout] --> src/parse/class_or_object.rs:45:7 [INFO] [stdout] | [INFO] [stdout] 45 | self.consume_if(TokenType::Semicolon)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 45 | let _ = self.consume_if(TokenType::Semicolon)?; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `MaybeToken` that must be used [INFO] [stdout] --> src/parse/stmt.rs:582:5 [INFO] [stdout] | [INFO] [stdout] 582 | self.consume_if(TokenType::Semicolon)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 582 | let _ = self.consume_if(TokenType::Semicolon)?; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:273:21 [INFO] [stdout] | [INFO] [stdout] 273 | for name in names { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 273 | while let Some(name) = names { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 273 | if let Some(name) = names { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:730:21 [INFO] [stdout] | [INFO] [stdout] 730 | for name in names { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 730 | while let Some(name) = names { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 730 | if let Some(name) = names { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `MaybeToken` that must be used [INFO] [stdout] --> src/parse/stmt.rs:582:5 [INFO] [stdout] | [INFO] [stdout] 582 | self.consume_if(TokenType::Semicolon)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 582 | let _ = self.consume_if(TokenType::Semicolon)?; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:273:21 [INFO] [stdout] | [INFO] [stdout] 273 | for name in names { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 273 | while let Some(name) = names { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 273 | if let Some(name) = names { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/visit.rs:730:21 [INFO] [stdout] | [INFO] [stdout] 730 | for name in names { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 730 | while let Some(name) = names { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 730 | if let Some(name) = names { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 19 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.24s [INFO] running `Command { std: "docker" "inspect" "bce2263a40ad214296c36eb62f5702091baf9d7694112d803434ab4b7c46a05f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bce2263a40ad214296c36eb62f5702091baf9d7694112d803434ab4b7c46a05f", kill_on_drop: false }` [INFO] [stdout] bce2263a40ad214296c36eb62f5702091baf9d7694112d803434ab4b7c46a05f