[INFO] fetching crate mclr 2.1.0... [INFO] checking mclr-2.1.0 against master#ab869e094a907cc5d19b4080f22eccaf347f1f95 for pr-129604 [INFO] extracting crate mclr 2.1.0 into /workspace/builds/worker-7-tc1/source [INFO] validating manifest of crates.io crate mclr 2.1.0 on toolchain ab869e094a907cc5d19b4080f22eccaf347f1f95 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mclr 2.1.0 [INFO] finished tweaking crates.io crate mclr 2.1.0 [INFO] tweaked toml for crates.io crate mclr 2.1.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 217 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding constant_time_eq v0.1.5 (latest: v0.3.1) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding password-hash v0.4.2 (latest: v0.5.0) [INFO] [stderr] Adding pbkdf2 v0.11.0 (latest: v0.12.2) [INFO] [stderr] Adding tower v0.4.13 (latest: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding zip v0.6.6 (latest: v2.2.0) [INFO] [stderr] Adding zip-extract v0.1.3 (latest: v0.2.1) [INFO] [stderr] Adding zstd v0.11.2+zstd.1.5.2 (latest: v0.13.2) [INFO] [stderr] Adding zstd-safe v5.0.2+zstd.1.5.2 (latest: v7.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zopfli v0.8.1 [INFO] [stderr] Downloaded deflate64 v0.1.9 [INFO] [stderr] Downloaded lockfree-object-pool v0.1.6 [INFO] [stderr] Downloaded lzma-rs v0.3.0 [INFO] [stderr] Downloaded zip v2.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ac15e6a54b21aa4c8d52017bb66c8f00ed6904c5f78c8ff9d1930b8dad882670 [INFO] running `Command { std: "docker" "start" "-a" "ac15e6a54b21aa4c8d52017bb66c8f00ed6904c5f78c8ff9d1930b8dad882670", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ac15e6a54b21aa4c8d52017bb66c8f00ed6904c5f78c8ff9d1930b8dad882670", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac15e6a54b21aa4c8d52017bb66c8f00ed6904c5f78c8ff9d1930b8dad882670", kill_on_drop: false }` [INFO] [stdout] ac15e6a54b21aa4c8d52017bb66c8f00ed6904c5f78c8ff9d1930b8dad882670 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b645bd732dc8a8a439782361944aa6ad67326cd04827b37465d47cc03aa38c5d [INFO] running `Command { std: "docker" "start" "-a" "b645bd732dc8a8a439782361944aa6ad67326cd04827b37465d47cc03aa38c5d", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Compiling zstd-safe v5.0.2+zstd.1.5.2 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking zstd v0.11.2+zstd.1.5.2 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Compiling zip v2.2.0 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking lockfree-object-pool v0.1.6 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking lzma-rs v0.3.0 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Checking deflate64 v0.1.9 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking zopfli v0.8.1 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking zip-extract v0.1.3 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking tar v0.4.41 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking mclr v2.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::fs` [INFO] [stdout] --> src/lib.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | use std::fs; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is a test module, consider adding a `#[cfg(test)]` to the containing module [INFO] [stdout] --> src/lib.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | mod tests { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::Path` [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | use std::path::Path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is a test module, consider adding a `#[cfg(test)]` to the containing module [INFO] [stdout] --> src/lib.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | mod tests { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::mc` [INFO] [stdout] --> src/lib.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | use crate::mc; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is a test module, consider adding a `#[cfg(test)]` to the containing module [INFO] [stdout] --> src/lib.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | mod tests { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::mc::mc::get_compatible_java` [INFO] [stdout] --> src/lib.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | use crate::mc::mc::get_compatible_java; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is a test module, consider adding a `#[cfg(test)]` to the containing module [INFO] [stdout] --> src/lib.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | mod tests { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `CommandAssetsConfig`, `CommandRamConfig`, `CommandResourcesConfig`, and `CommandUserConfig` [INFO] [stdout] --> src/lib.rs:15:45 [INFO] [stdout] | [INFO] [stdout] 15 | use crate::mc::utils::command_builder::{CommandAssetsConfig, CommandRamConfig, CommandResourcesConfig, CommandUserConfig}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is a test module, consider adding a `#[cfg(test)]` to the containing module [INFO] [stdout] --> src/lib.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | mod tests { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::utils::HandleEvent` [INFO] [stdout] --> src/lib.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | use crate::utils::HandleEvent; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is a test module, consider adding a `#[cfg(test)]` to the containing module [INFO] [stdout] --> src/lib.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | mod tests { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::utils::manifest::manifest` [INFO] [stdout] --> src/lib.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | use crate::utils::manifest::manifest; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is a test module, consider adding a `#[cfg(test)]` to the containing module [INFO] [stdout] --> src/lib.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | mod tests { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::utils::sync_utils::sync` [INFO] [stdout] --> src/lib.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | use crate::utils::sync_utils::sync; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: if this is a test module, consider adding a `#[cfg(test)]` to the containing module [INFO] [stdout] --> src/lib.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | mod tests { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `zip::read::ZipFile::<'a>::sanitized_name`: by stripping `..`s from the path, the meaning of paths can change. [INFO] [stdout] `mangled_name` can be used if this behaviour is desirable [INFO] [stdout] --> src/utils/io_utils.rs:94:48 [INFO] [stdout] | [INFO] [stdout] 94 | let outpath = output_dir.join(file.sanitized_name()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `zip::read::ZipFile::<'a>::sanitized_name`: by stripping `..`s from the path, the meaning of paths can change. [INFO] [stdout] `mangled_name` can be used if this behaviour is desirable [INFO] [stdout] --> src/utils/io_utils.rs:94:48 [INFO] [stdout] | [INFO] [stdout] 94 | let outpath = output_dir.join(file.sanitized_name()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/utils/io_utils.rs:3:21 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::{copy, Read}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/utils/io_utils.rs:3:21 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::{copy, Read}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `version_index` [INFO] [stdout] --> src/lib.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 25 | if let Some(version_index) = version_index { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_version_index` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/lib.rs:41:124 [INFO] [stdout] | [INFO] [stdout] 41 | mc::utils::libs_utils::get_libs(&libs_path.clone(), binary_path.as_str(), libs.clone(), HandleEvent::new(move |e| { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `path` and `sha1` are never read [INFO] [stdout] --> src/deserialize/json_version.rs:65:16 [INFO] [stdout] | [INFO] [stdout] 64 | pub struct LibraryDownloadsArtifacts { [INFO] [stdout] | ------------------------- fields in this struct [INFO] [stdout] 65 | pub(crate) path: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 66 | sha1: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LibraryDownloadsArtifacts` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `version` is never read [INFO] [stdout] --> src/deserialize/json_version.rs:77:20 [INFO] [stdout] | [INFO] [stdout] 75 | pub struct LibraryRuleOs { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 76 | pub(crate) name: String, [INFO] [stdout] 77 | #[serde(skip)] version: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LibraryRuleOs` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/deserialize/json_version.rs:89:16 [INFO] [stdout] | [INFO] [stdout] 87 | pub struct Library { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 88 | pub(crate) downloads: Option, [INFO] [stdout] 89 | pub(crate) name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 90 | pub(crate) rules: Option>, [INFO] [stdout] 91 | #[serde(default)] pub(crate) url: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 92 | pub natives: Option, [INFO] [stdout] 93 | #[serde(default)] md5: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 94 | #[serde(default)] sha1: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 95 | #[serde(default)] sha256: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 96 | #[serde(default)] sha521: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 97 | #[serde(default)] size: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 98 | pub(crate) extract: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Library` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `exclude` is never read [INFO] [stdout] --> src/deserialize/json_version.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 101 | pub struct LibraryExtract { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 102 | exclude: Vec [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LibraryExtract` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_customs_libs` is never used [INFO] [stdout] --> src/mc/utils/libs_utils.rs:144:4 [INFO] [stdout] | [INFO] [stdout] 144 | fn get_customs_libs(library: &Library, destination: &str) -> Result<(), Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_os` is never used [INFO] [stdout] --> src/mc/utils/libs_utils.rs:195:4 [INFO] [stdout] | [INFO] [stdout] 195 | fn is_os(def: bool) -> bool { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `fetch_data` is never used [INFO] [stdout] --> src/utils/io_utils.rs:35:4 [INFO] [stdout] | [INFO] [stdout] 35 | fn fetch_data(url: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `compute_sha1` is never used [INFO] [stdout] --> src/utils/io_utils.rs:179:8 [INFO] [stdout] | [INFO] [stdout] 179 | fn compute_sha1>(file_path: P) -> io::Result { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `minecraftArguments` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:9:24 [INFO] [stdout] | [INFO] [stdout] 9 | #[serde(skip)] pub minecraftArguments: (), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `minecraft_arguments` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `inheritsFrom` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:11:27 [INFO] [stdout] | [INFO] [stdout] 11 | #[serde(default)] pub inheritsFrom: String, [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `inherits_from` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `assetIndex` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub assetIndex: AssetsIndex, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `asset_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `compilanceLevel` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:14:27 [INFO] [stdout] | [INFO] [stdout] 14 | #[serde(default)] pub compilanceLevel: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `compilance_level` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `javaVersion` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub javaVersion: JavaVersion, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `java_version` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `mainClass` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub mainClass: String, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `main_class` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `minimumLauncherVersion` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub minimumLauncherVersion: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `minimum_launcher_version` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `releaseTime` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | pub releaseTime: String, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `release_time` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `versionType` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:23:35 [INFO] [stdout] | [INFO] [stdout] 23 | #[serde(rename = "type")] pub versionType: String, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `version_type` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `totalSize` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | pub totalSize: u64, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `total_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `majorVersion` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | pub majorVersion: u32, [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `major_version` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `ClientType` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:119:35 [INFO] [stdout] | [INFO] [stdout] 119 | #[serde(rename = "type")] pub ClientType: String [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `client_type` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `path` and `sha1` are never read [INFO] [stdout] --> src/deserialize/json_version.rs:65:16 [INFO] [stdout] | [INFO] [stdout] 64 | pub struct LibraryDownloadsArtifacts { [INFO] [stdout] | ------------------------- fields in this struct [INFO] [stdout] 65 | pub(crate) path: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 66 | sha1: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LibraryDownloadsArtifacts` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `version` is never read [INFO] [stdout] --> src/deserialize/json_version.rs:77:20 [INFO] [stdout] | [INFO] [stdout] 75 | pub struct LibraryRuleOs { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 76 | pub(crate) name: String, [INFO] [stdout] 77 | #[serde(skip)] version: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LibraryRuleOs` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/deserialize/json_version.rs:89:16 [INFO] [stdout] | [INFO] [stdout] 87 | pub struct Library { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 88 | pub(crate) downloads: Option, [INFO] [stdout] 89 | pub(crate) name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 90 | pub(crate) rules: Option>, [INFO] [stdout] 91 | #[serde(default)] pub(crate) url: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 92 | pub natives: Option, [INFO] [stdout] 93 | #[serde(default)] md5: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 94 | #[serde(default)] sha1: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 95 | #[serde(default)] sha256: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 96 | #[serde(default)] sha521: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 97 | #[serde(default)] size: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 98 | pub(crate) extract: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Library` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `exclude` is never read [INFO] [stdout] --> src/deserialize/json_version.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 101 | pub struct LibraryExtract { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 102 | exclude: Vec [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LibraryExtract` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_customs_libs` is never used [INFO] [stdout] --> src/mc/utils/libs_utils.rs:144:4 [INFO] [stdout] | [INFO] [stdout] 144 | fn get_customs_libs(library: &Library, destination: &str) -> Result<(), Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_os` is never used [INFO] [stdout] --> src/mc/utils/libs_utils.rs:195:4 [INFO] [stdout] | [INFO] [stdout] 195 | fn is_os(def: bool) -> bool { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `fetch_data` is never used [INFO] [stdout] --> src/utils/io_utils.rs:35:4 [INFO] [stdout] | [INFO] [stdout] 35 | fn fetch_data(url: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `compute_sha1` is never used [INFO] [stdout] --> src/utils/io_utils.rs:179:8 [INFO] [stdout] | [INFO] [stdout] 179 | fn compute_sha1>(file_path: P) -> io::Result { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `minecraftArguments` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:9:24 [INFO] [stdout] | [INFO] [stdout] 9 | #[serde(skip)] pub minecraftArguments: (), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `minecraft_arguments` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `inheritsFrom` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:11:27 [INFO] [stdout] | [INFO] [stdout] 11 | #[serde(default)] pub inheritsFrom: String, [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `inherits_from` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `assetIndex` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub assetIndex: AssetsIndex, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `asset_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `compilanceLevel` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:14:27 [INFO] [stdout] | [INFO] [stdout] 14 | #[serde(default)] pub compilanceLevel: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `compilance_level` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `javaVersion` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub javaVersion: JavaVersion, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `java_version` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `mainClass` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub mainClass: String, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `main_class` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `minimumLauncherVersion` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub minimumLauncherVersion: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `minimum_launcher_version` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `releaseTime` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | pub releaseTime: String, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `release_time` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `versionType` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:23:35 [INFO] [stdout] | [INFO] [stdout] 23 | #[serde(rename = "type")] pub versionType: String, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `version_type` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `versionType` should have a snake case name [INFO] [stdout] --> src/deserialize/json_manifest_version.rs:11:35 [INFO] [stdout] | [INFO] [stdout] 11 | #[serde(rename = "type")] pub versionType: String, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `version_type` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `totalSize` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | pub totalSize: u64, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `total_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `releaseTime` should have a snake case name [INFO] [stdout] --> src/deserialize/json_manifest_version.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub releaseTime: String [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `release_time` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `majorVersion` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | pub majorVersion: u32, [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `major_version` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `ClientType` should have a snake case name [INFO] [stdout] --> src/deserialize/json_version.rs:119:35 [INFO] [stdout] | [INFO] [stdout] 119 | #[serde(rename = "type")] pub ClientType: String [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case: `client_type` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `versionType` should have a snake case name [INFO] [stdout] --> src/deserialize/json_manifest_version.rs:11:35 [INFO] [stdout] | [INFO] [stdout] 11 | #[serde(rename = "type")] pub versionType: String, [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `version_type` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `releaseTime` should have a snake case name [INFO] [stdout] --> src/deserialize/json_manifest_version.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub releaseTime: String [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `release_time` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `Library` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:17:28 [INFO] [stdout] | [INFO] [stdout] 17 | let natives = &&lib.clone().natives; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `Library` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:17:28 [INFO] [stdout] | [INFO] [stdout] 17 | let natives = &&lib.clone().natives; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `Library` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:18:38 [INFO] [stdout] | [INFO] [stdout] 18 | if let Some(downloads) = &lib.clone().downloads { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `Library` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:18:38 [INFO] [stdout] | [INFO] [stdout] 18 | if let Some(downloads) = &lib.clone().downloads { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloads` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:35:32 [INFO] [stdout] | [INFO] [stdout] 35 | if let Some(c) = &downloads.clone().classifiers { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&std::option::Option` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:36:51 [INFO] [stdout] | [INFO] [stdout] 36 | let native_key = get_natives_value(natives.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloadsArtifacts` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:39:72 [INFO] [stdout] | [INFO] [stdout] 39 | download(format!("{}/{}", destination, get_resource_name(&n.clone().url).unwrap().as_str()).as_str(), &n.clone().url); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloadsArtifacts` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:39:117 [INFO] [stdout] | [INFO] [stdout] 39 | download(format!("{}/{}", destination, get_resource_name(&n.clone().url).unwrap().as_str()).as_str(), &n.clone().url); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloadsArtifacts` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:40:95 [INFO] [stdout] | [INFO] [stdout] 40 | extract_zip(binary_destination, format!("{}/{}", destination, get_resource_name(&n.clone().url).unwrap().as_str()).as_str()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloads` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:47:32 [INFO] [stdout] | [INFO] [stdout] 47 | if let Some(a) = &downloads.clone().artifact { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `Library` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:48:30 [INFO] [stdout] | [INFO] [stdout] 48 | if let Some(r) = &lib.clone().rules { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloadsArtifacts` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:50:76 [INFO] [stdout] | [INFO] [stdout] 50 | download(format!("{}/{}", destination, get_resource_name(&a.clone().url).unwrap().as_str()).as_str(), &a.clone().url); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloadsArtifacts` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:50:121 [INFO] [stdout] | [INFO] [stdout] 50 | download(format!("{}/{}", destination, get_resource_name(&a.clone().url).unwrap().as_str()).as_str(), &a.clone().url); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloadsArtifacts` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:55:72 [INFO] [stdout] | [INFO] [stdout] 55 | download(format!("{}/{}", destination, get_resource_name(&a.clone().url).unwrap().as_str()).as_str(), &a.clone().url); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloadsArtifacts` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:55:117 [INFO] [stdout] | [INFO] [stdout] 55 | download(format!("{}/{}", destination, get_resource_name(&a.clone().url).unwrap().as_str()).as_str(), &a.clone().url); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloads` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:61:39 [INFO] [stdout] | [INFO] [stdout] 61 | return if let Some(a) = &downloads.clone().artifact { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `Library` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:62:30 [INFO] [stdout] | [INFO] [stdout] 62 | if let Some(r) = &lib.clone().rules { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloadsArtifacts` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:67:77 [INFO] [stdout] | [INFO] [stdout] 67 | ... get_resource_name(&a.clone().url).unwrap() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloadsArtifacts` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:76:66 [INFO] [stdout] | [INFO] [stdout] 76 | ... get_resource_name(&a.clone().url).unwrap() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryNatives` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:90:45 [INFO] [stdout] | [INFO] [stdout] 90 | return if let Some(raw) = &n.clone().windows { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `Library` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:112:29 [INFO] [stdout] | [INFO] [stdout] 112 | let _natives = &&lib.clone().natives; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `Library` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:113:38 [INFO] [stdout] | [INFO] [stdout] 113 | if let Some(downloads) = &lib.clone().downloads { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `FILE` should have a snake case name [INFO] [stdout] --> src/utils/io_utils.rs:157:13 [INFO] [stdout] | [INFO] [stdout] 157 | let FILE: &str = binding.as_str(); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `file` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `json_manifest_version::JsonVersion` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:31:58 [INFO] [stdout] | [INFO] [stdout] 31 | ... if !Path::new(format!("versions/{}", versions.clone().id).as_str()).exists() { fs::create_dir(format!("versions/{}", &versions.clon... [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloads` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:35:32 [INFO] [stdout] | [INFO] [stdout] 35 | if let Some(c) = &downloads.clone().classifiers { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&std::option::Option` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:36:51 [INFO] [stdout] | [INFO] [stdout] 36 | let native_key = get_natives_value(natives.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloadsArtifacts` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:39:72 [INFO] [stdout] | [INFO] [stdout] 39 | download(format!("{}/{}", destination, get_resource_name(&n.clone().url).unwrap().as_str()).as_str(), &n.clone().url); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloadsArtifacts` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:39:117 [INFO] [stdout] | [INFO] [stdout] 39 | download(format!("{}/{}", destination, get_resource_name(&n.clone().url).unwrap().as_str()).as_str(), &n.clone().url); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloadsArtifacts` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:40:95 [INFO] [stdout] | [INFO] [stdout] 40 | extract_zip(binary_destination, format!("{}/{}", destination, get_resource_name(&n.clone().url).unwrap().as_str()).as_str()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloads` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:47:32 [INFO] [stdout] | [INFO] [stdout] 47 | if let Some(a) = &downloads.clone().artifact { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `Library` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:48:30 [INFO] [stdout] | [INFO] [stdout] 48 | if let Some(r) = &lib.clone().rules { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloadsArtifacts` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:50:76 [INFO] [stdout] | [INFO] [stdout] 50 | download(format!("{}/{}", destination, get_resource_name(&a.clone().url).unwrap().as_str()).as_str(), &a.clone().url); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloadsArtifacts` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:50:121 [INFO] [stdout] | [INFO] [stdout] 50 | download(format!("{}/{}", destination, get_resource_name(&a.clone().url).unwrap().as_str()).as_str(), &a.clone().url); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloadsArtifacts` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:55:72 [INFO] [stdout] | [INFO] [stdout] 55 | download(format!("{}/{}", destination, get_resource_name(&a.clone().url).unwrap().as_str()).as_str(), &a.clone().url); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloadsArtifacts` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:55:117 [INFO] [stdout] | [INFO] [stdout] 55 | download(format!("{}/{}", destination, get_resource_name(&a.clone().url).unwrap().as_str()).as_str(), &a.clone().url); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloads` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:61:39 [INFO] [stdout] | [INFO] [stdout] 61 | return if let Some(a) = &downloads.clone().artifact { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `Library` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:62:30 [INFO] [stdout] | [INFO] [stdout] 62 | if let Some(r) = &lib.clone().rules { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `json_manifest_version::JsonVersion` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:31:139 [INFO] [stdout] | [INFO] [stdout] 31 | ...r()).exists() { fs::create_dir(format!("versions/{}", &versions.clone().id)).expect("Cannot create versions dir") } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `json_manifest_version::JsonVersion` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:32:91 [INFO] [stdout] | [INFO] [stdout] 32 | let version = &versions.save_and_load(format!("versions/{}/{}.json", &versions.clone().id, &versions.clone().id).as_str()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `json_manifest_version::JsonVersion` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:32:113 [INFO] [stdout] | [INFO] [stdout] 32 | let version = &versions.save_and_load(format!("versions/{}/{}.json", &versions.clone().id, &versions.clone().id).as_str()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `json_version::JsonVersion` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:38:32 [INFO] [stdout] | [INFO] [stdout] 38 | let libs = &version.clone().libraries; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:41:91 [INFO] [stdout] | [INFO] [stdout] 41 | mc::utils::libs_utils::get_libs(&libs_path.clone(), binary_path.as_str(), libs.clone(), HandleEvent::new(move |e| { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Vec` does not implement `Clone`, so calling `clone` on `&Vec` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 41 - mc::utils::libs_utils::get_libs(&libs_path.clone(), binary_path.as_str(), libs.clone(), HandleEvent::new(move |e| { [INFO] [stdout] 41 + mc::utils::libs_utils::get_libs(&libs_path.clone(), binary_path.as_str(), libs, HandleEvent::new(move |e| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:55:45 [INFO] [stdout] | [INFO] [stdout] 55 | println!("{}", jar_path.as_str().clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloadsArtifacts` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:67:77 [INFO] [stdout] | [INFO] [stdout] 67 | ... get_resource_name(&a.clone().url).unwrap() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryDownloadsArtifacts` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:76:66 [INFO] [stdout] | [INFO] [stdout] 76 | ... get_resource_name(&a.clone().url).unwrap() [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `LibraryNatives` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:90:45 [INFO] [stdout] | [INFO] [stdout] 90 | return if let Some(raw) = &n.clone().windows { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `Library` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:112:29 [INFO] [stdout] | [INFO] [stdout] 112 | let _natives = &&lib.clone().natives; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `Library` instead of cloning the inner type [INFO] [stdout] --> src/mc/utils/libs_utils.rs:113:38 [INFO] [stdout] | [INFO] [stdout] 113 | if let Some(downloads) = &lib.clone().downloads { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `FILE` should have a snake case name [INFO] [stdout] --> src/utils/io_utils.rs:157:13 [INFO] [stdout] | [INFO] [stdout] 157 | let FILE: &str = binding.as_str(); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `file` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 54 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 53 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.64s [INFO] running `Command { std: "docker" "inspect" "b645bd732dc8a8a439782361944aa6ad67326cd04827b37465d47cc03aa38c5d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b645bd732dc8a8a439782361944aa6ad67326cd04827b37465d47cc03aa38c5d", kill_on_drop: false }` [INFO] [stdout] b645bd732dc8a8a439782361944aa6ad67326cd04827b37465d47cc03aa38c5d