[INFO] fetching crate iridium 0.0.33... [INFO] checking iridium-0.0.33 against master#ab869e094a907cc5d19b4080f22eccaf347f1f95 for pr-129604 [INFO] extracting crate iridium 0.0.33 into /workspace/builds/worker-1-tc1/source [INFO] validating manifest of crates.io crate iridium 0.0.33 on toolchain ab869e094a907cc5d19b4080f22eccaf347f1f95 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate iridium 0.0.33 [INFO] finished tweaking crates.io crate iridium 0.0.33 [INFO] tweaked toml for crates.io crate iridium 0.0.33 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 105 packages to latest compatible versions [INFO] [stderr] Adding autocfg v0.1.8 (latest: v1.3.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cast v0.2.7 (latest: v0.3.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding criterion v0.2.11 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.3.1 (latest: v0.5.0) [INFO] [stderr] Adding env_logger v0.5.13 (latest: v0.11.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding itertools v0.8.2 (latest: v0.13.0) [INFO] [stderr] Adding nom v4.2.3 (latest: v7.1.3) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding rand v0.6.5 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (latest: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rand_xoshiro v0.1.0 (latest: v0.6.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding uuid v0.7.4 (latest: v1.10.0) [INFO] [stderr] Adding version_check v0.1.5 (latest: v0.9.5) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding yaml-rust v0.3.5 (latest: v0.4.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded yaml-rust v0.3.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 451b57b62c07b74a20d96a8dbff91c519519d4a6a16790134fb0b83288683f60 [INFO] running `Command { std: "docker" "start" "-a" "451b57b62c07b74a20d96a8dbff91c519519d4a6a16790134fb0b83288683f60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "451b57b62c07b74a20d96a8dbff91c519519d4a6a16790134fb0b83288683f60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "451b57b62c07b74a20d96a8dbff91c519519d4a6a16790134fb0b83288683f60", kill_on_drop: false }` [INFO] [stdout] 451b57b62c07b74a20d96a8dbff91c519519d4a6a16790134fb0b83288683f60 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b38df56d4728b962caf11ecedb1a0b6c49860bf5d5b86dad0a88ba4f3f5964d9 [INFO] running `Command { std: "docker" "start" "-a" "b38df56d4728b962caf11ecedb1a0b6c49860bf5d5b86dad0a88ba4f3f5964d9", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_chacha v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Compiling nom v4.2.3 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking rand_xoshiro v0.1.0 [INFO] [stderr] Checking rand v0.6.5 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking uuid v0.7.4 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking criterion-plot v0.3.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking criterion v0.2.11 [INFO] [stderr] Checking iridium v0.0.33 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/comment_parsers.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / /// Looks for a comment start [INFO] [stdout] 5 | | /// Examples: [INFO] [stdout] | |_------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/directive_parsers.rs:40:1 [INFO] [stdout] | [INFO] [stdout] 40 | /// Will try to parse out any of the Directive forms [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/instruction_parsers.rs:235:1 [INFO] [stdout] | [INFO] [stdout] 235 | /// Will try to parse out any of the Instruction forms [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/label_parsers.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | /// Looks for a user-defined label, such as `label1:` [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/label_parsers.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | /// Looks for a user-defined label, such as `label1:` [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/operand_parsers.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / /// Parser for all numbers, which have to be prefaced with `#` in our assembly language: [INFO] [stdout] 8 | | /// #100 [INFO] [stdout] | |_-------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/operand_parsers.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 | / /// Parser for all floats, which have to be prefaced with `#` in our assembly language: [INFO] [stdout] 31 | | /// #100.0 [INFO] [stdout] | |_---------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `NodeInfo` [INFO] [stdout] --> src/cluster/client.rs:11:15 [INFO] [stdout] | [INFO] [stdout] 11 | use cluster::{NodeInfo}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `NodeAlias` [INFO] [stdout] --> src/cluster/manager.rs:2:15 [INFO] [stdout] | [INFO] [stdout] 2 | use cluster::{NodeAlias, NodeInfo}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/remote/client.rs:80:25 [INFO] [stdout] | [INFO] [stdout] 80 | buf.trim_right(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 80 | buf.trim_end(); [INFO] [stdout] | ~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `register` [INFO] [stdout] --> src/assembler/mod.rs:132:21 [INFO] [stdout] | [INFO] [stdout] 132 | let register = i.get_register_number(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_register` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/client.rs:54:27 [INFO] [stdout] | [INFO] [stdout] 54 | if let Ok(mut hello) = IridiumMessage::hello(alias, &self.bind_port.clone().unwrap()) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `alias` [INFO] [stdout] --> src/cluster/client.rs:183:29 [INFO] [stdout] | [INFO] [stdout] 183 | ... ref alias, [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `alias: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/server.rs:35:33 [INFO] [stdout] | [INFO] [stdout] 35 | ... let mut cmgr_lock = cmgr.read().unwrap(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/server.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | let mut cmgr = connection_manager.clone(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `buf` is never read [INFO] [stdout] --> src/assembler/mod.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct Assembler { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 61 | buf: [u8; 4], [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Assembler` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `symbol_type` is never read [INFO] [stdout] --> src/assembler/symbols.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Symbol { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 5 | symbol_type: SymbolType, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Symbol` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `at` and `application_id` are never read [INFO] [stdout] --> src/vm.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 35 | pub struct VMEvent { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 36 | pub event: VMEventType, [INFO] [stdout] 37 | at: DateTime, [INFO] [stdout] | ^^ [INFO] [stdout] 38 | application_id: Uuid, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VMEvent` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/assembler/mod.rs:134:17 [INFO] [stdout] | [INFO] [stdout] 134 | wtr.write_i16::(value.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 134 | let _ = wtr.write_i16::(value.unwrap()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::str::::trim_right` that must be used [INFO] [stdout] --> src/remote/client.rs:80:21 [INFO] [stdout] | [INFO] [stdout] 80 | buf.trim_right(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this returns the trimmed string as a new slice, without modifying the original [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 80 | let _ = buf.trim_right(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/repl/mod.rs:314:46 [INFO] [stdout] | [INFO] [stdout] 314 | let addr = ip.to_owned() + ":" + port.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 21 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude::*` [INFO] [stdout] --> src/bin/iridium.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/iridium.rs:118:21 [INFO] [stdout] | [INFO] [stdout] 118 | let mut vm = VM::new() [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/iridium.rs:122:21 [INFO] [stdout] | [INFO] [stdout] 122 | let mut rx = repl.rx_pipe.take(); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `PIE_HEADER_LENGTH` and `PIE_HEADER_PREFIX` [INFO] [stdout] --> benches/iridium.rs:6:26 [INFO] [stdout] | [INFO] [stdout] 6 | use iridium::assembler::{PIE_HEADER_LENGTH, PIE_HEADER_PREFIX}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude::*` [INFO] [stdout] --> src/bin/iridium.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/iridium.rs:118:21 [INFO] [stdout] | [INFO] [stdout] 118 | let mut vm = VM::new() [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/iridium.rs:122:21 [INFO] [stdout] | [INFO] [stdout] 122 | let mut rx = repl.rx_pipe.take(); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/comment_parsers.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / /// Looks for a comment start [INFO] [stdout] 5 | | /// Examples: [INFO] [stdout] | |_------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/directive_parsers.rs:40:1 [INFO] [stdout] | [INFO] [stdout] 40 | /// Will try to parse out any of the Directive forms [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/instruction_parsers.rs:235:1 [INFO] [stdout] | [INFO] [stdout] 235 | /// Will try to parse out any of the Instruction forms [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/label_parsers.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | /// Looks for a user-defined label, such as `label1:` [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/label_parsers.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | /// Looks for a user-defined label, such as `label1:` [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/operand_parsers.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / /// Parser for all numbers, which have to be prefaced with `#` in our assembly language: [INFO] [stdout] 8 | | /// #100 [INFO] [stdout] | |_-------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/operand_parsers.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 | / /// Parser for all floats, which have to be prefaced with `#` in our assembly language: [INFO] [stdout] 31 | | /// #100.0 [INFO] [stdout] | |_---------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `NodeInfo` [INFO] [stdout] --> src/cluster/client.rs:11:15 [INFO] [stdout] | [INFO] [stdout] 11 | use cluster::{NodeInfo}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `NodeAlias` [INFO] [stdout] --> src/cluster/manager.rs:2:15 [INFO] [stdout] | [INFO] [stdout] 2 | use cluster::{NodeAlias, NodeInfo}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/remote/client.rs:80:25 [INFO] [stdout] | [INFO] [stdout] 80 | buf.trim_right(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 80 | buf.trim_end(); [INFO] [stdout] | ~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `register` [INFO] [stdout] --> src/assembler/mod.rs:132:21 [INFO] [stdout] | [INFO] [stdout] 132 | let register = i.get_register_number(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_register` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/client.rs:54:27 [INFO] [stdout] | [INFO] [stdout] 54 | if let Ok(mut hello) = IridiumMessage::hello(alias, &self.bind_port.clone().unwrap()) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `alias` [INFO] [stdout] --> src/cluster/client.rs:183:29 [INFO] [stdout] | [INFO] [stdout] 183 | ... ref alias, [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `alias: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/server.rs:35:33 [INFO] [stdout] | [INFO] [stdout] 35 | ... let mut cmgr_lock = cmgr.read().unwrap(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/server.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | let mut cmgr = connection_manager.clone(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `buf` is never read [INFO] [stdout] --> src/assembler/mod.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct Assembler { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 61 | buf: [u8; 4], [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Assembler` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `symbol_type` is never read [INFO] [stdout] --> src/assembler/symbols.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Symbol { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 5 | symbol_type: SymbolType, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Symbol` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `at` and `application_id` are never read [INFO] [stdout] --> src/vm.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 35 | pub struct VMEvent { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 36 | pub event: VMEventType, [INFO] [stdout] 37 | at: DateTime, [INFO] [stdout] | ^^ [INFO] [stdout] 38 | application_id: Uuid, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VMEvent` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/assembler/mod.rs:134:17 [INFO] [stdout] | [INFO] [stdout] 134 | wtr.write_i16::(value.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 134 | let _ = wtr.write_i16::(value.unwrap()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::str::::trim_right` that must be used [INFO] [stdout] --> src/remote/client.rs:80:21 [INFO] [stdout] | [INFO] [stdout] 80 | buf.trim_right(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this returns the trimmed string as a new slice, without modifying the original [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 80 | let _ = buf.trim_right(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/repl/mod.rs:314:46 [INFO] [stdout] | [INFO] [stdout] 314 | let addr = ip.to_owned() + ":" + port.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 21 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.76s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: criterion v0.2.11, nom v4.2.3 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "b38df56d4728b962caf11ecedb1a0b6c49860bf5d5b86dad0a88ba4f3f5964d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b38df56d4728b962caf11ecedb1a0b6c49860bf5d5b86dad0a88ba4f3f5964d9", kill_on_drop: false }` [INFO] [stdout] b38df56d4728b962caf11ecedb1a0b6c49860bf5d5b86dad0a88ba4f3f5964d9