[INFO] fetching crate gavle 0.1.1... [INFO] checking gavle-0.1.1 against master#ab869e094a907cc5d19b4080f22eccaf347f1f95 for pr-129604 [INFO] extracting crate gavle 0.1.1 into /workspace/builds/worker-5-tc1/source [INFO] validating manifest of crates.io crate gavle 0.1.1 on toolchain ab869e094a907cc5d19b4080f22eccaf347f1f95 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gavle 0.1.1 [INFO] finished tweaking crates.io crate gavle 0.1.1 [INFO] tweaked toml for crates.io crate gavle 0.1.1 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 35 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.6.1 (latest: v0.7.6) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding glow v0.11.2 (latest: v0.14.0) [INFO] [stderr] Adding image v0.23.14 (latest: v0.25.2) [INFO] [stderr] Adding num-rational v0.3.2 (latest: v0.4.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded arrayvec v0.6.1 [INFO] [stderr] Downloaded generational-arena v0.2.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8fd935c140c693893692c9e31e2c9738d11b86bb50da50db76791a6ab0c2bf3e [INFO] running `Command { std: "docker" "start" "-a" "8fd935c140c693893692c9e31e2c9738d11b86bb50da50db76791a6ab0c2bf3e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8fd935c140c693893692c9e31e2c9738d11b86bb50da50db76791a6ab0c2bf3e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8fd935c140c693893692c9e31e2c9738d11b86bb50da50db76791a6ab0c2bf3e", kill_on_drop: false }` [INFO] [stdout] 8fd935c140c693893692c9e31e2c9738d11b86bb50da50db76791a6ab0c2bf3e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7c964c8971965ca17a4b7911186ae66fe217f815086d4f098b5827db0a580a82 [INFO] running `Command { std: "docker" "start" "-a" "7c964c8971965ca17a4b7911186ae66fe217f815086d4f098b5827db0a580a82", kill_on_drop: false }` [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking glow v0.11.2 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking arrayvec v0.6.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking generational-arena v0.2.9 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking gavle v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:402:19 [INFO] [stdout] | [INFO] [stdout] 402 | for texture in attachments { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 402 | while let Some(texture) = attachments { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 402 | if let Some(texture) = attachments { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:954:48 [INFO] [stdout] | [INFO] [stdout] 954 | let vertex_shader = descriptor.vertex.shader.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `shader::VertexShader` does not implement `Clone`, so calling `clone` on `&shader::VertexShader` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 954 - let vertex_shader = descriptor.vertex.shader.clone(); [INFO] [stdout] 954 + let vertex_shader = descriptor.vertex.shader; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `shader::VertexShader`, implement `Clone` for it [INFO] [stdout] --> src/shader.rs:61:3 [INFO] [stdout] | [INFO] [stdout] 61 + #[derive(Clone)] [INFO] [stdout] 62 | pub struct $name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:959:49 [INFO] [stdout] | [INFO] [stdout] 959 | let fragment_shader = fragment_state.shader.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `shader::FragmentShader` does not implement `Clone`, so calling `clone` on `&shader::FragmentShader` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 959 - let fragment_shader = fragment_state.shader.clone(); [INFO] [stdout] 959 + let fragment_shader = fragment_state.shader; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `shader::FragmentShader`, implement `Clone` for it [INFO] [stdout] --> src/shader.rs:61:3 [INFO] [stdout] | [INFO] [stdout] 61 + #[derive(Clone)] [INFO] [stdout] 62 | pub struct $name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:254:19 [INFO] [stdout] | [INFO] [stdout] 254 | for texture in &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 254 | while let Some(texture) = &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 254 | if let Some(texture) = &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:256:19 [INFO] [stdout] | [INFO] [stdout] 256 | for texture in &fb.depth_stencil { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 256 | while let Some(texture) = &fb.depth_stencil { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 256 | if let Some(texture) = &fb.depth_stencil { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:292:19 [INFO] [stdout] | [INFO] [stdout] 292 | for texture in &fb.depth_stencil { texture.release_write() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 292 | while let Some(texture) = &fb.depth_stencil { texture.release_write() } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 292 | if let Some(texture) = &fb.depth_stencil { texture.release_write() } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:294:19 [INFO] [stdout] | [INFO] [stdout] 294 | for texture in &fb.depth_stencil { texture.release_read() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 294 | while let Some(texture) = &fb.depth_stencil { texture.release_read() } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 294 | if let Some(texture) = &fb.depth_stencil { texture.release_read() } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 31 | for texture in &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 31 | while let Some(texture) = &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 31 | if let Some(texture) = &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:38:18 [INFO] [stdout] | [INFO] [stdout] 38 | for texture in &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 38 | while let Some(texture) = &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 38 | if let Some(texture) = &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 45 | for texture in &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 45 | while let Some(texture) = &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 45 | if let Some(texture) = &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | for texture in &self.depth_stencil { texture.release_write(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 50 | while let Some(texture) = &self.depth_stencil { texture.release_write(); } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 50 | if let Some(texture) = &self.depth_stencil { texture.release_write(); } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:55:18 [INFO] [stdout] | [INFO] [stdout] 55 | for texture in &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 55 | while let Some(texture) = &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 55 | if let Some(texture) = &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:60:18 [INFO] [stdout] | [INFO] [stdout] 60 | for texture in &self.depth_stencil { texture.release_read(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 60 | while let Some(texture) = &self.depth_stencil { texture.release_read(); } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 60 | if let Some(texture) = &self.depth_stencil { texture.release_read(); } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:402:19 [INFO] [stdout] | [INFO] [stdout] 402 | for texture in attachments { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 402 | while let Some(texture) = attachments { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 402 | if let Some(texture) = attachments { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:954:48 [INFO] [stdout] | [INFO] [stdout] 954 | let vertex_shader = descriptor.vertex.shader.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `shader::VertexShader` does not implement `Clone`, so calling `clone` on `&shader::VertexShader` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 954 - let vertex_shader = descriptor.vertex.shader.clone(); [INFO] [stdout] 954 + let vertex_shader = descriptor.vertex.shader; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `shader::VertexShader`, implement `Clone` for it [INFO] [stdout] --> src/shader.rs:61:3 [INFO] [stdout] | [INFO] [stdout] 61 + #[derive(Clone)] [INFO] [stdout] 62 | pub struct $name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:959:49 [INFO] [stdout] | [INFO] [stdout] 959 | let fragment_shader = fragment_state.shader.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `shader::FragmentShader` does not implement `Clone`, so calling `clone` on `&shader::FragmentShader` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 959 - let fragment_shader = fragment_state.shader.clone(); [INFO] [stdout] 959 + let fragment_shader = fragment_state.shader; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `shader::FragmentShader`, implement `Clone` for it [INFO] [stdout] --> src/shader.rs:61:3 [INFO] [stdout] | [INFO] [stdout] 61 + #[derive(Clone)] [INFO] [stdout] 62 | pub struct $name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:254:19 [INFO] [stdout] | [INFO] [stdout] 254 | for texture in &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 254 | while let Some(texture) = &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 254 | if let Some(texture) = &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:256:19 [INFO] [stdout] | [INFO] [stdout] 256 | for texture in &fb.depth_stencil { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 256 | while let Some(texture) = &fb.depth_stencil { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 256 | if let Some(texture) = &fb.depth_stencil { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:292:19 [INFO] [stdout] | [INFO] [stdout] 292 | for texture in &fb.depth_stencil { texture.release_write() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 292 | while let Some(texture) = &fb.depth_stencil { texture.release_write() } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 292 | if let Some(texture) = &fb.depth_stencil { texture.release_write() } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:294:19 [INFO] [stdout] | [INFO] [stdout] 294 | for texture in &fb.depth_stencil { texture.release_read() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 294 | while let Some(texture) = &fb.depth_stencil { texture.release_read() } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 294 | if let Some(texture) = &fb.depth_stencil { texture.release_read() } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 31 | for texture in &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 31 | while let Some(texture) = &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 31 | if let Some(texture) = &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:38:18 [INFO] [stdout] | [INFO] [stdout] 38 | for texture in &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 38 | while let Some(texture) = &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 38 | if let Some(texture) = &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 45 | for texture in &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 45 | while let Some(texture) = &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 45 | if let Some(texture) = &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | for texture in &self.depth_stencil { texture.release_write(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 50 | while let Some(texture) = &self.depth_stencil { texture.release_write(); } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 50 | if let Some(texture) = &self.depth_stencil { texture.release_write(); } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:55:18 [INFO] [stdout] | [INFO] [stdout] 55 | for texture in &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 55 | while let Some(texture) = &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 55 | if let Some(texture) = &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:60:18 [INFO] [stdout] | [INFO] [stdout] 60 | for texture in &self.depth_stencil { texture.release_read(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 60 | while let Some(texture) = &self.depth_stencil { texture.release_read(); } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 60 | if let Some(texture) = &self.depth_stencil { texture.release_read(); } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.13s [INFO] running `Command { std: "docker" "inspect" "7c964c8971965ca17a4b7911186ae66fe217f815086d4f098b5827db0a580a82", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c964c8971965ca17a4b7911186ae66fe217f815086d4f098b5827db0a580a82", kill_on_drop: false }` [INFO] [stdout] 7c964c8971965ca17a4b7911186ae66fe217f815086d4f098b5827db0a580a82