[INFO] fetching crate game_kernel_utils 0.1.0... [INFO] checking game_kernel_utils-0.1.0 against master#ab869e094a907cc5d19b4080f22eccaf347f1f95 for pr-129604 [INFO] extracting crate game_kernel_utils 0.1.0 into /workspace/builds/worker-4-tc1/source [INFO] validating manifest of crates.io crate game_kernel_utils 0.1.0 on toolchain ab869e094a907cc5d19b4080f22eccaf347f1f95 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate game_kernel_utils 0.1.0 [INFO] finished tweaking crates.io crate game_kernel_utils 0.1.0 [INFO] tweaked toml for crates.io crate game_kernel_utils 0.1.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 40 packages to latest compatible versions [INFO] [stderr] Adding approx v0.3.2 (latest: v0.5.1) [INFO] [stderr] Adding autocfg v0.1.8 (latest: v1.3.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cgmath v0.17.0 (latest: v0.18.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding lock_api v0.1.5 (latest: v0.4.12) [INFO] [stderr] Adding parking_lot v0.6.4 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.3.1 (latest: v0.9.10) [INFO] [stderr] Adding rand v0.5.6 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.6.5 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (latest: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding scopeguard v0.3.3 (latest: v1.2.0) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding smallvec v0.6.14 (latest: v1.13.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7c9c2cb11ccf6c13cdb7a1953e5c93a21e43e4bda06ccaee751d9be82c5362c9 [INFO] running `Command { std: "docker" "start" "-a" "7c9c2cb11ccf6c13cdb7a1953e5c93a21e43e4bda06ccaee751d9be82c5362c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7c9c2cb11ccf6c13cdb7a1953e5c93a21e43e4bda06ccaee751d9be82c5362c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c9c2cb11ccf6c13cdb7a1953e5c93a21e43e4bda06ccaee751d9be82c5362c9", kill_on_drop: false }` [INFO] [stdout] 7c9c2cb11ccf6c13cdb7a1953e5c93a21e43e4bda06ccaee751d9be82c5362c9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8371d8a6ea8f49118cf65073c8f4926d4b1d3b448606aad4a03f287a312d5853 [INFO] running `Command { std: "docker" "start" "-a" "8371d8a6ea8f49118cf65073c8f4926d4b1d3b448606aad4a03f287a312d5853", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling cgmath v0.17.0 [INFO] [stderr] Checking hashbag v0.1.12 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Checking evmap v10.0.2 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking game_kernel_utils v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self::evmap::ShallowCopy` [INFO] [stdout] --> src/hierarchy.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use self::evmap::ShallowCopy; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/hierarchy.rs:116:25 [INFO] [stdout] | [INFO] [stdout] 116 | pre_op: Option<&Fn(&Keytype) -> Result<(), E>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 116 | pre_op: Option<&dyn Fn(&Keytype) -> Result<(), E>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/hierarchy.rs:117:26 [INFO] [stdout] | [INFO] [stdout] 117 | post_op: Option<&Fn(&Keytype) -> Result<(), E>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 117 | post_op: Option<&dyn Fn(&Keytype) -> Result<(), E>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/hierarchy.rs:149:22 [INFO] [stdout] | [INFO] [stdout] 149 | on_removed: &Fn(&Keytype), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 149 | on_removed: &dyn Fn(&Keytype), [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::evmap::ShallowCopy` [INFO] [stdout] --> src/hierarchy.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use self::evmap::ShallowCopy; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/hierarchy.rs:116:25 [INFO] [stdout] | [INFO] [stdout] 116 | pre_op: Option<&Fn(&Keytype) -> Result<(), E>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 116 | pre_op: Option<&dyn Fn(&Keytype) -> Result<(), E>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/hierarchy.rs:117:26 [INFO] [stdout] | [INFO] [stdout] 117 | post_op: Option<&Fn(&Keytype) -> Result<(), E>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 117 | post_op: Option<&dyn Fn(&Keytype) -> Result<(), E>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/hierarchy.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 32 | let (r, mut w) = evmap::new(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/hierarchy.rs:149:22 [INFO] [stdout] | [INFO] [stdout] 149 | on_removed: &Fn(&Keytype), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 149 | on_removed: &dyn Fn(&Keytype), [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/lib.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | / fn get(&self, k: &Q) -> Option<&V> [INFO] [stdout] 83 | | where [INFO] [stdout] 84 | | Self: Sized, [INFO] [stdout] | |____________________^ cannot return without recursing [INFO] [stdout] 85 | { [INFO] [stdout] 86 | self.get(k) [INFO] [stdout] | ----------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] = note: `#[warn(unconditional_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/lib.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | / fn get_mut(&mut self, k: &Q) -> Option<&mut V> [INFO] [stdout] 90 | | where [INFO] [stdout] 91 | | Self: Sized, [INFO] [stdout] | |____________________^ cannot return without recursing [INFO] [stdout] 92 | { [INFO] [stdout] 93 | self.get_mut(k) [INFO] [stdout] | --------------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `current_index` is never read [INFO] [stdout] --> src/lib.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct AutoIndexMap { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 14 | data: Vec, [INFO] [stdout] 15 | current_index: u64, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AutoIndexMap` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/hierarchy.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | recursive_op(hierarchy, child, pre_op, post_op); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 135 | let _ = recursive_op(hierarchy, child, pre_op, post_op); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/hierarchy.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 32 | let (r, mut w) = evmap::new(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/lib.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | / fn get(&self, k: &Q) -> Option<&V> [INFO] [stdout] 83 | | where [INFO] [stdout] 84 | | Self: Sized, [INFO] [stdout] | |____________________^ cannot return without recursing [INFO] [stdout] 85 | { [INFO] [stdout] 86 | self.get(k) [INFO] [stdout] | ----------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] = note: `#[warn(unconditional_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function cannot return without recursing [INFO] [stdout] --> src/lib.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | / fn get_mut(&mut self, k: &Q) -> Option<&mut V> [INFO] [stdout] 90 | | where [INFO] [stdout] 91 | | Self: Sized, [INFO] [stdout] | |____________________^ cannot return without recursing [INFO] [stdout] 92 | { [INFO] [stdout] 93 | self.get_mut(k) [INFO] [stdout] | --------------- recursive call site [INFO] [stdout] | [INFO] [stdout] = help: a `loop` may express intention better if this is on purpose [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `current_index` is never read [INFO] [stdout] --> src/lib.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct AutoIndexMap { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 14 | data: Vec, [INFO] [stdout] 15 | current_index: u64, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AutoIndexMap` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/hierarchy.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | recursive_op(hierarchy, child, pre_op, post_op); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 135 | let _ = recursive_op(hierarchy, child, pre_op, post_op); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.88s [INFO] running `Command { std: "docker" "inspect" "8371d8a6ea8f49118cf65073c8f4926d4b1d3b448606aad4a03f287a312d5853", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8371d8a6ea8f49118cf65073c8f4926d4b1d3b448606aad4a03f287a312d5853", kill_on_drop: false }` [INFO] [stdout] 8371d8a6ea8f49118cf65073c8f4926d4b1d3b448606aad4a03f287a312d5853