[INFO] fetching crate ecsimple 0.1.0... [INFO] checking ecsimple-0.1.0 against master#ab869e094a907cc5d19b4080f22eccaf347f1f95 for pr-129604 [INFO] extracting crate ecsimple 0.1.0 into /workspace/builds/worker-0-tc1/source [INFO] validating manifest of crates.io crate ecsimple 0.1.0 on toolchain ab869e094a907cc5d19b4080f22eccaf347f1f95 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ecsimple 0.1.0 [INFO] finished tweaking crates.io crate ecsimple 0.1.0 [INFO] tweaked toml for crates.io crate ecsimple 0.1.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 70 packages to latest compatible versions [INFO] [stderr] Adding bytes v0.5.6 (latest: v1.7.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded sm3 v0.4.2 [INFO] [stderr] Downloaded asn1obj v0.1.6 [INFO] [stderr] Downloaded asn1obj_codegen v0.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f3d006983f04f0498e70e2271bfa926a904b2a1fa96c44f3a552d2bb99ffebf6 [INFO] running `Command { std: "docker" "start" "-a" "f3d006983f04f0498e70e2271bfa926a904b2a1fa96c44f3a552d2bb99ffebf6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f3d006983f04f0498e70e2271bfa926a904b2a1fa96c44f3a552d2bb99ffebf6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f3d006983f04f0498e70e2271bfa926a904b2a1fa96c44f3a552d2bb99ffebf6", kill_on_drop: false }` [INFO] [stdout] f3d006983f04f0498e70e2271bfa926a904b2a1fa96c44f3a552d2bb99ffebf6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ae2330363e355bc2b100033ce482ee8bbe2d6b86b55c4c91f2c342ece4701fa4 [INFO] running `Command { std: "docker" "start" "-a" "ae2330363e355bc2b100033ce482ee8bbe2d6b86b55c4c91f2c342ece4701fa4", kill_on_drop: false }` [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling iana-time-zone v0.1.60 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling bytes v0.5.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking sm3 v0.4.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling ppv-lite86 v0.2.20 [INFO] [stderr] Compiling chrono v0.4.38 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling asn1obj_codegen v0.1.0 [INFO] [stderr] Checking asn1obj v0.1.6 [INFO] [stderr] Checking ecsimple v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/randop.rs:165:8 [INFO] [stdout] | [INFO] [stdout] 165 | retv[(rnbytes - 1)] |= 1; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 165 - retv[(rnbytes - 1)] |= 1; [INFO] [stdout] 165 + retv[rnbytes - 1] |= 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/bngf2m.rs:498:15 [INFO] [stdout] | [INFO] [stdout] 498 | retv.data[(jdx - (n as usize))] ^= ( zz >> d0) as BValue; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 498 - retv.data[(jdx - (n as usize))] ^= ( zz >> d0) as BValue; [INFO] [stdout] 498 + retv.data[jdx - (n as usize)] ^= ( zz >> d0) as BValue; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/bngf2m.rs:501:16 [INFO] [stdout] | [INFO] [stdout] 501 | retv.data[(jdx - (n as usize) - 1)] ^= zz << d1; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 501 - retv.data[(jdx - (n as usize) - 1)] ^= zz << d1; [INFO] [stdout] 501 + retv.data[jdx - (n as usize) - 1] ^= zz << d1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/bngf2m.rs:549:15 [INFO] [stdout] | [INFO] [stdout] 549 | retv.data[(n as usize)] ^= zz << d0; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 549 - retv.data[(n as usize)] ^= zz << d0; [INFO] [stdout] 549 + retv.data[n as usize] ^= zz << d0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/bngf2m.rs:684:15 [INFO] [stdout] | [INFO] [stdout] 684 | retvdata[(kidx - addi as usize)] |= self.data[kidx] >> addb; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 684 - retvdata[(kidx - addi as usize)] |= self.data[kidx] >> addb; [INFO] [stdout] 684 + retvdata[kidx - addi as usize] |= self.data[kidx] >> addb; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/bngf2m.rs:685:15 [INFO] [stdout] | [INFO] [stdout] 685 | retvdata[(kidx - addi as usize - 1)] |= self.data[kidx] << ( BVALUE_BITS - addb as usize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 685 - retvdata[(kidx - addi as usize - 1)] |= self.data[kidx] << ( BVALUE_BITS - addb as usize); [INFO] [stdout] 685 + retvdata[kidx - addi as usize - 1] |= self.data[kidx] << ( BVALUE_BITS - addb as usize); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/bngf2m.rs:690:14 [INFO] [stdout] | [INFO] [stdout] 690 | retvdata[(kidx- addi as usize)] |= self.data[kidx]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 690 - retvdata[(kidx- addi as usize)] |= self.data[kidx]; [INFO] [stdout] 690 + retvdata[kidx- addi as usize] |= self.data[kidx]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/randop.rs:165:8 [INFO] [stdout] | [INFO] [stdout] 165 | retv[(rnbytes - 1)] |= 1; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 165 - retv[(rnbytes - 1)] |= 1; [INFO] [stdout] 165 + retv[rnbytes - 1] |= 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/bngf2m.rs:498:15 [INFO] [stdout] | [INFO] [stdout] 498 | retv.data[(jdx - (n as usize))] ^= ( zz >> d0) as BValue; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 498 - retv.data[(jdx - (n as usize))] ^= ( zz >> d0) as BValue; [INFO] [stdout] 498 + retv.data[jdx - (n as usize)] ^= ( zz >> d0) as BValue; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/bngf2m.rs:501:16 [INFO] [stdout] | [INFO] [stdout] 501 | retv.data[(jdx - (n as usize) - 1)] ^= zz << d1; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 501 - retv.data[(jdx - (n as usize) - 1)] ^= zz << d1; [INFO] [stdout] 501 + retv.data[jdx - (n as usize) - 1] ^= zz << d1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/bngf2m.rs:549:15 [INFO] [stdout] | [INFO] [stdout] 549 | retv.data[(n as usize)] ^= zz << d0; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 549 - retv.data[(n as usize)] ^= zz << d0; [INFO] [stdout] 549 + retv.data[n as usize] ^= zz << d0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/bngf2m.rs:684:15 [INFO] [stdout] | [INFO] [stdout] 684 | retvdata[(kidx - addi as usize)] |= self.data[kidx] >> addb; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 684 - retvdata[(kidx - addi as usize)] |= self.data[kidx] >> addb; [INFO] [stdout] 684 + retvdata[kidx - addi as usize] |= self.data[kidx] >> addb; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/bngf2m.rs:685:15 [INFO] [stdout] | [INFO] [stdout] 685 | retvdata[(kidx - addi as usize - 1)] |= self.data[kidx] << ( BVALUE_BITS - addb as usize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 685 - retvdata[(kidx - addi as usize - 1)] |= self.data[kidx] << ( BVALUE_BITS - addb as usize); [INFO] [stdout] 685 + retvdata[kidx - addi as usize - 1] |= self.data[kidx] << ( BVALUE_BITS - addb as usize); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/bngf2m.rs:690:14 [INFO] [stdout] | [INFO] [stdout] 690 | retvdata[(kidx- addi as usize)] |= self.data[kidx]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 690 - retvdata[(kidx- addi as usize)] |= self.data[kidx]; [INFO] [stdout] 690 + retvdata[kidx- addi as usize] |= self.data[kidx]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `x`, `y`, and `z` are never used [INFO] [stdout] --> src/group.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 22 | pub (crate) trait ECGroupInterface { [INFO] [stdout] | ---------------- methods in this trait [INFO] [stdout] 23 | fn x(&self) -> BigInt ; [INFO] [stdout] | ^ [INFO] [stdout] 24 | fn y(&self) -> BigInt ; [INFO] [stdout] | ^ [INFO] [stdout] 25 | fn z(&self) -> BigInt ; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils.rs:27:10 [INFO] [stdout] | [INFO] [stdout] 27 | bs = bn2.clone().to_vec(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/keys.rs:1088:14 [INFO] [stdout] | [INFO] [stdout] 1088 | idvec = idv.clone().to_vec(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `x`, `y`, and `z` are never used [INFO] [stdout] --> src/group.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 22 | pub (crate) trait ECGroupInterface { [INFO] [stdout] | ---------------- methods in this trait [INFO] [stdout] 23 | fn x(&self) -> BigInt ; [INFO] [stdout] | ^ [INFO] [stdout] 24 | fn y(&self) -> BigInt ; [INFO] [stdout] | ^ [INFO] [stdout] 25 | fn z(&self) -> BigInt ; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/utils.rs:27:10 [INFO] [stdout] | [INFO] [stdout] 27 | bs = bn2.clone().to_vec(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/keys.rs:1088:14 [INFO] [stdout] | [INFO] [stdout] 1088 | idvec = idv.clone().to_vec(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.69s [INFO] running `Command { std: "docker" "inspect" "ae2330363e355bc2b100033ce482ee8bbe2d6b86b55c4c91f2c342ece4701fa4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae2330363e355bc2b100033ce482ee8bbe2d6b86b55c4c91f2c342ece4701fa4", kill_on_drop: false }` [INFO] [stdout] ae2330363e355bc2b100033ce482ee8bbe2d6b86b55c4c91f2c342ece4701fa4