[INFO] cloning repository https://github.com/diegopy/p2pcontroller [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/diegopy/p2pcontroller" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdiegopy%2Fp2pcontroller", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdiegopy%2Fp2pcontroller'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f8a5ca754dec34101c33f0474082368162050481 [INFO] checking diegopy/p2pcontroller/f8a5ca754dec34101c33f0474082368162050481 against master#ab869e094a907cc5d19b4080f22eccaf347f1f95 for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdiegopy%2Fp2pcontroller" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/diegopy/p2pcontroller on toolchain ab869e094a907cc5d19b4080f22eccaf347f1f95 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/diegopy/p2pcontroller [INFO] finished tweaking git repo https://github.com/diegopy/p2pcontroller [INFO] tweaked toml for git repo https://github.com/diegopy/p2pcontroller written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/diegopy/p2pcontroller already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap_derive v3.1.4 [INFO] [stderr] Downloaded clap v3.1.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6ff2f0843f4839f791c3b121512818a9f6ae6923954c6bb909b41df1da4c5aea [INFO] running `Command { std: "docker" "start" "-a" "6ff2f0843f4839f791c3b121512818a9f6ae6923954c6bb909b41df1da4c5aea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6ff2f0843f4839f791c3b121512818a9f6ae6923954c6bb909b41df1da4c5aea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6ff2f0843f4839f791c3b121512818a9f6ae6923954c6bb909b41df1da4c5aea", kill_on_drop: false }` [INFO] [stdout] 6ff2f0843f4839f791c3b121512818a9f6ae6923954c6bb909b41df1da4c5aea [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cdfc4ed257c140962f056cd9657f09134b983523d74a10f1efa3dea40fc48bdb [INFO] running `Command { std: "docker" "start" "-a" "cdfc4ed257c140962f056cd9657f09134b983523d74a10f1efa3dea40fc48bdb", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling libc v0.2.119 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling rustversion v1.0.6 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling parking_lot_core v0.9.1 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling anyhow v1.0.55 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking num_threads v0.1.3 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking lock_api v0.4.6 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking mio v0.8.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling clap_derive v3.1.4 [INFO] [stderr] Compiling strum_macros v0.24.0 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking strum v0.24.0 [INFO] [stderr] Checking clap v3.1.5 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking time v0.3.7 [INFO] [stderr] Checking p2pcontroller v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `de` [INFO] [stdout] --> src/network/mod.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | use serde::{de, Deserialize, Deserializer}; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `de` [INFO] [stdout] --> src/network/mod.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | use serde::{de, Deserialize, Deserializer}; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/network/controller.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | config: Config, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/network/controller.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | config: Config, [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `state` is never read [INFO] [stdout] --> src/network/controller.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 37 | pub struct NetworkController { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 41 | state: Arc, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `feedback_peer_alive` is never used [INFO] [stdout] --> src/network/controller.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 44 | impl NetworkController { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 94 | pub fn feedback_peer_alive(&self, address: SocketAddr, is_outgoing: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `in_alive_count`, `in_handshacking_count`, and `set_peer_alive` are never used [INFO] [stdout] --> src/network/controller.rs:243:12 [INFO] [stdout] | [INFO] [stdout] 235 | impl ControllerState { [INFO] [stdout] | -------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 243 | pub fn in_alive_count(&self) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 247 | pub fn in_handshacking_count(&self) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 306 | pub fn set_peer_alive(&self, address: SocketAddr, is_outgoing: bool) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `OutConnecting`, `OutAlive`, and `InAlive` are never constructed [INFO] [stdout] --> src/network/peer.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub enum PeerState { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] 9 | Idle, //we know about the peer but we aren't currently doing anything with it [INFO] [stdout] 10 | OutConnecting, //we are currently trying to establish an outgoing TCP connection to the peer [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 11 | OutHandshaking, //we are currently handshaking with a peeer after having established and outgoing TCP connection to it [INFO] [stdout] 12 | OutAlive, //we have an outgoing TCP connection to the peer and the handshake is done, the peer is functional [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 13 | InHandshaking, //we are currently handshaking with a peeer after this peer established a TCP connection towards our node [INFO] [stdout] 14 | InAlive, //the peer has established a TCP connection towards us and the handshake is done, the peer is functional [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PeerState` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_alive` is never used [INFO] [stdout] --> src/network/peer.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 25 | impl Peer { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 69 | pub fn set_alive(&mut self, is_outgoing: bool) -> StateChange { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/network/controller.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | self.state.set_peer_alive(address, is_outgoing); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 95 | let _ = self.state.set_peer_alive(address, is_outgoing); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `state` is never read [INFO] [stdout] --> src/network/controller.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 37 | pub struct NetworkController { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 41 | state: Arc, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `feedback_peer_alive` is never used [INFO] [stdout] --> src/network/controller.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 44 | impl NetworkController { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 94 | pub fn feedback_peer_alive(&self, address: SocketAddr, is_outgoing: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `in_alive_count`, `in_handshacking_count`, and `set_peer_alive` are never used [INFO] [stdout] --> src/network/controller.rs:243:12 [INFO] [stdout] | [INFO] [stdout] 235 | impl ControllerState { [INFO] [stdout] | -------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 243 | pub fn in_alive_count(&self) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 247 | pub fn in_handshacking_count(&self) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 306 | pub fn set_peer_alive(&self, address: SocketAddr, is_outgoing: bool) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `OutConnecting`, `OutAlive`, and `InAlive` are never constructed [INFO] [stdout] --> src/network/peer.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub enum PeerState { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] 9 | Idle, //we know about the peer but we aren't currently doing anything with it [INFO] [stdout] 10 | OutConnecting, //we are currently trying to establish an outgoing TCP connection to the peer [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 11 | OutHandshaking, //we are currently handshaking with a peeer after having established and outgoing TCP connection to it [INFO] [stdout] 12 | OutAlive, //we have an outgoing TCP connection to the peer and the handshake is done, the peer is functional [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 13 | InHandshaking, //we are currently handshaking with a peeer after this peer established a TCP connection towards our node [INFO] [stdout] 14 | InAlive, //the peer has established a TCP connection towards us and the handshake is done, the peer is functional [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PeerState` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_alive` is never used [INFO] [stdout] --> src/network/peer.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 25 | impl Peer { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 69 | pub fn set_alive(&mut self, is_outgoing: bool) -> StateChange { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/network/controller.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | self.state.set_peer_alive(address, is_outgoing); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 95 | let _ = self.state.set_peer_alive(address, is_outgoing); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.16s [INFO] running `Command { std: "docker" "inspect" "cdfc4ed257c140962f056cd9657f09134b983523d74a10f1efa3dea40fc48bdb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cdfc4ed257c140962f056cd9657f09134b983523d74a10f1efa3dea40fc48bdb", kill_on_drop: false }` [INFO] [stdout] cdfc4ed257c140962f056cd9657f09134b983523d74a10f1efa3dea40fc48bdb