[INFO] cloning repository https://github.com/connorwstein/exchange [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/connorwstein/exchange" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconnorwstein%2Fexchange", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconnorwstein%2Fexchange'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 680e880e82c8faa753b2b359fcf89eb50348115c [INFO] checking connorwstein/exchange/680e880e82c8faa753b2b359fcf89eb50348115c against master#ab869e094a907cc5d19b4080f22eccaf347f1f95 for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconnorwstein%2Fexchange" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/connorwstein/exchange on toolchain ab869e094a907cc5d19b4080f22eccaf347f1f95 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/connorwstein/exchange [INFO] finished tweaking git repo https://github.com/connorwstein/exchange [INFO] tweaked toml for git repo https://github.com/connorwstein/exchange written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/connorwstein/exchange already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded diesel v1.4.3 [INFO] [stderr] Downloaded libc v0.2.64 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 31098d7bab2232ed7fb3d91094d46a64d0af30d2531e1773db1f75d0dec17e59 [INFO] running `Command { std: "docker" "start" "-a" "31098d7bab2232ed7fb3d91094d46a64d0af30d2531e1773db1f75d0dec17e59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "31098d7bab2232ed7fb3d91094d46a64d0af30d2531e1773db1f75d0dec17e59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "31098d7bab2232ed7fb3d91094d46a64d0af30d2531e1773db1f75d0dec17e59", kill_on_drop: false }` [INFO] [stdout] 31098d7bab2232ed7fb3d91094d46a64d0af30d2531e1773db1f75d0dec17e59 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2b06339cd7b58410a46b44aac62f1917a91f6ed92a27102f918a7e2a5285127c [INFO] running `Command { std: "docker" "start" "-a" "2b06339cd7b58410a46b44aac62f1917a91f6ed92a27102f918a7e2a5285127c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.64 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking futures v0.1.29 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Compiling proc-macro2 v1.0.5 [INFO] [stderr] Checking smallvec v0.6.10 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling syn v1.0.5 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Compiling getrandom v0.1.13 [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Compiling serde v1.0.102 [INFO] [stderr] Checking lock_api v0.3.1 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling pq-sys v0.4.6 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling indexmap v1.3.0 [INFO] [stderr] Checking unicode-normalization v0.1.8 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking termcolor v1.0.5 [INFO] [stderr] Compiling memoffset v0.5.1 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Compiling hyper v0.12.35 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking idna v0.2.0 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Checking mio v0.6.19 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Checking tokio-executor v0.1.8 [INFO] [stderr] Checking tokio-sync v0.1.7 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking want v0.2.0 [INFO] [stderr] Checking tokio-io v0.1.12 [INFO] [stderr] Checking http v0.1.19 [INFO] [stderr] Checking string v0.2.1 [INFO] [stderr] Checking tokio-buf v0.1.1 [INFO] [stderr] Checking tokio-current-thread v0.1.6 [INFO] [stderr] Checking tokio-timer v0.2.11 [INFO] [stderr] Checking tokio-threadpool v0.1.16 [INFO] [stderr] Checking url v2.1.0 [INFO] [stderr] Checking tokio-reactor v0.1.10 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Checking h2 v0.1.26 [INFO] [stderr] Checking http-body v0.1.0 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Compiling serde_derive v1.0.102 [INFO] [stderr] Compiling diesel_derives v1.4.1 [INFO] [stderr] Checking diesel v1.4.3 [INFO] [stderr] Checking serde_json v1.0.41 [INFO] [stderr] Checking uuid v0.8.1 [INFO] [stderr] Checking exchange v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `FillResult` [INFO] [stdout] --> src/order_book.rs:258:29 [INFO] [stdout] | [INFO] [stdout] 258 | use crate::order_book::{FillResult, OpenLimitOrder, OrderBook, Side, Symbol}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/order_book.rs:306:10 [INFO] [stdout] | [INFO] [stdout] 306 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `payload` [INFO] [stdout] --> src/main.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | let payload = String::new(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_payload` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `payload` [INFO] [stdout] --> src/main.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | let payload = String::new(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_payload` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `order_request` [INFO] [stdout] --> src/main.rs:146:25 [INFO] [stdout] | [INFO] [stdout] 146 | Err(order_request) => Box::new(future::ok( [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_order_request` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `side` [INFO] [stdout] --> src/order_book.rs:450:26 [INFO] [stdout] | [INFO] [stdout] 450 | fn create_order_book(side: Side, orders: Vec) -> OrderBook { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_side` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `payload` [INFO] [stdout] --> src/main.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | let payload = String::new(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_payload` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `payload` [INFO] [stdout] --> src/main.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | let payload = String::new(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_payload` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `order_request` [INFO] [stdout] --> src/main.rs:146:25 [INFO] [stdout] | [INFO] [stdout] 146 | Err(order_request) => Box::new(future::ok( [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_order_request` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `find_order` and `remove_order` are never used [INFO] [stdout] --> src/order_book.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 43 | impl OrderBook { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn find_order(&self, t: OpenLimitOrder) -> (Option, Option) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 68 | pub fn remove_order(&mut self, t: OpenLimitOrder) -> Result<&'static str, &'static str> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/order_book.rs:198:32 [INFO] [stdout] | [INFO] [stdout] 198 | panic!(result); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{:?}" format string to use the `Debug` implementation of `Result` [INFO] [stdout] | [INFO] [stdout] 198 | panic!("{:?}", result); [INFO] [stdout] | +++++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 198 | std::panic::panic_any(result); [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/order_book.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 217 | / self.add_order(OpenLimitOrder { [INFO] [stdout] 218 | | id: last_order.id, [INFO] [stdout] 219 | | price: last_order.price, [INFO] [stdout] 220 | | side: last_order.side, [INFO] [stdout] 221 | | amount: remaining.abs() as u32, [INFO] [stdout] 222 | | symbol: last_order.symbol, [INFO] [stdout] 223 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 217 | let _ = self.add_order(OpenLimitOrder { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/order_book.rs:242:46 [INFO] [stdout] | [INFO] [stdout] 242 | let mut orders_used = orders_used.clone().to_vec(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[OpenLimitOrder]` does not implement `Clone`, so calling `clone` on `&[OpenLimitOrder]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/order_book.rs:198:32 [INFO] [stdout] | [INFO] [stdout] 198 | panic!(result); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{:?}" format string to use the `Debug` implementation of `Result` [INFO] [stdout] | [INFO] [stdout] 198 | panic!("{:?}", result); [INFO] [stdout] | +++++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 198 | std::panic::panic_any(result); [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/order_book.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 217 | / self.add_order(OpenLimitOrder { [INFO] [stdout] 218 | | id: last_order.id, [INFO] [stdout] 219 | | price: last_order.price, [INFO] [stdout] 220 | | side: last_order.side, [INFO] [stdout] 221 | | amount: remaining.abs() as u32, [INFO] [stdout] 222 | | symbol: last_order.symbol, [INFO] [stdout] 223 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 217 | let _ = self.add_order(OpenLimitOrder { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/order_book.rs:242:46 [INFO] [stdout] | [INFO] [stdout] 242 | let mut orders_used = orders_used.clone().to_vec(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[OpenLimitOrder]` does not implement `Clone`, so calling `clone` on `&[OpenLimitOrder]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.78s [INFO] running `Command { std: "docker" "inspect" "2b06339cd7b58410a46b44aac62f1917a91f6ed92a27102f918a7e2a5285127c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b06339cd7b58410a46b44aac62f1917a91f6ed92a27102f918a7e2a5285127c", kill_on_drop: false }` [INFO] [stdout] 2b06339cd7b58410a46b44aac62f1917a91f6ed92a27102f918a7e2a5285127c