[INFO] cloning repository https://github.com/alightgoesout/advent2019 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/alightgoesout/advent2019" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falightgoesout%2Fadvent2019", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falightgoesout%2Fadvent2019'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3acc31629a0c7609e56e7aaaa72541cea55b49ed [INFO] checking alightgoesout/advent2019/3acc31629a0c7609e56e7aaaa72541cea55b49ed against master#ab869e094a907cc5d19b4080f22eccaf347f1f95 for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Falightgoesout%2Fadvent2019" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/alightgoesout/advent2019 on toolchain ab869e094a907cc5d19b4080f22eccaf347f1f95 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/alightgoesout/advent2019 [INFO] finished tweaking git repo https://github.com/alightgoesout/advent2019 [INFO] tweaked toml for git repo https://github.com/alightgoesout/advent2019 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/alightgoesout/advent2019 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bitmaps v2.0.0 [INFO] [stderr] Downloaded sized-chunks v0.5.0 [INFO] [stderr] Downloaded im-rc v14.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 434cdc9045590fa308e97b883be80f9fa1a803487687b8f124dc026f4fd58cc4 [INFO] running `Command { std: "docker" "start" "-a" "434cdc9045590fa308e97b883be80f9fa1a803487687b8f124dc026f4fd58cc4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "434cdc9045590fa308e97b883be80f9fa1a803487687b8f124dc026f4fd58cc4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "434cdc9045590fa308e97b883be80f9fa1a803487687b8f124dc026f4fd58cc4", kill_on_drop: false }` [INFO] [stdout] 434cdc9045590fa308e97b883be80f9fa1a803487687b8f124dc026f4fd58cc4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 77a3dbccb3964c4e81894badcb21ea7ed5ba6031cf1f79a6062af4ef501fe38a [INFO] running `Command { std: "docker" "start" "-a" "77a3dbccb3964c4e81894badcb21ea7ed5ba6031cf1f79a6062af4ef501fe38a", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.11.2 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_xoshiro v0.4.0 [INFO] [stderr] Compiling im-rc v14.0.0 [INFO] [stderr] Checking bitmaps v2.0.0 [INFO] [stderr] Checking sized-chunks v0.5.0 [INFO] [stderr] Checking advent2019 v7.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/day3.rs:8:48 [INFO] [stdout] | [INFO] [stdout] 8 | let wires: Vector = input.iter().map({ |l| str_to_wire(l) }).collect(); [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 8 - let wires: Vector = input.iter().map({ |l| str_to_wire(l) }).collect(); [INFO] [stdout] 8 + let wires: Vector = input.iter().map(|l| str_to_wire(l)).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/day3.rs:15:18 [INFO] [stdout] | [INFO] [stdout] 15 | .map({ |p| distance_from_central_port(&p) }) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 15 - .map({ |p| distance_from_central_port(&p) }) [INFO] [stdout] 15 + .map(|p| distance_from_central_port(&p)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/day3.rs:28:14 [INFO] [stdout] | [INFO] [stdout] 28 | .map({ |p| p.clone() }) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 28 - .map({ |p| p.clone() }) [INFO] [stdout] 28 + .map(|p| p.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/day3.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | .min_by({ |p1, p2| compare_points(p1, p2) }) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 27 - .min_by({ |p1, p2| compare_points(p1, p2) }) [INFO] [stdout] 27 + .min_by(|p1, p2| compare_points(p1, p2)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/day3.rs:40:14 [INFO] [stdout] | [INFO] [stdout] 40 | .map({ |(p, s)| w2_steps.get(p).unwrap() + s }) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 40 - .map({ |(p, s)| w2_steps.get(p).unwrap() + s }) [INFO] [stdout] 40 + .map(|(p, s)| w2_steps.get(p).unwrap() + s) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/day3.rs:51:17 [INFO] [stdout] | [INFO] [stdout] 51 | .filter({ |(_, p)| intersections.contains(p) }) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 51 - .filter({ |(_, p)| intersections.contains(p) }) [INFO] [stdout] 51 + .filter(|(_, p)| intersections.contains(p)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/day3.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 67 | .map({ |p| p.clone() }), [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 67 - .map({ |p| p.clone() }), [INFO] [stdout] 67 + .map(|p| p.clone()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/day3.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 66 | .filter({ |p| w2_points.contains(p) }) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 66 - .filter({ |p| w2_points.contains(p) }) [INFO] [stdout] 66 + .filter(|p| w2_points.contains(p)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/day4.rs:15:29 [INFO] [stdout] | [INFO] [stdout] 15 | (start..end + 1).filter({ |p| is_valid(*p) }).count() as u32 [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 15 - (start..end + 1).filter({ |p| is_valid(*p) }).count() as u32 [INFO] [stdout] 15 + (start..end + 1).filter(|p| is_valid(*p)).count() as u32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/day4.rs:19:29 [INFO] [stdout] | [INFO] [stdout] 19 | (start..end + 1).filter({ |p| is_valid2(*p) }).count() as u32 [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 19 - (start..end + 1).filter({ |p| is_valid2(*p) }).count() as u32 [INFO] [stdout] 19 + (start..end + 1).filter(|p| is_valid2(*p)).count() as u32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/day3.rs:8:48 [INFO] [stdout] | [INFO] [stdout] 8 | let wires: Vector = input.iter().map({ |l| str_to_wire(l) }).collect(); [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 8 - let wires: Vector = input.iter().map({ |l| str_to_wire(l) }).collect(); [INFO] [stdout] 8 + let wires: Vector = input.iter().map(|l| str_to_wire(l)).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/day3.rs:15:18 [INFO] [stdout] | [INFO] [stdout] 15 | .map({ |p| distance_from_central_port(&p) }) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 15 - .map({ |p| distance_from_central_port(&p) }) [INFO] [stdout] 15 + .map(|p| distance_from_central_port(&p)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/day3.rs:28:14 [INFO] [stdout] | [INFO] [stdout] 28 | .map({ |p| p.clone() }) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 28 - .map({ |p| p.clone() }) [INFO] [stdout] 28 + .map(|p| p.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/day3.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | .min_by({ |p1, p2| compare_points(p1, p2) }) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 27 - .min_by({ |p1, p2| compare_points(p1, p2) }) [INFO] [stdout] 27 + .min_by(|p1, p2| compare_points(p1, p2)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/day3.rs:40:14 [INFO] [stdout] | [INFO] [stdout] 40 | .map({ |(p, s)| w2_steps.get(p).unwrap() + s }) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 40 - .map({ |(p, s)| w2_steps.get(p).unwrap() + s }) [INFO] [stdout] 40 + .map(|(p, s)| w2_steps.get(p).unwrap() + s) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/day3.rs:51:17 [INFO] [stdout] | [INFO] [stdout] 51 | .filter({ |(_, p)| intersections.contains(p) }) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 51 - .filter({ |(_, p)| intersections.contains(p) }) [INFO] [stdout] 51 + .filter(|(_, p)| intersections.contains(p)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/day3.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 67 | .map({ |p| p.clone() }), [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 67 - .map({ |p| p.clone() }), [INFO] [stdout] 67 + .map(|p| p.clone()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/day3.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 66 | .filter({ |p| w2_points.contains(p) }) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 66 - .filter({ |p| w2_points.contains(p) }) [INFO] [stdout] 66 + .filter(|p| w2_points.contains(p)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/day4.rs:15:29 [INFO] [stdout] | [INFO] [stdout] 15 | (start..end + 1).filter({ |p| is_valid(*p) }).count() as u32 [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 15 - (start..end + 1).filter({ |p| is_valid(*p) }).count() as u32 [INFO] [stdout] 15 + (start..end + 1).filter(|p| is_valid(*p)).count() as u32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around method argument [INFO] [stdout] --> src/day4.rs:19:29 [INFO] [stdout] | [INFO] [stdout] 19 | (start..end + 1).filter({ |p| is_valid2(*p) }).count() as u32 [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 19 - (start..end + 1).filter({ |p| is_valid2(*p) }).count() as u32 [INFO] [stdout] 19 + (start..end + 1).filter(|p| is_valid2(*p)).count() as u32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.57s [INFO] running `Command { std: "docker" "inspect" "77a3dbccb3964c4e81894badcb21ea7ed5ba6031cf1f79a6062af4ef501fe38a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "77a3dbccb3964c4e81894badcb21ea7ed5ba6031cf1f79a6062af4ef501fe38a", kill_on_drop: false }` [INFO] [stdout] 77a3dbccb3964c4e81894badcb21ea7ed5ba6031cf1f79a6062af4ef501fe38a