[INFO] cloning repository https://github.com/Testare/dit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Testare/dit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTestare%2Fdit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTestare%2Fdit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 54fb9ccd897dcfa2221f006d66b91c6ae0ace39a [INFO] checking Testare/dit/54fb9ccd897dcfa2221f006d66b91c6ae0ace39a against master#ab869e094a907cc5d19b4080f22eccaf347f1f95 for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTestare%2Fdit" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Testare/dit on toolchain ab869e094a907cc5d19b4080f22eccaf347f1f95 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Testare/dit [INFO] finished tweaking git repo https://github.com/Testare/dit [INFO] tweaked toml for git repo https://github.com/Testare/dit written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/Testare/dit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded radium v0.6.2 [INFO] [stderr] Downloaded mio v0.7.11 [INFO] [stderr] Downloaded wyz v0.4.0 [INFO] [stderr] Downloaded funty v1.2.0 [INFO] [stderr] Downloaded crossterm_winapi v0.6.2 [INFO] [stderr] Downloaded crossterm v0.17.7 [INFO] [stderr] Downloaded hex-literal v0.3.1 [INFO] [stderr] Downloaded bitvec v0.22.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fa704fb226789eb333785df2aa247137c2f3f7e32ee8ef3d606e24eb244d97bf [INFO] running `Command { std: "docker" "start" "-a" "fa704fb226789eb333785df2aa247137c2f3f7e32ee8ef3d606e24eb244d97bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fa704fb226789eb333785df2aa247137c2f3f7e32ee8ef3d606e24eb244d97bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fa704fb226789eb333785df2aa247137c2f3f7e32ee8ef3d606e24eb244d97bf", kill_on_drop: false }` [INFO] [stdout] fa704fb226789eb333785df2aa247137c2f3f7e32ee8ef3d606e24eb244d97bf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b773eff1eae575fbd71ff7ecccc2e1324b4471ec0194455c03ff0301e53795a8 [INFO] running `Command { std: "docker" "start" "-a" "b773eff1eae575fbd71ff7ecccc2e1324b4471ec0194455c03ff0301e53795a8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.94 [INFO] [stderr] Compiling typenum v1.13.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling syn v1.0.72 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Compiling radium v0.6.2 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking block-padding v0.2.1 [INFO] [stderr] Checking wyz v0.4.0 [INFO] [stderr] Checking roff v0.1.0 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking keccak v0.1.0 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking funty v1.2.0 [INFO] [stderr] Checking man v0.3.0 [INFO] [stderr] Compiling hex-literal v0.3.1 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking bitvec v0.22.3 [INFO] [stderr] Checking parking_lot_core v0.7.2 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.7.11 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking signal-hook v0.1.17 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking crossterm v0.17.7 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking sha3 v0.9.1 [INFO] [stderr] Checking dit v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::iter::FromIterator` [INFO] [stdout] --> src/dit_core/model/ledger.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::iter::FromIterator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `book::Book` [INFO] [stdout] --> src/dit_core/model.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub use book::Book; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::iter::FromIterator` [INFO] [stdout] --> src/dit_core/model/ledger.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::iter::FromIterator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `book::Book` [INFO] [stdout] --> src/dit_core/model.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub use book::Book; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `dit_core::ops::with_game_state`: We'll be using book instead, only keeping this around to scale refactor [INFO] [stdout] --> src/app.rs:1:45 [INFO] [stdout] | [INFO] [stdout] 1 | use super::dit_core::{read_state, validate, with_game_state, ActionInterface}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `dit_core::ops::with_game_state`: We'll be using book instead, only keeping this around to scale refactor [INFO] [stdout] --> src/app.rs:57:21 [INFO] [stdout] | [INFO] [stdout] 57 | let k = with_game_state(file_name, |_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `dit_core::ops::with_game_state`: We'll be using book instead, only keeping this around to scale refactor [INFO] [stdout] --> src/dit_core.rs:10:37 [INFO] [stdout] | [INFO] [stdout] 10 | pub use ops::{read_state, validate, with_game_state}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `dit_core::ops::with_game_state`: We'll be using book instead, only keeping this around to scale refactor [INFO] [stdout] --> src/app.rs:1:45 [INFO] [stdout] | [INFO] [stdout] 1 | use super::dit_core::{read_state, validate, with_game_state, ActionInterface}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `dit_core::ops::with_game_state`: We'll be using book instead, only keeping this around to scale refactor [INFO] [stdout] --> src/app.rs:57:21 [INFO] [stdout] | [INFO] [stdout] 57 | let k = with_game_state(file_name, |_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `dit_core::ops::with_game_state`: We'll be using book instead, only keeping this around to scale refactor [INFO] [stdout] --> src/dit_core.rs:10:37 [INFO] [stdout] | [INFO] [stdout] 10 | pub use ops::{read_state, validate, with_game_state}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state` [INFO] [stdout] --> src/dit_core/model/book.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | let mut state = A::State::default(); //Self::from_read_header(iter.by_ref()); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/dit_core/model/book.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | let mut state = A::State::default(); //Self::from_read_header(iter.by_ref()); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state` [INFO] [stdout] --> src/dit_core/model/book.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | let mut state = A::State::default(); //Self::from_read_header(iter.by_ref()); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/dit_core/model/book.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | let mut state = A::State::default(); //Self::from_read_header(iter.by_ref()); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `book` [INFO] [stdout] --> src/dit_core/model/book.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | let book = Book::::from_read(cursor).expect("Should be readable"); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_book` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `saved_lines`, `messages`, and `state` are never read [INFO] [stdout] --> src/dit_core/model/book.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Book { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 12 | saved_lines: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 13 | messages: MessageVec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 14 | state: A::State, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Book` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/dit_core/model/book.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 17 | impl Book { [INFO] [stdout] | ----------------------- associated items in this implementation [INFO] [stdout] 18 | pub fn ledger(&self) -> Ledger<'_, A> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 22 | pub fn state(&self) -> &A::State { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 26 | pub fn write_changes(&mut self, writer: &mut W) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 31 | pub fn write_pending_changes(&self, writer: &mut W) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | fn from_read_header(i: I) -> A::State [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 49 | pub fn from_read(r: R) -> Result, super::Error> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 80 | fn apply_message_internal( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 94 | pub fn apply_message(&mut self, msg: Message) -> Result<&mut Self, super::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dit_core/model/book.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | self.write_pending_changes(writer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 27 | let _ = self.write_pending_changes(writer); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `saved_lines`, `messages`, and `state` are never read [INFO] [stdout] --> src/dit_core/model/book.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Book { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 12 | saved_lines: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 13 | messages: MessageVec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 14 | state: A::State, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Book` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `ledger`, `state`, `write_changes`, `write_pending_changes`, `from_read_header`, and `apply_message` are never used [INFO] [stdout] --> src/dit_core/model/book.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 17 | impl Book { [INFO] [stdout] | ----------------------- associated items in this implementation [INFO] [stdout] 18 | pub fn ledger(&self) -> Ledger<'_, A> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 22 | pub fn state(&self) -> &A::State { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 26 | pub fn write_changes(&mut self, writer: &mut W) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 31 | pub fn write_pending_changes(&self, writer: &mut W) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | fn from_read_header(i: I) -> A::State [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 94 | pub fn apply_message(&mut self, msg: Message) -> Result<&mut Self, super::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dit_core/model/book.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | self.write_pending_changes(writer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 27 | let _ = self.write_pending_changes(writer); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.74s [INFO] running `Command { std: "docker" "inspect" "b773eff1eae575fbd71ff7ecccc2e1324b4471ec0194455c03ff0301e53795a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b773eff1eae575fbd71ff7ecccc2e1324b4471ec0194455c03ff0301e53795a8", kill_on_drop: false }` [INFO] [stdout] b773eff1eae575fbd71ff7ecccc2e1324b4471ec0194455c03ff0301e53795a8