[INFO] cloning repository https://github.com/Spalynx/soliloquy [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Spalynx/soliloquy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSpalynx%2Fsoliloquy", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSpalynx%2Fsoliloquy'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e565d6fa48144a380720d870ff094123a9e3208b [INFO] checking Spalynx/soliloquy/e565d6fa48144a380720d870ff094123a9e3208b against master#ab869e094a907cc5d19b4080f22eccaf347f1f95 for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSpalynx%2Fsoliloquy" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Spalynx/soliloquy on toolchain ab869e094a907cc5d19b4080f22eccaf347f1f95 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Spalynx/soliloquy [INFO] finished tweaking git repo https://github.com/Spalynx/soliloquy [INFO] tweaked toml for git repo https://github.com/Spalynx/soliloquy written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/Spalynx/soliloquy already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded env_logger v0.6.1 [INFO] [stderr] Downloaded utf8-ranges v1.0.3 [INFO] [stderr] Downloaded regex v1.1.7 [INFO] [stderr] Downloaded regex-syntax v0.6.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ffbf1ace0c1c6ec6be0fe9e8cf096e4fb5dda384b719e1da1e854c6c987a2ab2 [INFO] running `Command { std: "docker" "start" "-a" "ffbf1ace0c1c6ec6be0fe9e8cf096e4fb5dda384b719e1da1e854c6c987a2ab2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ffbf1ace0c1c6ec6be0fe9e8cf096e4fb5dda384b719e1da1e854c6c987a2ab2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ffbf1ace0c1c6ec6be0fe9e8cf096e4fb5dda384b719e1da1e854c6c987a2ab2", kill_on_drop: false }` [INFO] [stdout] ffbf1ace0c1c6ec6be0fe9e8cf096e4fb5dda384b719e1da1e854c6c987a2ab2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c32eac8022307dc4f0c07a5176c002c96335f669480cff7dd6611a9e0ab9283e [INFO] running `Command { std: "docker" "start" "-a" "c32eac8022307dc4f0c07a5176c002c96335f669480cff7dd6611a9e0ab9283e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.50 [INFO] [stderr] Compiling memchr v2.2.0 [INFO] [stderr] Compiling regex v1.1.7 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking utf8-ranges v1.0.3 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Checking termcolor v1.0.5 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking humantime v1.2.0 [INFO] [stderr] Checking regex-syntax v0.6.7 [INFO] [stderr] Checking aho-corasick v0.7.3 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking env_logger v0.6.1 [INFO] [stderr] Checking soliloquy v0.1.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/core/memory.rs:94:18 [INFO] [stdout] | [INFO] [stdout] 94 | self.RAM[(0xFF + (sp as usize))] = val; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 94 - self.RAM[(0xFF + (sp as usize))] = val; [INFO] [stdout] 94 + self.RAM[0xFF + (sp as usize)] = val; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/core/memory.rs:99:33 [INFO] [stdout] | [INFO] [stdout] 99 | let temp: u8 = self.RAM[(0xFF + (sp as usize))]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 99 - let temp: u8 = self.RAM[(0xFF + (sp as usize))]; [INFO] [stdout] 99 + let temp: u8 = self.RAM[0xFF + (sp as usize)]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/core/memory.rs:100:18 [INFO] [stdout] | [INFO] [stdout] 100 | self.RAM[(0xFF + (sp as usize))] = 0; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 100 - self.RAM[(0xFF + (sp as usize))] = 0; [INFO] [stdout] 100 + self.RAM[0xFF + (sp as usize)] = 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `EMPTY_MAP` should have an upper camel case name [INFO] [stdout] --> src/core/mapper.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct EMPTY_MAP; [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `EmptyMap` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[macro_use]` only has an effect on `extern crate` and modules [INFO] [stdout] --> src/core/cpu.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_attributes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[macro_use]` only has an effect on `extern crate` and modules [INFO] [stdout] --> src/core/cpu.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[macro_use]` only has an effect on `extern crate` and modules [INFO] [stdout] --> src/core/cpu.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/core/memory.rs:17:21 [INFO] [stdout] | [INFO] [stdout] 17 | pub CART: Box, //Cartridge Space [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 17 | pub CART: Box, //Cartridge Space [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/core/memory.rs:39:28 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new(mapper: Box, ppu: u8, apu: u8, input: u8) -> MEM { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new(mapper: Box, ppu: u8, apu: u8, input: u8) -> MEM { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/core/nes.rs:34:25 [INFO] [stdout] | [INFO] [stdout] 34 | let mapper: Box = new_map(map_num, Box::new(cart)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 34 | let mapper: Box = new_map(map_num, Box::new(cart)); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/core/./cpu_test.rs:348:9 [INFO] [stdout] | [INFO] [stdout] 348 | / /// Ultimately, it looks like the NES disabled BCD arith "possibly [INFO] [stdout] 349 | | /// due to patent concerns" (fogleman @ Medium). [INFO] [stdout] 350 | | /// But I still want the functionality, because of the obscure few [INFO] [stdout] 351 | | /// famicon games that I've heard rumors about. [INFO] [stdout] ... | [INFO] [stdout] 354 | | /// Since I don't have such an overarching module fully planned, [INFO] [stdout] 355 | | /// This is going to be turfed to an issue to be solved post v1. [INFO] [stdout] | |_________---------------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/core/./cpu_test.rs:395:9 [INFO] [stdout] | [INFO] [stdout] 395 | / ///Same hold as testOP_ADC_decimal()... [INFO] [stdout] 396 | | /// Task state on WAIT. [INFO] [stdout] | |_________----------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/core/memory.rs:94:18 [INFO] [stdout] | [INFO] [stdout] 94 | self.RAM[(0xFF + (sp as usize))] = val; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 94 - self.RAM[(0xFF + (sp as usize))] = val; [INFO] [stdout] 94 + self.RAM[0xFF + (sp as usize)] = val; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/core/memory.rs:99:33 [INFO] [stdout] | [INFO] [stdout] 99 | let temp: u8 = self.RAM[(0xFF + (sp as usize))]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 99 - let temp: u8 = self.RAM[(0xFF + (sp as usize))]; [INFO] [stdout] 99 + let temp: u8 = self.RAM[0xFF + (sp as usize)]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/core/memory.rs:100:18 [INFO] [stdout] | [INFO] [stdout] 100 | self.RAM[(0xFF + (sp as usize))] = 0; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 100 - self.RAM[(0xFF + (sp as usize))] = 0; [INFO] [stdout] 100 + self.RAM[0xFF + (sp as usize)] = 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `EMPTY_MAP` should have an upper camel case name [INFO] [stdout] --> src/core/mapper.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct EMPTY_MAP; [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `EmptyMap` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[macro_use]` only has an effect on `extern crate` and modules [INFO] [stdout] --> src/core/cpu.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_attributes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[macro_use]` only has an effect on `extern crate` and modules [INFO] [stdout] --> src/core/cpu.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[macro_use]` only has an effect on `extern crate` and modules [INFO] [stdout] --> src/core/cpu.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/core/memory.rs:17:21 [INFO] [stdout] | [INFO] [stdout] 17 | pub CART: Box, //Cartridge Space [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 17 | pub CART: Box, //Cartridge Space [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/core/memory.rs:39:28 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new(mapper: Box, ppu: u8, apu: u8, input: u8) -> MEM { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new(mapper: Box, ppu: u8, apu: u8, input: u8) -> MEM { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/core/nes.rs:27:16 [INFO] [stdout] | [INFO] [stdout] 27 | Ok(e) => debug!("COMPLETE -> ROM read."), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/core/nes.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | Err(e) => panic!("ERROR -> ROM read."), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/nes.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | let mut memory = MEM::new(mapper, ppu, apu, input); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/cartridge.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let mut f = File::open(self.filename.to_string())?; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 31 | fn get(&self, address: u16) -> u8{ 0 } [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | fn set(&mut self, address: u16, val: u8){ } [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:32:37 [INFO] [stdout] | [INFO] [stdout] 32 | fn set(&mut self, address: u16, val: u8){ } [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:33:23 [INFO] [stdout] | [INFO] [stdout] 33 | fn get_chr(&self, address: u16) -> u8{ 0 } [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:34:27 [INFO] [stdout] | [INFO] [stdout] 34 | fn set_chr(&mut self, address: u16, val: u8){ } [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:34:41 [INFO] [stdout] | [INFO] [stdout] 34 | fn set_chr(&mut self, address: u16, val: u8){ } [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:72:23 [INFO] [stdout] | [INFO] [stdout] 72 | fn set(&mut self, address: u16, val: u8) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:72:37 [INFO] [stdout] | [INFO] [stdout] 72 | fn set(&mut self, address: u16, val: u8) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:75:23 [INFO] [stdout] | [INFO] [stdout] 75 | fn get_chr(&self, address: u16) -> u8 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:78:27 [INFO] [stdout] | [INFO] [stdout] 78 | fn set_chr(&mut self, address: u16, val: u8){ [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:78:41 [INFO] [stdout] | [INFO] [stdout] 78 | fn set_chr(&mut self, address: u16, val: u8){ [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:114:23 [INFO] [stdout] | [INFO] [stdout] 114 | fn set(&mut self, address: u16, val: u8) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:114:37 [INFO] [stdout] | [INFO] [stdout] 114 | fn set(&mut self, address: u16, val: u8) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:117:23 [INFO] [stdout] | [INFO] [stdout] 117 | fn get_chr(&self, address: u16) -> u8 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:120:27 [INFO] [stdout] | [INFO] [stdout] 120 | fn set_chr(&mut self, address: u16, val: u8){ [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:120:41 [INFO] [stdout] | [INFO] [stdout] 120 | fn set_chr(&mut self, address: u16, val: u8){ [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `DEBUG_ROM` is never used [INFO] [stdout] --> src/core/nes.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const DEBUG_ROM: bool = true; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 31 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/core/nes.rs:34:25 [INFO] [stdout] | [INFO] [stdout] 34 | let mapper: Box = new_map(map_num, Box::new(cart)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 34 | let mapper: Box = new_map(map_num, Box::new(cart)); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/core/memory.rs:94:18 [INFO] [stdout] | [INFO] [stdout] 94 | self.RAM[(0xFF + (sp as usize))] = val; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 94 - self.RAM[(0xFF + (sp as usize))] = val; [INFO] [stdout] 94 + self.RAM[0xFF + (sp as usize)] = val; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/core/memory.rs:99:33 [INFO] [stdout] | [INFO] [stdout] 99 | let temp: u8 = self.RAM[(0xFF + (sp as usize))]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 99 - let temp: u8 = self.RAM[(0xFF + (sp as usize))]; [INFO] [stdout] 99 + let temp: u8 = self.RAM[0xFF + (sp as usize)]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/core/memory.rs:100:18 [INFO] [stdout] | [INFO] [stdout] 100 | self.RAM[(0xFF + (sp as usize))] = 0; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 100 - self.RAM[(0xFF + (sp as usize))] = 0; [INFO] [stdout] 100 + self.RAM[0xFF + (sp as usize)] = 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `EMPTY_MAP` should have an upper camel case name [INFO] [stdout] --> src/core/mapper.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct EMPTY_MAP; [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `EmptyMap` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[macro_use]` only has an effect on `extern crate` and modules [INFO] [stdout] --> src/core/cpu.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_attributes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[macro_use]` only has an effect on `extern crate` and modules [INFO] [stdout] --> src/core/cpu.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[macro_use]` only has an effect on `extern crate` and modules [INFO] [stdout] --> src/core/cpu.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/core/memory.rs:17:21 [INFO] [stdout] | [INFO] [stdout] 17 | pub CART: Box, //Cartridge Space [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 17 | pub CART: Box, //Cartridge Space [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/core/memory.rs:39:28 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new(mapper: Box, ppu: u8, apu: u8, input: u8) -> MEM { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new(mapper: Box, ppu: u8, apu: u8, input: u8) -> MEM { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/core/./cpu_test.rs:348:9 [INFO] [stdout] | [INFO] [stdout] 348 | / /// Ultimately, it looks like the NES disabled BCD arith "possibly [INFO] [stdout] 349 | | /// due to patent concerns" (fogleman @ Medium). [INFO] [stdout] 350 | | /// But I still want the functionality, because of the obscure few [INFO] [stdout] 351 | | /// famicon games that I've heard rumors about. [INFO] [stdout] ... | [INFO] [stdout] 354 | | /// Since I don't have such an overarching module fully planned, [INFO] [stdout] 355 | | /// This is going to be turfed to an issue to be solved post v1. [INFO] [stdout] | |_________---------------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/core/./cpu_test.rs:395:9 [INFO] [stdout] | [INFO] [stdout] 395 | / ///Same hold as testOP_ADC_decimal()... [INFO] [stdout] 396 | | /// Task state on WAIT. [INFO] [stdout] | |_________----------------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/core/memory.rs:94:18 [INFO] [stdout] | [INFO] [stdout] 94 | self.RAM[(0xFF + (sp as usize))] = val; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 94 - self.RAM[(0xFF + (sp as usize))] = val; [INFO] [stdout] 94 + self.RAM[0xFF + (sp as usize)] = val; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/core/memory.rs:99:33 [INFO] [stdout] | [INFO] [stdout] 99 | let temp: u8 = self.RAM[(0xFF + (sp as usize))]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 99 - let temp: u8 = self.RAM[(0xFF + (sp as usize))]; [INFO] [stdout] 99 + let temp: u8 = self.RAM[0xFF + (sp as usize)]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/core/memory.rs:100:18 [INFO] [stdout] | [INFO] [stdout] 100 | self.RAM[(0xFF + (sp as usize))] = 0; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 100 - self.RAM[(0xFF + (sp as usize))] = 0; [INFO] [stdout] 100 + self.RAM[0xFF + (sp as usize)] = 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `EMPTY_MAP` should have an upper camel case name [INFO] [stdout] --> src/core/mapper.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct EMPTY_MAP; [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `EmptyMap` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/core/nes.rs:27:16 [INFO] [stdout] | [INFO] [stdout] 27 | Ok(e) => debug!("COMPLETE -> ROM read."), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[macro_use]` only has an effect on `extern crate` and modules [INFO] [stdout] --> src/core/cpu.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_attributes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[macro_use]` only has an effect on `extern crate` and modules [INFO] [stdout] --> src/core/cpu.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/core/nes.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | Err(e) => panic!("ERROR -> ROM read."), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[macro_use]` only has an effect on `extern crate` and modules [INFO] [stdout] --> src/core/cpu.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/nes.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | let mut memory = MEM::new(mapper, ppu, apu, input); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/core/memory.rs:17:21 [INFO] [stdout] | [INFO] [stdout] 17 | pub CART: Box, //Cartridge Space [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 17 | pub CART: Box, //Cartridge Space [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/cartridge.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let mut f = File::open(self.filename.to_string())?; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 31 | fn get(&self, address: u16) -> u8{ 0 } [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | fn set(&mut self, address: u16, val: u8){ } [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:32:37 [INFO] [stdout] | [INFO] [stdout] 32 | fn set(&mut self, address: u16, val: u8){ } [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:33:23 [INFO] [stdout] | [INFO] [stdout] 33 | fn get_chr(&self, address: u16) -> u8{ 0 } [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:34:27 [INFO] [stdout] | [INFO] [stdout] 34 | fn set_chr(&mut self, address: u16, val: u8){ } [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:34:41 [INFO] [stdout] | [INFO] [stdout] 34 | fn set_chr(&mut self, address: u16, val: u8){ } [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:72:23 [INFO] [stdout] | [INFO] [stdout] 72 | fn set(&mut self, address: u16, val: u8) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:72:37 [INFO] [stdout] | [INFO] [stdout] 72 | fn set(&mut self, address: u16, val: u8) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:75:23 [INFO] [stdout] | [INFO] [stdout] 75 | fn get_chr(&self, address: u16) -> u8 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:78:27 [INFO] [stdout] | [INFO] [stdout] 78 | fn set_chr(&mut self, address: u16, val: u8){ [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:78:41 [INFO] [stdout] | [INFO] [stdout] 78 | fn set_chr(&mut self, address: u16, val: u8){ [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:114:23 [INFO] [stdout] | [INFO] [stdout] 114 | fn set(&mut self, address: u16, val: u8) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:114:37 [INFO] [stdout] | [INFO] [stdout] 114 | fn set(&mut self, address: u16, val: u8) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:117:23 [INFO] [stdout] | [INFO] [stdout] 117 | fn get_chr(&self, address: u16) -> u8 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:120:27 [INFO] [stdout] | [INFO] [stdout] 120 | fn set_chr(&mut self, address: u16, val: u8){ [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:120:41 [INFO] [stdout] | [INFO] [stdout] 120 | fn set_chr(&mut self, address: u16, val: u8){ [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `DEBUG_ROM` is never used [INFO] [stdout] --> src/core/nes.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const DEBUG_ROM: bool = true; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/core/memory.rs:39:28 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new(mapper: Box, ppu: u8, apu: u8, input: u8) -> MEM { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new(mapper: Box, ppu: u8, apu: u8, input: u8) -> MEM { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 33 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/core/nes.rs:34:25 [INFO] [stdout] | [INFO] [stdout] 34 | let mapper: Box = new_map(map_num, Box::new(cart)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 34 | let mapper: Box = new_map(map_num, Box::new(cart)); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/core/nes.rs:27:16 [INFO] [stdout] | [INFO] [stdout] 27 | Ok(e) => debug!("COMPLETE -> ROM read."), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/core/nes.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | Err(e) => panic!("ERROR -> ROM read."), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/nes.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | let mut memory = MEM::new(mapper, ppu, apu, input); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/cartridge.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let mut f = File::open(self.filename.to_string())?; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/core/nes.rs:34:25 [INFO] [stdout] | [INFO] [stdout] 34 | let mapper: Box = new_map(map_num, Box::new(cart)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 34 | let mapper: Box = new_map(map_num, Box::new(cart)); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 31 | fn get(&self, address: u16) -> u8{ 0 } [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | fn set(&mut self, address: u16, val: u8){ } [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:32:37 [INFO] [stdout] | [INFO] [stdout] 32 | fn set(&mut self, address: u16, val: u8){ } [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:33:23 [INFO] [stdout] | [INFO] [stdout] 33 | fn get_chr(&self, address: u16) -> u8{ 0 } [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:34:27 [INFO] [stdout] | [INFO] [stdout] 34 | fn set_chr(&mut self, address: u16, val: u8){ } [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:34:41 [INFO] [stdout] | [INFO] [stdout] 34 | fn set_chr(&mut self, address: u16, val: u8){ } [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:72:23 [INFO] [stdout] | [INFO] [stdout] 72 | fn set(&mut self, address: u16, val: u8) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:72:37 [INFO] [stdout] | [INFO] [stdout] 72 | fn set(&mut self, address: u16, val: u8) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:75:23 [INFO] [stdout] | [INFO] [stdout] 75 | fn get_chr(&self, address: u16) -> u8 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:78:27 [INFO] [stdout] | [INFO] [stdout] 78 | fn set_chr(&mut self, address: u16, val: u8){ [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:78:41 [INFO] [stdout] | [INFO] [stdout] 78 | fn set_chr(&mut self, address: u16, val: u8){ [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:114:23 [INFO] [stdout] | [INFO] [stdout] 114 | fn set(&mut self, address: u16, val: u8) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:114:37 [INFO] [stdout] | [INFO] [stdout] 114 | fn set(&mut self, address: u16, val: u8) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:117:23 [INFO] [stdout] | [INFO] [stdout] 117 | fn get_chr(&self, address: u16) -> u8 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:120:27 [INFO] [stdout] | [INFO] [stdout] 120 | fn set_chr(&mut self, address: u16, val: u8){ [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:120:41 [INFO] [stdout] | [INFO] [stdout] 120 | fn set_chr(&mut self, address: u16, val: u8){ [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `DEBUG_ROM` is never used [INFO] [stdout] --> src/core/nes.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const DEBUG_ROM: bool = true; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 31 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/core/nes.rs:27:16 [INFO] [stdout] | [INFO] [stdout] 27 | Ok(e) => debug!("COMPLETE -> ROM read."), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/core/nes.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | Err(e) => panic!("ERROR -> ROM read."), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/nes.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | let mut memory = MEM::new(mapper, ppu, apu, input); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/cartridge.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | let mut f = File::open(self.filename.to_string())?; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 31 | fn get(&self, address: u16) -> u8{ 0 } [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | fn set(&mut self, address: u16, val: u8){ } [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:32:37 [INFO] [stdout] | [INFO] [stdout] 32 | fn set(&mut self, address: u16, val: u8){ } [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:33:23 [INFO] [stdout] | [INFO] [stdout] 33 | fn get_chr(&self, address: u16) -> u8{ 0 } [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:34:27 [INFO] [stdout] | [INFO] [stdout] 34 | fn set_chr(&mut self, address: u16, val: u8){ } [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:34:41 [INFO] [stdout] | [INFO] [stdout] 34 | fn set_chr(&mut self, address: u16, val: u8){ } [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:72:23 [INFO] [stdout] | [INFO] [stdout] 72 | fn set(&mut self, address: u16, val: u8) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:72:37 [INFO] [stdout] | [INFO] [stdout] 72 | fn set(&mut self, address: u16, val: u8) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:75:23 [INFO] [stdout] | [INFO] [stdout] 75 | fn get_chr(&self, address: u16) -> u8 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:78:27 [INFO] [stdout] | [INFO] [stdout] 78 | fn set_chr(&mut self, address: u16, val: u8){ [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:78:41 [INFO] [stdout] | [INFO] [stdout] 78 | fn set_chr(&mut self, address: u16, val: u8){ [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:114:23 [INFO] [stdout] | [INFO] [stdout] 114 | fn set(&mut self, address: u16, val: u8) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:114:37 [INFO] [stdout] | [INFO] [stdout] 114 | fn set(&mut self, address: u16, val: u8) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:117:23 [INFO] [stdout] | [INFO] [stdout] 117 | fn get_chr(&self, address: u16) -> u8 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `address` [INFO] [stdout] --> src/core/mapper.rs:120:27 [INFO] [stdout] | [INFO] [stdout] 120 | fn set_chr(&mut self, address: u16, val: u8){ [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_address` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/core/mapper.rs:120:41 [INFO] [stdout] | [INFO] [stdout] 120 | fn set_chr(&mut self, address: u16, val: u8){ [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `DEBUG_ROM` is never used [INFO] [stdout] --> src/core/nes.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const DEBUG_ROM: bool = true; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 33 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.77s [INFO] running `Command { std: "docker" "inspect" "c32eac8022307dc4f0c07a5176c002c96335f669480cff7dd6611a9e0ab9283e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c32eac8022307dc4f0c07a5176c002c96335f669480cff7dd6611a9e0ab9283e", kill_on_drop: false }` [INFO] [stdout] c32eac8022307dc4f0c07a5176c002c96335f669480cff7dd6611a9e0ab9283e