[INFO] cloning repository https://github.com/ProbablyClem/cargo-todo [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ProbablyClem/cargo-todo" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FProbablyClem%2Fcargo-todo", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FProbablyClem%2Fcargo-todo'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 59a4315f1e88a85ec83d9830cda794a4df393a7d [INFO] checking ProbablyClem/cargo-todo/59a4315f1e88a85ec83d9830cda794a4df393a7d against master#ab869e094a907cc5d19b4080f22eccaf347f1f95 for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FProbablyClem%2Fcargo-todo" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ProbablyClem/cargo-todo on toolchain ab869e094a907cc5d19b4080f22eccaf347f1f95 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ProbablyClem/cargo-todo [INFO] finished tweaking git repo https://github.com/ProbablyClem/cargo-todo [INFO] tweaked toml for git repo https://github.com/ProbablyClem/cargo-todo written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/ProbablyClem/cargo-todo already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded string-parser v0.1.5 [INFO] [stderr] Downloaded string_format v0.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b55efff27b0c80828d4e8bc6ff0ec8bf626f3b1e59d6cf5ef860755fa9f0dd4a [INFO] running `Command { std: "docker" "start" "-a" "b55efff27b0c80828d4e8bc6ff0ec8bf626f3b1e59d6cf5ef860755fa9f0dd4a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b55efff27b0c80828d4e8bc6ff0ec8bf626f3b1e59d6cf5ef860755fa9f0dd4a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b55efff27b0c80828d4e8bc6ff0ec8bf626f3b1e59d6cf5ef860755fa9f0dd4a", kill_on_drop: false }` [INFO] [stdout] b55efff27b0c80828d4e8bc6ff0ec8bf626f3b1e59d6cf5ef860755fa9f0dd4a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f87e874f925c8442b1935dd846b6ceec36dad61290510cddebc0f36b0ddd4ceb [INFO] running `Command { std: "docker" "start" "-a" "f87e874f925c8442b1935dd846b6ceec36dad61290510cddebc0f36b0ddd4ceb", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.72 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking string-parser v0.1.5 [INFO] [stderr] Checking string_format v0.1.0 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Checking aho-corasick v0.7.13 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.5 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking colored v1.9.3 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking chrono v0.4.13 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking cargo-todo v0.2.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> src/regex.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> src/regex.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/regex.rs:38:19 [INFO] [stdout] | [INFO] [stdout] 38 | if(regex.is_match(&line)){ // If the line matches the regex [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 38 - if(regex.is_match(&line)){ // If the line matches the regex [INFO] [stdout] 38 + if regex.is_match(&line) { // If the line matches the regex [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/regex.rs:38:19 [INFO] [stdout] | [INFO] [stdout] 38 | if(regex.is_match(&line)){ // If the line matches the regex [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 38 - if(regex.is_match(&line)){ // If the line matches the regex [INFO] [stdout] 38 + if regex.is_match(&line) { // If the line matches the regex [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:156:33 [INFO] [stdout] | [INFO] [stdout] 156 | let verbosity : i8 = if (matches.occurrences_of("verbose") == 0 || matches.occurrences_of("verbose") == 2){ 2 } else { 1 }; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 156 - let verbosity : i8 = if (matches.occurrences_of("verbose") == 0 || matches.occurrences_of("verbose") == 2){ 2 } else { 1 }; [INFO] [stdout] 156 + let verbosity : i8 = if matches.occurrences_of("verbose") == 0 || matches.occurrences_of("verbose") == 2 { 2 } else { 1 }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:156:33 [INFO] [stdout] | [INFO] [stdout] 156 | let verbosity : i8 = if (matches.occurrences_of("verbose") == 0 || matches.occurrences_of("verbose") == 2){ 2 } else { 1 }; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 156 - let verbosity : i8 = if (matches.occurrences_of("verbose") == 0 || matches.occurrences_of("verbose") == 2){ 2 } else { 1 }; [INFO] [stdout] 156 + let verbosity : i8 = if matches.occurrences_of("verbose") == 0 || matches.occurrences_of("verbose") == 2 { 2 } else { 1 }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `number_regex` [INFO] [stdout] --> src/token.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | let number_regex = Regex::new("\\b[1-9]\\b").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_number_regex` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `number_regex` [INFO] [stdout] --> src/token.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | let number_regex = Regex::new("\\b[1-9]\\b").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_number_regex` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:259:25 [INFO] [stdout] | [INFO] [stdout] 259 | &new_tokens.push(i.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 259 | let _ = &new_tokens.push(i.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:277:25 [INFO] [stdout] | [INFO] [stdout] 277 | &new_tokens.push(i.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 277 | let _ = &new_tokens.push(i.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:291:25 [INFO] [stdout] | [INFO] [stdout] 291 | &new_tokens.push(i.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 291 | let _ = &new_tokens.push(i.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:309:25 [INFO] [stdout] | [INFO] [stdout] 309 | &new_tokens.push(i.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 309 | let _ = &new_tokens.push(i.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:259:25 [INFO] [stdout] | [INFO] [stdout] 259 | &new_tokens.push(i.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 259 | let _ = &new_tokens.push(i.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:277:25 [INFO] [stdout] | [INFO] [stdout] 277 | &new_tokens.push(i.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 277 | let _ = &new_tokens.push(i.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:291:25 [INFO] [stdout] | [INFO] [stdout] 291 | &new_tokens.push(i.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 291 | let _ = &new_tokens.push(i.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:309:25 [INFO] [stdout] | [INFO] [stdout] 309 | &new_tokens.push(i.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 309 | let _ = &new_tokens.push(i.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.46s [INFO] running `Command { std: "docker" "inspect" "f87e874f925c8442b1935dd846b6ceec36dad61290510cddebc0f36b0ddd4ceb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f87e874f925c8442b1935dd846b6ceec36dad61290510cddebc0f36b0ddd4ceb", kill_on_drop: false }` [INFO] [stdout] f87e874f925c8442b1935dd846b6ceec36dad61290510cddebc0f36b0ddd4ceb