[INFO] cloning repository https://github.com/MattBJ/mgba_gaming_agent [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MattBJ/mgba_gaming_agent" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMattBJ%2Fmgba_gaming_agent", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMattBJ%2Fmgba_gaming_agent'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 89d82e62b2af61c1c89c65d61fb8b05441ec3d13 [INFO] checking MattBJ/mgba_gaming_agent/89d82e62b2af61c1c89c65d61fb8b05441ec3d13 against master#ab869e094a907cc5d19b4080f22eccaf347f1f95 for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMattBJ%2Fmgba_gaming_agent" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MattBJ/mgba_gaming_agent on toolchain ab869e094a907cc5d19b4080f22eccaf347f1f95 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/MattBJ/mgba_gaming_agent [INFO] finished tweaking git repo https://github.com/MattBJ/mgba_gaming_agent [INFO] tweaked toml for git repo https://github.com/MattBJ/mgba_gaming_agent written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/MattBJ/mgba_gaming_agent already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded fork v0.1.23 [INFO] [stderr] Downloaded ouroboros v0.18.3 [INFO] [stderr] Downloaded ouroboros_macro v0.18.3 [INFO] [stderr] Downloaded yansi v1.0.0-rc.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e9e648516818631c3496bedd2f159b47297b684ae838553426e72cf93e23a2ac [INFO] running `Command { std: "docker" "start" "-a" "e9e648516818631c3496bedd2f159b47297b684ae838553426e72cf93e23a2ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e9e648516818631c3496bedd2f159b47297b684ae838553426e72cf93e23a2ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9e648516818631c3496bedd2f159b47297b684ae838553426e72cf93e23a2ac", kill_on_drop: false }` [INFO] [stdout] e9e648516818631c3496bedd2f159b47297b684ae838553426e72cf93e23a2ac [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c6ef22bb003922afec7386b98996b58384c62bb38524dc33e4b21c82a6831d6a [INFO] running `Command { std: "docker" "start" "-a" "c6ef22bb003922afec7386b98996b58384c62bb38524dc33e4b21c82a6831d6a", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling proc-macro2-diagnostics v0.10.1 [INFO] [stderr] Compiling yansi v1.0.0-rc.1 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking half v2.4.0 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling sdl2 v0.36.0 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking bytemuck v1.14.3 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Compiling sdl2-sys v0.36.0 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking aliasable v0.1.3 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking libloading v0.8.2 [INFO] [stderr] Checking argparse v0.2.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rayon v1.9.0 [INFO] [stderr] Checking exr v1.72.0 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking fork v0.1.23 [INFO] [stderr] Checking ctrlc v3.4.2 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling ouroboros_macro v0.18.3 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking ouroboros v0.18.3 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking mgba_gaming_agent v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/agent_stuff/observation.rs:117:44 [INFO] [stdout] | [INFO] [stdout] 117 | .for_each(|([a,b,c,_],d)| *d = (( (0.2989*((a) as f32)) + (0.5870*((b) as f32)) + (0.114*((c) as f32))) as u8)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 117 - .for_each(|([a,b,c,_],d)| *d = (( (0.2989*((a) as f32)) + (0.5870*((b) as f32)) + (0.114*((c) as f32))) as u8)); [INFO] [stdout] 117 + .for_each(|([a,b,c,_],d)| *d = ( (0.2989*((a) as f32)) + (0.5870*((b) as f32)) + (0.114*((c) as f32))) as u8); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/agent_stuff.rs:337:36 [INFO] [stdout] | [INFO] [stdout] 337 | ... if (0!=((cycle_counter+1) % (cycles_ignore+1))) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 337 - if (0!=((cycle_counter+1) % (cycles_ignore+1))) { [INFO] [stdout] 337 + if 0!=((cycle_counter+1) % (cycles_ignore+1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/agent_stuff/observation.rs:117:44 [INFO] [stdout] | [INFO] [stdout] 117 | .for_each(|([a,b,c,_],d)| *d = (( (0.2989*((a) as f32)) + (0.5870*((b) as f32)) + (0.114*((c) as f32))) as u8)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 117 - .for_each(|([a,b,c,_],d)| *d = (( (0.2989*((a) as f32)) + (0.5870*((b) as f32)) + (0.114*((c) as f32))) as u8)); [INFO] [stdout] 117 + .for_each(|([a,b,c,_],d)| *d = ( (0.2989*((a) as f32)) + (0.5870*((b) as f32)) + (0.114*((c) as f32))) as u8); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/agent_stuff.rs:337:36 [INFO] [stdout] | [INFO] [stdout] 337 | ... if (0!=((cycle_counter+1) % (cycles_ignore+1))) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 337 - if (0!=((cycle_counter+1) % (cycles_ignore+1))) { [INFO] [stdout] 337 + if 0!=((cycle_counter+1) % (cycles_ignore+1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/agent_stuff.rs:390:33 [INFO] [stdout] | [INFO] [stdout] 387 | ... break 'agent_loop_cycle; [INFO] [stdout] | ----------------------- any code following this expression is unreachable [INFO] [stdout] ... [INFO] [stdout] 390 | ... FRAME_COUNTER += 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/agent_stuff.rs:390:33 [INFO] [stdout] | [INFO] [stdout] 387 | ... break 'agent_loop_cycle; [INFO] [stdout] | ----------------------- any code following this expression is unreachable [INFO] [stdout] ... [INFO] [stdout] 390 | ... FRAME_COUNTER += 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/agent_stuff.rs:293:13 [INFO] [stdout] | [INFO] [stdout] 293 | let mut ret_val: Option [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/agent_stuff.rs:293:13 [INFO] [stdout] | [INFO] [stdout] 293 | let mut ret_val: Option [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_size` and `write_buffer` are never used [INFO] [stdout] --> src/agent_stuff/observation.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 66 | impl FrameBuffer { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 85 | pub fn get_size(&self) -> usize { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 94 | pub fn write_buffer(&mut self, data: &[u8]) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `push` is never used [INFO] [stdout] --> src/agent_stuff/observation.rs:261:12 [INFO] [stdout] | [INFO] [stdout] 159 | impl ObservationSet { [INFO] [stdout] | ------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 261 | pub fn push(&mut self, data: ObservationData) { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_size` and `write_buffer` are never used [INFO] [stdout] --> src/agent_stuff/observation.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 66 | impl FrameBuffer { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 85 | pub fn get_size(&self) -> usize { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 94 | pub fn write_buffer(&mut self, data: &[u8]) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `push` is never used [INFO] [stdout] --> src/agent_stuff/observation.rs:261:12 [INFO] [stdout] | [INFO] [stdout] 159 | impl ObservationSet { [INFO] [stdout] | ------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 261 | pub fn push(&mut self, data: ObservationData) { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 35.84s [INFO] running `Command { std: "docker" "inspect" "c6ef22bb003922afec7386b98996b58384c62bb38524dc33e4b21c82a6831d6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c6ef22bb003922afec7386b98996b58384c62bb38524dc33e4b21c82a6831d6a", kill_on_drop: false }` [INFO] [stdout] c6ef22bb003922afec7386b98996b58384c62bb38524dc33e4b21c82a6831d6a