[INFO] cloning repository https://github.com/Kampfkarren/rbxlx-to-rojo [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Kampfkarren/rbxlx-to-rojo" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKampfkarren%2Frbxlx-to-rojo", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKampfkarren%2Frbxlx-to-rojo'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 02d0395e10b0af78b0b30a47e5678f017863af63 [INFO] checking Kampfkarren/rbxlx-to-rojo/02d0395e10b0af78b0b30a47e5678f017863af63 against master#ab869e094a907cc5d19b4080f22eccaf347f1f95 for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FKampfkarren%2Frbxlx-to-rojo" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Kampfkarren/rbxlx-to-rojo on toolchain ab869e094a907cc5d19b4080f22eccaf347f1f95 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Kampfkarren/rbxlx-to-rojo [INFO] finished tweaking git repo https://github.com/Kampfkarren/rbxlx-to-rojo [INFO] tweaked toml for git repo https://github.com/Kampfkarren/rbxlx-to-rojo written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/Kampfkarren/rbxlx-to-rojo already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/saurvs/nfd-rs` [INFO] [stderr] Updating git submodule `https://github.com/mlabbe/nativefiledialog` [INFO] [stderr] Updating git repository `https://github.com/rojo-rbx/rbx-dom/` [INFO] [stderr] Updating git submodule `https://github.com/rojo-rbx/rbx-test-files.git` [INFO] [stderr] Updating git submodule `https://github.com/Roblox/testez.git` [INFO] [stderr] Updating git submodule `https://github.com/LPGhatguy/lemur.git` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rbx_dom_weak v1.10.1 [INFO] [stderr] Downloaded serde_repr v0.1.6 [INFO] [stderr] Downloaded lz4 v1.23.2 [INFO] [stderr] Downloaded blake3 v0.1.5 [INFO] [stderr] Downloaded lz4-sys v1.9.2 [INFO] [stderr] Downloaded rbx_reflection v3.3.454 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4e046e20b0806b6962af0c3fa23cf693258782f700aff72ee6d75a19a1bf113d [INFO] running `Command { std: "docker" "start" "-a" "4e046e20b0806b6962af0c3fa23cf693258782f700aff72ee6d75a19a1bf113d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4e046e20b0806b6962af0c3fa23cf693258782f700aff72ee6d75a19a1bf113d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e046e20b0806b6962af0c3fa23cf693258782f700aff72ee6d75a19a1bf113d", kill_on_drop: false }` [INFO] [stdout] 4e046e20b0806b6962af0c3fa23cf693258782f700aff72ee6d75a19a1bf113d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cd8acfc870a9dee9dcb8f6ca32526c51910dceafeeddadaa5c942c7bcf705477 [INFO] running `Command { std: "docker" "start" "-a" "cd8acfc870a9dee9dcb8f6ca32526c51910dceafeeddadaa5c942c7bcf705477", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling libc v0.2.93 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.69 [INFO] [stderr] Compiling serde_derive v1.0.125 [INFO] [stderr] Compiling cc v1.0.67 [INFO] [stderr] Compiling serde v1.0.125 [INFO] [stderr] Compiling typenum v1.13.0 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking base64 v0.11.0 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Checking subtle v1.0.0 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking arrayref v0.3.6 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling blake3 v0.1.5 [INFO] [stderr] Compiling lz4-sys v1.9.2 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking generic-array v0.12.4 [INFO] [stderr] Checking regex-syntax v0.6.23 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking crypto-mac v0.7.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking rmp v0.8.10 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking xml-rs v0.8.3 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking pretty_assertions v0.6.1 [INFO] [stderr] Checking regex v1.4.5 [INFO] [stderr] Compiling serde_repr v0.1.6 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Checking thiserror v1.0.24 [INFO] [stderr] Checking rbx_types v0.3.0 (https://github.com/rojo-rbx/rbx-dom/?branch=master#05fd11f1) [INFO] [stderr] Checking rmp-serde v0.14.4 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking rbx_dom_weak v1.10.1 [INFO] [stderr] Checking rbx_reflection v4.0.0-alpha.1 (https://github.com/rojo-rbx/rbx-dom/?branch=master#05fd11f1) [INFO] [stderr] Checking rbx_dom_weak v2.0.0-alpha.1 (https://github.com/rojo-rbx/rbx-dom/?branch=master#05fd11f1) [INFO] [stderr] Checking rbx_reflection_database v0.1.0+roblox-465 (https://github.com/rojo-rbx/rbx-dom/?branch=master#05fd11f1) [INFO] [stderr] Checking rbx_xml v0.12.0-alpha.4 (https://github.com/rojo-rbx/rbx-dom/?branch=master#05fd11f1) [INFO] [stderr] Checking rbx_reflection v3.3.454 [INFO] [stderr] Checking lz4 v1.23.2 [INFO] [stderr] Checking rbx_binary v0.6.0-alpha.4 (https://github.com/rojo-rbx/rbx-dom/?branch=master#05fd11f1) [INFO] [stderr] Checking rbxlx-to-rojo v1.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/filesystem.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 79 | for mut child in partition.children.values_mut() { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/filesystem.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 79 | for mut child in partition.children.values_mut() { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/tests.rs:85:84 [INFO] [stdout] | [INFO] [stdout] 85 | ... let child_instance = tree.get_by_ref(child_id).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Instance` does not implement `Clone`, so calling `clone` on `&Instance` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 85 - let child_instance = tree.get_by_ref(child_id).unwrap().clone(); [INFO] [stdout] 85 + let child_instance = tree.get_by_ref(child_id).unwrap(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Instance`, implement `Clone` for it [INFO] [stdout] --> /opt/rustwide/cargo-home/git/checkouts/rbx-dom-cf9b8248e8106831/05fd11f/rbx_dom_weak/src/instance.rs:152:1 [INFO] [stdout] | [INFO] [stdout] 152+ #[derive(Clone)] [INFO] [stdout] 153| pub struct Instance { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 39.27s [INFO] running `Command { std: "docker" "inspect" "cd8acfc870a9dee9dcb8f6ca32526c51910dceafeeddadaa5c942c7bcf705477", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd8acfc870a9dee9dcb8f6ca32526c51910dceafeeddadaa5c942c7bcf705477", kill_on_drop: false }` [INFO] [stdout] cd8acfc870a9dee9dcb8f6ca32526c51910dceafeeddadaa5c942c7bcf705477