[INFO] cloning repository https://github.com/Giacom/rust-man [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Giacom/rust-man" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGiacom%2Frust-man", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGiacom%2Frust-man'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 05fda02f5cb29c0d7423b9a3208f855316092a3e [INFO] checking Giacom/rust-man/05fda02f5cb29c0d7423b9a3208f855316092a3e against master#ab869e094a907cc5d19b4080f22eccaf347f1f95 for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FGiacom%2Frust-man" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Giacom/rust-man on toolchain ab869e094a907cc5d19b4080f22eccaf347f1f95 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Giacom/rust-man [INFO] finished tweaking git repo https://github.com/Giacom/rust-man [INFO] tweaked toml for git repo https://github.com/Giacom/rust-man written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] crate git repo https://github.com/Giacom/rust-man already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded libc v0.2.6 [INFO] [stderr] Downloaded rand v0.3.13 [INFO] [stderr] Downloaded sfml v0.9.3 [INFO] [stderr] Downloaded winapi v0.2.5 [INFO] [stderr] Downloaded advapi32-sys v0.1.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4ab9d9a427777b7aec3c923bcca5a87d86bd2d9787937abd6e04a7a4fa2b1c7d [INFO] running `Command { std: "docker" "start" "-a" "4ab9d9a427777b7aec3c923bcca5a87d86bd2d9787937abd6e04a7a4fa2b1c7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4ab9d9a427777b7aec3c923bcca5a87d86bd2d9787937abd6e04a7a4fa2b1c7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4ab9d9a427777b7aec3c923bcca5a87d86bd2d9787937abd6e04a7a4fa2b1c7d", kill_on_drop: false }` [INFO] [stdout] 4ab9d9a427777b7aec3c923bcca5a87d86bd2d9787937abd6e04a7a4fa2b1c7d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+ab869e094a907cc5d19b4080f22eccaf347f1f95" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 356e2c8acd1a8315f1bc60722f71c9fd581c51d4f64772b732b87fe722456e55 [INFO] running `Command { std: "docker" "start" "-a" "356e2c8acd1a8315f1bc60722f71c9fd581c51d4f64772b732b87fe722456e55", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking winapi v0.2.5 [INFO] [stderr] Checking libc v0.2.6 [INFO] [stderr] Compiling advapi32-sys v0.1.2 [INFO] [stderr] Checking rand v0.3.13 [INFO] [stderr] Checking sfml v0.9.3 [INFO] [stderr] Checking rust-man v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/level.rs:25:71 [INFO] [stdout] | [INFO] [stdout] 25 | vertex_array: VertexArray::new_init(PrimitiveType::Quads, (size.x * size.y * 4)).unwrap(), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 25 - vertex_array: VertexArray::new_init(PrimitiveType::Quads, (size.x * size.y * 4)).unwrap(), [INFO] [stdout] 25 + vertex_array: VertexArray::new_init(PrimitiveType::Quads, size.x * size.y * 4).unwrap(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Sprite` [INFO] [stdout] --> src/player.rs:2:64 [INFO] [stdout] | [INFO] [stdout] 2 | use sfml::graphics::{RenderTarget, VertexArray, PrimitiveType, Sprite, RenderStates, FloatRect}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/input.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | (*self.held_keys.get(&HKey(key)).unwrap_or(&false) == true) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 47 - (*self.held_keys.get(&HKey(key)).unwrap_or(&false) == true) [INFO] [stdout] 47 + *self.held_keys.get(&HKey(key)).unwrap_or(&false) == true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/input.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | (*self.keys_down.get(&HKey(key)).unwrap_or(&false) == true) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 51 - (*self.keys_down.get(&HKey(key)).unwrap_or(&false) == true) [INFO] [stdout] 51 + *self.keys_down.get(&HKey(key)).unwrap_or(&false) == true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/input.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | (*self.keys_up.get(&HKey(key)).unwrap_or(&false) == true) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 56 - (*self.keys_up.get(&HKey(key)).unwrap_or(&false) == true) [INFO] [stdout] 56 + *self.keys_up.get(&HKey(key)).unwrap_or(&false) == true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `FloatRect` [INFO] [stdout] --> src/animation_sprite.rs:3:39 [INFO] [stdout] | [INFO] [stdout] 3 | use sfml::graphics::{Sprite, IntRect, FloatRect}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AnimationSprite` [INFO] [stdout] --> src/main.rs:21:24 [INFO] [stdout] | [INFO] [stdout] 21 | use animation_sprite::{AnimationSprite}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/main.rs:39:66 [INFO] [stdout] | [INFO] [stdout] 39 | let mut window = match RenderWindow::new(VideoMode::new_init(((level.size.x as u32) * GAME_SIZE), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 39 - let mut window = match RenderWindow::new(VideoMode::new_init(((level.size.x as u32) * GAME_SIZE), [INFO] [stdout] 39 + let mut window = match RenderWindow::new(VideoMode::new_init((level.size.x as u32) * GAME_SIZE, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/main.rs:40:66 [INFO] [stdout] | [INFO] [stdout] 40 | ... ((level.size.y as u32) * GAME_SIZE), 32), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 40 - ((level.size.y as u32) * GAME_SIZE), 32), [INFO] [stdout] 40 + (level.size.y as u32) * GAME_SIZE, 32), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/level.rs:25:71 [INFO] [stdout] | [INFO] [stdout] 25 | vertex_array: VertexArray::new_init(PrimitiveType::Quads, (size.x * size.y * 4)).unwrap(), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 25 - vertex_array: VertexArray::new_init(PrimitiveType::Quads, (size.x * size.y * 4)).unwrap(), [INFO] [stdout] 25 + vertex_array: VertexArray::new_init(PrimitiveType::Quads, size.x * size.y * 4).unwrap(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Sprite` [INFO] [stdout] --> src/player.rs:2:64 [INFO] [stdout] | [INFO] [stdout] 2 | use sfml::graphics::{RenderTarget, VertexArray, PrimitiveType, Sprite, RenderStates, FloatRect}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/input.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | (*self.held_keys.get(&HKey(key)).unwrap_or(&false) == true) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 47 - (*self.held_keys.get(&HKey(key)).unwrap_or(&false) == true) [INFO] [stdout] 47 + *self.held_keys.get(&HKey(key)).unwrap_or(&false) == true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/input.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | (*self.keys_down.get(&HKey(key)).unwrap_or(&false) == true) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 51 - (*self.keys_down.get(&HKey(key)).unwrap_or(&false) == true) [INFO] [stdout] 51 + *self.keys_down.get(&HKey(key)).unwrap_or(&false) == true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/input.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | (*self.keys_up.get(&HKey(key)).unwrap_or(&false) == true) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 56 - (*self.keys_up.get(&HKey(key)).unwrap_or(&false) == true) [INFO] [stdout] 56 + *self.keys_up.get(&HKey(key)).unwrap_or(&false) == true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `FloatRect` [INFO] [stdout] --> src/animation_sprite.rs:3:39 [INFO] [stdout] | [INFO] [stdout] 3 | use sfml::graphics::{Sprite, IntRect, FloatRect}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AnimationSprite` [INFO] [stdout] --> src/main.rs:21:24 [INFO] [stdout] | [INFO] [stdout] 21 | use animation_sprite::{AnimationSprite}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/main.rs:39:66 [INFO] [stdout] | [INFO] [stdout] 39 | let mut window = match RenderWindow::new(VideoMode::new_init(((level.size.x as u32) * GAME_SIZE), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 39 - let mut window = match RenderWindow::new(VideoMode::new_init(((level.size.x as u32) * GAME_SIZE), [INFO] [stdout] 39 + let mut window = match RenderWindow::new(VideoMode::new_init((level.size.x as u32) * GAME_SIZE, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/main.rs:40:66 [INFO] [stdout] | [INFO] [stdout] 40 | ... ((level.size.y as u32) * GAME_SIZE), 32), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 40 - ((level.size.y as u32) * GAME_SIZE), 32), [INFO] [stdout] 40 + (level.size.y as u32) * GAME_SIZE, 32), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `start_time` is never read [INFO] [stdout] --> src/game_time.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct GameTime { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 7 | pub start_time: units::MS, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `reset_animation` is never used [INFO] [stdout] --> src/animation_sprite.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 18 | impl<'s> AnimationSprite<'s> { [INFO] [stdout] | ---------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 39 | pub fn reset_animation(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message contains an unused formatting placeholder [INFO] [stdout] --> src/sprite_sheet.rs:76:61 [INFO] [stdout] | [INFO] [stdout] 76 | &None => panic!("Unable to retrieve SpriteType::{:?}.") [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this message is not used as a format string when given without arguments, but will be in Rust 2021 [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add the missing argument [INFO] [stdout] | [INFO] [stdout] 76 | &None => panic!("Unable to retrieve SpriteType::{:?}.", ...) [INFO] [stdout] | +++++ [INFO] [stdout] help: or add a "{}" format string to use the message literally [INFO] [stdout] | [INFO] [stdout] 76 | &None => panic!("{}", "Unable to retrieve SpriteType::{:?}.") [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `start_time` is never read [INFO] [stdout] --> src/game_time.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct GameTime { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 7 | pub start_time: units::MS, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `reset_animation` is never used [INFO] [stdout] --> src/animation_sprite.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 18 | impl<'s> AnimationSprite<'s> { [INFO] [stdout] | ---------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 39 | pub fn reset_animation(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message contains an unused formatting placeholder [INFO] [stdout] --> src/sprite_sheet.rs:76:61 [INFO] [stdout] | [INFO] [stdout] 76 | &None => panic!("Unable to retrieve SpriteType::{:?}.") [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this message is not used as a format string when given without arguments, but will be in Rust 2021 [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add the missing argument [INFO] [stdout] | [INFO] [stdout] 76 | &None => panic!("Unable to retrieve SpriteType::{:?}.", ...) [INFO] [stdout] | +++++ [INFO] [stdout] help: or add a "{}" format string to use the message literally [INFO] [stdout] | [INFO] [stdout] 76 | &None => panic!("{}", "Unable to retrieve SpriteType::{:?}.") [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.23s [INFO] running `Command { std: "docker" "inspect" "356e2c8acd1a8315f1bc60722f71c9fd581c51d4f64772b732b87fe722456e55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "356e2c8acd1a8315f1bc60722f71c9fd581c51d4f64772b732b87fe722456e55", kill_on_drop: false }` [INFO] [stdout] 356e2c8acd1a8315f1bc60722f71c9fd581c51d4f64772b732b87fe722456e55