[INFO] fetching crate rtd 0.3.3... [INFO] checking rtd-0.3.3 against master#f167efad2f51088d86180ee89177b3d7c9e7c2f5 for pr-129543 [INFO] extracting crate rtd 0.3.3 into /workspace/builds/worker-3-tc1/source [INFO] validating manifest of crates.io crate rtd 0.3.3 on toolchain f167efad2f51088d86180ee89177b3d7c9e7c2f5 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f167efad2f51088d86180ee89177b3d7c9e7c2f5" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rtd 0.3.3 [INFO] finished tweaking crates.io crate rtd 0.3.3 [INFO] tweaked toml for crates.io crate rtd 0.3.3 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] crate crates.io crate rtd 0.3.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f167efad2f51088d86180ee89177b3d7c9e7c2f5" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.64 [INFO] [stderr] Downloaded wasm-bindgen v0.2.64 [INFO] [stderr] Downloaded tinyvec v0.3.3 [INFO] [stderr] Downloaded pkg-config v0.3.17 [INFO] [stderr] Downloaded vcpkg v0.2.10 [INFO] [stderr] Downloaded linked-hash-map v0.5.3 [INFO] [stderr] Downloaded anyhow v1.0.31 [INFO] [stderr] Downloaded migrant_lib v0.28.0 [INFO] [stderr] Downloaded url v2.1.1 [INFO] [stderr] Downloaded unicode-normalization v0.1.13 [INFO] [stderr] Downloaded serde_json v1.0.56 [INFO] [stderr] Downloaded chrono v0.4.13 [INFO] [stderr] Downloaded rusqlite v0.21.0 [INFO] [stderr] Downloaded cc v1.0.57 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.64 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.64 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.64 [INFO] [stderr] Downloaded libsqlite3-sys v0.17.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f167efad2f51088d86180ee89177b3d7c9e7c2f5" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3c63fae99132192a70dd18bfcf3c4b0485cf3e06d8eb43c0cb606990d8b00310 [INFO] running `Command { std: "docker" "start" "-a" "3c63fae99132192a70dd18bfcf3c4b0485cf3e06d8eb43c0cb606990d8b00310", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3c63fae99132192a70dd18bfcf3c4b0485cf3e06d8eb43c0cb606990d8b00310", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3c63fae99132192a70dd18bfcf3c4b0485cf3e06d8eb43c0cb606990d8b00310", kill_on_drop: false }` [INFO] [stdout] 3c63fae99132192a70dd18bfcf3c4b0485cf3e06d8eb43c0cb606990d8b00310 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f167efad2f51088d86180ee89177b3d7c9e7c2f5" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fef970b36c32e46165b72ba21edbc45fd4f5a83f90e672d8363880a3bf74273c [INFO] running `Command { std: "docker" "start" "-a" "fef970b36c32e46165b72ba21edbc45fd4f5a83f90e672d8363880a3bf74273c", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling serde v1.0.114 [INFO] [stderr] Compiling syn v1.0.33 [INFO] [stderr] Compiling cc v1.0.57 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Checking tinyvec v0.3.3 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Compiling error-chain v0.12.2 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Checking unicode-normalization v0.1.13 [INFO] [stderr] Checking linked-hash-map v0.5.3 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling serde_json v1.0.56 [INFO] [stderr] Compiling serde_derive v1.0.114 [INFO] [stderr] Checking lru-cache v0.1.2 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Compiling anyhow v1.0.31 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Compiling libsqlite3-sys v0.17.3 [INFO] [stderr] Checking idna v0.2.0 [INFO] [stderr] Checking dirs-sys v0.3.5 [INFO] [stderr] Checking encode_unicode v0.3.6 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking chrono v0.4.13 [INFO] [stderr] Checking url v2.1.1 [INFO] [stderr] Checking bstr v0.2.13 [INFO] [stderr] Checking toml v0.5.6 [INFO] [stderr] Checking csv v1.1.3 [INFO] [stderr] Compiling time-macros-impl v0.1.1 [INFO] [stderr] Checking time-macros v0.1.0 [INFO] [stderr] Checking time v0.2.16 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking rusqlite v0.21.0 [INFO] [stderr] Checking migrant_lib v0.28.0 [INFO] [stderr] Checking rtd v0.3.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&Task` instead of cloning the inner type [INFO] [stdout] --> src/view/list.rs:50:52 [INFO] [stdout] | [INFO] [stdout] 50 | let formatter = Formatter::new(task.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/view/single.rs:7:40 [INFO] [stdout] | [INFO] [stdout] 7 | let formatter = Formatter::new(task.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Task` does not implement `Clone`, so calling `clone` on `&Task` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 7 - let formatter = Formatter::new(task.clone()); [INFO] [stdout] 7 + let formatter = Formatter::new(task); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Task`, implement `Clone` for it [INFO] [stdout] --> src/model/task.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10| pub struct Task { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&Task` instead of cloning the inner type [INFO] [stdout] --> src/view/list.rs:50:52 [INFO] [stdout] | [INFO] [stdout] 50 | let formatter = Formatter::new(task.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/view/single.rs:7:40 [INFO] [stdout] | [INFO] [stdout] 7 | let formatter = Formatter::new(task.clone()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Task` does not implement `Clone`, so calling `clone` on `&Task` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 7 - let formatter = Formatter::new(task.clone()); [INFO] [stdout] 7 + let formatter = Formatter::new(task); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Task`, implement `Clone` for it [INFO] [stdout] --> src/model/task.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10| pub struct Task { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 31.14s [INFO] running `Command { std: "docker" "inspect" "fef970b36c32e46165b72ba21edbc45fd4f5a83f90e672d8363880a3bf74273c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fef970b36c32e46165b72ba21edbc45fd4f5a83f90e672d8363880a3bf74273c", kill_on_drop: false }` [INFO] [stdout] fef970b36c32e46165b72ba21edbc45fd4f5a83f90e672d8363880a3bf74273c