[INFO] fetching crate goscript-types 0.1.0... [INFO] checking goscript-types-0.1.0 against master#f167efad2f51088d86180ee89177b3d7c9e7c2f5 for pr-129543 [INFO] extracting crate goscript-types 0.1.0 into /workspace/builds/worker-7-tc1/source [INFO] validating manifest of crates.io crate goscript-types 0.1.0 on toolchain f167efad2f51088d86180ee89177b3d7c9e7c2f5 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f167efad2f51088d86180ee89177b3d7c9e7c2f5" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate goscript-types 0.1.0 [INFO] finished tweaking crates.io crate goscript-types 0.1.0 [INFO] tweaked toml for crates.io crate goscript-types 0.1.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f167efad2f51088d86180ee89177b3d7c9e7c2f5" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] [stderr] Adding num-bigint v0.2.6 (latest: v0.4.6) [INFO] [stderr] Adding num-rational v0.2.4 (latest: v0.4.2) [INFO] [stderr] Adding ordered-float v2.10.1 (latest: v4.2.2) [INFO] [stderr] Adding slotmap v0.4.3 (latest: v1.0.7) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+f167efad2f51088d86180ee89177b3d7c9e7c2f5" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded goscript-parser v0.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f167efad2f51088d86180ee89177b3d7c9e7c2f5" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 050b1bbca8cd47b0ea2875b2eba670cbdfe6d2eae641281a31fe819c680d9e19 [INFO] running `Command { std: "docker" "start" "-a" "050b1bbca8cd47b0ea2875b2eba670cbdfe6d2eae641281a31fe819c680d9e19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "050b1bbca8cd47b0ea2875b2eba670cbdfe6d2eae641281a31fe819c680d9e19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "050b1bbca8cd47b0ea2875b2eba670cbdfe6d2eae641281a31fe819c680d9e19", kill_on_drop: false }` [INFO] [stdout] 050b1bbca8cd47b0ea2875b2eba670cbdfe6d2eae641281a31fe819c680d9e19 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+f167efad2f51088d86180ee89177b3d7c9e7c2f5" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e42602aeda82c063152132f35ddb7ec001535549d8725dd04a3583ac46ff11ff [INFO] running `Command { std: "docker" "start" "-a" "e42602aeda82c063152132f35ddb7ec001535549d8725dd04a3583ac46ff11ff", kill_on_drop: false }` [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking slotmap v0.4.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking goscript-parser v0.1.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking goscript-types v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `check::Checker` [INFO] [stdout] --> src/check/mod.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub use check::Checker; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `IfaceInfo` [INFO] [stdout] --> src/check/mod.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 21 | pub use interface::{IfaceInfo, MethodInfo}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/check/typexpr.rs:621:61 [INFO] [stdout] | [INFO] [stdout] 621 | if info.is_none() || info.as_ref().unwrap().as_ref().borrow().is_empty() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `IfaceInfo` does not implement `Borrow`, so calling `borrow` on `&IfaceInfo` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 621 - if info.is_none() || info.as_ref().unwrap().as_ref().borrow().is_empty() { [INFO] [stdout] 621 + if info.is_none() || info.as_ref().unwrap().as_ref().is_empty() { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `IfaceInfo`, implement `Clone` for it [INFO] [stdout] --> src/check/interface.rs:131:1 [INFO] [stdout] | [INFO] [stdout] 131 + #[derive(Clone)] [INFO] [stdout] 132 | pub struct IfaceInfo { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/check/typexpr.rs:643:55 [INFO] [stdout] | [INFO] [stdout] 643 | let info_ref = info.as_ref().unwrap().as_ref().borrow(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `IfaceInfo` does not implement `Borrow`, so calling `borrow` on `&IfaceInfo` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 643 - let info_ref = info.as_ref().unwrap().as_ref().borrow(); [INFO] [stdout] 643 + let info_ref = info.as_ref().unwrap().as_ref(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `IfaceInfo`, implement `Clone` for it [INFO] [stdout] --> src/check/interface.rs:131:1 [INFO] [stdout] | [INFO] [stdout] 131 + #[derive(Clone)] [INFO] [stdout] 132 | pub struct IfaceInfo { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/check/typexpr.rs:702:9 [INFO] [stdout] | [INFO] [stdout] 702 | drop(info_ref); [INFO] [stdout] | ^^^^^--------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&IfaceInfo` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 702 - drop(info_ref); [INFO] [stdout] 702 + let _ = info_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking regex v1.10.6 [INFO] [stdout] warning: unused import: `check::Checker` [INFO] [stdout] --> src/check/mod.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub use check::Checker; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `IfaceInfo` [INFO] [stdout] --> src/check/mod.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 21 | pub use interface::{IfaceInfo, MethodInfo}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/check/typexpr.rs:621:61 [INFO] [stdout] | [INFO] [stdout] 621 | if info.is_none() || info.as_ref().unwrap().as_ref().borrow().is_empty() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `IfaceInfo` does not implement `Borrow`, so calling `borrow` on `&IfaceInfo` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 621 - if info.is_none() || info.as_ref().unwrap().as_ref().borrow().is_empty() { [INFO] [stdout] 621 + if info.is_none() || info.as_ref().unwrap().as_ref().is_empty() { [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `IfaceInfo`, implement `Clone` for it [INFO] [stdout] --> src/check/interface.rs:131:1 [INFO] [stdout] | [INFO] [stdout] 131 + #[derive(Clone)] [INFO] [stdout] 132 | pub struct IfaceInfo { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/check/typexpr.rs:643:55 [INFO] [stdout] | [INFO] [stdout] 643 | let info_ref = info.as_ref().unwrap().as_ref().borrow(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `IfaceInfo` does not implement `Borrow`, so calling `borrow` on `&IfaceInfo` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 643 - let info_ref = info.as_ref().unwrap().as_ref().borrow(); [INFO] [stdout] 643 + let info_ref = info.as_ref().unwrap().as_ref(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `IfaceInfo`, implement `Clone` for it [INFO] [stdout] --> src/check/interface.rs:131:1 [INFO] [stdout] | [INFO] [stdout] 131 + #[derive(Clone)] [INFO] [stdout] 132 | pub struct IfaceInfo { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/check/typexpr.rs:702:9 [INFO] [stdout] | [INFO] [stdout] 702 | drop(info_ref); [INFO] [stdout] | ^^^^^--------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&IfaceInfo` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 702 - drop(info_ref); [INFO] [stdout] 702 + let _ = info_ref; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.82s [INFO] running `Command { std: "docker" "inspect" "e42602aeda82c063152132f35ddb7ec001535549d8725dd04a3583ac46ff11ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e42602aeda82c063152132f35ddb7ec001535549d8725dd04a3583ac46ff11ff", kill_on_drop: false }` [INFO] [stdout] e42602aeda82c063152132f35ddb7ec001535549d8725dd04a3583ac46ff11ff