[INFO] fetching crate zarchive 0.2.0... [INFO] checking zarchive-0.2.0 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate zarchive 0.2.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate zarchive 0.2.0 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zarchive 0.2.0 [INFO] finished tweaking crates.io crate zarchive 0.2.0 [INFO] tweaked toml for crates.io crate zarchive 0.2.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 49 packages to latest compatible versions [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ecb28c337e016b781a5c178b3ff86510ba00b9223f2a723b22ca87afd1d88b2a [INFO] running `Command { std: "docker" "start" "-a" "ecb28c337e016b781a5c178b3ff86510ba00b9223f2a723b22ca87afd1d88b2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ecb28c337e016b781a5c178b3ff86510ba00b9223f2a723b22ca87afd1d88b2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ecb28c337e016b781a5c178b3ff86510ba00b9223f2a723b22ca87afd1d88b2a", kill_on_drop: false }` [INFO] [stdout] ecb28c337e016b781a5c178b3ff86510ba00b9223f2a723b22ca87afd1d88b2a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 348089868cf4e1f8a3b3e71bb9176de6728f7e63cad040878c35c22cdcb6ba33 [INFO] running `Command { std: "docker" "start" "-a" "348089868cf4e1f8a3b3e71bb9176de6728f7e63cad040878c35c22cdcb6ba33", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling scratch v1.0.7 [INFO] [stderr] Compiling unicode-width v0.1.14 [INFO] [stderr] Compiling termcolor v1.4.1 [INFO] [stderr] Compiling cxxbridge-flags v1.0.128 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling codespan-reporting v0.11.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling cc v1.1.21 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling link-cplusplus v1.0.9 [INFO] [stderr] Compiling cxx v1.0.128 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling cxx-build v1.0.128 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling cxxbridge-macro v1.0.128 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Compiling zarchive v0.2.0 (/tmp/fixit) [INFO] [stderr] Migrating build.rs from 2021 edition to 2024 [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `zarchive` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/reader.rs [INFO] [stderr] * src/writer.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: expected one of `!`, `+`, `::`, `;`, `where`, or `{`, found keyword `unsafe` [INFO] [stderr] --> src/reader.rs:447:80 [INFO] [stderr] | [INFO] [stderr] 442 | unsafe extern "C++" { [INFO] [stderr] | - while parsing this item list starting here [INFO] [stderr] ... [INFO] [stderr] 447 | fn OpenFromFile(path: &str) -> Result>unsafe ; [INFO] [stderr] | ^^^^^^ expected one of `!`, `+`, `::`, `;`, `where`, or `{` [INFO] [stderr] ... [INFO] [stderr] 475 | } [INFO] [stderr] | - the item list ends here [INFO] [stderr] [INFO] [stderr] error: expected one of `!`, `+`, `::`, `;`, `where`, or `{`, found keyword `unsafe` [INFO] [stderr] --> src/writer.rs:33:65 [INFO] [stderr] | [INFO] [stderr] 30 | unsafe extern "C++" { [INFO] [stderr] | - while parsing this item list starting here [INFO] [stderr] ... [INFO] [stderr] 33 | fn Pack(inputPath: &str, outputPath: &str) -> Result<()>unsafe ; [INFO] [stderr] | ^^^^^^ expected one of `!`, `+`, `::`, `;`, `where`, or `{` [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/reader.rs:447:73 [INFO] [stdout] | [INFO] [stdout] 447 | fn OpenFromFile(path: &str) -> Result>; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] = note: `--force-warn missing-unsafe-on-extern` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] 34 | } [INFO] [stderr] | - the item list ends here [INFO] [stderr] [INFO] [stderr] error: expected `;` [INFO] [stderr] --> src/reader.rs:447:80 [INFO] [stderr] | [INFO] [stderr] 447 | fn OpenFromFile(path: &str) -> Result>unsafe ; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] error: expected `;` [INFO] [stderr] --> src/writer.rs:33:65 [INFO] [stderr] | [INFO] [stderr] 33 | fn Pack(inputPath: &str, outputPath: &str) -> Result<()>unsafe ; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/reader.rs:367:29 [INFO] [stderr] | [INFO] [stderr] 367 | let mut dir_entry = ffi::DirEntry::default(); [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/reader.rs:453:40 [INFO] [stdout] | [INFO] [stdout] 453 | ) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] | [INFO] [stderr] help: consider importing one of these structs [INFO] [stderr] | [INFO] [stderr] 14 + use crate::reader::DirEntry; [INFO] [stderr] | [INFO] [stderr] 14 + use std::fs::DirEntry; [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/reader.rs:455:94 [INFO] [stdout] | [INFO] [stdout] 455 | fn IsDirectory(self: &ZArchiveReader, nodeHandle: ZArchiveNodeHandle) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | [INFO] [stderr] help: if you import `DirEntry`, refer to it directly [INFO] [stderr] | [INFO] [stderr] 367 - let mut dir_entry = ffi::DirEntry::default(); [INFO] [stderr] 367 + let mut dir_entry = DirEntry::default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/reader.rs:176:29 [INFO] [stderr] | [INFO] [stderr] 176 | Ok(Self(RwLock::new(ffi::OpenFromFile( [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/writer.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | ffi::Pack( [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/reader.rs:34:12 [INFO] [stderr] | [INFO] [stderr] 34 | inner: ffi::DirEntry<'a>, [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/reader.rs:98:12 [INFO] [stderr] | [INFO] [stderr] 98 | entry: ffi::DirEntry<'a>, [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/reader.rs:162:49 [INFO] [stderr] | [INFO] [stderr] 162 | pub struct ZArchiveReader(RwLock>); [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/reader.rs:456:89 [INFO] [stdout] | [INFO] [stdout] 456 | fn IsFile(self: &ZArchiveReader, nodeHandle: ZArchiveNodeHandle) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/reader.rs:334:29 [INFO] [stderr] | [INFO] [stderr] 334 | dir_entry: &mut ffi::DirEntry, [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error: aborting due to 11 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0433`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/reader.rs:457:98 [INFO] [stdout] | [INFO] [stdout] 457 | fn GetDirEntryCount(self: &ZArchiveReader, nodeHandle: ZArchiveNodeHandle) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/reader.rs:463:26 [INFO] [stdout] | [INFO] [stdout] 463 | ) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/reader.rs:467:25 [INFO] [stdout] | [INFO] [stdout] 467 | ) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/reader.rs:474:25 [INFO] [stdout] | [INFO] [stdout] 474 | ) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/reader.rs:447:71 [INFO] [stdout] | [INFO] [stdout] 447 | fn OpenFromFile(path: &str) -> Result>; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/writer.rs:33:65 [INFO] [stdout] | [INFO] [stdout] 33 | fn Pack(inputPath: &str, outputPath: &str) -> Result<()>; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `zarchive` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/reader.rs [INFO] [stderr] * src/writer.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: expected one of `!`, `+`, `::`, `;`, `where`, or `{`, found keyword `unsafe` [INFO] [stderr] --> src/reader.rs:447:80 [INFO] [stderr] | [INFO] [stderr] 442 | unsafe extern "C++" { [INFO] [stderr] | - while parsing this item list starting here [INFO] [stderr] ... [INFO] [stderr] 447 | fn OpenFromFile(path: &str) -> Result>unsafe ; [INFO] [stderr] | ^^^^^^ expected one of `!`, `+`, `::`, `;`, `where`, or `{` [INFO] [stderr] ... [INFO] [stderr] 475 | } [INFO] [stderr] | - the item list ends here [INFO] [stderr] [INFO] [stderr] error: expected one of `!`, `+`, `::`, `;`, `where`, or `{`, found keyword `unsafe` [INFO] [stderr] --> src/writer.rs:33:65 [INFO] [stderr] | [INFO] [stderr] 30 | unsafe extern "C++" { [INFO] [stderr] | - while parsing this item list starting here [INFO] [stderr] ... [INFO] [stderr] 33 | fn Pack(inputPath: &str, outputPath: &str) -> Result<()>unsafe ; [INFO] [stderr] | ^^^^^^ expected one of `!`, `+`, `::`, `;`, `where`, or `{` [INFO] [stderr] 34 | } [INFO] [stderr] | - the item list ends here [INFO] [stderr] [INFO] [stderr] error: expected `;` [INFO] [stderr] --> src/reader.rs:447:80 [INFO] [stderr] | [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/reader.rs:447:73 [INFO] [stdout] | [INFO] [stdout] 447 | fn OpenFromFile(path: &str) -> Result>; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] = note: `--force-warn missing-unsafe-on-extern` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] 447 | fn OpenFromFile(path: &str) -> Result>unsafe ; [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/reader.rs:453:40 [INFO] [stdout] | [INFO] [stdout] 453 | ) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | ^^^^^^ [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/reader.rs:455:94 [INFO] [stdout] | [INFO] [stdout] 455 | fn IsDirectory(self: &ZArchiveReader, nodeHandle: ZArchiveNodeHandle) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/reader.rs:456:89 [INFO] [stdout] | [INFO] [stdout] 456 | fn IsFile(self: &ZArchiveReader, nodeHandle: ZArchiveNodeHandle) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: expected `;` [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/reader.rs:457:98 [INFO] [stdout] | [INFO] [stdout] 457 | fn GetDirEntryCount(self: &ZArchiveReader, nodeHandle: ZArchiveNodeHandle) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] --> src/writer.rs:33:65 [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/reader.rs:463:26 [INFO] [stdout] | [INFO] [stdout] 463 | ) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/reader.rs:467:25 [INFO] [stdout] | [INFO] [stdout] 467 | ) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] 33 | fn Pack(inputPath: &str, outputPath: &str) -> Result<()>unsafe ; [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/reader.rs:474:25 [INFO] [stdout] | [INFO] [stdout] 474 | ) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | ^^^^^^ [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/reader.rs:447:71 [INFO] [stdout] | [INFO] [stdout] 447 | fn OpenFromFile(path: &str) -> Result>; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/writer.rs:33:65 [INFO] [stdout] | [INFO] [stdout] 33 | fn Pack(inputPath: &str, outputPath: &str) -> Result<()>; [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/reader.rs:367:29 [INFO] [stderr] | [INFO] [stderr] 367 | let mut dir_entry = ffi::DirEntry::default(); [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/reader.rs:551:16 [INFO] [stdout] | [INFO] [stdout] 551 | if let Some(data) = archive.read_from_file(&file, 0, 4) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^-------^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/reader.rs:553:13 [INFO] [stdout] | [INFO] [stdout] 553 | } else if !file.contains("AocMainField") { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 551 ~ match archive.read_from_file(&file, 0, 4) { Some(data) => { [INFO] [stdout] 552 | println!("{}", std::str::from_utf8(&data[..4]).unwrap()); [INFO] [stdout] 553 ~ } _ => if !file.contains("AocMainField") { [INFO] [stdout] 554 | panic!("Failed to get data for {}", file); [INFO] [stdout] 555 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | [INFO] [stdout] warning: 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] help: consider importing one of these structs [INFO] [stderr] | [INFO] [stderr] 14 + use crate::reader::DirEntry; [INFO] [stderr] | [INFO] [stderr] 14 + use std::fs::DirEntry; [INFO] [stderr] | [INFO] [stderr] help: if you import `DirEntry`, refer to it directly [INFO] [stderr] | [INFO] [stderr] 367 - let mut dir_entry = ffi::DirEntry::default(); [INFO] [stderr] 367 + let mut dir_entry = DirEntry::default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/reader.rs:588:29 [INFO] [stderr] | [INFO] [stderr] 588 | let mut dir_entry = ffi::DirEntry::default(); [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] | [INFO] [stderr] help: consider importing one of these structs [INFO] [stderr] | [INFO] [stderr] 480 + use crate::reader::DirEntry; [INFO] [stderr] | [INFO] [stderr] 480 + use std::fs::DirEntry; [INFO] [stderr] | [INFO] [stderr] help: if you import `DirEntry`, refer to it directly [INFO] [stderr] | [INFO] [stderr] 588 - let mut dir_entry = ffi::DirEntry::default(); [INFO] [stderr] 588 + let mut dir_entry = DirEntry::default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/reader.rs:176:29 [INFO] [stderr] | [INFO] [stderr] 176 | Ok(Self(RwLock::new(ffi::OpenFromFile( [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/reader.rs:562:13 [INFO] [stderr] | [INFO] [stderr] 562 | ffi::OpenFromFile("test/crafting.zar").unwrap(); [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/writer.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | ffi::Pack( [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/reader.rs:34:12 [INFO] [stderr] | [INFO] [stderr] 34 | inner: ffi::DirEntry<'a>, [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/reader.rs:98:12 [INFO] [stderr] | [INFO] [stderr] 98 | entry: ffi::DirEntry<'a>, [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/reader.rs:162:49 [INFO] [stderr] | [INFO] [stderr] 162 | pub struct ZArchiveReader(RwLock>); [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/reader.rs:595:42 [INFO] [stderr] | [INFO] [stderr] 595 | archive: &mut cxx::UniquePtr, [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/reader.rs:334:29 [INFO] [stderr] | [INFO] [stderr] 334 | dir_entry: &mut ffi::DirEntry, [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/reader.rs:561:41 [INFO] [stderr] | [INFO] [stderr] 561 | let mut archive: cxx::UniquePtr = [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared crate or module `ffi` [INFO] [stderr] --> src/reader.rs:596:29 [INFO] [stderr] | [INFO] [stderr] 596 | dir_entry: &mut ffi::DirEntry, [INFO] [stderr] | ^^^ use of undeclared crate or module `ffi` [INFO] [stderr] [INFO] [stderr] error: aborting due to 16 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0433`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.46s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Compiling zarchive v0.2.0 (/tmp/fixit) [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/reader.rs:447:73 [INFO] [stdout] | [INFO] [stdout] 447 | fn OpenFromFile(path: &str) -> Result>; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/reader.rs:453:40 [INFO] [stdout] | [INFO] [stdout] 453 | ) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/reader.rs:455:94 [INFO] [stdout] | [INFO] [stdout] 455 | fn IsDirectory(self: &ZArchiveReader, nodeHandle: ZArchiveNodeHandle) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/reader.rs:456:89 [INFO] [stdout] | [INFO] [stdout] 456 | fn IsFile(self: &ZArchiveReader, nodeHandle: ZArchiveNodeHandle) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/reader.rs:457:98 [INFO] [stdout] | [INFO] [stdout] 457 | fn GetDirEntryCount(self: &ZArchiveReader, nodeHandle: ZArchiveNodeHandle) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/reader.rs:463:26 [INFO] [stdout] | [INFO] [stdout] 463 | ) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/reader.rs:467:25 [INFO] [stdout] | [INFO] [stdout] 467 | ) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/reader.rs:474:25 [INFO] [stdout] | [INFO] [stdout] 474 | ) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/reader.rs:447:71 [INFO] [stdout] | [INFO] [stdout] 447 | fn OpenFromFile(path: &str) -> Result>; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/writer.rs:33:65 [INFO] [stdout] | [INFO] [stdout] 33 | fn Pack(inputPath: &str, outputPath: &str) -> Result<()>; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/reader.rs:447:73 [INFO] [stdout] | [INFO] [stdout] 447 | fn OpenFromFile(path: &str) -> Result>; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/reader.rs:453:40 [INFO] [stdout] | [INFO] [stdout] 453 | ) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/reader.rs:455:94 [INFO] [stdout] | [INFO] [stdout] 455 | fn IsDirectory(self: &ZArchiveReader, nodeHandle: ZArchiveNodeHandle) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/reader.rs:456:89 [INFO] [stdout] | [INFO] [stdout] 456 | fn IsFile(self: &ZArchiveReader, nodeHandle: ZArchiveNodeHandle) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/reader.rs:457:98 [INFO] [stdout] | [INFO] [stdout] 457 | fn GetDirEntryCount(self: &ZArchiveReader, nodeHandle: ZArchiveNodeHandle) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/reader.rs:463:26 [INFO] [stdout] | [INFO] [stdout] 463 | ) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/reader.rs:467:25 [INFO] [stdout] | [INFO] [stdout] 467 | ) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/reader.rs:474:25 [INFO] [stdout] | [INFO] [stdout] 474 | ) -> Result; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/reader.rs:447:71 [INFO] [stdout] | [INFO] [stdout] 447 | fn OpenFromFile(path: &str) -> Result>; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/writer.rs:33:65 [INFO] [stdout] | [INFO] [stdout] 33 | fn Pack(inputPath: &str, outputPath: &str) -> Result<()>; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zarchive` (lib) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zarchive` (lib test) due to 11 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "348089868cf4e1f8a3b3e71bb9176de6728f7e63cad040878c35c22cdcb6ba33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "348089868cf4e1f8a3b3e71bb9176de6728f7e63cad040878c35c22cdcb6ba33", kill_on_drop: false }` [INFO] [stdout] 348089868cf4e1f8a3b3e71bb9176de6728f7e63cad040878c35c22cdcb6ba33