[INFO] fetching crate webrtc-util 0.9.0... [INFO] checking webrtc-util-0.9.0 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate webrtc-util 0.9.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate webrtc-util 0.9.0 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate webrtc-util 0.9.0 [INFO] finished tweaking crates.io crate webrtc-util 0.9.0 [INFO] tweaked toml for crates.io crate webrtc-util 0.9.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate webrtc-util 0.9.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7c75a2c87abb862ca49248622ec748575d84e26592c49fb04e64881bb44a7df3 [INFO] running `Command { std: "docker" "start" "-a" "7c75a2c87abb862ca49248622ec748575d84e26592c49fb04e64881bb44a7df3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7c75a2c87abb862ca49248622ec748575d84e26592c49fb04e64881bb44a7df3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c75a2c87abb862ca49248622ec748575d84e26592c49fb04e64881bb44a7df3", kill_on_drop: false }` [INFO] [stdout] 7c75a2c87abb862ca49248622ec748575d84e26592c49fb04e64881bb44a7df3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f1e91bb97b4f48ab78e46cc398814e9529b9b61868775cc80b5e20700fcc1905 [INFO] running `Command { std: "docker" "start" "-a" "f1e91bb97b4f48ab78e46cc398814e9529b9b61868775cc80b5e20700fcc1905", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Compiling serde v1.0.198 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking concurrent-queue v2.4.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Checking event-listener v5.3.0 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking event-listener-strategy v0.5.1 [INFO] [stderr] Checking async-lock v3.3.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking async-task v4.7.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking async-channel v2.2.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking blocking v1.5.1 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking async-executor v1.11.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling serde_derive v1.0.198 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking thiserror v1.0.58 [INFO] [stderr] Checking polling v3.6.0 [INFO] [stderr] Checking async-io v2.3.2 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking webrtc-util v0.9.0 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Fixed src/vnet/resolver.rs (1 fix) [INFO] [stderr] Fixed src/conn/conn_bridge.rs (3 fixes) [INFO] [stderr] Fixed src/vnet/nat.rs (4 fixes) [INFO] [stderr] Fixed src/conn/conn_udp_listener.rs (4 fixes) [INFO] [stderr] Fixed src/vnet/conn_map.rs (2 fixes) [INFO] [stderr] Fixed src/vnet/net.rs (9 fixes) [INFO] [stderr] Fixed src/vnet/router.rs (8 fixes) [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vnet/conn.rs:85:15 [INFO] [stdout] | [INFO] [stdout] 85 | while let Some(chunk) = read_ch.recv().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vnet/conn.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vnet/router.rs:320:19 [INFO] [stdout] | [INFO] [stdout] 320 | while let Ok(d) = Router::process_chunks( [INFO] [stdout] | ___________________^ - [INFO] [stdout] | |_______________________________| [INFO] [stdout] 321 | || &name, [INFO] [stdout] 322 | || ipv4net, [INFO] [stdout] 323 | || max_jitter, [INFO] [stdout] ... || [INFO] [stdout] 327 | || ) [INFO] [stdout] 328 | || .await [INFO] [stdout] | ||__________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |__________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vnet/router.rs:344:13 [INFO] [stdout] | [INFO] [stdout] 344 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating benches/bench.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/vnet/net/net_test.rs (6 fixes) [INFO] [stderr] Migrating examples/display-interfaces.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/vnet/resolver/resolver_test.rs (4 fixes) [INFO] [stderr] Fixed src/vnet/router/router_test.rs (5 fixes) [INFO] [stderr] Fixed src/conn/conn_bridge_test.rs (1 fix) [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vnet/conn.rs:85:15 [INFO] [stdout] | [INFO] [stdout] 85 | while let Some(chunk) = read_ch.recv().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vnet/conn.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vnet/router.rs:320:19 [INFO] [stdout] | [INFO] [stdout] 320 | while let Ok(d) = Router::process_chunks( [INFO] [stdout] | ___________________^ - [INFO] [stdout] | |_______________________________| [INFO] [stdout] 321 | || &name, [INFO] [stdout] 322 | || ipv4net, [INFO] [stdout] 323 | || max_jitter, [INFO] [stdout] ... || [INFO] [stdout] 327 | || ) [INFO] [stdout] 328 | || .await [INFO] [stdout] | ||__________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |__________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vnet/router.rs:344:13 [INFO] [stdout] | [INFO] [stdout] 344 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.29s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking webrtc-util v0.9.0 (/tmp/fixit) [INFO] [stdout] error[E0515]: cannot return value referencing temporary value [INFO] [stdout] --> src/conn/conn_udp_listener.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | ListenConfig::default().listen(laddr).await [INFO] [stdout] | -----------------------^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | returns a value referencing data owned by the current function [INFO] [stdout] | temporary value created here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0515]: cannot return value referencing temporary value [INFO] [stdout] --> src/conn/conn_udp_listener.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | ListenConfig::default().listen(laddr).await [INFO] [stdout] | -----------------------^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | returns a value referencing data owned by the current function [INFO] [stdout] | temporary value created here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0515`. [INFO] [stdout] [INFO] [stderr] error: could not compile `webrtc-util` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> src/conn/conn_udp_listener_test.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 69 | let listener = ListenConfig { [INFO] [stdout] | ____________________^ [INFO] [stdout] 70 | | backlog: BACKLOG, [INFO] [stdout] 71 | | ..Default::default() [INFO] [stdout] 72 | | } [INFO] [stdout] | |_____^ creates a temporary value which is freed while still in use [INFO] [stdout] 73 | .listen("0.0.0.0:0") [INFO] [stdout] 74 | .await?; [INFO] [stdout] | - temporary value is freed at the end of this statement [INFO] [stdout] ... [INFO] [stdout] 90 | } [INFO] [stdout] | - borrow might be used here, when `listener` is dropped and runs the destructor for type `impl conn::Listener` [INFO] [stdout] | [INFO] [stdout] help: consider using a `let` binding to create a longer lived value [INFO] [stdout] | [INFO] [stdout] 69 ~ let binding = ListenConfig { [INFO] [stdout] 70 + backlog: BACKLOG, [INFO] [stdout] 71 + ..Default::default() [INFO] [stdout] 72 + }; [INFO] [stdout] 73 ~ let listener = binding [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> src/conn/conn_udp_listener_test.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | // ListenConfig { [INFO] [stdout] 106 | || accept_filter, [INFO] [stdout] 107 | || ..Default::default() [INFO] [stdout] 108 | || } [INFO] [stdout] | ||_____________^ creates a temporary value which is freed while still in use [INFO] [stdout] 109 | | .listen("0.0.0.0:0") [INFO] [stdout] | |_________________________________- argument requires that borrow lasts for `'static` [INFO] [stdout] 110 | .await?, [INFO] [stdout] 111 | ); [INFO] [stdout] | - temporary value is freed at the end of this statement [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> src/conn/conn_udp_listener_test.rs:162:9 [INFO] [stdout] | [INFO] [stdout] 162 | // ListenConfig { [INFO] [stdout] 163 | || backlog: BACKLOG, [INFO] [stdout] 164 | || ..Default::default() [INFO] [stdout] 165 | || } [INFO] [stdout] | ||_________^ creates a temporary value which is freed while still in use [INFO] [stdout] 166 | | .listen("0.0.0.0:0") [INFO] [stdout] | |_____________________________- argument requires that borrow lasts for `'static` [INFO] [stdout] 167 | .await?, [INFO] [stdout] 168 | ); [INFO] [stdout] | - temporary value is freed at the end of this statement [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] Some errors have detailed explanations: E0515, E0716. [INFO] [stdout] [INFO] [stdout] For more information about an error, try `rustc --explain E0515`. [INFO] [stdout] [INFO] [stderr] error: could not compile `webrtc-util` (lib test) due to 5 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "f1e91bb97b4f48ab78e46cc398814e9529b9b61868775cc80b5e20700fcc1905", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1e91bb97b4f48ab78e46cc398814e9529b9b61868775cc80b5e20700fcc1905", kill_on_drop: false }` [INFO] [stdout] f1e91bb97b4f48ab78e46cc398814e9529b9b61868775cc80b5e20700fcc1905