[INFO] fetching crate vineyard 0.18.1... [INFO] checking vineyard-0.18.1 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate vineyard 0.18.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate vineyard 0.18.1 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vineyard 0.18.1 [INFO] finished tweaking crates.io crate vineyard 0.18.1 [INFO] tweaked toml for crates.io crate vineyard 0.18.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 116 packages to latest compatible versions [INFO] [stderr] Adding arrow-array v46.0.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-buffer v46.0.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-cast v46.0.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-data v46.0.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-ipc v46.0.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-schema v46.0.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-select v46.0.0 (available: v53.0.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding flatbuffers v23.5.26 (available: v24.3.25) [INFO] [stderr] Adding itertools v0.11.0 (available: v0.13.0) [INFO] [stderr] Adding lexical-core v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding lexical-parse-float v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding lexical-parse-integer v0.8.6 (available: v1.0.2) [INFO] [stderr] Adding lexical-util v0.8.5 (available: v1.0.3) [INFO] [stderr] Adding lexical-write-float v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding lexical-write-integer v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding memmap2 v0.7.1 (available: v0.9.5) [INFO] [stderr] Adding num v0.1.42 (available: v0.4.3) [INFO] [stderr] Adding num-bigint v0.1.44 (available: v0.4.6) [INFO] [stderr] Adding num-complex v0.1.43 (available: v0.4.6) [INFO] [stderr] Adding num-rational v0.1.42 (available: v0.4.2) [INFO] [stderr] Adding rand v0.4.6 (available: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (available: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (available: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (available: v0.8.3) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 03d3a42527f24d388e3ff824dd29becb1c7cb52c253a5db30c64f4c288b059c7 [INFO] running `Command { std: "docker" "start" "-a" "03d3a42527f24d388e3ff824dd29becb1c7cb52c253a5db30c64f4c288b059c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "03d3a42527f24d388e3ff824dd29becb1c7cb52c253a5db30c64f4c288b059c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "03d3a42527f24d388e3ff824dd29becb1c7cb52c253a5db30c64f4c288b059c7", kill_on_drop: false }` [INFO] [stdout] 03d3a42527f24d388e3ff824dd29becb1c7cb52c253a5db30c64f4c288b059c7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e192ea747aaf8ad4055cd8cd1d73f5c1bf52867748943d3abcdafd7b0a6b9bd5 [INFO] running `Command { std: "docker" "start" "-a" "e192ea747aaf8ad4055cd8cd1d73f5c1bf52867748943d3abcdafd7b0a6b9bd5", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking arrow-schema v46.0.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking sendfd v0.4.3 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Compiling flatbuffers v23.5.26 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling uuid v1.10.0 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking arrow-buffer v46.0.0 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking spectral v0.6.0 [INFO] [stderr] Checking arrow-data v46.0.0 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling gensym v0.1.1 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling ctor v0.2.8 [INFO] [stderr] Checking static_str_ops v0.1.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking arrow-array v46.0.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking arrow-select v46.0.0 [INFO] [stderr] Checking arrow-cast v46.0.0 [INFO] [stderr] Checking arrow-ipc v46.0.0 [INFO] [stderr] Checking vineyard v0.18.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `vineyard` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/client/ipc_client.rs [INFO] [stderr] * src/common/util/typename.rs [INFO] [stderr] * src/ds/arrow_utils.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/client/ipc_client.rs:490:38 [INFO] [stderr] | [INFO] [stderr] 490 | ($client: ident, $object_ty: ty, $object_id: expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/client/ipc_client.rs:497:6 [INFO] [stderr] | [INFO] [stderr] 497 | ($client: expr_2021, $builder_ty: ty, $($arg: expr_2021),* $(,)?) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/client/ipc_client.rs:497:45 [INFO] [stderr] | [INFO] [stderr] 497 | ($client: expr_2021, $builder_ty: ty, $($arg: expr_2021),* $(,)?) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/common/util/typename.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | ($t:ty, $name:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/ds/arrow_utils.rs:29:14 [INFO] [stderr] | [INFO] [stderr] 29 | ($ty:ty, $datatype:expr_2021, $type:ty, $array_ty:ty, $builder_ty:ty) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/common/util/uuid.rs:29:33 [INFO] [stdout] | [INFO] [stdout] 29 | 0x7FFFFFFFFFFFFFFFu64 & rng.gen::() [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/common/util/uuid.rs:34:33 [INFO] [stdout] | [INFO] [stdout] 34 | 0x7FFFFFFFFFFFFFFFu64 & rng.gen::() [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/client/ipc_client.rs:490:50 [INFO] [stdout] | [INFO] [stdout] 490 | ($client: ident, $object_ty: ty, $object_id: expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 490 | ($client: ident, $object_ty: ty, $object_id: expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/client/ipc_client.rs:497:15 [INFO] [stdout] | [INFO] [stdout] 497 | ($client: expr, $builder_ty: ty, $($arg: expr),* $(,)?) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 497 | ($client: expr_2021, $builder_ty: ty, $($arg: expr),* $(,)?) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/client/ipc_client.rs:497:46 [INFO] [stdout] | [INFO] [stdout] 497 | ($client: expr, $builder_ty: ty, $($arg: expr),* $(,)?) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 497 | ($client: expr, $builder_ty: ty, $($arg: expr_2021),* $(,)?) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/common/util/typename.rs:41:19 [INFO] [stdout] | [INFO] [stdout] 41 | ($t:ty, $name:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 41 | ($t:ty, $name:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/ds/arrow_utils.rs:29:24 [INFO] [stdout] | [INFO] [stdout] 29 | ($ty:ty, $datatype:expr, $type:ty, $array_ty:ty, $builder_ty:ty) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 29 | ($ty:ty, $datatype:expr_2021, $type:ty, $array_ty:ty, $builder_ty:ty) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/ds/blob.rs:336:12 [INFO] [stdout] | [INFO] [stdout] 336 | if let Err(err) = self.abort() { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/ds/blob.rs:338:9 [INFO] [stdout] | [INFO] [stdout] 338 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 336 ~ match self.abort() { Err(err) => { [INFO] [stdout] 337 | error!("Failed to abort blob writer: {}, {}", self.object_id, err); [INFO] [stdout] 338 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/ds/object_meta.rs:379:24 [INFO] [stdout] | [INFO] [stdout] 379 | if let Ok(Some(buf)) = self.buffers.get(*id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/ds/object_meta.rs:381:21 [INFO] [stdout] | [INFO] [stdout] 381 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 379 ~ match self.buffers.get(*id) { Ok(Some(buf)) => { [INFO] [stdout] 380 | let _ = buffer.insert(buf); [INFO] [stdout] 381 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/ds/object_meta.rs:520:16 [INFO] [stdout] | [INFO] [stdout] 520 | if let Ok(client) = self.get_client() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/ds/object_meta.rs:522:13 [INFO] [stdout] | [INFO] [stdout] 522 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 520 ~ match self.get_client() { Ok(client) => { [INFO] [stdout] 521 | instance_id = client.instance_id(); [INFO] [stdout] 522 ~ } _ => { [INFO] [stdout] 523 | // no client instance, ignore [INFO] [stdout] 524 | return Ok(()); [INFO] [stdout] 525 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/ipc_client.rs:209:16 [INFO] [stdout] | [INFO] [stdout] 209 | if let Err(err) = self.do_write(&message_out) { [INFO] [stdout] | ^^^^^^^^^^^^^^^--------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/ipc_client.rs:211:13 [INFO] [stdout] | [INFO] [stdout] 211 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 209 ~ match self.do_write(&message_out) { Err(err) => { [INFO] [stdout] 210 | error!("Failed to disconnect the client: {}", err); [INFO] [stdout] 211 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/ipc_client.rs:310:20 [INFO] [stdout] | [INFO] [stdout] 310 | if let Some(buffer) = buffers.get(&buffer_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-------^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/ipc_client.rs:312:17 [INFO] [stdout] | [INFO] [stdout] 312 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 310 ~ match buffers.get(&buffer_id) { Some(buffer) => { [INFO] [stdout] 311 | meta.set_buffer(buffer_id, buffer.clone())?; [INFO] [stdout] 312 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/ipc_client.rs:466:12 [INFO] [stdout] | [INFO] [stdout] 466 | if let Some(client) = clients.get(&socket) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-------^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/ipc_client.rs:471:9 [INFO] [stdout] | [INFO] [stdout] 471 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 466 ~ match clients.get(&socket) { Some(client) => { [INFO] [stdout] 467 | if Arc::strong_count(client) == 1 { [INFO] [stdout] ... [INFO] [stdout] 470 | return Ok(()); [INFO] [stdout] 471 ~ } _ => { [INFO] [stdout] 472 | return Err(VineyardError::invalid(format!( [INFO] [stdout] ... [INFO] [stdout] 475 | ))); [INFO] [stdout] 476 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/rpc_client.rs:56:16 [INFO] [stdout] | [INFO] [stdout] 56 | if let Err(err) = self.do_write(&message_out) { [INFO] [stdout] | ^^^^^^^^^^^^^^^--------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/rpc_client.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 56 ~ match self.do_write(&message_out) { Err(err) => { [INFO] [stdout] 57 | error!("Failed to disconnect the client: {}", err); [INFO] [stdout] 58 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/rpc_client.rs:224:12 [INFO] [stdout] | [INFO] [stdout] 224 | if let Some(client) = clients.get(&endpoint) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-------^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/rpc_client.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 229 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 224 ~ match clients.get(&endpoint) { Some(client) => { [INFO] [stdout] 225 | if Arc::strong_count(client) == 1 { [INFO] [stdout] ... [INFO] [stdout] 228 | return Ok(()); [INFO] [stdout] 229 ~ } _ => { [INFO] [stdout] 230 | return Err(VineyardError::invalid(format!( [INFO] [stdout] ... [INFO] [stdout] 233 | ))); [INFO] [stdout] 234 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/ds/arrow.rs:227:12 [INFO] [stdout] | [INFO] [stdout] 227 | if let Some(null_bitmap) = null_bitmap { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/ds/arrow.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 229 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 227 ~ match null_bitmap { Some(null_bitmap) => { [INFO] [stdout] 228 | meta.add_member("null_bitmap_", null_bitmap)?; [INFO] [stdout] 229 ~ } _ => { [INFO] [stdout] 230 | meta.add_member("null_bitmap_", Blob::empty(client)?)?; [INFO] [stdout] 231 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/ds/arrow.rs:443:12 [INFO] [stdout] | [INFO] [stdout] 443 | if let Some(null_bitmap) = null_bitmap { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/ds/arrow.rs:445:9 [INFO] [stdout] | [INFO] [stdout] 445 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 443 ~ match null_bitmap { Some(null_bitmap) => { [INFO] [stdout] 444 | meta.add_member("null_bitmap_", null_bitmap)?; [INFO] [stdout] 445 ~ } _ => { [INFO] [stdout] 446 | meta.add_member("null_bitmap_", Blob::empty(client)?)?; [INFO] [stdout] 447 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `vineyard` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/client/ipc_client.rs [INFO] [stderr] * src/common/util/typename.rs [INFO] [stderr] * src/ds/arrow_utils.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/client/ipc_client.rs:490:38 [INFO] [stderr] | [INFO] [stderr] 490 | ($client: ident, $object_ty: ty, $object_id: expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/client/ipc_client.rs:497:6 [INFO] [stderr] | [INFO] [stderr] 497 | ($client: expr_2021, $builder_ty: ty, $($arg: expr_2021),* $(,)?) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/client/ipc_client.rs:497:45 [INFO] [stderr] | [INFO] [stderr] 497 | ($client: expr_2021, $builder_ty: ty, $($arg: expr_2021),* $(,)?) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/common/util/typename.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | ($t:ty, $name:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/ds/arrow_utils.rs:29:14 [INFO] [stderr] | [INFO] [stderr] 29 | ($ty:ty, $datatype:expr_2021, $type:ty, $array_ty:ty, $builder_ty:ty) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/common/util/uuid.rs:29:33 [INFO] [stdout] | [INFO] [stdout] 29 | 0x7FFFFFFFFFFFFFFFu64 & rng.gen::() [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/common/util/uuid.rs:34:33 [INFO] [stdout] | [INFO] [stdout] 34 | 0x7FFFFFFFFFFFFFFFu64 & rng.gen::() [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/client/ipc_client.rs:490:50 [INFO] [stdout] | [INFO] [stdout] 490 | ($client: ident, $object_ty: ty, $object_id: expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 490 | ($client: ident, $object_ty: ty, $object_id: expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/client/ipc_client.rs:497:15 [INFO] [stdout] | [INFO] [stdout] 497 | ($client: expr, $builder_ty: ty, $($arg: expr),* $(,)?) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 497 | ($client: expr_2021, $builder_ty: ty, $($arg: expr),* $(,)?) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/client/ipc_client.rs:497:46 [INFO] [stdout] | [INFO] [stdout] 497 | ($client: expr, $builder_ty: ty, $($arg: expr),* $(,)?) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 497 | ($client: expr, $builder_ty: ty, $($arg: expr_2021),* $(,)?) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/common/util/typename.rs:41:19 [INFO] [stdout] | [INFO] [stdout] 41 | ($t:ty, $name:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 41 | ($t:ty, $name:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/ds/arrow_utils.rs:29:24 [INFO] [stdout] | [INFO] [stdout] 29 | ($ty:ty, $datatype:expr, $type:ty, $array_ty:ty, $builder_ty:ty) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 29 | ($ty:ty, $datatype:expr_2021, $type:ty, $array_ty:ty, $builder_ty:ty) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/ds/blob.rs:336:12 [INFO] [stdout] | [INFO] [stdout] 336 | if let Err(err) = self.abort() { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/ds/blob.rs:338:9 [INFO] [stdout] | [INFO] [stdout] 338 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 336 ~ match self.abort() { Err(err) => { [INFO] [stdout] 337 | error!("Failed to abort blob writer: {}, {}", self.object_id, err); [INFO] [stdout] 338 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/ds/object_meta.rs:379:24 [INFO] [stdout] | [INFO] [stdout] 379 | if let Ok(Some(buf)) = self.buffers.get(*id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/ds/object_meta.rs:381:21 [INFO] [stdout] | [INFO] [stdout] 381 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 379 ~ match self.buffers.get(*id) { Ok(Some(buf)) => { [INFO] [stdout] 380 | let _ = buffer.insert(buf); [INFO] [stdout] 381 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/ds/object_meta.rs:520:16 [INFO] [stdout] | [INFO] [stdout] 520 | if let Ok(client) = self.get_client() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/ds/object_meta.rs:522:13 [INFO] [stdout] | [INFO] [stdout] 522 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 520 ~ match self.get_client() { Ok(client) => { [INFO] [stdout] 521 | instance_id = client.instance_id(); [INFO] [stdout] 522 ~ } _ => { [INFO] [stdout] 523 | // no client instance, ignore [INFO] [stdout] 524 | return Ok(()); [INFO] [stdout] 525 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/ipc_client.rs:209:16 [INFO] [stdout] | [INFO] [stdout] 209 | if let Err(err) = self.do_write(&message_out) { [INFO] [stdout] | ^^^^^^^^^^^^^^^--------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/ipc_client.rs:211:13 [INFO] [stdout] | [INFO] [stdout] 211 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 209 ~ match self.do_write(&message_out) { Err(err) => { [INFO] [stdout] 210 | error!("Failed to disconnect the client: {}", err); [INFO] [stdout] 211 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/ipc_client.rs:310:20 [INFO] [stdout] | [INFO] [stdout] 310 | if let Some(buffer) = buffers.get(&buffer_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-------^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/ipc_client.rs:312:17 [INFO] [stdout] | [INFO] [stdout] 312 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 310 ~ match buffers.get(&buffer_id) { Some(buffer) => { [INFO] [stdout] 311 | meta.set_buffer(buffer_id, buffer.clone())?; [INFO] [stdout] 312 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/ipc_client.rs:466:12 [INFO] [stdout] | [INFO] [stdout] 466 | if let Some(client) = clients.get(&socket) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-------^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/ipc_client.rs:471:9 [INFO] [stdout] | [INFO] [stdout] 471 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 466 ~ match clients.get(&socket) { Some(client) => { [INFO] [stdout] 467 | if Arc::strong_count(client) == 1 { [INFO] [stdout] ... [INFO] [stdout] 470 | return Ok(()); [INFO] [stdout] 471 ~ } _ => { [INFO] [stdout] 472 | return Err(VineyardError::invalid(format!( [INFO] [stdout] ... [INFO] [stdout] 475 | ))); [INFO] [stdout] 476 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/rpc_client.rs:56:16 [INFO] [stdout] | [INFO] [stdout] 56 | if let Err(err) = self.do_write(&message_out) { [INFO] [stdout] | ^^^^^^^^^^^^^^^--------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/rpc_client.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 56 ~ match self.do_write(&message_out) { Err(err) => { [INFO] [stdout] 57 | error!("Failed to disconnect the client: {}", err); [INFO] [stdout] 58 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/rpc_client.rs:224:12 [INFO] [stdout] | [INFO] [stdout] 224 | if let Some(client) = clients.get(&endpoint) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-------^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/rpc_client.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 229 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 224 ~ match clients.get(&endpoint) { Some(client) => { [INFO] [stdout] 225 | if Arc::strong_count(client) == 1 { [INFO] [stdout] ... [INFO] [stdout] 228 | return Ok(()); [INFO] [stdout] 229 ~ } _ => { [INFO] [stdout] 230 | return Err(VineyardError::invalid(format!( [INFO] [stdout] ... [INFO] [stdout] 233 | ))); [INFO] [stdout] 234 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/ds/arrow.rs:227:12 [INFO] [stdout] | [INFO] [stdout] 227 | if let Some(null_bitmap) = null_bitmap { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/ds/arrow.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 229 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 227 ~ match null_bitmap { Some(null_bitmap) => { [INFO] [stdout] 228 | meta.add_member("null_bitmap_", null_bitmap)?; [INFO] [stdout] 229 ~ } _ => { [INFO] [stdout] 230 | meta.add_member("null_bitmap_", Blob::empty(client)?)?; [INFO] [stdout] 231 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/ds/arrow.rs:443:12 [INFO] [stdout] | [INFO] [stdout] 443 | if let Some(null_bitmap) = null_bitmap { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/ds/arrow.rs:445:9 [INFO] [stdout] | [INFO] [stdout] 445 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 443 ~ match null_bitmap { Some(null_bitmap) => { [INFO] [stdout] 444 | meta.add_member("null_bitmap_", null_bitmap)?; [INFO] [stdout] 445 ~ } _ => { [INFO] [stdout] 446 | meta.add_member("null_bitmap_", Blob::empty(client)?)?; [INFO] [stdout] 447 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.75s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: num-bigint v0.1.44, num-complex v0.1.43, num-rational v0.1.42 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking vineyard v0.18.1 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/common/util/uuid.rs:29:33 [INFO] [stdout] | [INFO] [stdout] 29 | 0x7FFFFFFFFFFFFFFFu64 & rng.gen::() [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 29 | 0x7FFFFFFFFFFFFFFFu64 & rng.r#gen::() [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/common/util/uuid.rs:29:33 [INFO] [stdout] | [INFO] [stdout] 29 | 0x7FFFFFFFFFFFFFFFu64 & rng.gen::() [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 29 | 0x7FFFFFFFFFFFFFFFu64 & rng.r#gen::() [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/common/util/uuid.rs:34:33 [INFO] [stdout] | [INFO] [stdout] 34 | 0x7FFFFFFFFFFFFFFFu64 & rng.gen::() [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 34 | 0x7FFFFFFFFFFFFFFFu64 & rng.r#gen::() [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/common/util/uuid.rs:34:33 [INFO] [stdout] | [INFO] [stdout] 34 | 0x7FFFFFFFFFFFFFFFu64 & rng.gen::() [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 34 | 0x7FFFFFFFFFFFFFFFu64 & rng.r#gen::() [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vineyard` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vineyard` (lib test) due to 3 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "e192ea747aaf8ad4055cd8cd1d73f5c1bf52867748943d3abcdafd7b0a6b9bd5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e192ea747aaf8ad4055cd8cd1d73f5c1bf52867748943d3abcdafd7b0a6b9bd5", kill_on_drop: false }` [INFO] [stdout] e192ea747aaf8ad4055cd8cd1d73f5c1bf52867748943d3abcdafd7b0a6b9bd5