[INFO] fetching crate vertigo 0.6.0... [INFO] checking vertigo-0.6.0 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate vertigo 0.6.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate vertigo 0.6.0 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate vertigo 0.6.0 [INFO] finished tweaking crates.io crate vertigo 0.6.0 [INFO] tweaked toml for crates.io crate vertigo 0.6.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 43 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (available: v0.22.1) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding heck v0.3.3 (available: v0.5.0) [INFO] [stderr] Adding itertools v0.12.1 (available: v0.13.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding syn-rsx v0.8.1 (available: v0.9.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 93473915907e1da2110b36feb353cb9ce2389e0be6cbe1040bcad9be0304a20a [INFO] running `Command { std: "docker" "start" "-a" "93473915907e1da2110b36feb353cb9ce2389e0be6cbe1040bcad9be0304a20a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "93473915907e1da2110b36feb353cb9ce2389e0be6cbe1040bcad9be0304a20a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93473915907e1da2110b36feb353cb9ce2389e0be6cbe1040bcad9be0304a20a", kill_on_drop: false }` [INFO] [stdout] 93473915907e1da2110b36feb353cb9ce2389e0be6cbe1040bcad9be0304a20a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d081ea5b59b7f881abb538dd464125e9102c7b9a4adee7e8c67cfcdd3448afac [INFO] running `Command { std: "docker" "start" "-a" "d081ea5b59b7f881abb538dd464125e9102c7b9a4adee7e8c67cfcdd3448afac", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Fixed Cargo.toml (1 fix) [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling unicode-segmentation v1.12.0 [INFO] [stderr] Compiling crc-catalog v2.4.0 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling base64 v0.21.7 [INFO] [stderr] Compiling vertigo v0.6.0 (/tmp/fixit) [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Migrating build.rs from 2021 edition to 2024 [INFO] [stderr] Compiling crc v3.2.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling pkg-version-impl v0.1.1 [INFO] [stderr] Compiling pkg-version v1.0.0 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling pest v2.7.13 [INFO] [stderr] Compiling syn-rsx v0.8.1 [INFO] [stderr] Compiling bae v0.1.7 [INFO] [stderr] Compiling pest_meta v2.7.13 [INFO] [stderr] Compiling pest_generator v2.7.13 [INFO] [stderr] Compiling pest_derive v2.7.13 [INFO] [stderr] Compiling vertigo-macro v0.6.0 [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `vertigo` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/computed/mod.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/computed/mod.rs:67:24 [INFO] [stderr] | [INFO] [stderr] 67 | ($($name: ident => $arg: expr_2021),*) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/lib.rs:457:3 [INFO] [stdout] | [INFO] [stdout] 457 | #[no_mangle] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] = note: `--force-warn unsafe-attr-outside-unsafe` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 457 | #[unsafe(no_mangle)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/computed/mod.rs:67:30 [INFO] [stdout] | [INFO] [stdout] 67 | ($($name: ident => $arg: expr),*) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 67 | ($($name: ident => $arg: expr_2021),*) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::rc::Rc::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:52:41 [INFO] [stdout] | [INFO] [stdout] 52 | let ptr = ManuallyDrop::new(Rc::from_raw(ptr as *const Task)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | unsafe fn raw_clone(ptr: *const ()) -> RawWaker { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `--force-warn unsafe-op-in-unsafe-fn` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `driver_module::utils::futures_spawn::Task::into_raw_waker` is unsafe and requires unsafe block [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | Task::into_raw_waker((*ptr).clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::rc::Rc::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:57:23 [INFO] [stdout] | [INFO] [stdout] 57 | let ptr = Rc::from_raw(ptr as *const Task); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | unsafe fn raw_wake(ptr: *const ()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::rc::Rc::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:62:41 [INFO] [stdout] | [INFO] [stdout] 62 | let ptr = ManuallyDrop::new(Rc::from_raw(ptr as *const Task)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | unsafe fn raw_wake_by_ref(ptr: *const ()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::rc::Rc::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 67 | drop(Rc::from_raw(ptr as *const Task)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | unsafe fn raw_drop(ptr: *const ()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/computed/dependencies/external_connections.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | if let Some(connect_func) = self.connect.get_and_clone(&id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/computed/dependencies/external_connections.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 34 ~ match self.connect.get_and_clone(&id) { Some(connect_func) => { [INFO] [stdout] 35 | self.connected_resource.insert(id, connect_func()); [INFO] [stdout] 36 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/computed/dependencies/refresh.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 40 | if let Some(refresh) = self.get(id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/computed/dependencies/refresh.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 40 ~ match self.get(id) { Some(refresh) => { [INFO] [stdout] 41 | refresh(true); [INFO] [stdout] 42 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/computed/dependencies/refresh.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 46 | if let Some(refresh) = self.get(id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/computed/dependencies/refresh.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 46 ~ match self.get(id) { Some(refresh) => { [INFO] [stdout] 47 | refresh(false); [INFO] [stdout] 48 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/computed/drop_resource.rs:27:20 [INFO] [stdout] | [INFO] [stdout] 27 | if let Some(drop_fun) = drop_fun { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/computed/drop_resource.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 29 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 27 ~ match drop_fun { Some(drop_fun) => { [INFO] [stdout] 28 | drop_fun(); [INFO] [stdout] 29 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/computed/graph_value.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 35 | if let Some(weak_value) = weak_value.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/computed/graph_value.rs:46:17 [INFO] [stdout] | [INFO] [stdout] 46 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 35 ~ match weak_value.upgrade() { Some(weak_value) => { [INFO] [stdout] 36 | match kind { [INFO] [stdout] ... [INFO] [stdout] 45 | } [INFO] [stdout] 46 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/computed/struct_mut/hash_map_mut.rs:70:16 [INFO] [stdout] | [INFO] [stdout] 70 | if let Some(mapped) = map(value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/computed/struct_mut/hash_map_mut.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 70 ~ match map(value) { Some(mapped) => { [INFO] [stdout] 71 | list.push(mapped); [INFO] [stdout] 72 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/driver_module/api/arguments.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | if let Some(param) = param { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/driver_module/api/arguments.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 33 ~ match param { Some(param) => { [INFO] [stdout] 34 | match JsValue::from_block(param) { [INFO] [stdout] ... [INFO] [stdout] 40 | } [INFO] [stdout] 41 ~ } _ => { [INFO] [stdout] 42 | log::error!("get_by_ptr - not found MemoryBlock ptr={ptr}"); [INFO] [stdout] 43 | JsValue::Undefined [INFO] [stdout] 44 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/driver_module/driver.rs:278:24 [INFO] [stdout] | [INFO] [stdout] 278 | if let Some(callback) = callback_ref.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^------------^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/driver_module/driver.rs:282:21 [INFO] [stdout] | [INFO] [stdout] 282 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 278 ~ match callback_ref.as_deref() { Some(callback) => { [INFO] [stdout] 279 | if let Some(body) = callback(&url) { [INFO] [stdout] 280 | self.inner.api.plain_response(body) [INFO] [stdout] 281 | } [INFO] [stdout] 282 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/future_box.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 40 | if let Some(w) = self.inner.waker.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/future_box.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 40 ~ match self.inner.waker.take() { Some(w) => { [INFO] [stdout] 41 | w.wake() [INFO] [stdout] 42 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `vertigo` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/computed/mod.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/computed/mod.rs:67:24 [INFO] [stderr] | [INFO] [stderr] 67 | ($($name: ident => $arg: expr_2021),*) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: unsafe attribute used without unsafe [INFO] [stdout] --> src/lib.rs:457:3 [INFO] [stdout] | [INFO] [stdout] 457 | #[no_mangle] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123757 [INFO] [stdout] = note: `--force-warn unsafe-attr-outside-unsafe` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 457 | #[unsafe(no_mangle)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/computed/mod.rs:67:30 [INFO] [stdout] | [INFO] [stdout] 67 | ($($name: ident => $arg: expr),*) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 67 | ($($name: ident => $arg: expr_2021),*) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::rc::Rc::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:52:41 [INFO] [stdout] | [INFO] [stdout] 52 | let ptr = ManuallyDrop::new(Rc::from_raw(ptr as *const Task)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | unsafe fn raw_clone(ptr: *const ()) -> RawWaker { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `--force-warn unsafe-op-in-unsafe-fn` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `driver_module::utils::futures_spawn::Task::into_raw_waker` is unsafe and requires unsafe block [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | Task::into_raw_waker((*ptr).clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::rc::Rc::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:57:23 [INFO] [stdout] | [INFO] [stdout] 57 | let ptr = Rc::from_raw(ptr as *const Task); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | unsafe fn raw_wake(ptr: *const ()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::rc::Rc::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:62:41 [INFO] [stdout] | [INFO] [stdout] 62 | let ptr = ManuallyDrop::new(Rc::from_raw(ptr as *const Task)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | unsafe fn raw_wake_by_ref(ptr: *const ()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::rc::Rc::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 67 | drop(Rc::from_raw(ptr as *const Task)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | unsafe fn raw_drop(ptr: *const ()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/computed/dependencies/external_connections.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | if let Some(connect_func) = self.connect.get_and_clone(&id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/computed/dependencies/external_connections.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 34 ~ match self.connect.get_and_clone(&id) { Some(connect_func) => { [INFO] [stdout] 35 | self.connected_resource.insert(id, connect_func()); [INFO] [stdout] 36 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/computed/dependencies/refresh.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 40 | if let Some(refresh) = self.get(id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/computed/dependencies/refresh.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 40 ~ match self.get(id) { Some(refresh) => { [INFO] [stdout] 41 | refresh(true); [INFO] [stdout] 42 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/computed/dependencies/refresh.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 46 | if let Some(refresh) = self.get(id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/computed/dependencies/refresh.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 46 ~ match self.get(id) { Some(refresh) => { [INFO] [stdout] 47 | refresh(false); [INFO] [stdout] 48 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/computed/drop_resource.rs:27:20 [INFO] [stdout] | [INFO] [stdout] 27 | if let Some(drop_fun) = drop_fun { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/computed/drop_resource.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 29 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 27 ~ match drop_fun { Some(drop_fun) => { [INFO] [stdout] 28 | drop_fun(); [INFO] [stdout] 29 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/computed/graph_value.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 35 | if let Some(weak_value) = weak_value.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/computed/graph_value.rs:46:17 [INFO] [stdout] | [INFO] [stdout] 46 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 35 ~ match weak_value.upgrade() { Some(weak_value) => { [INFO] [stdout] 36 | match kind { [INFO] [stdout] ... [INFO] [stdout] 45 | } [INFO] [stdout] 46 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/computed/struct_mut/hash_map_mut.rs:70:16 [INFO] [stdout] | [INFO] [stdout] 70 | if let Some(mapped) = map(value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/computed/struct_mut/hash_map_mut.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 70 ~ match map(value) { Some(mapped) => { [INFO] [stdout] 71 | list.push(mapped); [INFO] [stdout] 72 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/driver_module/api/arguments.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | if let Some(param) = param { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/driver_module/api/arguments.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 33 ~ match param { Some(param) => { [INFO] [stdout] 34 | match JsValue::from_block(param) { [INFO] [stdout] ... [INFO] [stdout] 40 | } [INFO] [stdout] 41 ~ } _ => { [INFO] [stdout] 42 | log::error!("get_by_ptr - not found MemoryBlock ptr={ptr}"); [INFO] [stdout] 43 | JsValue::Undefined [INFO] [stdout] 44 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/driver_module/driver.rs:278:24 [INFO] [stdout] | [INFO] [stdout] 278 | if let Some(callback) = callback_ref.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^------------^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/driver_module/driver.rs:282:21 [INFO] [stdout] | [INFO] [stdout] 282 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 278 ~ match callback_ref.as_deref() { Some(callback) => { [INFO] [stdout] 279 | if let Some(body) = callback(&url) { [INFO] [stdout] 280 | self.inner.api.plain_response(body) [INFO] [stdout] 281 | } [INFO] [stdout] 282 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/future_box.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 40 | if let Some(w) = self.inner.waker.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/future_box.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 40 ~ match self.inner.waker.take() { Some(w) => { [INFO] [stdout] 41 | w.wake() [INFO] [stdout] 42 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.38s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Compiling vertigo v0.6.0 (/tmp/fixit) [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/lib.rs:457:3 [INFO] [stdout] | [INFO] [stdout] 457 | #[no_mangle] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 457 | #[unsafe(no_mangle)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: unsafe attribute used without unsafe [INFO] [stdout] --> src/lib.rs:457:3 [INFO] [stdout] | [INFO] [stdout] 457 | #[no_mangle] [INFO] [stdout] | ^^^^^^^^^ usage of unsafe attribute [INFO] [stdout] | [INFO] [stdout] help: wrap the attribute in `unsafe(...)` [INFO] [stdout] | [INFO] [stdout] 457 | #[unsafe(no_mangle)] [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::rc::Rc::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:52:41 [INFO] [stdout] | [INFO] [stdout] 52 | let ptr = ManuallyDrop::new(Rc::from_raw(ptr as *const Task)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | unsafe fn raw_clone(ptr: *const ()) -> RawWaker { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(unsafe_op_in_unsafe_fn)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `driver_module::utils::futures_spawn::Task::into_raw_waker` is unsafe and requires unsafe block [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | Task::into_raw_waker((*ptr).clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::rc::Rc::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:57:23 [INFO] [stdout] | [INFO] [stdout] 57 | let ptr = Rc::from_raw(ptr as *const Task); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | unsafe fn raw_wake(ptr: *const ()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::rc::Rc::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:62:41 [INFO] [stdout] | [INFO] [stdout] 62 | let ptr = ManuallyDrop::new(Rc::from_raw(ptr as *const Task)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | unsafe fn raw_wake_by_ref(ptr: *const ()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::rc::Rc::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 67 | drop(Rc::from_raw(ptr as *const Task)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | unsafe fn raw_drop(ptr: *const ()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `vertigo` (lib) due to 2 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning[E0133]: call to unsafe function `std::rc::Rc::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:52:41 [INFO] [stdout] | [INFO] [stdout] 52 | let ptr = ManuallyDrop::new(Rc::from_raw(ptr as *const Task)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | unsafe fn raw_clone(ptr: *const ()) -> RawWaker { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(unsafe_op_in_unsafe_fn)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `driver_module::utils::futures_spawn::Task::into_raw_waker` is unsafe and requires unsafe block [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | Task::into_raw_waker((*ptr).clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::rc::Rc::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:57:23 [INFO] [stdout] | [INFO] [stdout] 57 | let ptr = Rc::from_raw(ptr as *const Task); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | unsafe fn raw_wake(ptr: *const ()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::rc::Rc::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:62:41 [INFO] [stdout] | [INFO] [stdout] 62 | let ptr = ManuallyDrop::new(Rc::from_raw(ptr as *const Task)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | unsafe fn raw_wake_by_ref(ptr: *const ()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `std::rc::Rc::::from_raw` is unsafe and requires unsafe block [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 67 | drop(Rc::from_raw(ptr as *const Task)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/driver_module/utils/futures_spawn.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | unsafe fn raw_drop(ptr: *const ()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `vertigo` (lib test) due to 2 previous errors; 5 warnings emitted [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "d081ea5b59b7f881abb538dd464125e9102c7b9a4adee7e8c67cfcdd3448afac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d081ea5b59b7f881abb538dd464125e9102c7b9a4adee7e8c67cfcdd3448afac", kill_on_drop: false }` [INFO] [stdout] d081ea5b59b7f881abb538dd464125e9102c7b9a4adee7e8c67cfcdd3448afac