[INFO] fetching crate velarixdb 0.0.15... [INFO] checking velarixdb-0.0.15 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate velarixdb 0.0.15 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate velarixdb 0.0.15 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate velarixdb 0.0.15 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate velarixdb 0.0.15 [INFO] tweaked toml for crates.io crate velarixdb 0.0.15 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate velarixdb 0.0.15 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8527b65fc82f684bbbef8b13510753cc9a96dfd8ae49cdc4de0d13df8dc3b01a [INFO] running `Command { std: "docker" "start" "-a" "8527b65fc82f684bbbef8b13510753cc9a96dfd8ae49cdc4de0d13df8dc3b01a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8527b65fc82f684bbbef8b13510753cc9a96dfd8ae49cdc4de0d13df8dc3b01a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8527b65fc82f684bbbef8b13510753cc9a96dfd8ae49cdc4de0d13df8dc3b01a", kill_on_drop: false }` [INFO] [stdout] 8527b65fc82f684bbbef8b13510753cc9a96dfd8ae49cdc4de0d13df8dc3b01a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6d964867eac7d27b1e1acb746099cf7ec681580712bdfc7919352f22235ad019 [INFO] running `Command { std: "docker" "start" "-a" "6d964867eac7d27b1e1acb746099cf7ec681580712bdfc7919352f22235ad019", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling serde v1.0.205 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking use v0.0.1-pre.0 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking crossbeam-skiplist v0.1.3 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking async-broadcast v0.7.1 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.205 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking skip-list v0.1.3 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking velarixdb v0.0.15 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `velarixdb` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/fs/mod.rs [INFO] [stderr] * src/macro/mod.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/macro/mod.rs:4:10 [INFO] [stderr] | [INFO] [stderr] 4 | ($file:expr_2021, $buffer:expr_2021, $file_path:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/macro/mod.rs:4:27 [INFO] [stderr] | [INFO] [stderr] 4 | ($file:expr_2021, $buffer:expr_2021, $file_path:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/macro/mod.rs:4:46 [INFO] [stderr] | [INFO] [stderr] 4 | ($file:expr_2021, $buffer:expr_2021, $file_path:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/macro/mod.rs:16:10 [INFO] [stderr] | [INFO] [stderr] 16 | ($path:expr_2021) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] warning: elided lifetime has a name [INFO] [stderr] --> src/fs/mod.rs:67:37 [INFO] [stderr] | [INFO] [stderr] 67 | async fn w_lock(&self) -> WGuard; [INFO] [stderr] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stderr] | | [INFO] [stderr] | lifetime `'life0` declared here [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stderr] [INFO] [stderr] warning: elided lifetime has a name [INFO] [stderr] --> src/fs/mod.rs:69:37 [INFO] [stderr] | [INFO] [stderr] 69 | async fn r_lock(&self) -> RGuard; [INFO] [stderr] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stderr] | | [INFO] [stderr] | lifetime `'life0` declared here [INFO] [stderr] [INFO] [stderr] warning: elided lifetime has a name [INFO] [stderr] --> src/fs/mod.rs:243:37 [INFO] [stderr] | [INFO] [stderr] 243 | async fn w_lock(&self) -> WGuard { [INFO] [stderr] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stderr] | | [INFO] [stderr] | lifetime `'life0` declared here [INFO] [stderr] [INFO] [stderr] warning: elided lifetime has a name [INFO] [stderr] --> src/fs/mod.rs:247:37 [INFO] [stderr] | [INFO] [stderr] 247 | async fn r_lock(&self) -> RGuard { [INFO] [stderr] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stderr] | | [INFO] [stderr] | lifetime `'life0` declared here [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/fs/mod.rs:67:37 [INFO] [stdout] | [INFO] [stdout] 67 | async fn w_lock(&self) -> WGuard; [INFO] [stdout] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'life0` declared here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/fs/mod.rs:69:37 [INFO] [stdout] | [INFO] [stdout] 69 | async fn r_lock(&self) -> RGuard; [INFO] [stdout] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'life0` declared here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/fs/mod.rs:243:37 [INFO] [stdout] | [INFO] [stdout] 243 | async fn w_lock(&self) -> WGuard { [INFO] [stdout] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'life0` declared here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/fs/mod.rs:247:37 [INFO] [stdout] | [INFO] [stdout] 247 | async fn r_lock(&self) -> RGuard { [INFO] [stdout] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'life0` declared here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/gc/garbage_collector.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | extern "C" { [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | _help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | | [INFO] [stdout] 27 | | fn fallocate(fd: libc::c_int, mode: c_int, offset: off_t, len: off_t) -> c_int; [INFO] [stdout] 28 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] = note: `--force-warn missing-unsafe-on-extern` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/macro/mod.rs:4:16 [INFO] [stdout] | [INFO] [stdout] 4 | ($file:expr, $buffer:expr, $file_path:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 4 | ($file:expr_2021, $buffer:expr, $file_path:expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/macro/mod.rs:4:30 [INFO] [stdout] | [INFO] [stdout] 4 | ($file:expr, $buffer:expr, $file_path:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 4 | ($file:expr, $buffer:expr_2021, $file_path:expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/macro/mod.rs:4:47 [INFO] [stdout] | [INFO] [stdout] 4 | ($file:expr, $buffer:expr, $file_path:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 4 | ($file:expr, $buffer:expr, $file_path:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/macro/mod.rs:16:16 [INFO] [stdout] | [INFO] [stdout] 16 | ($path:expr) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 16 | ($path:expr_2021) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bucket/bucket_manager.rs:323:24 [INFO] [stdout] | [INFO] [stdout] 323 | if let Err(err) = fs::remove_dir_all(&bucket.dir).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bucket/bucket_manager.rs:325:21 [INFO] [stdout] | [INFO] [stdout] 325 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 323 ~ match fs::remove_dir_all(&bucket.dir).await { Err(err) => { [INFO] [stdout] 324 | log::error!("{}", DirDelete(err)); [INFO] [stdout] 325 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bucket/bucket_manager.rs:331:24 [INFO] [stdout] | [INFO] [stdout] 331 | if let Err(err) = fs::remove_dir_all(&sst.dir).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bucket/bucket_manager.rs:334:21 [INFO] [stdout] | [INFO] [stdout] 334 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 331 ~ match fs::remove_dir_all(&sst.dir).await { Err(err) => { [INFO] [stdout] 332 | all_ssts_deleted = false; [INFO] [stdout] 333 | log::error!("{}", DirDelete(err)); [INFO] [stdout] 334 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bucket/bucket_manager.rs:352:20 [INFO] [stdout] | [INFO] [stdout] 352 | if let Err(err) = fs::remove_dir_all(&bucket.dir).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bucket/bucket_manager.rs:354:17 [INFO] [stdout] | [INFO] [stdout] 354 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 352 ~ match fs::remove_dir_all(&bucket.dir).await { Err(err) => { [INFO] [stdout] 353 | log::error!("{}", FileDelete(err)); [INFO] [stdout] 354 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/compactors/compact.rs:235:20 [INFO] [stdout] | [INFO] [stdout] 235 | if let CompState::Sleep = *state { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/compactors/compact.rs:259:17 [INFO] [stdout] | [INFO] [stdout] 259 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 235 ~ match *state { CompState::Sleep => { [INFO] [stdout] 236 | if let Err(err) = signal { [INFO] [stdout] ... [INFO] [stdout] 258 | *state = CompState::Sleep; [INFO] [stdout] 259 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/compactors/compact.rs:273:20 [INFO] [stdout] | [INFO] [stdout] 273 | if let CompState::Sleep = *state { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/compactors/compact.rs:283:17 [INFO] [stdout] | [INFO] [stdout] 283 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 273 ~ match *state { CompState::Sleep => { [INFO] [stdout] 274 | *state = CompState::Active; [INFO] [stdout] ... [INFO] [stdout] 282 | *state = CompState::Sleep; [INFO] [stdout] 283 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db/recovery.rs:53:15 [INFO] [stdout] | [INFO] [stdout] 53 | while let Some(bucket_dir) = buckets_stream.next_entry().await.map_err(|err| DirOpen { [INFO] [stdout] | _______________^ - [INFO] [stdout] | |______________________________________| [INFO] [stdout] 54 | || path: buckets_path.as_ref().to_path_buf(), [INFO] [stdout] 55 | || error: err, [INFO] [stdout] 56 | || })? { [INFO] [stdout] | ||___________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db/recovery.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db/recovery.rs:61:19 [INFO] [stdout] | [INFO] [stdout] 61 | while let Some(sst_dir) = sst_dir_stream.next_entry().await.map_err(|err| DirOpen { [INFO] [stdout] | ___________________^ - [INFO] [stdout] | |_______________________________________| [INFO] [stdout] 62 | || path: buckets_path.as_ref().to_path_buf(), [INFO] [stdout] 63 | || error: err, [INFO] [stdout] 64 | || })? { [INFO] [stdout] | ||_______________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |_______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db/recovery.rs:132:13 [INFO] [stdout] | [INFO] [stdout] 132 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db/recovery.rs:70:23 [INFO] [stdout] | [INFO] [stdout] 70 | while let Some(file) = files_stream.next_entry().await.map_err(|err| DirOpen { [INFO] [stdout] | _______________________^ - [INFO] [stdout] | |________________________________________| [INFO] [stdout] 71 | || path: buckets_path.as_ref().to_path_buf(), [INFO] [stdout] 72 | || error: err, [INFO] [stdout] 73 | || })? { [INFO] [stdout] | ||___________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |___________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db/recovery.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db/recovery.rs:105:20 [INFO] [stdout] | [INFO] [stdout] 105 | if let Some(b) = recovered_buckets.get(&bucket_uuid) { [INFO] [stdout] | ^^^^^^^^^^^^^^-----------------^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db/recovery.rs:111:17 [INFO] [stdout] | [INFO] [stdout] 111 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 105 ~ match recovered_buckets.get(&bucket_uuid) { Some(b) => { [INFO] [stdout] 106 | let temp_sstables = b.sstables.clone(); [INFO] [stdout] ... [INFO] [stdout] 110 | recovered_buckets.insert(bucket_uuid, updated_bucket); [INFO] [stdout] 111 ~ } _ => { [INFO] [stdout] 112 | // Create new bucket [INFO] [stdout] 113 | let updated_bucket = Bucket::from(bucket_dir.path(), bucket_uuid, vec![table.clone()], 0).await?; [INFO] [stdout] 114 | recovered_buckets.insert(bucket_uuid, updated_bucket); [INFO] [stdout] 115 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db/store.rs:307:16 [INFO] [stdout] | [INFO] [stdout] 307 | if let Err(err) = meta.lock().await.write().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db/store.rs:309:13 [INFO] [stdout] | [INFO] [stdout] 309 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 307 ~ match meta.lock().await.write().await { Err(err) => { [INFO] [stdout] 308 | log::error!("{}", err) [INFO] [stdout] 309 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db/store.rs:444:12 [INFO] [stdout] | [INFO] [stdout] 444 | if let Some(val) = self.active_memtable.get(key.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^--------------------^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db/store.rs:449:9 [INFO] [stdout] | [INFO] [stdout] 449 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 444 ~ match self.active_memtable.get(key.as_ref()) { Some(val) => { [INFO] [stdout] 445 | if val.is_tombstone { [INFO] [stdout] ... [INFO] [stdout] 448 | self.get_value_from_vlog(val.val_offset, val.created_at).await [INFO] [stdout] 449 ~ } _ => { [INFO] [stdout] 450 | let mut is_deleted = false; [INFO] [stdout] ... [INFO] [stdout] 471 | } [INFO] [stdout] 472 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db/store.rs:452:20 [INFO] [stdout] | [INFO] [stdout] 452 | if let Some(val) = table.value().get(key.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^-----^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db/store.rs:458:17 [INFO] [stdout] | [INFO] [stdout] 458 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 452 ~ match table.value().get(key.as_ref()) { Some(val) => { [INFO] [stdout] 453 | if val.created_at > insert_time { [INFO] [stdout] ... [INFO] [stdout] 457 | } [INFO] [stdout] 458 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db/store.rs:484:16 [INFO] [stdout] | [INFO] [stdout] 484 | if let Some(e) = gc_entries.get(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db/store.rs:490:13 [INFO] [stdout] | [INFO] [stdout] 490 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 484 ~ match gc_entries.get(key) { Some(e) => { [INFO] [stdout] 485 | let val = e.value(); [INFO] [stdout] ... [INFO] [stdout] 489 | return self.get_value_from_vlog(val.val_offset, val.created_at).await; [INFO] [stdout] 490 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/flush/flusher.rs:85:24 [INFO] [stdout] | [INFO] [stdout] 85 | if let Err(err) = tx.try_broadcast(FLUSH_SIGNAL) { [INFO] [stdout] | ^^^^^^^^^^^^^^^--^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/flush/flusher.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 92 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 85 ~ match tx.try_broadcast(FLUSH_SIGNAL) { Err(err) => { [INFO] [stdout] 86 | match err { [INFO] [stdout] ... [INFO] [stdout] 91 | } [INFO] [stdout] 92 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/gc/garbage_collector.rs:436:12 [INFO] [stdout] | [INFO] [stdout] 436 | if let Some(value) = memtable.read().await.get(&key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^---------------------^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/gc/garbage_collector.rs:441:9 [INFO] [stdout] | [INFO] [stdout] 441 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 436 ~ match memtable.read().await.get(&key) { Some(value) => { [INFO] [stdout] 437 | if value.is_tombstone { [INFO] [stdout] ... [INFO] [stdout] 440 | GC::get_value_from_vlog(&vlog, value.val_offset, value.created_at).await [INFO] [stdout] 441 ~ } _ => { [INFO] [stdout] 442 | // Step 2: Check the read-only memtables [INFO] [stdout] ... [INFO] [stdout] 462 | } [INFO] [stdout] 463 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/gc/garbage_collector.rs:445:20 [INFO] [stdout] | [INFO] [stdout] 445 | if let Some(value) = table.value().get(&key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^-----^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/gc/garbage_collector.rs:451:17 [INFO] [stdout] | [INFO] [stdout] 451 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 445 ~ match table.value().get(&key) { Some(value) => { [INFO] [stdout] 446 | if value.created_at > insert_time { [INFO] [stdout] ... [INFO] [stdout] 450 | } [INFO] [stdout] 451 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/memtable/mem.rs:229:16 [INFO] [stdout] | [INFO] [stdout] 229 | if let Some(entry) = self.entries.get(key.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/memtable/mem.rs:231:13 [INFO] [stdout] | [INFO] [stdout] 231 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 229 ~ match self.entries.get(key.as_ref()) { Some(entry) => { [INFO] [stdout] 230 | return Some(entry.value().to_owned()); // returns value offset [INFO] [stdout] 231 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vlog/v_log.rs:250:16 [INFO] [stdout] | [INFO] [stdout] 250 | if let Err(err) = self.content.file.node.remove_dir_all().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vlog/v_log.rs:252:13 [INFO] [stdout] | [INFO] [stdout] 252 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 250 ~ match self.content.file.node.remove_dir_all().await { Err(err) => { [INFO] [stdout] 251 | log::info!("{}", err); [INFO] [stdout] 252 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 27 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/delete.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `velarixdb` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/fs/mod.rs [INFO] [stderr] * src/macro/mod.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/macro/mod.rs:4:10 [INFO] [stderr] | [INFO] [stderr] 4 | ($file:expr_2021, $buffer:expr_2021, $file_path:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/macro/mod.rs:4:27 [INFO] [stderr] | [INFO] [stderr] 4 | ($file:expr_2021, $buffer:expr_2021, $file_path:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/macro/mod.rs:4:46 [INFO] [stderr] | [INFO] [stderr] 4 | ($file:expr_2021, $buffer:expr_2021, $file_path:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/macro/mod.rs:16:10 [INFO] [stderr] | [INFO] [stderr] 16 | ($path:expr_2021) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] warning: elided lifetime has a name [INFO] [stderr] --> src/fs/mod.rs:67:37 [INFO] [stderr] | [INFO] [stderr] 67 | async fn w_lock(&self) -> WGuard; [INFO] [stderr] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stderr] | | [INFO] [stderr] | lifetime `'life0` declared here [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stderr] [INFO] [stderr] warning: elided lifetime has a name [INFO] [stderr] --> src/fs/mod.rs:69:37 [INFO] [stderr] | [INFO] [stderr] 69 | async fn r_lock(&self) -> RGuard; [INFO] [stderr] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stderr] | | [INFO] [stderr] | lifetime `'life0` declared here [INFO] [stderr] [INFO] [stderr] warning: elided lifetime has a name [INFO] [stderr] --> src/fs/mod.rs:243:37 [INFO] [stderr] | [INFO] [stderr] 243 | async fn w_lock(&self) -> WGuard { [INFO] [stderr] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stderr] | | [INFO] [stderr] | lifetime `'life0` declared here [INFO] [stderr] [INFO] [stderr] warning: elided lifetime has a name [INFO] [stderr] --> src/fs/mod.rs:247:37 [INFO] [stderr] | [INFO] [stderr] 247 | async fn r_lock(&self) -> RGuard { [INFO] [stderr] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stderr] | | [INFO] [stderr] | lifetime `'life0` declared here [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/fs/mod.rs:67:37 [INFO] [stdout] | [INFO] [stdout] 67 | async fn w_lock(&self) -> WGuard; [INFO] [stdout] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'life0` declared here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/fs/mod.rs:69:37 [INFO] [stdout] | [INFO] [stdout] 69 | async fn r_lock(&self) -> RGuard; [INFO] [stdout] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'life0` declared here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/fs/mod.rs:243:37 [INFO] [stdout] | [INFO] [stdout] 243 | async fn w_lock(&self) -> WGuard { [INFO] [stdout] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'life0` declared here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/fs/mod.rs:247:37 [INFO] [stdout] | [INFO] [stdout] 247 | async fn r_lock(&self) -> RGuard { [INFO] [stdout] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'life0` declared here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/gc/garbage_collector.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | extern "C" { [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | _help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | | [INFO] [stdout] 27 | | fn fallocate(fd: libc::c_int, mode: c_int, offset: off_t, len: off_t) -> c_int; [INFO] [stdout] 28 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] = note: `--force-warn missing-unsafe-on-extern` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/macro/mod.rs:4:16 [INFO] [stdout] | [INFO] [stdout] 4 | ($file:expr, $buffer:expr, $file_path:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 4 | ($file:expr_2021, $buffer:expr, $file_path:expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/macro/mod.rs:4:30 [INFO] [stdout] | [INFO] [stdout] 4 | ($file:expr, $buffer:expr, $file_path:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 4 | ($file:expr, $buffer:expr_2021, $file_path:expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/macro/mod.rs:4:47 [INFO] [stdout] | [INFO] [stdout] 4 | ($file:expr, $buffer:expr, $file_path:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 4 | ($file:expr, $buffer:expr, $file_path:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/macro/mod.rs:16:16 [INFO] [stdout] | [INFO] [stdout] 16 | ($path:expr) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 16 | ($path:expr_2021) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bucket/bucket_manager.rs:323:24 [INFO] [stdout] | [INFO] [stdout] 323 | if let Err(err) = fs::remove_dir_all(&bucket.dir).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bucket/bucket_manager.rs:325:21 [INFO] [stdout] | [INFO] [stdout] 325 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 323 ~ match fs::remove_dir_all(&bucket.dir).await { Err(err) => { [INFO] [stdout] 324 | log::error!("{}", DirDelete(err)); [INFO] [stdout] 325 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bucket/bucket_manager.rs:331:24 [INFO] [stdout] | [INFO] [stdout] 331 | if let Err(err) = fs::remove_dir_all(&sst.dir).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bucket/bucket_manager.rs:334:21 [INFO] [stdout] | [INFO] [stdout] 334 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 331 ~ match fs::remove_dir_all(&sst.dir).await { Err(err) => { [INFO] [stdout] 332 | all_ssts_deleted = false; [INFO] [stdout] 333 | log::error!("{}", DirDelete(err)); [INFO] [stdout] 334 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/bucket/bucket_manager.rs:352:20 [INFO] [stdout] | [INFO] [stdout] 352 | if let Err(err) = fs::remove_dir_all(&bucket.dir).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/bucket/bucket_manager.rs:354:17 [INFO] [stdout] | [INFO] [stdout] 354 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 352 ~ match fs::remove_dir_all(&bucket.dir).await { Err(err) => { [INFO] [stdout] 353 | log::error!("{}", FileDelete(err)); [INFO] [stdout] 354 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/compactors/compact.rs:235:20 [INFO] [stdout] | [INFO] [stdout] 235 | if let CompState::Sleep = *state { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/compactors/compact.rs:259:17 [INFO] [stdout] | [INFO] [stdout] 259 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 235 ~ match *state { CompState::Sleep => { [INFO] [stdout] 236 | if let Err(err) = signal { [INFO] [stdout] ... [INFO] [stdout] 258 | *state = CompState::Sleep; [INFO] [stdout] 259 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/compactors/compact.rs:273:20 [INFO] [stdout] | [INFO] [stdout] 273 | if let CompState::Sleep = *state { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/compactors/compact.rs:283:17 [INFO] [stdout] | [INFO] [stdout] 283 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 273 ~ match *state { CompState::Sleep => { [INFO] [stdout] 274 | *state = CompState::Active; [INFO] [stdout] ... [INFO] [stdout] 282 | *state = CompState::Sleep; [INFO] [stdout] 283 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db/recovery.rs:53:15 [INFO] [stdout] | [INFO] [stdout] 53 | while let Some(bucket_dir) = buckets_stream.next_entry().await.map_err(|err| DirOpen { [INFO] [stdout] | _______________^ - [INFO] [stdout] | |______________________________________| [INFO] [stdout] 54 | || path: buckets_path.as_ref().to_path_buf(), [INFO] [stdout] 55 | || error: err, [INFO] [stdout] 56 | || })? { [INFO] [stdout] | ||___________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db/recovery.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db/recovery.rs:61:19 [INFO] [stdout] | [INFO] [stdout] 61 | while let Some(sst_dir) = sst_dir_stream.next_entry().await.map_err(|err| DirOpen { [INFO] [stdout] | ___________________^ - [INFO] [stdout] | |_______________________________________| [INFO] [stdout] 62 | || path: buckets_path.as_ref().to_path_buf(), [INFO] [stdout] 63 | || error: err, [INFO] [stdout] 64 | || })? { [INFO] [stdout] | ||_______________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |_______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db/recovery.rs:132:13 [INFO] [stdout] | [INFO] [stdout] 132 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db/recovery.rs:70:23 [INFO] [stdout] | [INFO] [stdout] 70 | while let Some(file) = files_stream.next_entry().await.map_err(|err| DirOpen { [INFO] [stdout] | _______________________^ - [INFO] [stdout] | |________________________________________| [INFO] [stdout] 71 | || path: buckets_path.as_ref().to_path_buf(), [INFO] [stdout] 72 | || error: err, [INFO] [stdout] 73 | || })? { [INFO] [stdout] | ||___________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |___________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db/recovery.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db/recovery.rs:105:20 [INFO] [stdout] | [INFO] [stdout] 105 | if let Some(b) = recovered_buckets.get(&bucket_uuid) { [INFO] [stdout] | ^^^^^^^^^^^^^^-----------------^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db/recovery.rs:111:17 [INFO] [stdout] | [INFO] [stdout] 111 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 105 ~ match recovered_buckets.get(&bucket_uuid) { Some(b) => { [INFO] [stdout] 106 | let temp_sstables = b.sstables.clone(); [INFO] [stdout] ... [INFO] [stdout] 110 | recovered_buckets.insert(bucket_uuid, updated_bucket); [INFO] [stdout] 111 ~ } _ => { [INFO] [stdout] 112 | // Create new bucket [INFO] [stdout] 113 | let updated_bucket = Bucket::from(bucket_dir.path(), bucket_uuid, vec![table.clone()], 0).await?; [INFO] [stdout] 114 | recovered_buckets.insert(bucket_uuid, updated_bucket); [INFO] [stdout] 115 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db/store.rs:307:16 [INFO] [stdout] | [INFO] [stdout] 307 | if let Err(err) = meta.lock().await.write().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db/store.rs:309:13 [INFO] [stdout] | [INFO] [stdout] 309 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 307 ~ match meta.lock().await.write().await { Err(err) => { [INFO] [stdout] 308 | log::error!("{}", err) [INFO] [stdout] 309 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db/store.rs:444:12 [INFO] [stdout] | [INFO] [stdout] 444 | if let Some(val) = self.active_memtable.get(key.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^--------------------^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db/store.rs:449:9 [INFO] [stdout] | [INFO] [stdout] 449 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 444 ~ match self.active_memtable.get(key.as_ref()) { Some(val) => { [INFO] [stdout] 445 | if val.is_tombstone { [INFO] [stdout] ... [INFO] [stdout] 448 | self.get_value_from_vlog(val.val_offset, val.created_at).await [INFO] [stdout] 449 ~ } _ => { [INFO] [stdout] 450 | let mut is_deleted = false; [INFO] [stdout] ... [INFO] [stdout] 471 | } [INFO] [stdout] 472 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db/store.rs:452:20 [INFO] [stdout] | [INFO] [stdout] 452 | if let Some(val) = table.value().get(key.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^-----^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db/store.rs:458:17 [INFO] [stdout] | [INFO] [stdout] 458 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 452 ~ match table.value().get(key.as_ref()) { Some(val) => { [INFO] [stdout] 453 | if val.created_at > insert_time { [INFO] [stdout] ... [INFO] [stdout] 457 | } [INFO] [stdout] 458 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db/store.rs:484:16 [INFO] [stdout] | [INFO] [stdout] 484 | if let Some(e) = gc_entries.get(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db/store.rs:490:13 [INFO] [stdout] | [INFO] [stdout] 490 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 484 ~ match gc_entries.get(key) { Some(e) => { [INFO] [stdout] 485 | let val = e.value(); [INFO] [stdout] ... [INFO] [stdout] 489 | return self.get_value_from_vlog(val.val_offset, val.created_at).await; [INFO] [stdout] 490 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/flush/flusher.rs:85:24 [INFO] [stdout] | [INFO] [stdout] 85 | if let Err(err) = tx.try_broadcast(FLUSH_SIGNAL) { [INFO] [stdout] | ^^^^^^^^^^^^^^^--^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/flush/flusher.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 92 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 85 ~ match tx.try_broadcast(FLUSH_SIGNAL) { Err(err) => { [INFO] [stdout] 86 | match err { [INFO] [stdout] ... [INFO] [stdout] 91 | } [INFO] [stdout] 92 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/gc/garbage_collector.rs:436:12 [INFO] [stdout] | [INFO] [stdout] 436 | if let Some(value) = memtable.read().await.get(&key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^---------------------^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/gc/garbage_collector.rs:441:9 [INFO] [stdout] | [INFO] [stdout] 441 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 436 ~ match memtable.read().await.get(&key) { Some(value) => { [INFO] [stdout] 437 | if value.is_tombstone { [INFO] [stdout] ... [INFO] [stdout] 440 | GC::get_value_from_vlog(&vlog, value.val_offset, value.created_at).await [INFO] [stdout] 441 ~ } _ => { [INFO] [stdout] 442 | // Step 2: Check the read-only memtables [INFO] [stdout] ... [INFO] [stdout] 462 | } [INFO] [stdout] 463 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/gc/garbage_collector.rs:445:20 [INFO] [stdout] | [INFO] [stdout] 445 | if let Some(value) = table.value().get(&key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^-----^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/gc/garbage_collector.rs:451:17 [INFO] [stdout] | [INFO] [stdout] 451 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 445 ~ match table.value().get(&key) { Some(value) => { [INFO] [stdout] 446 | if value.created_at > insert_time { [INFO] [stdout] ... [INFO] [stdout] 450 | } [INFO] [stdout] 451 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/memtable/mem.rs:229:16 [INFO] [stdout] | [INFO] [stdout] 229 | if let Some(entry) = self.entries.get(key.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/memtable/mem.rs:231:13 [INFO] [stdout] | [INFO] [stdout] 231 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 229 ~ match self.entries.get(key.as_ref()) { Some(entry) => { [INFO] [stdout] 230 | return Some(entry.value().to_owned()); // returns value offset [INFO] [stdout] 231 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/vlog/v_log.rs:250:16 [INFO] [stdout] | [INFO] [stdout] 250 | if let Err(err) = self.content.file.node.remove_dir_all().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/vlog/v_log.rs:252:13 [INFO] [stdout] | [INFO] [stdout] 252 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 250 ~ match self.content.file.node.remove_dir_all().await { Err(err) => { [INFO] [stdout] 251 | log::info!("{}", err); [INFO] [stdout] 252 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 27 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/get_concurrent.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/update.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/put.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/get_concurrent.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/delete.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/get.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/update.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/put_concurrent.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/get.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/json.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/put_concurrent.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.60s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking velarixdb v0.0.15 (/tmp/fixit) [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/gc/garbage_collector.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | / extern "C" { [INFO] [stdout] 27 | | fn fallocate(fd: libc::c_int, mode: c_int, offset: off_t, len: off_t) -> c_int; [INFO] [stdout] 28 | | } [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/fs/mod.rs:67:37 [INFO] [stdout] | [INFO] [stdout] 67 | async fn w_lock(&self) -> WGuard; [INFO] [stdout] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'life0` declared here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/fs/mod.rs:69:37 [INFO] [stdout] | [INFO] [stdout] 69 | async fn r_lock(&self) -> RGuard; [INFO] [stdout] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'life0` declared here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/fs/mod.rs:243:37 [INFO] [stdout] | [INFO] [stdout] 243 | async fn w_lock(&self) -> WGuard { [INFO] [stdout] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'life0` declared here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/fs/mod.rs:247:37 [INFO] [stdout] | [INFO] [stdout] 247 | async fn r_lock(&self) -> RGuard { [INFO] [stdout] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'life0` declared here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/gc/garbage_collector.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | / extern "C" { [INFO] [stdout] 27 | | fn fallocate(fd: libc::c_int, mode: c_int, offset: off_t, len: off_t) -> c_int; [INFO] [stdout] 28 | | } [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/fs/mod.rs:67:37 [INFO] [stdout] | [INFO] [stdout] 67 | async fn w_lock(&self) -> WGuard; [INFO] [stdout] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'life0` declared here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/fs/mod.rs:69:37 [INFO] [stdout] | [INFO] [stdout] 69 | async fn r_lock(&self) -> RGuard; [INFO] [stdout] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'life0` declared here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/fs/mod.rs:243:37 [INFO] [stdout] | [INFO] [stdout] 243 | async fn w_lock(&self) -> WGuard { [INFO] [stdout] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'life0` declared here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/fs/mod.rs:247:37 [INFO] [stdout] | [INFO] [stdout] 247 | async fn r_lock(&self) -> RGuard { [INFO] [stdout] | - ^ this elided lifetime gets resolved as `'life0` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'life0` declared here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `velarixdb` (lib) due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `velarixdb` (lib test) due to 2 previous errors; 4 warnings emitted [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "6d964867eac7d27b1e1acb746099cf7ec681580712bdfc7919352f22235ad019", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d964867eac7d27b1e1acb746099cf7ec681580712bdfc7919352f22235ad019", kill_on_drop: false }` [INFO] [stdout] 6d964867eac7d27b1e1acb746099cf7ec681580712bdfc7919352f22235ad019