[INFO] fetching crate tracing-rc 0.1.3... [INFO] checking tracing-rc-0.1.3 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate tracing-rc 0.1.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate tracing-rc 0.1.3 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tracing-rc 0.1.3 [INFO] finished tweaking crates.io crate tracing-rc 0.1.3 [INFO] tweaked toml for crates.io crate tracing-rc 0.1.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate tracing-rc 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 650b91633028ea900a92db88bac31c83b7b6361214fbe26d51d75d226b9e40a6 [INFO] running `Command { std: "docker" "start" "-a" "650b91633028ea900a92db88bac31c83b7b6361214fbe26d51d75d226b9e40a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "650b91633028ea900a92db88bac31c83b7b6361214fbe26d51d75d226b9e40a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "650b91633028ea900a92db88bac31c83b7b6361214fbe26d51d75d226b9e40a6", kill_on_drop: false }` [INFO] [stdout] 650b91633028ea900a92db88bac31c83b7b6361214fbe26d51d75d226b9e40a6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 83ffac8873ae82218c6ba24179cbe6f6529fa4bb9502f7dd35108409d1b621fa [INFO] running `Command { std: "docker" "start" "-a" "83ffac8873ae82218c6ba24179cbe6f6529fa4bb9502f7dd35108409d1b621fa", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Fixed Cargo.toml (6 fixes) [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.84 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking fixedbitset v0.4.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking diff v0.1.12 [INFO] [stderr] Checking pretty_assertions v1.0.0 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling quote v1.0.14 [INFO] [stderr] Checking petgraph v0.6.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling tracing-rc-derive v0.1.1 [INFO] [stderr] Checking tracing-rc v0.1.3 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `tracing_rc` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/lib.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/lib.rs:173:111 [INFO] [stderr] | [INFO] [stderr] 173 | ($name:ident { $field:ident: $ptr_ty:ident<$inner_ty:ident>$(,)? }, upgrade($varname:ident) => $upg:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/rc/mod.rs:246:29 [INFO] [stdout] | [INFO] [stdout] 246 | YOUNG_GEN.with(|gen| { [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/rc/mod.rs:247:25 [INFO] [stdout] | [INFO] [stdout] 247 | let mut gen = gen.borrow_mut(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/rc/mod.rs:247:31 [INFO] [stdout] | [INFO] [stdout] 247 | let mut gen = gen.borrow_mut(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/rc/mod.rs:251:17 [INFO] [stdout] | [INFO] [stdout] 251 | gen.insert(node, 0); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/rc/collector.rs:96:25 [INFO] [stdout] | [INFO] [stdout] 96 | YOUNG_GEN.with(|gen| { [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/rc/collector.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | gen.borrow_mut().retain(|node, generation| { [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/lib.rs:173:116 [INFO] [stdout] | [INFO] [stdout] 173 | ($name:ident { $field:ident: $ptr_ty:ident<$inner_ty:ident>$(,)? }, upgrade($varname:ident) => $upg:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 173 | ($name:ident { $field:ident: $ptr_ty:ident<$inner_ty:ident>$(,)? }, upgrade($varname:ident) => $upg:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/rc/mod.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 161 | if let Ok(cell_ref) = self.ptr.data.try_borrow() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/rc/mod.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 164 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 161 ~ match self.ptr.data.try_borrow() { Ok(cell_ref) => { [INFO] [stdout] 162 | self.ptr.mark_live(); [INFO] [stdout] 163 | Some(Ref { cell_ref }) [INFO] [stdout] 164 ~ } _ => { [INFO] [stdout] 165 | None [INFO] [stdout] 166 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/rc/mod.rs:184:12 [INFO] [stdout] | [INFO] [stdout] 184 | if let Ok(cell_ref) = self.ptr.data.try_borrow_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/rc/mod.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 184 ~ match self.ptr.data.try_borrow_mut() { Ok(cell_ref) => { [INFO] [stdout] 185 | self.ptr.mark_live(); [INFO] [stdout] 186 | Some(RefMut { cell_ref }) [INFO] [stdout] 187 ~ } _ => { [INFO] [stdout] 188 | None [INFO] [stdout] 189 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/rc/mod.rs:332:12 [INFO] [stdout] | [INFO] [stdout] 332 | if let Ok(mut mut_borrow) = self.data.try_borrow_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^-------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/rc/mod.rs:342:9 [INFO] [stdout] | [INFO] [stdout] 342 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 332 ~ match self.data.try_borrow_mut() { Ok(mut mut_borrow) => { [INFO] [stdout] 333 | self.status.set(Status::Dead); [INFO] [stdout] ... [INFO] [stdout] 341 | std::mem::forget(mut_borrow); [INFO] [stdout] 342 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/rc/collector.rs:98:38 [INFO] [stdout] | [INFO] [stdout] 98 | let strong_node = if let Some(node) = node.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/rc/collector.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 98 ~ let strong_node = match node.upgrade() { Some(node) => { [INFO] [stdout] 99 | node [INFO] [stdout] 100 ~ } _ => { [INFO] [stdout] 101 | return false; [INFO] [stdout] 102 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/rc/collector.rs:188:21 [INFO] [stdout] | [INFO] [stdout] 188 | let parent = if let Ok(parent) = pin_parent.data.try_borrow_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/rc/collector.rs:190:5 [INFO] [stdout] | [INFO] [stdout] 190 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 188 ~ let parent = match pin_parent.data.try_borrow_mut() { Ok(parent) => { [INFO] [stdout] 189 | parent [INFO] [stdout] 190 ~ } _ => { [INFO] [stdout] 191 | // If we can't get mutable access to child, it must be exclusively borrowed by somebody [INFO] [stdout] ... [INFO] [stdout] 200 | return; [INFO] [stdout] 201 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `tracing_rc` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/lib.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/lib.rs:173:111 [INFO] [stderr] | [INFO] [stderr] 173 | ($name:ident { $field:ident: $ptr_ty:ident<$inner_ty:ident>$(,)? }, upgrade($varname:ident) => $upg:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/rc/mod.rs:246:29 [INFO] [stdout] | [INFO] [stdout] 246 | YOUNG_GEN.with(|gen| { [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/rc/mod.rs:247:25 [INFO] [stdout] | [INFO] [stdout] 247 | let mut gen = gen.borrow_mut(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/rc/mod.rs:247:31 [INFO] [stdout] | [INFO] [stdout] 247 | let mut gen = gen.borrow_mut(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/rc/mod.rs:251:17 [INFO] [stdout] | [INFO] [stdout] 251 | gen.insert(node, 0); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/rc/collector.rs:96:25 [INFO] [stdout] | [INFO] [stdout] 96 | YOUNG_GEN.with(|gen| { [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/rc/collector.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | gen.borrow_mut().retain(|node, generation| { [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/lib.rs:173:116 [INFO] [stdout] | [INFO] [stdout] 173 | ($name:ident { $field:ident: $ptr_ty:ident<$inner_ty:ident>$(,)? }, upgrade($varname:ident) => $upg:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 173 | ($name:ident { $field:ident: $ptr_ty:ident<$inner_ty:ident>$(,)? }, upgrade($varname:ident) => $upg:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/rc/mod.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 161 | if let Ok(cell_ref) = self.ptr.data.try_borrow() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/rc/mod.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 164 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 161 ~ match self.ptr.data.try_borrow() { Ok(cell_ref) => { [INFO] [stdout] 162 | self.ptr.mark_live(); [INFO] [stdout] 163 | Some(Ref { cell_ref }) [INFO] [stdout] 164 ~ } _ => { [INFO] [stdout] 165 | None [INFO] [stdout] 166 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/rc/mod.rs:184:12 [INFO] [stdout] | [INFO] [stdout] 184 | if let Ok(cell_ref) = self.ptr.data.try_borrow_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/rc/mod.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 184 ~ match self.ptr.data.try_borrow_mut() { Ok(cell_ref) => { [INFO] [stdout] 185 | self.ptr.mark_live(); [INFO] [stdout] 186 | Some(RefMut { cell_ref }) [INFO] [stdout] 187 ~ } _ => { [INFO] [stdout] 188 | None [INFO] [stdout] 189 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/rc/mod.rs:332:12 [INFO] [stdout] | [INFO] [stdout] 332 | if let Ok(mut mut_borrow) = self.data.try_borrow_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^-------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/rc/mod.rs:342:9 [INFO] [stdout] | [INFO] [stdout] 342 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 332 ~ match self.data.try_borrow_mut() { Ok(mut mut_borrow) => { [INFO] [stdout] 333 | self.status.set(Status::Dead); [INFO] [stdout] ... [INFO] [stdout] 341 | std::mem::forget(mut_borrow); [INFO] [stdout] 342 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/rc/collector.rs:98:38 [INFO] [stdout] | [INFO] [stdout] 98 | let strong_node = if let Some(node) = node.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/rc/collector.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 98 ~ let strong_node = match node.upgrade() { Some(node) => { [INFO] [stdout] 99 | node [INFO] [stdout] 100 ~ } _ => { [INFO] [stdout] 101 | return false; [INFO] [stdout] 102 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/rc/collector.rs:188:21 [INFO] [stdout] | [INFO] [stdout] 188 | let parent = if let Ok(parent) = pin_parent.data.try_borrow_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/rc/collector.rs:190:5 [INFO] [stdout] | [INFO] [stdout] 190 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 188 ~ let parent = match pin_parent.data.try_borrow_mut() { Ok(parent) => { [INFO] [stdout] 189 | parent [INFO] [stdout] 190 ~ } _ => { [INFO] [stdout] 191 | // If we can't get mutable access to child, it must be exclusively borrowed by somebody [INFO] [stdout] ... [INFO] [stdout] 200 | return; [INFO] [stdout] 201 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/tests.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/toy_graph.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.50s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking tracing-rc v0.1.3 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/rc/mod.rs:246:29 [INFO] [stdout] | [INFO] [stdout] 246 | YOUNG_GEN.with(|gen| { [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/rc/mod.rs:246:29 [INFO] [stdout] | [INFO] [stdout] 246 | YOUNG_GEN.with(|gen| { [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/rc/collector.rs:96:25 [INFO] [stdout] | [INFO] [stdout] 96 | YOUNG_GEN.with(|gen| { [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/rc/collector.rs:96:25 [INFO] [stdout] | [INFO] [stdout] 96 | YOUNG_GEN.with(|gen| { [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `YOUNG_GEN` [INFO] [stdout] --> src/rc/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | YOUNG_GEN, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `YOUNG_GEN` [INFO] [stdout] --> src/rc/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | YOUNG_GEN, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tracing-rc` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `tracing-rc` (lib test) due to 3 previous errors; 1 warning emitted [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "83ffac8873ae82218c6ba24179cbe6f6529fa4bb9502f7dd35108409d1b621fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "83ffac8873ae82218c6ba24179cbe6f6529fa4bb9502f7dd35108409d1b621fa", kill_on_drop: false }` [INFO] [stdout] 83ffac8873ae82218c6ba24179cbe6f6529fa4bb9502f7dd35108409d1b621fa