[INFO] fetching crate tokio-console 0.1.12... [INFO] checking tokio-console-0.1.12 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate tokio-console 0.1.12 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate tokio-console 0.1.12 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tokio-console 0.1.12 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate tokio-console 0.1.12 [INFO] tweaked toml for crates.io crate tokio-console 0.1.12 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate tokio-console 0.1.12 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0a31b722d3a1845acc265759270f657fad7883f7a0ef3a888f6f5c539e5aa1c9 [INFO] running `Command { std: "docker" "start" "-a" "0a31b722d3a1845acc265759270f657fad7883f7a0ef3a888f6f5c539e5aa1c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0a31b722d3a1845acc265759270f657fad7883f7a0ef3a888f6f5c539e5aa1c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0a31b722d3a1845acc265759270f657fad7883f7a0ef3a888f6f5c539e5aa1c9", kill_on_drop: false }` [INFO] [stdout] 0a31b722d3a1845acc265759270f657fad7883f7a0ef3a888f6f5c539e5aa1c9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bb9e2fadc0db77242dc9af892579f5c8bc62f955008816b15b4928741ca0ae1f [INFO] running `Command { std: "docker" "start" "-a" "bb9e2fadc0db77242dc9af892579f5c8bc62f955008816b15b4928741ca0ae1f", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Fixed Cargo.toml (1 fix) [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling unicode-ident v1.0.8 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling syn v1.0.90 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling parking_lot_core v0.9.2 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling rustversion v1.0.12 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Checking itoa v1.0.6 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Compiling anyhow v1.0.56 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Compiling async-trait v0.1.68 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Checking tracing-log v0.1.3 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Compiling syn v2.0.65 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Compiling axum v0.7.5 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking sync_wrapper v0.1.1 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking matchit v0.7.0 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking tracing-subscriber v0.3.17 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking gimli v0.26.1 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling eyre v0.6.7 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking castaway v0.2.2 [INFO] [stderr] Checking aho-corasick v1.0.5 [INFO] [stderr] Checking object v0.27.1 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Compiling backtrace v0.3.64 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking unicode-segmentation v1.10.1 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking os_pipe v1.1.4 [INFO] [stderr] Checking filetime v0.2.22 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking snapbox-macros v0.3.9 [INFO] [stderr] Checking content_inspector v0.2.4 [INFO] [stderr] Checking similar v2.3.0 [INFO] [stderr] Checking winnow v0.6.13 [INFO] [stderr] Checking dunce v1.0.4 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking addr2line v0.17.0 [INFO] [stderr] Checking snapbox v0.6.13 [INFO] [stderr] Checking hdrhistogram v7.5.0 [INFO] [stderr] Checking regex-automata v0.3.8 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling pin-project-internal v1.0.12 [INFO] [stderr] Checking pin-project v1.0.12 [INFO] [stderr] Compiling tracing-attributes v0.1.26 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling prost-derive v0.13.1 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Compiling strum_macros v0.26.2 [INFO] [stderr] Compiling stability v0.2.0 [INFO] [stderr] Compiling automod v1.0.14 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking regex v1.9.5 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking color-spantrace v0.2.0 [INFO] [stderr] Checking color-eyre v0.6.2 [INFO] [stderr] Checking prost v0.13.1 [INFO] [stderr] Checking strum v0.26.2 [INFO] [stderr] Checking ratatui v0.26.2 [INFO] [stderr] Checking prost-types v0.13.1 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking clap_complete v4.5.2 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking tokio-util v0.7.1 [INFO] [stderr] Checking tokio-stream v0.1.8 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking humantime-serde v1.1.1 [INFO] [stderr] Checking toml_edit v0.22.15 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking trycmd v0.15.4 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Checking hyper-timeout v0.5.1 [INFO] [stderr] Checking tonic v0.12.0 [INFO] [stderr] Checking console-api v0.8.0 [INFO] [stderr] Checking tokio-console v0.1.12 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `tokio_console` [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/conn.rs:39:39 [INFO] [stdout] | [INFO] [stdout] 39 | ($me:ident, $client:ident, $block:expr) => ({ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 39 | ($me:ident, $client:ident, $block:expr_2021) => ({ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/conn.rs:80:15 [INFO] [stdout] | [INFO] [stdout] 80 | while let State::Disconnected(backoff) = self.state { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/conn.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/conn.rs:171:12 [INFO] [stdout] | [INFO] [stdout] 171 | if let Err(e) = res { [INFO] [stdout] | ^^^^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/conn.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 171 ~ match res { Err(e) => { [INFO] [stdout] 172 | tracing::error!(error = %e, "rpc error sending pause command"); [INFO] [stdout] 173 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/conn.rs:183:12 [INFO] [stdout] | [INFO] [stdout] 183 | if let Err(e) = res { [INFO] [stdout] | ^^^^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/conn.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 183 ~ match res { Err(e) => { [INFO] [stdout] 184 | tracing::error!(error = %e, "rpc error sending resume command"); [INFO] [stdout] 185 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] * src/conn.rs [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/state/async_ops.rs:195:16 [INFO] [stdout] | [INFO] [stdout] 195 | if let Some(meta) = metas.get(&async_op.meta_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/state/async_ops.rs:198:13 [INFO] [stdout] | [INFO] [stdout] 198 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 195 ~ match metas.get(&async_op.meta_id) { Some(meta) => { [INFO] [stdout] 196 | tracing::trace!(?async_op, ?stats, "processing stats update for"); [INFO] [stdout] 197 | async_op.stats = AsyncOpStats::from_proto(stats, meta, styles, strings, task_ids); [INFO] [stdout] 198 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/conn.rs:39:32 [INFO] [stderr] | [INFO] [stderr] 39 | ($me:ident, $client:ident, $block:expr_2021) => ({ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/state/resources.rs:264:16 [INFO] [stdout] | [INFO] [stdout] 264 | if let Some(meta) = metas.get(&resource.meta_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/state/resources.rs:267:13 [INFO] [stdout] | [INFO] [stdout] 267 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 264 ~ match metas.get(&resource.meta_id) { Some(meta) => { [INFO] [stdout] 265 | tracing::trace!(?resource, ?stats, "processing stats update for"); [INFO] [stdout] 266 | resource.stats = ResourceStats::from_proto(stats, meta, styles, strings); [INFO] [stdout] 267 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/state/tasks.rs:266:16 [INFO] [stdout] | [INFO] [stdout] 266 | if let Some(task) = self.tasks.get(*id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^----------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/state/tasks.rs:270:13 [INFO] [stdout] | [INFO] [stdout] 270 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 266 ~ match self.tasks.get(*id) { Some(task) => { [INFO] [stdout] 267 | if let TaskLintResult::RequiresRecheck = task.borrow_mut().lint(linters) { [INFO] [stdout] 268 | next_pending_lint.insert(*id); [INFO] [stdout] 269 | } [INFO] [stdout] 270 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/state/tasks.rs:267:20 [INFO] [stdout] | [INFO] [stdout] 267 | if let TaskLintResult::RequiresRecheck = task.borrow_mut().lint(linters) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-----------------^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/state/tasks.rs:269:17 [INFO] [stdout] | [INFO] [stdout] 269 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 267 ~ match task.borrow_mut().lint(linters) { TaskLintResult::RequiresRecheck => { [INFO] [stdout] 268 | next_pending_lint.insert(*id); [INFO] [stdout] 269 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/term.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 43 | if let Err(error) = (self.action)() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^--------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/term.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 43 ~ match (self.action)() { Err(error) => { [INFO] [stdout] 44 | tracing::error!(%error, "error running terminal cleanup"); [INFO] [stdout] 45 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/view/mod.rs:135:28 [INFO] [stdout] | [INFO] [stdout] 135 | if let Some(task) = self.tasks_list.selected_item() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/view/mod.rs:141:25 [INFO] [stdout] | [INFO] [stdout] 141 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 135 ~ match self.tasks_list.selected_item() { Some(task) => { [INFO] [stdout] 136 | update_kind = UpdateKind::SelectTask(task.borrow().span_id()); [INFO] [stdout] ... [INFO] [stdout] 140 | )); [INFO] [stdout] 141 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/view/mod.rs:152:28 [INFO] [stdout] | [INFO] [stdout] 152 | if let Some(res) = self.resources_list.selected_item() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^-------------------^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/view/mod.rs:155:25 [INFO] [stdout] | [INFO] [stdout] 155 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 152 ~ match self.resources_list.selected_item() { Some(res) => { [INFO] [stdout] 153 | update_kind = UpdateKind::SelectResource(res.borrow().span_id()); [INFO] [stdout] 154 | self.state = ResourceInstance(self::resource::ResourceView::new(res)); [INFO] [stdout] 155 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/view/mod.rs:172:28 [INFO] [stdout] | [INFO] [stdout] 172 | if let Some(op) = view.async_ops_table.selected_item() { [INFO] [stdout] | ^^^^^^^^^^^^^^^--------------------^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/view/mod.rs:189:25 [INFO] [stdout] | [INFO] [stdout] 189 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 172 ~ match view.async_ops_table.selected_item() { Some(op) => { [INFO] [stdout] 173 | if let Some(task_id) = op.borrow().task_id() { [INFO] [stdout] ... [INFO] [stdout] 188 | } [INFO] [stdout] 189 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/view/mod.rs:173:32 [INFO] [stdout] | [INFO] [stdout] 173 | ... if let Some(task_id) = op.borrow().task_id() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^-----------^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/view/mod.rs:188:29 [INFO] [stdout] | [INFO] [stdout] 188 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 173 ~ match op.borrow().task_id() { Some(task_id) => { [INFO] [stdout] 174 | let task = self [INFO] [stdout] ... [INFO] [stdout] 187 | } [INFO] [stdout] 188 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/view/mod.rs:181:36 [INFO] [stdout] | [INFO] [stdout] 181 | ... if let Some(task) = task { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^---- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/view/mod.rs:187:33 [INFO] [stdout] | [INFO] [stdout] 187 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 181 ~ match task { Some(task) => { [INFO] [stdout] 182 | update_kind = UpdateKind::SelectTask(task.borrow().span_id()); [INFO] [stdout] ... [INFO] [stdout] 186 | )); [INFO] [stdout] 187 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 14 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/cli-ui.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `tokio_console` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/conn.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/conn.rs:39:32 [INFO] [stderr] | [INFO] [stderr] 39 | ($me:ident, $client:ident, $block:expr_2021) => ({ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/conn.rs:39:39 [INFO] [stdout] | [INFO] [stdout] 39 | ($me:ident, $client:ident, $block:expr) => ({ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 39 | ($me:ident, $client:ident, $block:expr_2021) => ({ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/config.rs:999:13 [INFO] [stdout] | [INFO] [stdout] 999 | env::set_var("COLORTERM", "truecolor"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 999 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 1000~ unsafe { env::set_var("COLORTERM", "truecolor") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/config.rs:1000:13 [INFO] [stdout] | [INFO] [stdout] 1000 | env::set_var("LANG", "en_US.UTF-8"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 1000 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 1001 ~ unsafe { env::set_var("LANG", "en_US.UTF-8") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/conn.rs:80:15 [INFO] [stdout] | [INFO] [stdout] 80 | while let State::Disconnected(backoff) = self.state { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/conn.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/conn.rs:171:12 [INFO] [stdout] | [INFO] [stdout] 171 | if let Err(e) = res { [INFO] [stdout] | ^^^^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/conn.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 171 ~ match res { Err(e) => { [INFO] [stdout] 172 | tracing::error!(error = %e, "rpc error sending pause command"); [INFO] [stdout] 173 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/conn.rs:183:12 [INFO] [stdout] | [INFO] [stdout] 183 | if let Err(e) = res { [INFO] [stdout] | ^^^^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/conn.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 183 ~ match res { Err(e) => { [INFO] [stdout] 184 | tracing::error!(error = %e, "rpc error sending resume command"); [INFO] [stdout] 185 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/state/async_ops.rs:195:16 [INFO] [stdout] | [INFO] [stdout] 195 | if let Some(meta) = metas.get(&async_op.meta_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/state/async_ops.rs:198:13 [INFO] [stdout] | [INFO] [stdout] 198 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 195 ~ match metas.get(&async_op.meta_id) { Some(meta) => { [INFO] [stdout] 196 | tracing::trace!(?async_op, ?stats, "processing stats update for"); [INFO] [stdout] 197 | async_op.stats = AsyncOpStats::from_proto(stats, meta, styles, strings, task_ids); [INFO] [stdout] 198 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/state/resources.rs:264:16 [INFO] [stdout] | [INFO] [stdout] 264 | if let Some(meta) = metas.get(&resource.meta_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/state/resources.rs:267:13 [INFO] [stdout] | [INFO] [stdout] 267 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 264 ~ match metas.get(&resource.meta_id) { Some(meta) => { [INFO] [stdout] 265 | tracing::trace!(?resource, ?stats, "processing stats update for"); [INFO] [stdout] 266 | resource.stats = ResourceStats::from_proto(stats, meta, styles, strings); [INFO] [stdout] 267 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/state/tasks.rs:266:16 [INFO] [stdout] | [INFO] [stdout] 266 | if let Some(task) = self.tasks.get(*id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^----------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/state/tasks.rs:270:13 [INFO] [stdout] | [INFO] [stdout] 270 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 266 ~ match self.tasks.get(*id) { Some(task) => { [INFO] [stdout] 267 | if let TaskLintResult::RequiresRecheck = task.borrow_mut().lint(linters) { [INFO] [stdout] 268 | next_pending_lint.insert(*id); [INFO] [stdout] 269 | } [INFO] [stdout] 270 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/state/tasks.rs:267:20 [INFO] [stdout] | [INFO] [stdout] 267 | if let TaskLintResult::RequiresRecheck = task.borrow_mut().lint(linters) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-----------------^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/state/tasks.rs:269:17 [INFO] [stdout] | [INFO] [stdout] 269 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 267 ~ match task.borrow_mut().lint(linters) { TaskLintResult::RequiresRecheck => { [INFO] [stdout] 268 | next_pending_lint.insert(*id); [INFO] [stdout] 269 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/term.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 43 | if let Err(error) = (self.action)() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^--------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/term.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 43 ~ match (self.action)() { Err(error) => { [INFO] [stdout] 44 | tracing::error!(%error, "error running terminal cleanup"); [INFO] [stdout] 45 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/view/mod.rs:135:28 [INFO] [stdout] | [INFO] [stdout] 135 | if let Some(task) = self.tasks_list.selected_item() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/view/mod.rs:141:25 [INFO] [stdout] | [INFO] [stdout] 141 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 135 ~ match self.tasks_list.selected_item() { Some(task) => { [INFO] [stdout] 136 | update_kind = UpdateKind::SelectTask(task.borrow().span_id()); [INFO] [stdout] ... [INFO] [stdout] 140 | )); [INFO] [stdout] 141 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/view/mod.rs:152:28 [INFO] [stdout] | [INFO] [stdout] 152 | if let Some(res) = self.resources_list.selected_item() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^-------------------^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/view/mod.rs:155:25 [INFO] [stdout] | [INFO] [stdout] 155 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 152 ~ match self.resources_list.selected_item() { Some(res) => { [INFO] [stdout] 153 | update_kind = UpdateKind::SelectResource(res.borrow().span_id()); [INFO] [stdout] 154 | self.state = ResourceInstance(self::resource::ResourceView::new(res)); [INFO] [stdout] 155 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/view/mod.rs:172:28 [INFO] [stdout] | [INFO] [stdout] 172 | if let Some(op) = view.async_ops_table.selected_item() { [INFO] [stdout] | ^^^^^^^^^^^^^^^--------------------^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/view/mod.rs:189:25 [INFO] [stdout] | [INFO] [stdout] 189 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 172 ~ match view.async_ops_table.selected_item() { Some(op) => { [INFO] [stdout] 173 | if let Some(task_id) = op.borrow().task_id() { [INFO] [stdout] ... [INFO] [stdout] 188 | } [INFO] [stdout] 189 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/view/mod.rs:173:32 [INFO] [stdout] | [INFO] [stdout] 173 | ... if let Some(task_id) = op.borrow().task_id() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^-----------^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/view/mod.rs:188:29 [INFO] [stdout] | [INFO] [stdout] 188 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 173 ~ match op.borrow().task_id() { Some(task_id) => { [INFO] [stdout] 174 | let task = self [INFO] [stdout] ... [INFO] [stdout] 187 | } [INFO] [stdout] 188 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/view/mod.rs:181:36 [INFO] [stdout] | [INFO] [stdout] 181 | ... if let Some(task) = task { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^---- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/view/mod.rs:187:33 [INFO] [stdout] | [INFO] [stdout] 187 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 181 ~ match task { Some(task) => { [INFO] [stdout] 182 | update_kind = UpdateKind::SelectTask(task.borrow().span_id()); [INFO] [stdout] ... [INFO] [stdout] 186 | )); [INFO] [stdout] 187 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed tests/cli-ui.rs (3 fixes) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.66s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking tokio-console v0.1.12 (/tmp/fixit) [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/config.rs:999:13 [INFO] [stdout] | [INFO] [stdout] 999 | env::set_var("COLORTERM", "truecolor"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/config.rs:1000:13 [INFO] [stdout] | [INFO] [stdout] 1000 | env::set_var("LANG", "en_US.UTF-8"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `tokio-console` (bin "tokio-console" test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "bb9e2fadc0db77242dc9af892579f5c8bc62f955008816b15b4928741ca0ae1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb9e2fadc0db77242dc9af892579f5c8bc62f955008816b15b4928741ca0ae1f", kill_on_drop: false }` [INFO] [stdout] bb9e2fadc0db77242dc9af892579f5c8bc62f955008816b15b4928741ca0ae1f