[INFO] fetching crate tmaze 1.15.2... [INFO] checking tmaze-1.15.2 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate tmaze 1.15.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate tmaze 1.15.2 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tmaze 1.15.2 [INFO] finished tweaking crates.io crate tmaze 1.15.2 [INFO] tweaked toml for crates.io crate tmaze 1.15.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate tmaze 1.15.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3cca6a027f1de0d68a7a8e5c30a2abc0e84e75cc0ee37a46dfd8be91aadbbeb2 [INFO] running `Command { std: "docker" "start" "-a" "3cca6a027f1de0d68a7a8e5c30a2abc0e84e75cc0ee37a46dfd8be91aadbbeb2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3cca6a027f1de0d68a7a8e5c30a2abc0e84e75cc0ee37a46dfd8be91aadbbeb2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3cca6a027f1de0d68a7a8e5c30a2abc0e84e75cc0ee37a46dfd8be91aadbbeb2", kill_on_drop: false }` [INFO] [stdout] 3cca6a027f1de0d68a7a8e5c30a2abc0e84e75cc0ee37a46dfd8be91aadbbeb2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6045dfd5ee54d5bd1a2767cd06270f6abde2201184c1de9ed000725bb76e656c [INFO] running `Command { std: "docker" "start" "-a" "6045dfd5ee54d5bd1a2767cd06270f6abde2201184c1de9ed000725bb76e656c", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling cc v1.0.94 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling rustls v0.22.4 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking bytemuck v1.15.0 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking symphonia-core v0.5.4 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling backtrace v0.3.71 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling cpal v0.15.3 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking symphonia-metadata v0.5.4 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.4 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking webpki-roots v0.26.1 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Compiling substring v1.4.5 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking rustls-webpki v0.102.4 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking symphonia v0.5.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking pausable_clock v1.0.1 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking better-panic v0.3.0 [INFO] [stderr] Checking pad v0.1.6 [INFO] [stderr] Checking cmaze v0.7.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking serde v1.0.197 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking hyper-util v0.1.4 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking hyper-rustls v0.26.0 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking serde_json v1.0.115 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking chrono v0.4.37 [INFO] [stderr] Checking alsa v0.9.0 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking reqwest v0.12.4 [INFO] [stderr] Checking rodio v0.18.1 [INFO] [stderr] Checking crates_io_api v0.11.0 [INFO] [stderr] Checking tmaze v1.15.2 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `tmaze` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/helpers/mod.rs [INFO] [stderr] * src/ui/draw.rs [INFO] [stderr] * src/ui/menu.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/helpers/mod.rs:194:7 [INFO] [stderr] | [INFO] [stderr] 194 | (($a:expr_2021) -> ($b:expr_2021) at $t:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/helpers/mod.rs:194:25 [INFO] [stderr] | [INFO] [stderr] 194 | (($a:expr_2021) -> ($b:expr_2021) at $t:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/helpers/mod.rs:194:42 [INFO] [stderr] | [INFO] [stderr] 194 | (($a:expr_2021) -> ($b:expr_2021) at $t:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/ui/menu.rs:392:14 [INFO] [stderr] | [INFO] [stderr] 392 | ($change:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/ui/menu.rs:548:62 [INFO] [stderr] | [INFO] [stderr] 548 | ($($name:literal $(on $feature:literal)? -> $data:pat => $action:expr_2021),* $(,)?) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] warning: elided lifetime has a name [INFO] [stderr] --> src/ui/draw.rs:89:86 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn trim_absolute<'a>(&'a self, text: &'a impl AsRef, mut pos: Dims) -> (&str, Dims) { [INFO] [stderr] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stderr] [INFO] [stderr] warning: elided lifetime has a name [INFO] [stderr] --> src/ui/draw.rs:113:82 [INFO] [stderr] | [INFO] [stderr] 113 | pub fn trim_relative<'a>(&'a self, text: &'a impl AsRef, pos: Dims) -> (&str, Dims) { [INFO] [stderr] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/app/game.rs:318:25 [INFO] [stdout] | [INFO] [stdout] 318 | let gen = self.functions[index](data); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/app/game.rs:322:66 [INFO] [stdout] | [INFO] [stdout] 322 | MazeGenerationActivity::new(self.preset, gen, &data.settings), [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/helpers/mod.rs:194:10 [INFO] [stdout] | [INFO] [stdout] 194 | (($a:expr) -> ($b:expr) at $t:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 194 | (($a:expr_2021) -> ($b:expr) at $t:expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/helpers/mod.rs:194:23 [INFO] [stdout] | [INFO] [stdout] 194 | (($a:expr) -> ($b:expr) at $t:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 194 | (($a:expr) -> ($b:expr_2021) at $t:expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/helpers/mod.rs:194:35 [INFO] [stdout] | [INFO] [stdout] 194 | (($a:expr) -> ($b:expr) at $t:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 194 | (($a:expr) -> ($b:expr) at $t:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/ui/draw.rs:89:86 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn trim_absolute<'a>(&'a self, text: &'a impl AsRef, mut pos: Dims) -> (&str, Dims) { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/ui/draw.rs:113:82 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn trim_relative<'a>(&'a self, text: &'a impl AsRef, pos: Dims) -> (&str, Dims) { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/ui/menu.rs:392:22 [INFO] [stdout] | [INFO] [stdout] 392 | ($change:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 392 | ($change:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/ui/menu.rs:548:70 [INFO] [stdout] | [INFO] [stdout] 548 | ($($name:literal $(on $feature:literal)? -> $data:pat => $action:expr),* $(,)?) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 548 | ($($name:literal $(on $feature:literal)? -> $data:pat => $action:expr_2021),* $(,)?) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app/activity.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 115 | if let Some(index) = self.activities.iter().rposition(|a| a.name() == name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^---------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app/activity.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 115 ~ match self.activities.iter().rposition(|a| a.name() == name) { Some(index) => { [INFO] [stdout] 116 | self.activities.truncate(index + 1); [INFO] [stdout] 117 | index [INFO] [stdout] 118 ~ } _ => { [INFO] [stdout] 119 | log::warn!("Activity `{}` not found, popping top", name); [INFO] [stdout] 120 | self.pop_n(1); [INFO] [stdout] 121 | 1 [INFO] [stdout] 122 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app/app.rs:125:19 [INFO] [stdout] | [INFO] [stdout] 125 | while let Some(job) = self.data.jobs.pop() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app/app.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app/app.rs:132:19 [INFO] [stdout] | [INFO] [stdout] 132 | while let Ok(true) = crossterm::event::poll(delay) { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app/app.rs:149:13 [INFO] [stdout] | [INFO] [stdout] 149 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app/app.rs:151:19 [INFO] [stdout] | [INFO] [stdout] 151 | while let Some(change) = match self.activities.active_mut() { [INFO] [stdout] | ___________________^ - [INFO] [stdout] | |______________________________________| [INFO] [stdout] 152 | || Some(active) => { [INFO] [stdout] 153 | || log::trace!("Active activity: '{}'", active.name()); [INFO] [stdout] 154 | || active [INFO] [stdout] ... || [INFO] [stdout] 157 | || } [INFO] [stdout] 158 | || .update(std::mem::take(&mut events), &mut self.data) [INFO] [stdout] | ||________________________________________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app/app.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app/game.rs:696:16 [INFO] [stdout] | [INFO] [stdout] 696 | if let Event::Term(TermEvent::Key(key_event)) = event { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app/game.rs:709:13 [INFO] [stdout] | [INFO] [stdout] 709 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 696 ~ match event { Event::Term(TermEvent::Key(key_event)) => { [INFO] [stdout] 697 | match self.game.handle_event(&data.settings, key_event) { [INFO] [stdout] ... [INFO] [stdout] 708 | } [INFO] [stdout] 709 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/settings/mod.rs:406:46 [INFO] [stdout] | [INFO] [stdout] 406 | let mut settings: SettingsInner = if let Ok(settings_string) = settings_string { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^--------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/settings/mod.rs:410:9 [INFO] [stdout] | [INFO] [stdout] 410 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 406 ~ let mut settings: SettingsInner = match settings_string { Ok(settings_string) => { [INFO] [stdout] 407 | options [INFO] [stdout] 408 | .from_str(&settings_string) [INFO] [stdout] 409 | .expect("Could not parse settings file") [INFO] [stdout] 410 ~ } _ => { [INFO] [stdout] 411 | fs::create_dir_all(path.parent().unwrap())?; [INFO] [stdout] 412 | fs::write(&path, default_settings_string)?; [INFO] [stdout] 413 | options.from_str(default_settings_string).unwrap() [INFO] [stdout] 414 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/ui/menu.rs:359:12 [INFO] [stdout] | [INFO] [stdout] 359 | if let MenuItem::Slider(SliderDef { [INFO] [stdout] | ____________^ [INFO] [stdout] 360 | | val, range, fun, .. [INFO] [stdout] 361 | | }) = &mut self.config.options[self.selected as usize] [INFO] [stdout] | |___________________------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/ui/menu.rs:365:9 [INFO] [stdout] | [INFO] [stdout] 365 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 359 ~ match &mut self.config.options[self.selected as usize] [INFO] [stdout] 360 ~ { MenuItem::Slider(SliderDef { [INFO] [stdout] 361 + val, range, fun, .. [INFO] [stdout] 362 ~ }) => { [INFO] [stdout] 363 | fun(right, val, data); [INFO] [stdout] 364 | *val = (*val).clamp(*range.start(), *range.end()); [INFO] [stdout] 365 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/ui/popup.rs:60:16 [INFO] [stdout] | [INFO] [stdout] 60 | if let Event::Term(TermEvent::Key(KeyEvent { code, kind, .. })) = event { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/ui/popup.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 60 ~ match event { Event::Term(TermEvent::Key(KeyEvent { code, kind, .. })) => { [INFO] [stdout] 61 | if !is_release(kind) { [INFO] [stdout] 62 | return Some(Change::pop_top_with(code)); [INFO] [stdout] 63 | } [INFO] [stdout] 64 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `tmaze` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/helpers/mod.rs [INFO] [stderr] * src/ui/draw.rs [INFO] [stderr] * src/ui/menu.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/helpers/mod.rs:194:7 [INFO] [stderr] | [INFO] [stderr] 194 | (($a:expr_2021) -> ($b:expr_2021) at $t:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/helpers/mod.rs:194:25 [INFO] [stderr] | [INFO] [stderr] 194 | (($a:expr_2021) -> ($b:expr_2021) at $t:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/helpers/mod.rs:194:42 [INFO] [stderr] | [INFO] [stderr] 194 | (($a:expr_2021) -> ($b:expr_2021) at $t:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/ui/menu.rs:392:14 [INFO] [stderr] | [INFO] [stderr] 392 | ($change:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/ui/menu.rs:548:62 [INFO] [stderr] | [INFO] [stderr] 548 | ($($name:literal $(on $feature:literal)? -> $data:pat => $action:expr_2021),* $(,)?) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] warning: elided lifetime has a name [INFO] [stderr] --> src/ui/draw.rs:89:86 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn trim_absolute<'a>(&'a self, text: &'a impl AsRef, mut pos: Dims) -> (&str, Dims) { [INFO] [stderr] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stderr] [INFO] [stderr] warning: elided lifetime has a name [INFO] [stderr] --> src/ui/draw.rs:113:82 [INFO] [stderr] | [INFO] [stderr] 113 | pub fn trim_relative<'a>(&'a self, text: &'a impl AsRef, pos: Dims) -> (&str, Dims) { [INFO] [stderr] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/app/game.rs:318:25 [INFO] [stdout] | [INFO] [stdout] 318 | let gen = self.functions[index](data); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/app/game.rs:322:66 [INFO] [stdout] | [INFO] [stdout] 322 | MazeGenerationActivity::new(self.preset, gen, &data.settings), [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/helpers/mod.rs:194:10 [INFO] [stdout] | [INFO] [stdout] 194 | (($a:expr) -> ($b:expr) at $t:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 194 | (($a:expr_2021) -> ($b:expr) at $t:expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/helpers/mod.rs:194:23 [INFO] [stdout] | [INFO] [stdout] 194 | (($a:expr) -> ($b:expr) at $t:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 194 | (($a:expr) -> ($b:expr_2021) at $t:expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/helpers/mod.rs:194:35 [INFO] [stdout] | [INFO] [stdout] 194 | (($a:expr) -> ($b:expr) at $t:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 194 | (($a:expr) -> ($b:expr) at $t:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/ui/draw.rs:89:86 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn trim_absolute<'a>(&'a self, text: &'a impl AsRef, mut pos: Dims) -> (&str, Dims) { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/ui/draw.rs:113:82 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn trim_relative<'a>(&'a self, text: &'a impl AsRef, pos: Dims) -> (&str, Dims) { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/ui/menu.rs:392:22 [INFO] [stdout] | [INFO] [stdout] 392 | ($change:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 392 | ($change:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/ui/menu.rs:548:70 [INFO] [stdout] | [INFO] [stdout] 548 | ($($name:literal $(on $feature:literal)? -> $data:pat => $action:expr),* $(,)?) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 548 | ($($name:literal $(on $feature:literal)? -> $data:pat => $action:expr_2021),* $(,)?) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app/activity.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 115 | if let Some(index) = self.activities.iter().rposition(|a| a.name() == name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^---------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app/activity.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 115 ~ match self.activities.iter().rposition(|a| a.name() == name) { Some(index) => { [INFO] [stdout] 116 | self.activities.truncate(index + 1); [INFO] [stdout] 117 | index [INFO] [stdout] 118 ~ } _ => { [INFO] [stdout] 119 | log::warn!("Activity `{}` not found, popping top", name); [INFO] [stdout] 120 | self.pop_n(1); [INFO] [stdout] 121 | 1 [INFO] [stdout] 122 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app/app.rs:125:19 [INFO] [stdout] | [INFO] [stdout] 125 | while let Some(job) = self.data.jobs.pop() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app/app.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app/app.rs:132:19 [INFO] [stdout] | [INFO] [stdout] 132 | while let Ok(true) = crossterm::event::poll(delay) { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app/app.rs:149:13 [INFO] [stdout] | [INFO] [stdout] 149 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app/app.rs:151:19 [INFO] [stdout] | [INFO] [stdout] 151 | while let Some(change) = match self.activities.active_mut() { [INFO] [stdout] | ___________________^ - [INFO] [stdout] | |______________________________________| [INFO] [stdout] 152 | || Some(active) => { [INFO] [stdout] 153 | || log::trace!("Active activity: '{}'", active.name()); [INFO] [stdout] 154 | || active [INFO] [stdout] ... || [INFO] [stdout] 157 | || } [INFO] [stdout] 158 | || .update(std::mem::take(&mut events), &mut self.data) [INFO] [stdout] | ||________________________________________________________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app/app.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app/game.rs:696:16 [INFO] [stdout] | [INFO] [stdout] 696 | if let Event::Term(TermEvent::Key(key_event)) = event { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app/game.rs:709:13 [INFO] [stdout] | [INFO] [stdout] 709 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 696 ~ match event { Event::Term(TermEvent::Key(key_event)) => { [INFO] [stdout] 697 | match self.game.handle_event(&data.settings, key_event) { [INFO] [stdout] ... [INFO] [stdout] 708 | } [INFO] [stdout] 709 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/settings/mod.rs:406:46 [INFO] [stdout] | [INFO] [stdout] 406 | let mut settings: SettingsInner = if let Ok(settings_string) = settings_string { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^--------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/settings/mod.rs:410:9 [INFO] [stdout] | [INFO] [stdout] 410 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 406 ~ let mut settings: SettingsInner = match settings_string { Ok(settings_string) => { [INFO] [stdout] 407 | options [INFO] [stdout] 408 | .from_str(&settings_string) [INFO] [stdout] 409 | .expect("Could not parse settings file") [INFO] [stdout] 410 ~ } _ => { [INFO] [stdout] 411 | fs::create_dir_all(path.parent().unwrap())?; [INFO] [stdout] 412 | fs::write(&path, default_settings_string)?; [INFO] [stdout] 413 | options.from_str(default_settings_string).unwrap() [INFO] [stdout] 414 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/ui/menu.rs:359:12 [INFO] [stdout] | [INFO] [stdout] 359 | if let MenuItem::Slider(SliderDef { [INFO] [stdout] | ____________^ [INFO] [stdout] 360 | | val, range, fun, .. [INFO] [stdout] 361 | | }) = &mut self.config.options[self.selected as usize] [INFO] [stdout] | |___________________------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/ui/menu.rs:365:9 [INFO] [stdout] | [INFO] [stdout] 365 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 359 ~ match &mut self.config.options[self.selected as usize] [INFO] [stdout] 360 ~ { MenuItem::Slider(SliderDef { [INFO] [stdout] 361 + val, range, fun, .. [INFO] [stdout] 362 ~ }) => { [INFO] [stdout] 363 | fun(right, val, data); [INFO] [stdout] 364 | *val = (*val).clamp(*range.start(), *range.end()); [INFO] [stdout] 365 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/ui/popup.rs:60:16 [INFO] [stdout] | [INFO] [stdout] 60 | if let Event::Term(TermEvent::Key(KeyEvent { code, kind, .. })) = event { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/ui/popup.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 60 ~ match event { Event::Term(TermEvent::Key(KeyEvent { code, kind, .. })) => { [INFO] [stdout] 61 | if !is_release(kind) { [INFO] [stdout] 62 | return Some(Change::pop_top_with(code)); [INFO] [stdout] 63 | } [INFO] [stdout] 64 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/menu.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/box.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/updates.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/one_menu.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/audio.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/logging.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/empty_menu.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/popup.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.24s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking tmaze v1.15.2 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/app/game.rs:318:25 [INFO] [stdout] | [INFO] [stdout] 318 | let gen = self.functions[index](data); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 318 | let r#gen = self.functions[index](data); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected expression, found reserved keyword `gen` [INFO] [stdout] --> src/app/game.rs:322:66 [INFO] [stdout] | [INFO] [stdout] 322 | MazeGenerationActivity::new(self.preset, gen, &data.settings), [INFO] [stdout] | ^^^ expected expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/app/game.rs:318:25 [INFO] [stdout] | [INFO] [stdout] 318 | let gen = self.functions[index](data); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 318 | let r#gen = self.functions[index](data); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected expression, found reserved keyword `gen` [INFO] [stdout] --> src/app/game.rs:322:66 [INFO] [stdout] | [INFO] [stdout] 322 | MazeGenerationActivity::new(self.preset, gen, &data.settings), [INFO] [stdout] | ^^^ expected expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/ui/draw.rs:89:86 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn trim_absolute<'a>(&'a self, text: &'a impl AsRef, mut pos: Dims) -> (&str, Dims) { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/ui/draw.rs:113:82 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn trim_relative<'a>(&'a self, text: &'a impl AsRef, pos: Dims) -> (&str, Dims) { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/ui/draw.rs:89:86 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn trim_absolute<'a>(&'a self, text: &'a impl AsRef, mut pos: Dims) -> (&str, Dims) { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/ui/draw.rs:113:82 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn trim_relative<'a>(&'a self, text: &'a impl AsRef, pos: Dims) -> (&str, Dims) { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tmaze` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `tmaze` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "6045dfd5ee54d5bd1a2767cd06270f6abde2201184c1de9ed000725bb76e656c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6045dfd5ee54d5bd1a2767cd06270f6abde2201184c1de9ed000725bb76e656c", kill_on_drop: false }` [INFO] [stdout] 6045dfd5ee54d5bd1a2767cd06270f6abde2201184c1de9ed000725bb76e656c