[INFO] fetching crate surrealdb-tikv-client 0.3.0-surreal.1... [INFO] checking surrealdb-tikv-client-0.3.0-surreal.1 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate surrealdb-tikv-client 0.3.0-surreal.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate surrealdb-tikv-client 0.3.0-surreal.1 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-3-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate surrealdb-tikv-client 0.3.0-surreal.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate surrealdb-tikv-client 0.3.0-surreal.1 [INFO] tweaked toml for crates.io crate surrealdb-tikv-client 0.3.0-surreal.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate surrealdb-tikv-client 0.3.0-surreal.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 99aebe5ff7b0791170b02f7ebbae8913954fba9aec80f9a06fc2c1fea15a5930 [INFO] running `Command { std: "docker" "start" "-a" "99aebe5ff7b0791170b02f7ebbae8913954fba9aec80f9a06fc2c1fea15a5930", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "99aebe5ff7b0791170b02f7ebbae8913954fba9aec80f9a06fc2c1fea15a5930", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "99aebe5ff7b0791170b02f7ebbae8913954fba9aec80f9a06fc2c1fea15a5930", kill_on_drop: false }` [INFO] [stdout] 99aebe5ff7b0791170b02f7ebbae8913954fba9aec80f9a06fc2c1fea15a5930 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c45faaf5ba01a4127eaba8df997523da3595547701b2accf4d006466cd78e8af [INFO] running `Command { std: "docker" "start" "-a" "c45faaf5ba01a4127eaba8df997523da3595547701b2accf4d006466cd78e8af", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling cc v1.0.100 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Compiling openssl-src v300.3.1+3.3.1 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling axum-core v0.3.4 [INFO] [stderr] Compiling either v1.12.0 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling axum v0.6.20 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling protobuf v2.28.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling procfs v0.16.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking procfs-core v0.16.0 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Compiling rstest_macros v0.18.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling prometheus v0.13.4 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling prost-derive v0.12.6 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking prost v0.12.6 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-io-timeout v1.2.0 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking fail v0.4.0 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Compiling derive-new v0.5.9 [INFO] [stderr] Compiling serial_test_derive v0.5.1 [INFO] [stderr] Compiling async-recursion v0.3.2 [INFO] [stderr] Checking colored v1.9.4 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stderr] Checking hyper v0.14.29 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking rstest v0.18.2 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking simple_logger v1.16.0 [INFO] [stderr] Checking serial_test v0.5.1 [INFO] [stderr] Checking hyper-util v0.1.5 [INFO] [stderr] Compiling proptest-derive v0.3.0 [INFO] [stderr] Checking hyper-timeout v0.4.1 [INFO] [stderr] Checking tonic v0.10.2 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking surrealdb-tikv-client v0.3.0-surreal.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `tikv_client` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/common/errors.rs [INFO] [stderr] * src/pd/cluster.rs [INFO] [stderr] * src/pd/retry.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/common/errors.rs:134:6 [INFO] [stderr] | [INFO] [stderr] 134 | ($e:expr_2021) => ({ [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/common/errors.rs:139:15 [INFO] [stderr] | [INFO] [stderr] 139 | ($f:tt, $($arg:expr_2021),+) => ({ [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/pd/cluster.rs:35:6 [INFO] [stderr] | [INFO] [stderr] 35 | ($cluster_id:expr_2021, $type:ty) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/pd/retry.rs:77:35 [INFO] [stderr] | [INFO] [stderr] 77 | ($self: ident, $tag: literal, $call: expr_2021) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/pd/retry.rs:104:53 [INFO] [stderr] | [INFO] [stderr] 104 | ($self: ident, $tag: literal, |$cluster: ident| $call: expr_2021) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/pd/retry.rs:115:53 [INFO] [stderr] | [INFO] [stderr] 115 | ($self: ident, $tag: literal, |$cluster: ident| $call: expr_2021) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/request/shard.rs:288:41 [INFO] [stdout] | [INFO] [stdout] 288 | .map(|_| (0..2).map(|_| rng.gen::()).collect::>()) [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/request/shard.rs:308:41 [INFO] [stdout] | [INFO] [stdout] 308 | .map(|_| (0..3).map(|_| rng.gen::()).collect::>()) [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/common/errors.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 134 | ($e:expr) => ({ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 134 | ($e:expr_2021) => ({ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/common/errors.rs:139:20 [INFO] [stdout] | [INFO] [stdout] 139 | ($f:tt, $($arg:expr),+) => ({ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 139 | ($f:tt, $($arg:expr_2021),+) => ({ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/pd/cluster.rs:35:18 [INFO] [stdout] | [INFO] [stdout] 35 | ($cluster_id:expr, $type:ty) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 35 | ($cluster_id:expr_2021, $type:ty) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/pd/retry.rs:77:42 [INFO] [stdout] | [INFO] [stdout] 77 | ($self: ident, $tag: literal, $call: expr) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 77 | ($self: ident, $tag: literal, $call: expr_2021) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/pd/retry.rs:104:60 [INFO] [stdout] | [INFO] [stdout] 104 | ($self: ident, $tag: literal, |$cluster: ident| $call: expr) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 104 | ($self: ident, $tag: literal, |$cluster: ident| $call: expr_2021) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/pd/retry.rs:115:60 [INFO] [stdout] | [INFO] [stdout] 115 | ($self: ident, $tag: literal, |$cluster: ident| $call: expr) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 115 | ($self: ident, $tag: literal, |$cluster: ident| $call: expr_2021) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/request/plan.rs:184:12 [INFO] [stdout] | [INFO] [stdout] 184 | if let Some(e) = resp.key_errors() { [INFO] [stdout] | ^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 185 | Ok(vec![Err(Error::MultipleKeyErrors(e))]) [INFO] [stdout] 186 | } else if let Some(e) = resp.region_error() { [INFO] [stdout] | ---- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/request/plan.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | } else if let Some(e) = resp.region_error() { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/request/plan.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 206 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 184 ~ match resp.key_errors() { Some(e) => { [INFO] [stdout] 185 | Ok(vec![Err(Error::MultipleKeyErrors(e))]) [INFO] [stdout] 186 ~ } _ => { match resp.region_error() { Some(e) => { [INFO] [stdout] 187 | match backoff.next_delay_duration() { [INFO] [stdout] ... [INFO] [stdout] 205 | } [INFO] [stdout] 206 ~ } _ => { [INFO] [stdout] 207 | Ok(vec![Ok(resp)]) [INFO] [stdout] 208 ~ }}}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/request/plan.rs:432:24 [INFO] [stdout] | [INFO] [stdout] 432 | if let Some(e) = resp.key_errors() { [INFO] [stdout] | ^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 433 | return Err(Error::MultipleKeyErrors(e)); [INFO] [stdout] 434 | } else if let Some(e) = resp.region_error() { [INFO] [stdout] | ---- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/request/plan.rs:434:21 [INFO] [stdout] | [INFO] [stdout] 434 | } else if let Some(e) = resp.region_error() { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/request/plan.rs:437:21 [INFO] [stdout] | [INFO] [stdout] 437 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 432 ~ match resp.key_errors() { Some(e) => { [INFO] [stdout] 433 | return Err(Error::MultipleKeyErrors(e)); [INFO] [stdout] 434 ~ } _ => { match resp.region_error() { Some(e) => { [INFO] [stdout] 435 | // Store request should not return region error. [INFO] [stdout] 436 | return Err(Error::RegionError(Box::new(e))); [INFO] [stdout] 437 ~ } _ => { [INFO] [stdout] 438 | return Ok(resp); [INFO] [stdout] 439 ~ }}}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/request/plan.rs:687:16 [INFO] [stdout] | [INFO] [stdout] 687 | if let Some(e) = scan_lock_resp.key_errors() { [INFO] [stdout] | ^^^^^^^^^^^^^^--------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 691 | } else if let Some(e) = scan_lock_resp.region_error() { [INFO] [stdout] | -------------- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/request/plan.rs:691:13 [INFO] [stdout] | [INFO] [stdout] 691 | } else if let Some(e) = scan_lock_resp.region_error() { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/request/plan.rs:695:13 [INFO] [stdout] | [INFO] [stdout] 695 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 687 ~ match scan_lock_resp.key_errors() { Some(e) => { [INFO] [stdout] 688 | info!("CleanupLocks::execute, inner key errors:{:?}", e); [INFO] [stdout] 689 | result.key_error = Some(e); [INFO] [stdout] 690 | return Ok(result); [INFO] [stdout] 691 ~ } _ => { match scan_lock_resp.region_error() { Some(e) => { [INFO] [stdout] 692 | info!("CleanupLocks::execute, inner region error:{}", e.message); [INFO] [stdout] 693 | result.region_error = Some(e); [INFO] [stdout] 694 | return Ok(result); [INFO] [stdout] 695 ~ } _ => {}}}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/request/plan.rs:737:24 [INFO] [stdout] | [INFO] [stdout] 737 | if let Error::RegionError(e) = errors.pop().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/request/plan.rs:739:21 [INFO] [stdout] | [INFO] [stdout] 739 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 737 ~ match errors.pop().unwrap() { Error::RegionError(e) => { [INFO] [stdout] 738 | result.region_error = Some(*e); [INFO] [stdout] 739 ~ } _ => { [INFO] [stdout] 740 | result.key_error = Some(errors); [INFO] [stdout] 741 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/request/plan.rs:788:12 [INFO] [stdout] | [INFO] [stdout] 788 | if let Some(errors) = result.key_errors() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 789 | Err(Error::ExtractedErrors(errors)) [INFO] [stdout] 790 | } else if let Some(errors) = result.region_errors() { [INFO] [stdout] | ------ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/request/plan.rs:790:9 [INFO] [stdout] | [INFO] [stdout] 790 | } else if let Some(errors) = result.region_errors() { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/request/plan.rs:797:9 [INFO] [stdout] | [INFO] [stdout] 797 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 788 ~ match result.key_errors() { Some(errors) => { [INFO] [stdout] 789 | Err(Error::ExtractedErrors(errors)) [INFO] [stdout] 790 ~ } _ => { match result.region_errors() { Some(errors) => { [INFO] [stdout] 791 | Err(Error::ExtractedErrors( [INFO] [stdout] ... [INFO] [stdout] 796 | )) [INFO] [stdout] 797 ~ } _ => { [INFO] [stdout] 798 | Ok(result) [INFO] [stdout] 799 ~ }}}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transaction/transaction.rs:872:12 [INFO] [stdout] | [INFO] [stdout] 872 | if let Err(err) = pairs { [INFO] [stdout] | ^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transaction/transaction.rs:885:9 [INFO] [stdout] | [INFO] [stdout] 885 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 872 ~ match pairs { Err(err) => { [INFO] [stdout] 873 | match err { [INFO] [stdout] ... [INFO] [stdout] 884 | } [INFO] [stdout] 885 ~ } _ => { [INFO] [stdout] 886 | // primary key will be set here if needed [INFO] [stdout] ... [INFO] [stdout] 895 | pairs [INFO] [stdout] 896 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transaction/transaction.rs:1001:16 [INFO] [stdout] | [INFO] [stdout] 1001 | if let Err(err) = heartbeat_task.await { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transaction/transaction.rs:1003:13 [INFO] [stdout] | [INFO] [stdout] 1003 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1001 ~ match heartbeat_task.await { Err(err) => { [INFO] [stdout] 1002 | log::error!("Error: While sending heartbeat. {}", err); [INFO] [stdout] 1003 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transaction/transaction.rs:1307:16 [INFO] [stdout] | [INFO] [stdout] 1307 | if let Err(e) = res { [INFO] [stdout] | ^^^^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transaction/transaction.rs:1309:13 [INFO] [stdout] | [INFO] [stdout] 1309 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1307 ~ match res { Err(e) => { [INFO] [stdout] 1308 | log::warn!("Failed to commit secondary keys: {}", e); [INFO] [stdout] 1309 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/client.rs:96:20 [INFO] [stdout] | [INFO] [stdout] 96 | if let Some(key) = keys.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/client.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 96 ~ match keys.next() { Some(key) => { [INFO] [stdout] 97 | let region = this.region_for_key(key.as_ref()).await?; [INFO] [stdout] ... [INFO] [stdout] 105 | Ok(Some((keys, (region, grouped)))) [INFO] [stdout] 106 ~ } _ => { [INFO] [stdout] 107 | Ok(None) [INFO] [stdout] 108 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/client.rs:99:27 [INFO] [stdout] | [INFO] [stdout] 99 | while let Some(key) = keys.peek() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/client.rs:104:21 [INFO] [stdout] | [INFO] [stdout] 104 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/cluster.rs:324:20 [INFO] [stdout] | [INFO] [stdout] 324 | if let Ok((client, keyspace_client, members)) = [INFO] [stdout] | ____________________^ [INFO] [stdout] 325 | | self.try_connect(ep.as_str(), cluster_id, timeout).await [INFO] [stdout] | |_____________________-------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/cluster.rs:328:17 [INFO] [stdout] | [INFO] [stdout] 328 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 324 ~ match self.try_connect(ep.as_str(), cluster_id, timeout).await [INFO] [stdout] 325 ~ { Ok((client, keyspace_client, members)) => { [INFO] [stdout] 326 | return Ok((client, keyspace_client, members)); [INFO] [stdout] 327 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/cluster.rs:350:12 [INFO] [stdout] | [INFO] [stdout] 350 | if let Some(err) = &response.header().error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^--------^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/cluster.rs:352:9 [INFO] [stdout] | [INFO] [stdout] 352 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 350 ~ match &response.header().error { Some(err) => { [INFO] [stdout] 351 | Err(internal_err!(err.message)) [INFO] [stdout] 352 ~ } _ => { [INFO] [stdout] 353 | Ok(response) [INFO] [stdout] 354 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await { [INFO] [stdout] | ^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 149 | / retry_mut!(self, "get_region", |cluster| { [INFO] [stdout] 150 | | let key = key.clone(); [INFO] [stdout] 151 | | async { [INFO] [stdout] 152 | | cluster [INFO] [stdout] ... | [INFO] [stdout] 158 | | } [INFO] [stdout] 159 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | } [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 149 | / retry_mut!(self, "get_region", |cluster| { [INFO] [stdout] 150 | | let key = key.clone(); [INFO] [stdout] 151 | | async { [INFO] [stdout] 152 | | cluster [INFO] [stdout] ... | [INFO] [stdout] 158 | | } [INFO] [stdout] 159 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `retry_core` which comes from the expansion of the macro `retry_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await { [INFO] [stdout] | ^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 163 | / retry_mut!(self, "get_region_by_id", |cluster| async { [INFO] [stdout] 164 | | cluster [INFO] [stdout] 165 | | .get_region_by_id(region_id, self.timeout) [INFO] [stdout] 166 | | .await [INFO] [stdout] ... | [INFO] [stdout] 169 | | }) [INFO] [stdout] 170 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | } [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 163 | / retry_mut!(self, "get_region_by_id", |cluster| async { [INFO] [stdout] 164 | | cluster [INFO] [stdout] 165 | | .get_region_by_id(region_id, self.timeout) [INFO] [stdout] 166 | | .await [INFO] [stdout] ... | [INFO] [stdout] 169 | | }) [INFO] [stdout] 170 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `retry_core` which comes from the expansion of the macro `retry_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await { [INFO] [stdout] | ^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 174 | / retry_mut!(self, "get_store", |cluster| async { [INFO] [stdout] 175 | | cluster [INFO] [stdout] 176 | | .get_store(id, self.timeout) [INFO] [stdout] 177 | | .await [INFO] [stdout] 178 | | .map(|resp| resp.store.unwrap()) [INFO] [stdout] 179 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | } [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 174 | / retry_mut!(self, "get_store", |cluster| async { [INFO] [stdout] 175 | | cluster [INFO] [stdout] 176 | | .get_store(id, self.timeout) [INFO] [stdout] 177 | | .await [INFO] [stdout] 178 | | .map(|resp| resp.store.unwrap()) [INFO] [stdout] 179 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `retry_core` which comes from the expansion of the macro `retry_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await { [INFO] [stdout] | ^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 183 | / retry_mut!(self, "get_all_stores", |cluster| async { [INFO] [stdout] 184 | | cluster [INFO] [stdout] 185 | | .get_all_stores(self.timeout) [INFO] [stdout] 186 | | .await [INFO] [stdout] 187 | | .map(|resp| resp.stores.into_iter().map(Into::into).collect()) [INFO] [stdout] 188 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | } [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 183 | / retry_mut!(self, "get_all_stores", |cluster| async { [INFO] [stdout] 184 | | cluster [INFO] [stdout] 185 | | .get_all_stores(self.timeout) [INFO] [stdout] 186 | | .await [INFO] [stdout] 187 | | .map(|resp| resp.stores.into_iter().map(Into::into).collect()) [INFO] [stdout] 188 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `retry_core` which comes from the expansion of the macro `retry_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await { [INFO] [stdout] | ^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 192 | retry!(self, "get_timestamp", |cluster| cluster.get_timestamp()) [INFO] [stdout] | ---------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | } [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 192 | retry!(self, "get_timestamp", |cluster| cluster.get_timestamp()) [INFO] [stdout] | ---------------------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `retry_core` which comes from the expansion of the macro `retry` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await { [INFO] [stdout] | ^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 196 | / retry_mut!(self, "update_gc_safepoint", |cluster| async { [INFO] [stdout] 197 | | cluster [INFO] [stdout] 198 | | .update_safepoint(safepoint, self.timeout) [INFO] [stdout] 199 | | .await [INFO] [stdout] 200 | | .map(|resp| resp.new_safe_point == safepoint) [INFO] [stdout] 201 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | } [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 196 | / retry_mut!(self, "update_gc_safepoint", |cluster| async { [INFO] [stdout] 197 | | cluster [INFO] [stdout] 198 | | .update_safepoint(safepoint, self.timeout) [INFO] [stdout] 199 | | .await [INFO] [stdout] 200 | | .map(|resp| resp.new_safe_point == safepoint) [INFO] [stdout] 201 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `retry_core` which comes from the expansion of the macro `retry_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await { [INFO] [stdout] | ^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 205 | / retry_mut!(self, "load_keyspace", |cluster| async { [INFO] [stdout] 206 | | cluster.load_keyspace(keyspace, self.timeout).await [INFO] [stdout] 207 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | } [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 205 | / retry_mut!(self, "load_keyspace", |cluster| async { [INFO] [stdout] 206 | | cluster.load_keyspace(keyspace, self.timeout).await [INFO] [stdout] 207 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `retry_core` which comes from the expansion of the macro `retry_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/timestamp.rs:100:11 [INFO] [stdout] | [INFO] [stdout] 100 | while let Some(Ok(resp)) = responses.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/timestamp.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/timestamp.rs:136:39 [INFO] [stdout] | [INFO] [stdout] 136 | let mut pending_requests = if let Poll::Ready(pending_requests) = pending_requests.poll(cx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/timestamp.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 136 ~ let mut pending_requests = match pending_requests.poll(cx) [INFO] [stdout] 137 ~ { Poll::Ready(pending_requests) => { [INFO] [stdout] 138 | pending_requests [INFO] [stdout] 139 ~ } _ => { [INFO] [stdout] 140 | this.self_waker.register(cx.waker()); [INFO] [stdout] 141 | return Poll::Pending; [INFO] [stdout] 142 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/timestamp.rs:194:8 [INFO] [stdout] | [INFO] [stdout] 194 | if let Some(RequestGroup { [INFO] [stdout] | ________^ [INFO] [stdout] 195 | | tso_request, [INFO] [stdout] 196 | | requests, [INFO] [stdout] 197 | | }) = pending_requests.pop_front() [INFO] [stdout] | |__________---------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/timestamp.rs:214:5 [INFO] [stdout] | [INFO] [stdout] 214 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 194 ~ match pending_requests.pop_front() [INFO] [stdout] 195 ~ { Some(RequestGroup { [INFO] [stdout] 196 + tso_request, [INFO] [stdout] 197 + requests, [INFO] [stdout] 198 ~ }) => { [INFO] [stdout] 199 | if tso_request.count != offset { [INFO] [stdout] ... [INFO] [stdout] 213 | } [INFO] [stdout] 214 ~ } _ => { [INFO] [stdout] 215 | return Err(internal_err!("PD gives more TsoResponse than expected")); [INFO] [stdout] 216 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/region_cache.rs:113:16 [INFO] [stdout] | [INFO] [stdout] 113 | if let Some(n) = notified { [INFO] [stdout] | ^^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/region_cache.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 116 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 113 ~ match notified { Some(n) => { [INFO] [stdout] 114 | n.await; [INFO] [stdout] 115 | continue; [INFO] [stdout] 116 ~ } _ => { [INFO] [stdout] 117 | return self.read_through_region_by_id(id).await; [INFO] [stdout] 118 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/store/errors.rs:179:16 [INFO] [stdout] | [INFO] [stdout] 179 | if let Some(e) = t.key_errors() { [INFO] [stdout] | ^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/store/errors.rs:181:13 [INFO] [stdout] | [INFO] [stdout] 181 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 179 ~ match t.key_errors() { Some(e) => { [INFO] [stdout] 180 | return Some(e); [INFO] [stdout] 181 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 32 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/pessimistic.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `tikv_client` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/common/errors.rs [INFO] [stderr] * src/pd/cluster.rs [INFO] [stderr] * src/pd/retry.rs [INFO] [stderr] * src/transaction/requests.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/common/errors.rs:134:6 [INFO] [stderr] | [INFO] [stderr] 134 | ($e:expr_2021) => ({ [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/common/errors.rs:139:15 [INFO] [stderr] | [INFO] [stderr] 139 | ($f:tt, $($arg:expr_2021),+) => ({ [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/pd/cluster.rs:35:6 [INFO] [stderr] | [INFO] [stderr] 35 | ($cluster_id:expr_2021, $type:ty) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/pd/retry.rs:77:35 [INFO] [stderr] | [INFO] [stderr] 77 | ($self: ident, $tag: literal, $call: expr_2021) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/pd/retry.rs:104:53 [INFO] [stderr] | [INFO] [stderr] 104 | ($self: ident, $tag: literal, |$cluster: ident| $call: expr_2021) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/pd/retry.rs:115:53 [INFO] [stderr] | [INFO] [stderr] 115 | ($self: ident, $tag: literal, |$cluster: ident| $call: expr_2021) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] warning: unexpected `cfg` condition value: `protobuf-codec` [INFO] [stderr] --> src/transaction/requests.rs:907:12 [INFO] [stderr] | [INFO] [stderr] 907 | #[cfg_attr(feature = "protobuf-codec", allow(clippy::useless_conversion))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: expected values for `feature` are: `default`, `integration-tests`, and `prometheus` [INFO] [stderr] = help: consider adding `protobuf-codec` as a feature in `Cargo.toml` [INFO] [stderr] = note: see for more information about checking conditional configuration [INFO] [stderr] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/request/shard.rs:288:41 [INFO] [stdout] | [INFO] [stdout] 288 | .map(|_| (0..2).map(|_| rng.gen::()).collect::>()) [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/request/shard.rs:308:41 [INFO] [stdout] | [INFO] [stdout] 308 | .map(|_| (0..3).map(|_| rng.gen::()).collect::>()) [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `protobuf-codec` [INFO] [stdout] --> src/transaction/requests.rs:907:12 [INFO] [stdout] | [INFO] [stdout] 907 | #[cfg_attr(feature = "protobuf-codec", allow(clippy::useless_conversion))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `integration-tests`, and `prometheus` [INFO] [stdout] = help: consider adding `protobuf-codec` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/common/errors.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 134 | ($e:expr) => ({ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 134 | ($e:expr_2021) => ({ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/common/errors.rs:139:20 [INFO] [stdout] | [INFO] [stdout] 139 | ($f:tt, $($arg:expr),+) => ({ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 139 | ($f:tt, $($arg:expr_2021),+) => ({ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/pd/cluster.rs:35:18 [INFO] [stdout] | [INFO] [stdout] 35 | ($cluster_id:expr, $type:ty) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 35 | ($cluster_id:expr_2021, $type:ty) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/pd/retry.rs:77:42 [INFO] [stdout] | [INFO] [stdout] 77 | ($self: ident, $tag: literal, $call: expr) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 77 | ($self: ident, $tag: literal, $call: expr_2021) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/pd/retry.rs:104:60 [INFO] [stdout] | [INFO] [stdout] 104 | ($self: ident, $tag: literal, |$cluster: ident| $call: expr) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 104 | ($self: ident, $tag: literal, |$cluster: ident| $call: expr_2021) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/pd/retry.rs:115:60 [INFO] [stdout] | [INFO] [stdout] 115 | ($self: ident, $tag: literal, |$cluster: ident| $call: expr) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 115 | ($self: ident, $tag: literal, |$cluster: ident| $call: expr_2021) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/request/plan.rs:184:12 [INFO] [stdout] | [INFO] [stdout] 184 | if let Some(e) = resp.key_errors() { [INFO] [stdout] | ^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 185 | Ok(vec![Err(Error::MultipleKeyErrors(e))]) [INFO] [stdout] 186 | } else if let Some(e) = resp.region_error() { [INFO] [stdout] | ---- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/request/plan.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | } else if let Some(e) = resp.region_error() { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/request/plan.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 206 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 184 ~ match resp.key_errors() { Some(e) => { [INFO] [stdout] 185 | Ok(vec![Err(Error::MultipleKeyErrors(e))]) [INFO] [stdout] 186 ~ } _ => { match resp.region_error() { Some(e) => { [INFO] [stdout] 187 | match backoff.next_delay_duration() { [INFO] [stdout] ... [INFO] [stdout] 205 | } [INFO] [stdout] 206 ~ } _ => { [INFO] [stdout] 207 | Ok(vec![Ok(resp)]) [INFO] [stdout] 208 ~ }}}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/request/plan.rs:432:24 [INFO] [stdout] | [INFO] [stdout] 432 | if let Some(e) = resp.key_errors() { [INFO] [stdout] | ^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 433 | return Err(Error::MultipleKeyErrors(e)); [INFO] [stdout] 434 | } else if let Some(e) = resp.region_error() { [INFO] [stdout] | ---- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/request/plan.rs:434:21 [INFO] [stdout] | [INFO] [stdout] 434 | } else if let Some(e) = resp.region_error() { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/request/plan.rs:437:21 [INFO] [stdout] | [INFO] [stdout] 437 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 432 ~ match resp.key_errors() { Some(e) => { [INFO] [stdout] 433 | return Err(Error::MultipleKeyErrors(e)); [INFO] [stdout] 434 ~ } _ => { match resp.region_error() { Some(e) => { [INFO] [stdout] 435 | // Store request should not return region error. [INFO] [stdout] 436 | return Err(Error::RegionError(Box::new(e))); [INFO] [stdout] 437 ~ } _ => { [INFO] [stdout] 438 | return Ok(resp); [INFO] [stdout] 439 ~ }}}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/request/plan.rs:687:16 [INFO] [stdout] | [INFO] [stdout] 687 | if let Some(e) = scan_lock_resp.key_errors() { [INFO] [stdout] | ^^^^^^^^^^^^^^--------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 691 | } else if let Some(e) = scan_lock_resp.region_error() { [INFO] [stdout] | -------------- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/request/plan.rs:691:13 [INFO] [stdout] | [INFO] [stdout] 691 | } else if let Some(e) = scan_lock_resp.region_error() { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/request/plan.rs:695:13 [INFO] [stdout] | [INFO] [stdout] 695 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 687 ~ match scan_lock_resp.key_errors() { Some(e) => { [INFO] [stdout] 688 | info!("CleanupLocks::execute, inner key errors:{:?}", e); [INFO] [stdout] 689 | result.key_error = Some(e); [INFO] [stdout] 690 | return Ok(result); [INFO] [stdout] 691 ~ } _ => { match scan_lock_resp.region_error() { Some(e) => { [INFO] [stdout] 692 | info!("CleanupLocks::execute, inner region error:{}", e.message); [INFO] [stdout] 693 | result.region_error = Some(e); [INFO] [stdout] 694 | return Ok(result); [INFO] [stdout] 695 ~ } _ => {}}}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/request/plan.rs:737:24 [INFO] [stdout] | [INFO] [stdout] 737 | if let Error::RegionError(e) = errors.pop().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/request/plan.rs:739:21 [INFO] [stdout] | [INFO] [stdout] 739 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 737 ~ match errors.pop().unwrap() { Error::RegionError(e) => { [INFO] [stdout] 738 | result.region_error = Some(*e); [INFO] [stdout] 739 ~ } _ => { [INFO] [stdout] 740 | result.key_error = Some(errors); [INFO] [stdout] 741 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/request/plan.rs:788:12 [INFO] [stdout] | [INFO] [stdout] 788 | if let Some(errors) = result.key_errors() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 789 | Err(Error::ExtractedErrors(errors)) [INFO] [stdout] 790 | } else if let Some(errors) = result.region_errors() { [INFO] [stdout] | ------ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/request/plan.rs:790:9 [INFO] [stdout] | [INFO] [stdout] 790 | } else if let Some(errors) = result.region_errors() { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/request/plan.rs:797:9 [INFO] [stdout] | [INFO] [stdout] 797 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 788 ~ match result.key_errors() { Some(errors) => { [INFO] [stdout] 789 | Err(Error::ExtractedErrors(errors)) [INFO] [stdout] 790 ~ } _ => { match result.region_errors() { Some(errors) => { [INFO] [stdout] 791 | Err(Error::ExtractedErrors( [INFO] [stdout] ... [INFO] [stdout] 796 | )) [INFO] [stdout] 797 ~ } _ => { [INFO] [stdout] 798 | Ok(result) [INFO] [stdout] 799 ~ }}}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transaction/requests.rs:994:16 [INFO] [stdout] | [INFO] [stdout] 994 | if let PessimisticLockError { [INFO] [stdout] | ________________^ [INFO] [stdout] 995 | | inner, [INFO] [stdout] 996 | | success_keys, [INFO] [stdout] 997 | | } = result.unwrap_err() [INFO] [stdout] | |_________________------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transaction/requests.rs:1004:13 [INFO] [stdout] | [INFO] [stdout] 1004 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 994 ~ match result.unwrap_err() [INFO] [stdout] 995 ~ { PessimisticLockError { [INFO] [stdout] 996 + inner, [INFO] [stdout] 997 + success_keys, [INFO] [stdout] 998 ~ } => { [INFO] [stdout] 999 | assert!(matches!(*inner, ResolveLockError(_))); [INFO] [stdout] ... [INFO] [stdout] 1003 | ); [INFO] [stdout] 1004 ~ } _ => { [INFO] [stdout] 1005 | panic!(); [INFO] [stdout] 1006 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transaction/transaction.rs:872:12 [INFO] [stdout] | [INFO] [stdout] 872 | if let Err(err) = pairs { [INFO] [stdout] | ^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transaction/transaction.rs:885:9 [INFO] [stdout] | [INFO] [stdout] 885 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 872 ~ match pairs { Err(err) => { [INFO] [stdout] 873 | match err { [INFO] [stdout] ... [INFO] [stdout] 884 | } [INFO] [stdout] 885 ~ } _ => { [INFO] [stdout] 886 | // primary key will be set here if needed [INFO] [stdout] ... [INFO] [stdout] 895 | pairs [INFO] [stdout] 896 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transaction/transaction.rs:1001:16 [INFO] [stdout] | [INFO] [stdout] 1001 | if let Err(err) = heartbeat_task.await { [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transaction/transaction.rs:1003:13 [INFO] [stdout] | [INFO] [stdout] 1003 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1001 ~ match heartbeat_task.await { Err(err) => { [INFO] [stdout] 1002 | log::error!("Error: While sending heartbeat. {}", err); [INFO] [stdout] 1003 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/transaction/transaction.rs:1307:16 [INFO] [stdout] | [INFO] [stdout] 1307 | if let Err(e) = res { [INFO] [stdout] | ^^^^^^^^^^^^^--- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/transaction/transaction.rs:1309:13 [INFO] [stdout] | [INFO] [stdout] 1309 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1307 ~ match res { Err(e) => { [INFO] [stdout] 1308 | log::warn!("Failed to commit secondary keys: {}", e); [INFO] [stdout] 1309 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/client.rs:96:20 [INFO] [stdout] | [INFO] [stdout] 96 | if let Some(key) = keys.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/client.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 96 ~ match keys.next() { Some(key) => { [INFO] [stdout] 97 | let region = this.region_for_key(key.as_ref()).await?; [INFO] [stdout] ... [INFO] [stdout] 105 | Ok(Some((keys, (region, grouped)))) [INFO] [stdout] 106 ~ } _ => { [INFO] [stdout] 107 | Ok(None) [INFO] [stdout] 108 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/client.rs:99:27 [INFO] [stdout] | [INFO] [stdout] 99 | while let Some(key) = keys.peek() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/client.rs:104:21 [INFO] [stdout] | [INFO] [stdout] 104 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/cluster.rs:324:20 [INFO] [stdout] | [INFO] [stdout] 324 | if let Ok((client, keyspace_client, members)) = [INFO] [stdout] | ____________________^ [INFO] [stdout] 325 | | self.try_connect(ep.as_str(), cluster_id, timeout).await [INFO] [stdout] | |_____________________-------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/cluster.rs:328:17 [INFO] [stdout] | [INFO] [stdout] 328 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 324 ~ match self.try_connect(ep.as_str(), cluster_id, timeout).await [INFO] [stdout] 325 ~ { Ok((client, keyspace_client, members)) => { [INFO] [stdout] 326 | return Ok((client, keyspace_client, members)); [INFO] [stdout] 327 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/cluster.rs:350:12 [INFO] [stdout] | [INFO] [stdout] 350 | if let Some(err) = &response.header().error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^--------^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/cluster.rs:352:9 [INFO] [stdout] | [INFO] [stdout] 352 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 350 ~ match &response.header().error { Some(err) => { [INFO] [stdout] 351 | Err(internal_err!(err.message)) [INFO] [stdout] 352 ~ } _ => { [INFO] [stdout] 353 | Ok(response) [INFO] [stdout] 354 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await { [INFO] [stdout] | ^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 149 | / retry_mut!(self, "get_region", |cluster| { [INFO] [stdout] 150 | | let key = key.clone(); [INFO] [stdout] 151 | | async { [INFO] [stdout] 152 | | cluster [INFO] [stdout] ... | [INFO] [stdout] 158 | | } [INFO] [stdout] 159 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | } [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 149 | / retry_mut!(self, "get_region", |cluster| { [INFO] [stdout] 150 | | let key = key.clone(); [INFO] [stdout] 151 | | async { [INFO] [stdout] 152 | | cluster [INFO] [stdout] ... | [INFO] [stdout] 158 | | } [INFO] [stdout] 159 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `retry_core` which comes from the expansion of the macro `retry_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await { [INFO] [stdout] | ^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 163 | / retry_mut!(self, "get_region_by_id", |cluster| async { [INFO] [stdout] 164 | | cluster [INFO] [stdout] 165 | | .get_region_by_id(region_id, self.timeout) [INFO] [stdout] 166 | | .await [INFO] [stdout] ... | [INFO] [stdout] 169 | | }) [INFO] [stdout] 170 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | } [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 163 | / retry_mut!(self, "get_region_by_id", |cluster| async { [INFO] [stdout] 164 | | cluster [INFO] [stdout] 165 | | .get_region_by_id(region_id, self.timeout) [INFO] [stdout] 166 | | .await [INFO] [stdout] ... | [INFO] [stdout] 169 | | }) [INFO] [stdout] 170 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `retry_core` which comes from the expansion of the macro `retry_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await { [INFO] [stdout] | ^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 174 | / retry_mut!(self, "get_store", |cluster| async { [INFO] [stdout] 175 | | cluster [INFO] [stdout] 176 | | .get_store(id, self.timeout) [INFO] [stdout] 177 | | .await [INFO] [stdout] 178 | | .map(|resp| resp.store.unwrap()) [INFO] [stdout] 179 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | } [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 174 | / retry_mut!(self, "get_store", |cluster| async { [INFO] [stdout] 175 | | cluster [INFO] [stdout] 176 | | .get_store(id, self.timeout) [INFO] [stdout] 177 | | .await [INFO] [stdout] 178 | | .map(|resp| resp.store.unwrap()) [INFO] [stdout] 179 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `retry_core` which comes from the expansion of the macro `retry_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await { [INFO] [stdout] | ^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 183 | / retry_mut!(self, "get_all_stores", |cluster| async { [INFO] [stdout] 184 | | cluster [INFO] [stdout] 185 | | .get_all_stores(self.timeout) [INFO] [stdout] 186 | | .await [INFO] [stdout] 187 | | .map(|resp| resp.stores.into_iter().map(Into::into).collect()) [INFO] [stdout] 188 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | } [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 183 | / retry_mut!(self, "get_all_stores", |cluster| async { [INFO] [stdout] 184 | | cluster [INFO] [stdout] 185 | | .get_all_stores(self.timeout) [INFO] [stdout] 186 | | .await [INFO] [stdout] 187 | | .map(|resp| resp.stores.into_iter().map(Into::into).collect()) [INFO] [stdout] 188 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `retry_core` which comes from the expansion of the macro `retry_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await { [INFO] [stdout] | ^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 192 | retry!(self, "get_timestamp", |cluster| cluster.get_timestamp()) [INFO] [stdout] | ---------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | } [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 192 | retry!(self, "get_timestamp", |cluster| cluster.get_timestamp()) [INFO] [stdout] | ---------------------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `retry_core` which comes from the expansion of the macro `retry` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await { [INFO] [stdout] | ^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 196 | / retry_mut!(self, "update_gc_safepoint", |cluster| async { [INFO] [stdout] 197 | | cluster [INFO] [stdout] 198 | | .update_safepoint(safepoint, self.timeout) [INFO] [stdout] 199 | | .await [INFO] [stdout] 200 | | .map(|resp| resp.new_safe_point == safepoint) [INFO] [stdout] 201 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | } [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 196 | / retry_mut!(self, "update_gc_safepoint", |cluster| async { [INFO] [stdout] 197 | | cluster [INFO] [stdout] 198 | | .update_safepoint(safepoint, self.timeout) [INFO] [stdout] 199 | | .await [INFO] [stdout] 200 | | .map(|resp| resp.new_safe_point == safepoint) [INFO] [stdout] 201 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `retry_core` which comes from the expansion of the macro `retry_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await { [INFO] [stdout] | ^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 205 | / retry_mut!(self, "load_keyspace", |cluster| async { [INFO] [stdout] 206 | | cluster.load_keyspace(keyspace, self.timeout).await [INFO] [stdout] 207 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | } [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 205 | / retry_mut!(self, "load_keyspace", |cluster| async { [INFO] [stdout] 206 | | cluster.load_keyspace(keyspace, self.timeout).await [INFO] [stdout] 207 | | }) [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `retry_core` which comes from the expansion of the macro `retry_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await { [INFO] [stdout] | ^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 285 | retry_mut!(client, "test", |_c| ready(Err(internal_err!("whoops")))) [INFO] [stdout] | -------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | } [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 285 | retry_mut!(client, "test", |_c| ready(Err(internal_err!("whoops")))) [INFO] [stdout] | -------------------------------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `retry_core` which comes from the expansion of the macro `retry_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await { [INFO] [stdout] | ^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 289 | retry!(client, "test", |_c| ready(Ok::<_, Error>(()))) [INFO] [stdout] | ------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | } [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 289 | retry!(client, "test", |_c| ready(Ok::<_, Error>(()))) [INFO] [stdout] | ------------------------------------------------------ in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `retry_core` which comes from the expansion of the macro `retry` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await { [INFO] [stdout] | ^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 338 | / retry_mut!(client, "test", |c| { [INFO] [stdout] 339 | | c.fetch_add(1, std::sync::atomic::Ordering::SeqCst); [INFO] [stdout] 340 | | [INFO] [stdout] 341 | | let max_retries = max_retries.fetch_sub(1, Ordering::SeqCst) - 1; [INFO] [stdout] ... | [INFO] [stdout] 346 | | } [INFO] [stdout] 347 | | }) [INFO] [stdout] | |______________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | } [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 338 | / retry_mut!(client, "test", |c| { [INFO] [stdout] 339 | | c.fetch_add(1, std::sync::atomic::Ordering::SeqCst); [INFO] [stdout] 340 | | [INFO] [stdout] 341 | | let max_retries = max_retries.fetch_sub(1, Ordering::SeqCst) - 1; [INFO] [stdout] ... | [INFO] [stdout] 346 | | } [INFO] [stdout] 347 | | }) [INFO] [stdout] | |______________- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `retry_core` which comes from the expansion of the macro `retry_mut` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:89:19 [INFO] [stdout] | [INFO] [stdout] 89 | while let Err(e) = $self.reconnect(RECONNECT_INTERVAL_SEC).await { [INFO] [stdout] | ^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 354 | / retry!(client, "test", |c| { [INFO] [stdout] 355 | | c.fetch_add(1, std::sync::atomic::Ordering::SeqCst); [INFO] [stdout] 356 | | [INFO] [stdout] 357 | | let max_retries = max_retries.fetch_sub(1, Ordering::SeqCst) - 1; [INFO] [stdout] ... | [INFO] [stdout] 362 | | } [INFO] [stdout] 363 | | }) [INFO] [stdout] | |______________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/retry.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | } [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 354 | / retry!(client, "test", |c| { [INFO] [stdout] 355 | | c.fetch_add(1, std::sync::atomic::Ordering::SeqCst); [INFO] [stdout] 356 | | [INFO] [stdout] 357 | | let max_retries = max_retries.fetch_sub(1, Ordering::SeqCst) - 1; [INFO] [stdout] ... | [INFO] [stdout] 362 | | } [INFO] [stdout] 363 | | }) [INFO] [stdout] | |______________- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `retry_core` which comes from the expansion of the macro `retry` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/timestamp.rs:100:11 [INFO] [stdout] | [INFO] [stdout] 100 | while let Some(Ok(resp)) = responses.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/timestamp.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/timestamp.rs:136:39 [INFO] [stdout] | [INFO] [stdout] 136 | let mut pending_requests = if let Poll::Ready(pending_requests) = pending_requests.poll(cx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/timestamp.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 136 ~ let mut pending_requests = match pending_requests.poll(cx) [INFO] [stdout] 137 ~ { Poll::Ready(pending_requests) => { [INFO] [stdout] 138 | pending_requests [INFO] [stdout] 139 ~ } _ => { [INFO] [stdout] 140 | this.self_waker.register(cx.waker()); [INFO] [stdout] 141 | return Poll::Pending; [INFO] [stdout] 142 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/pd/timestamp.rs:194:8 [INFO] [stdout] | [INFO] [stdout] 194 | if let Some(RequestGroup { [INFO] [stdout] | ________^ [INFO] [stdout] 195 | | tso_request, [INFO] [stdout] 196 | | requests, [INFO] [stdout] 197 | | }) = pending_requests.pop_front() [INFO] [stdout] | |__________---------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/pd/timestamp.rs:214:5 [INFO] [stdout] | [INFO] [stdout] 214 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 194 ~ match pending_requests.pop_front() [INFO] [stdout] 195 ~ { Some(RequestGroup { [INFO] [stdout] 196 + tso_request, [INFO] [stdout] 197 + requests, [INFO] [stdout] 198 ~ }) => { [INFO] [stdout] 199 | if tso_request.count != offset { [INFO] [stdout] ... [INFO] [stdout] 213 | } [INFO] [stdout] 214 ~ } _ => { [INFO] [stdout] 215 | return Err(internal_err!("PD gives more TsoResponse than expected")); [INFO] [stdout] 216 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/region_cache.rs:113:16 [INFO] [stdout] | [INFO] [stdout] 113 | if let Some(n) = notified { [INFO] [stdout] | ^^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/region_cache.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 116 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 113 ~ match notified { Some(n) => { [INFO] [stdout] 114 | n.await; [INFO] [stdout] 115 | continue; [INFO] [stdout] 116 ~ } _ => { [INFO] [stdout] 117 | return self.read_through_region_by_id(id).await; [INFO] [stdout] 118 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/store/errors.rs:179:16 [INFO] [stdout] | [INFO] [stdout] 179 | if let Some(e) = t.key_errors() { [INFO] [stdout] | ^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/store/errors.rs:181:13 [INFO] [stdout] | [INFO] [stdout] 181 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 179 ~ match t.key_errors() { Some(e) => { [INFO] [stdout] 180 | return Some(e); [INFO] [stdout] 181 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 38 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/failpoint_tests.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/transaction.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/raw.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/integration_tests.rs from 2021 edition to 2024 [INFO] [stderr] Fixed tests/integration_tests.rs (3 fixes) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 58s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking surrealdb-tikv-client v0.3.0-surreal.1 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/request/shard.rs:288:41 [INFO] [stdout] | [INFO] [stdout] 288 | .map(|_| (0..2).map(|_| rng.gen::()).collect::>()) [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 288 | .map(|_| (0..2).map(|_| rng.r#gen::()).collect::>()) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/request/shard.rs:288:41 [INFO] [stdout] | [INFO] [stdout] 288 | .map(|_| (0..2).map(|_| rng.gen::()).collect::>()) [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 288 | .map(|_| (0..2).map(|_| rng.r#gen::()).collect::>()) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/request/shard.rs:308:41 [INFO] [stdout] | [INFO] [stdout] 308 | .map(|_| (0..3).map(|_| rng.gen::()).collect::>()) [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 308 | .map(|_| (0..3).map(|_| rng.r#gen::()).collect::>()) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/request/shard.rs:308:41 [INFO] [stdout] | [INFO] [stdout] 308 | .map(|_| (0..3).map(|_| rng.gen::()).collect::>()) [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 308 | .map(|_| (0..3).map(|_| rng.r#gen::()).collect::>()) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `protobuf-codec` [INFO] [stdout] --> src/transaction/requests.rs:907:12 [INFO] [stdout] | [INFO] [stdout] 907 | #[cfg_attr(feature = "protobuf-codec", allow(clippy::useless_conversion))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `integration-tests`, and `prometheus` [INFO] [stdout] = help: consider adding `protobuf-codec` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0499]: cannot borrow `buffer` as mutable more than once at a time [INFO] [stdout] --> src/transaction/buffer.rs:496:27 [INFO] [stdout] | [INFO] [stdout] 492 | buffer.batch_get_or_else(vec![k1.clone(), k2.clone()].into_iter(), move |_| { [INFO] [stdout] | ------ first mutable borrow occurs here [INFO] [stdout] ... [INFO] [stdout] 496 | let r2 = block_on(buffer.get_or_else(k2.clone(), move |_| ready(Err(internal_err!(""))))); [INFO] [stdout] | ^^^^^^ second mutable borrow occurs here [INFO] [stdout] ... [INFO] [stdout] 503 | r1.unwrap().collect::>(), [INFO] [stdout] | -- first borrow later used here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0499]: cannot borrow `buffer` as mutable more than once at a time [INFO] [stdout] --> src/transaction/buffer.rs:498:13 [INFO] [stdout] | [INFO] [stdout] 492 | buffer.batch_get_or_else(vec![k1.clone(), k2.clone()].into_iter(), move |_| { [INFO] [stdout] | ------ first mutable borrow occurs here [INFO] [stdout] ... [INFO] [stdout] 498 | buffer.batch_get_or_else(vec![k1.clone(), k2.clone()].into_iter(), move |_| { [INFO] [stdout] | ^^^^^^ second mutable borrow occurs here [INFO] [stdout] ... [INFO] [stdout] 503 | r1.unwrap().collect::>(), [INFO] [stdout] | -- first borrow later used here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0499`. [INFO] [stdout] [INFO] [stderr] error: could not compile `surrealdb-tikv-client` (lib test) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `surrealdb-tikv-client` (lib) due to 3 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "c45faaf5ba01a4127eaba8df997523da3595547701b2accf4d006466cd78e8af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c45faaf5ba01a4127eaba8df997523da3595547701b2accf4d006466cd78e8af", kill_on_drop: false }` [INFO] [stdout] c45faaf5ba01a4127eaba8df997523da3595547701b2accf4d006466cd78e8af