[INFO] fetching crate static-keys 0.5.0... [INFO] checking static-keys-0.5.0 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate static-keys 0.5.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate static-keys 0.5.0 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-0-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate static-keys 0.5.0 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate static-keys 0.5.0 [INFO] tweaked toml for crates.io crate static-keys 0.5.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate static-keys 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bf4aef999909104bf3cdedce1ad329107fca3e3577bb1f4e774731fe007bcfb1 [INFO] running `Command { std: "docker" "start" "-a" "bf4aef999909104bf3cdedce1ad329107fca3e3577bb1f4e774731fe007bcfb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bf4aef999909104bf3cdedce1ad329107fca3e3577bb1f4e774731fe007bcfb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf4aef999909104bf3cdedce1ad329107fca3e3577bb1f4e774731fe007bcfb1", kill_on_drop: false }` [INFO] [stdout] bf4aef999909104bf3cdedce1ad329107fca3e3577bb1f4e774731fe007bcfb1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 344dc2265f3933a376a4e8e0880ddb4855602398e5e203bd1cadd628bec38e7a [INFO] running `Command { std: "docker" "start" "-a" "344dc2265f3933a376a4e8e0880ddb4855602398e5e203bd1cadd628bec38e7a", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking winnow v0.6.15 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Compiling trybuild v1.0.97 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking clear-cache v0.1.0 [INFO] [stderr] Checking static-keys v0.5.0 (/tmp/fixit) [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `static_keys` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/lib.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/lib.rs:411:17 [INFO] [stderr] | [INFO] [stderr] 411 | ($key:path, $branch:expr_2021) => {'my_label: { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/lib.rs:442:17 [INFO] [stderr] | [INFO] [stderr] 442 | ($key:path, $branch:expr_2021) => {'my_label: { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] warning: the feature `asm_const` has been stable since 1.82.0 and no longer requires an attribute to enable [INFO] [stderr] --> src/lib.rs:4:12 [INFO] [stderr] | [INFO] [stderr] 4 | #![feature(asm_const)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(stable_features)]` on by default [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/os/linux.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 | extern "Rust" { [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | _help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | | [INFO] [stdout] 19 | | /// Address of this static is the start address of __static_keys section [INFO] [stdout] 20 | | #[link_name = "__start___static_keys"] [INFO] [stdout] 21 | | pub static mut JUMP_ENTRY_START: JumpEntry; [INFO] [stdout] ... | [INFO] [stdout] 24 | | pub static mut JUMP_ENTRY_STOP: JumpEntry; [INFO] [stdout] 25 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] = note: `--force-warn missing-unsafe-on-extern` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/lib.rs:411:25 [INFO] [stdout] | [INFO] [stdout] 411 | ($key:path, $branch:expr) => {'my_label: { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 411 | ($key:path, $branch:expr_2021) => {'my_label: { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/lib.rs:442:25 [INFO] [stdout] | [INFO] [stdout] 442 | ($key:path, $branch:expr) => {'my_label: { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 442 | ($key:path, $branch:expr_2021) => {'my_label: { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `asm_const` has been stable since 1.82.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | #![feature(asm_const)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `static_key_update` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | static_key_update(self, true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/lib.rs:173:5 [INFO] [stdout] | [INFO] [stdout] 173 | pub unsafe fn enable(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `--force-warn unsafe-op-in-unsafe-fn` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `static_key_update` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | static_key_update(self, false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/lib.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 185 | pub unsafe fn disable(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:366:27 [INFO] [stdout] | [INFO] [stdout] 366 | let jump_entry = &*jump_entry_addr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/lib.rs:348:1 [INFO] [stdout] | [INFO] [stdout] 348 | / unsafe fn static_key_update( [INFO] [stdout] 349 | | key: &mut GenericStaticKey, [INFO] [stdout] 350 | | enabled: bool, [INFO] [stdout] 351 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `jump_entry_update` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:372:9 [INFO] [stdout] | [INFO] [stdout] 372 | jump_entry_update::(jump_entry, enabled); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::const_ptr::::add` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:374:27 [INFO] [stdout] | [INFO] [stdout] 374 | jump_entry_addr = jump_entry_addr.add(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `code_manipulate::CodeManipulator::write_code` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:403:5 [INFO] [stdout] | [INFO] [stdout] 403 | M::write_code(jump_entry.code_addr() as *mut _, &code_bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/lib.rs:395:1 [INFO] [stdout] | [INFO] [stdout] 395 | unsafe fn jump_entry_update(jump_entry: &JumpEntry, enabled: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Checking toml_edit v0.22.16 [INFO] [stderr] Checking toml v0.8.15 [INFO] [stderr] Migrating tests/ui_test.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/basic.rs from 2021 edition to 2024 [INFO] [stdout] warning: the feature `asm_const` has been stable since 1.82.0 and no longer requires an attribute to enable [INFO] [stdout] --> tests/basic.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | #![feature(asm_const)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/usage.rs from 2021 edition to 2024 [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `asm_const` has been stable since 1.82.0 and no longer requires an attribute to enable [INFO] [stdout] --> examples/usage.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(asm_const)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `static_keys` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/lib.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/lib.rs:411:17 [INFO] [stderr] | [INFO] [stderr] 411 | ($key:path, $branch:expr_2021) => {'my_label: { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/lib.rs:442:17 [INFO] [stderr] | [INFO] [stderr] 442 | ($key:path, $branch:expr_2021) => {'my_label: { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] warning: the feature `asm_const` has been stable since 1.82.0 and no longer requires an attribute to enable [INFO] [stderr] --> src/lib.rs:4:12 [INFO] [stderr] | [INFO] [stderr] 4 | #![feature(asm_const)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(stable_features)]` on by default [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/os/linux.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 | extern "Rust" { [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | _help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | | [INFO] [stdout] 19 | | /// Address of this static is the start address of __static_keys section [INFO] [stdout] 20 | | #[link_name = "__start___static_keys"] [INFO] [stdout] 21 | | pub static mut JUMP_ENTRY_START: JumpEntry; [INFO] [stdout] ... | [INFO] [stdout] 24 | | pub static mut JUMP_ENTRY_STOP: JumpEntry; [INFO] [stdout] 25 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] = note: `--force-warn missing-unsafe-on-extern` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/lib.rs:411:25 [INFO] [stdout] | [INFO] [stdout] 411 | ($key:path, $branch:expr) => {'my_label: { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 411 | ($key:path, $branch:expr_2021) => {'my_label: { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/lib.rs:442:25 [INFO] [stdout] | [INFO] [stdout] 442 | ($key:path, $branch:expr) => {'my_label: { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 442 | ($key:path, $branch:expr_2021) => {'my_label: { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `asm_const` has been stable since 1.82.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | #![feature(asm_const)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `static_key_update` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | static_key_update(self, true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/lib.rs:173:5 [INFO] [stdout] | [INFO] [stdout] 173 | pub unsafe fn enable(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `--force-warn unsafe-op-in-unsafe-fn` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `static_key_update` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | static_key_update(self, false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/lib.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 185 | pub unsafe fn disable(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:366:27 [INFO] [stdout] | [INFO] [stdout] 366 | let jump_entry = &*jump_entry_addr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/lib.rs:348:1 [INFO] [stdout] | [INFO] [stdout] 348 | / unsafe fn static_key_update( [INFO] [stdout] 349 | | key: &mut GenericStaticKey, [INFO] [stdout] 350 | | enabled: bool, [INFO] [stdout] 351 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `jump_entry_update` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:372:9 [INFO] [stdout] | [INFO] [stdout] 372 | jump_entry_update::(jump_entry, enabled); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::const_ptr::::add` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:374:27 [INFO] [stdout] | [INFO] [stdout] 374 | jump_entry_addr = jump_entry_addr.add(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `code_manipulate::CodeManipulator::write_code` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:403:5 [INFO] [stdout] | [INFO] [stdout] 403 | M::write_code(jump_entry.code_addr() as *mut _, &code_bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/lib.rs:395:1 [INFO] [stdout] | [INFO] [stdout] 395 | unsafe fn jump_entry_update(jump_entry: &JumpEntry, enabled: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.59s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking static-keys v0.5.0 (/tmp/fixit) [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/os/linux.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 | / extern "Rust" { [INFO] [stdout] 19 | | /// Address of this static is the start address of __static_keys section [INFO] [stdout] 20 | | #[link_name = "__start___static_keys"] [INFO] [stdout] 21 | | pub static mut JUMP_ENTRY_START: JumpEntry; [INFO] [stdout] ... | [INFO] [stdout] 24 | | pub static mut JUMP_ENTRY_STOP: JumpEntry; [INFO] [stdout] 25 | | } [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/os/linux.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 | / extern "Rust" { [INFO] [stdout] 19 | | /// Address of this static is the start address of __static_keys section [INFO] [stdout] 20 | | #[link_name = "__start___static_keys"] [INFO] [stdout] 21 | | pub static mut JUMP_ENTRY_START: JumpEntry; [INFO] [stdout] ... | [INFO] [stdout] 24 | | pub static mut JUMP_ENTRY_STOP: JumpEntry; [INFO] [stdout] 25 | | } [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `asm_const` has been stable since 1.82.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | #![feature(asm_const)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `asm_const` has been stable since 1.82.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | #![feature(asm_const)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `static_key_update` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | static_key_update(self, true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/lib.rs:173:5 [INFO] [stdout] | [INFO] [stdout] 173 | pub unsafe fn enable(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(unsafe_op_in_unsafe_fn)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `static_key_update` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | static_key_update(self, false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/lib.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 185 | pub unsafe fn disable(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `static_key_update` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | static_key_update(self, true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/lib.rs:173:5 [INFO] [stdout] | [INFO] [stdout] 173 | pub unsafe fn enable(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(unsafe_op_in_unsafe_fn)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `static_key_update` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | static_key_update(self, false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/lib.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 185 | pub unsafe fn disable(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:366:27 [INFO] [stdout] | [INFO] [stdout] 366 | let jump_entry = &*jump_entry_addr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/lib.rs:348:1 [INFO] [stdout] | [INFO] [stdout] 348 | / unsafe fn static_key_update( [INFO] [stdout] 349 | | key: &mut GenericStaticKey, [INFO] [stdout] 350 | | enabled: bool, [INFO] [stdout] 351 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `jump_entry_update` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:372:9 [INFO] [stdout] | [INFO] [stdout] 372 | jump_entry_update::(jump_entry, enabled); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: dereference of raw pointer is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:366:27 [INFO] [stdout] | [INFO] [stdout] 366 | let jump_entry = &*jump_entry_addr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ dereference of raw pointer [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: raw pointers may be null, dangling or unaligned; they can violate aliasing rules and cause data races: all of these are undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/lib.rs:348:1 [INFO] [stdout] | [INFO] [stdout] 348 | / unsafe fn static_key_update( [INFO] [stdout] 349 | | key: &mut GenericStaticKey, [INFO] [stdout] 350 | | enabled: bool, [INFO] [stdout] 351 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `jump_entry_update` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:372:9 [INFO] [stdout] | [INFO] [stdout] 372 | jump_entry_update::(jump_entry, enabled); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::const_ptr::::add` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:374:27 [INFO] [stdout] | [INFO] [stdout] 374 | jump_entry_addr = jump_entry_addr.add(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `code_manipulate::CodeManipulator::write_code` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:403:5 [INFO] [stdout] | [INFO] [stdout] 403 | M::write_code(jump_entry.code_addr() as *mut _, &code_bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/lib.rs:395:1 [INFO] [stdout] | [INFO] [stdout] 395 | unsafe fn jump_entry_update(jump_entry: &JumpEntry, enabled: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `core::ptr::const_ptr::::add` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:374:27 [INFO] [stdout] | [INFO] [stdout] 374 | jump_entry_addr = jump_entry_addr.add(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `code_manipulate::CodeManipulator::write_code` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:403:5 [INFO] [stdout] | [INFO] [stdout] 403 | M::write_code(jump_entry.code_addr() as *mut _, &code_bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> src/lib.rs:395:1 [INFO] [stdout] | [INFO] [stdout] 395 | unsafe fn jump_entry_update(jump_entry: &JumpEntry, enabled: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `static-keys` (lib) due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `static-keys` (lib test) due to 2 previous errors; 7 warnings emitted [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "344dc2265f3933a376a4e8e0880ddb4855602398e5e203bd1cadd628bec38e7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "344dc2265f3933a376a4e8e0880ddb4855602398e5e203bd1cadd628bec38e7a", kill_on_drop: false }` [INFO] [stdout] 344dc2265f3933a376a4e8e0880ddb4855602398e5e203bd1cadd628bec38e7a