[INFO] fetching crate srt-tokio 0.4.4... [INFO] checking srt-tokio-0.4.4 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate srt-tokio 0.4.4 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate srt-tokio 0.4.4 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate srt-tokio 0.4.4 [INFO] finished tweaking crates.io crate srt-tokio 0.4.4 [INFO] tweaked toml for crates.io crate srt-tokio 0.4.4 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate srt-tokio 0.4.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f301bc671969be57734010eff0d624bfc941e6f513425c965f52e9b624aab725 [INFO] running `Command { std: "docker" "start" "-a" "f301bc671969be57734010eff0d624bfc941e6f513425c965f52e9b624aab725", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f301bc671969be57734010eff0d624bfc941e6f513425c965f52e9b624aab725", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f301bc671969be57734010eff0d624bfc941e6f513425c965f52e9b624aab725", kill_on_drop: false }` [INFO] [stdout] f301bc671969be57734010eff0d624bfc941e6f513425c965f52e9b624aab725 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aa15c7999ff884292475459eddfc5769b4e2540a0034c30cac77fc2fdd25e195 [INFO] running `Command { std: "docker" "start" "-a" "aa15c7999ff884292475459eddfc5769b4e2540a0034c30cac77fc2fdd25e195", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Fixed Cargo.toml (1 fix) [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling syn v2.0.50 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking indexmap v2.2.3 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking streaming-stats v0.2.3 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking sha-1 v0.10.1 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking take-until v0.2.0 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Compiling anyhow v1.0.80 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking keyed_priority_queue v0.4.2 [INFO] [stderr] Checking arraydeque v0.5.1 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking libloading v0.8.1 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking srt-protocol v0.4.4 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking srt-tokio v0.4.4 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `srt_tokio` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/listener/mod.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: ambiguous `+` in a type [INFO] [stderr] --> src/listener/mod.rs:91:40 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn incoming(&mut self) -> &mut impl Stream + use<> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: try adding parentheses [INFO] [stderr] | [INFO] [stderr] 91 | pub fn incoming(&mut self) -> &mut (impl Stream + use<>) { [INFO] [stderr] | + + [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `impl futures::Stream + Clone` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/listener/mod.rs:80:43 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn statistics(&mut self) -> &mut (impl Stream + Clone) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/listener/mod.rs:80:23 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn statistics(&mut self) -> &mut (impl Stream + Clone) { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 80 | pub fn statistics(&mut self) -> &mut (impl Stream + Clone + use<>) { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Stream` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/listener/mod.rs:91:40 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn incoming(&mut self) -> &mut impl Stream { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/listener/mod.rs:91:21 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn incoming(&mut self) -> &mut impl Stream { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 91 | pub fn incoming(&mut self) -> &mut impl Stream + use<> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/listener/state.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 133 | if let Some(packet) = packet { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/listener/state.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 133 ~ match packet { Some(packet) => { [INFO] [stdout] 134 | self.socket.send(packet).await.ok().ok_or(()) [INFO] [stdout] 135 ~ } _ => { [INFO] [stdout] 136 | Ok(0) [INFO] [stdout] 137 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/listener/mod.rs:315:19 [INFO] [stdout] | [INFO] [stdout] 315 | while let Some(request) = incoming.incoming().next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/listener/mod.rs:346:13 [INFO] [stdout] | [INFO] [stdout] 346 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/listener/mod.rs:365:19 [INFO] [stdout] | [INFO] [stdout] 365 | while let Some((_instant, _bytes)) = srt_socket.try_next().await? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/listener/mod.rs:370:13 [INFO] [stdout] | [INFO] [stdout] 370 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Stream + Unpin` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/socket/mod.rs:107:27 [INFO] [stdout] | [INFO] [stdout] 107 | Pin<&mut Peekable + Unpin>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/socket/mod.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | &mut self, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 107 | Pin<&mut Peekable + Unpin + use<>>>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Sink<(std::time::Instant, bytes::Bytes), Error = impl std::fmt::Debug> + Unpin` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/socket/mod.rs:108:19 [INFO] [stdout] | [INFO] [stdout] 108 | Pin<&mut (impl Sink<(Instant, Bytes), Error = impl Debug> + Unpin)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/socket/mod.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | &mut self, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 108 | Pin<&mut (impl Sink<(Instant, Bytes), Error = impl Debug> + Unpin + use<>)>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl std::fmt::Debug` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/socket/mod.rs:108:55 [INFO] [stdout] | [INFO] [stdout] 108 | Pin<&mut (impl Sink<(Instant, Bytes), Error = impl Debug> + Unpin)>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/socket/mod.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | &mut self, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 108 | Pin<&mut (impl Sink<(Instant, Bytes), Error = impl Debug + use<>> + Unpin)>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Stream + Clone` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/socket/mod.rs:122:43 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn statistics(&mut self) -> &mut (impl Stream + Clone) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/socket/mod.rs:122:23 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn statistics(&mut self) -> &mut (impl Stream + Clone) { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 122 | pub fn statistics(&mut self) -> &mut (impl Stream + Clone + use<>) { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/socket/listen.rs:39:20 [INFO] [stdout] | [INFO] [stdout] 39 | if let Some(packet) = packet { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/socket/listen.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 39 ~ match packet { Some(packet) => { [INFO] [stdout] 40 | let _ = socket.send(packet).await?; [INFO] [stdout] 41 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:47:19 [INFO] [stdout] | [INFO] [stdout] 47 | while let Some(packet) = connection.next_packet(Instant::now()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:48:20 [INFO] [stdout] | [INFO] [stdout] 48 | if let Err(e) = socket.send(packet).await { [INFO] [stdout] | ^^^^^^^^^^^^^------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 48 ~ match socket.send(packet).await { Err(e) => { [INFO] [stdout] 49 | error!("Error while sending packet: {:?}", e); // TODO: real error handling [INFO] [stdout] 50 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:53:19 [INFO] [stdout] | [INFO] [stdout] 53 | while let Some(data) = connection.next_data(Instant::now()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:57:20 [INFO] [stdout] | [INFO] [stdout] 57 | if let Err(e) = output_data.send(data).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:59:17 [INFO] [stdout] | [INFO] [stdout] 59 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 57 ~ match output_data.send(data).await { Err(e) => { [INFO] [stdout] 58 | error!("Error while releasing packet {:?}", e); [INFO] [stdout] 59 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 91 | if let Err(e) = output_data.close().await { [INFO] [stdout] | ^^^^^^^^^^^^^-----------^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 91 ~ match output_data.close().await { Err(e) => { [INFO] [stdout] 92 | error!("Error while closing data output stream {:?}", e); [INFO] [stdout] 93 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:109:28 [INFO] [stdout] | [INFO] [stdout] 109 | if let Err(e) = output_data.send(data).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:111:25 [INFO] [stdout] | [INFO] [stdout] 111 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 109 ~ match output_data.send(data).await { Err(e) => { [INFO] [stdout] 110 | error!("Error while releasing data {:?}", e); [INFO] [stdout] 111 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 138 | if let Err(e) = output_data.close().await { [INFO] [stdout] | ^^^^^^^^^^^^^-----------^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 138 ~ match output_data.close().await { Err(e) => { [INFO] [stdout] 139 | error!("Error while closing data output stream {:?}", e); [INFO] [stdout] 140 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Stream + Clone` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/listener/mod.rs:80:43 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn statistics(&mut self) -> &mut (impl Stream + Clone) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/listener/mod.rs:80:23 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn statistics(&mut self) -> &mut (impl Stream + Clone) { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 80 | pub fn statistics(&mut self) -> &mut (impl Stream + Clone + use<>) { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Stream` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/listener/mod.rs:91:40 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn incoming(&mut self) -> &mut impl Stream { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/listener/mod.rs:91:21 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn incoming(&mut self) -> &mut impl Stream { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 91 | pub fn incoming(&mut self) -> &mut impl Stream + use<> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/listener/state.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 133 | if let Some(packet) = packet { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/listener/state.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 133 ~ match packet { Some(packet) => { [INFO] [stdout] 134 | self.socket.send(packet).await.ok().ok_or(()) [INFO] [stdout] 135 ~ } _ => { [INFO] [stdout] 136 | Ok(0) [INFO] [stdout] 137 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures::Stream + Unpin` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/socket/mod.rs:107:27 [INFO] [stdout] | [INFO] [stdout] 107 | Pin<&mut Peekable + Unpin>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/socket/mod.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | &mut self, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 107 | Pin<&mut Peekable + Unpin + use<>>>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `srt_tokio` [INFO] [stdout] warning: `impl futures::Sink<(std::time::Instant, bytes::Bytes), Error = impl std::fmt::Debug> + Unpin` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/socket/mod.rs:108:19 [INFO] [stdout] | [INFO] [stdout] 108 | Pin<&mut (impl Sink<(Instant, Bytes), Error = impl Debug> + Unpin)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/socket/mod.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | &mut self, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 108 | Pin<&mut (impl Sink<(Instant, Bytes), Error = impl Debug> + Unpin + use<>)>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: `impl std::fmt::Debug` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/socket/mod.rs:108:55 [INFO] [stdout] | [INFO] [stdout] 108 | Pin<&mut (impl Sink<(Instant, Bytes), Error = impl Debug> + Unpin)>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/socket/mod.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | &mut self, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 108 | Pin<&mut (impl Sink<(Instant, Bytes), Error = impl Debug + use<>> + Unpin)>, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stdout] warning: `impl futures::Stream + Clone` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/socket/mod.rs:122:43 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn statistics(&mut self) -> &mut (impl Stream + Clone) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/socket/mod.rs:122:23 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn statistics(&mut self) -> &mut (impl Stream + Clone) { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 122 | pub fn statistics(&mut self) -> &mut (impl Stream + Clone + use<>) { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/socket/listen.rs:39:20 [INFO] [stdout] | [INFO] [stdout] 39 | if let Some(packet) = packet { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/socket/listen.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 39 ~ match packet { Some(packet) => { [INFO] [stdout] 40 | let _ = socket.send(packet).await?; [INFO] [stdout] 41 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] * src/listener/mod.rs [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:47:19 [INFO] [stdout] | [INFO] [stdout] 47 | while let Some(packet) = connection.next_packet(Instant::now()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^-------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:48:20 [INFO] [stdout] | [INFO] [stdout] 48 | if let Err(e) = socket.send(packet).await { [INFO] [stdout] | ^^^^^^^^^^^^^------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 48 ~ match socket.send(packet).await { Err(e) => { [INFO] [stdout] 49 | error!("Error while sending packet: {:?}", e); // TODO: real error handling [INFO] [stdout] 50 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:53:19 [INFO] [stdout] | [INFO] [stdout] 53 | while let Some(data) = connection.next_data(Instant::now()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:57:20 [INFO] [stdout] | [INFO] [stdout] 57 | if let Err(e) = output_data.send(data).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:59:17 [INFO] [stdout] | [INFO] [stdout] 59 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 57 ~ match output_data.send(data).await { Err(e) => { [INFO] [stdout] 58 | error!("Error while releasing packet {:?}", e); [INFO] [stdout] 59 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 91 | if let Err(e) = output_data.close().await { [INFO] [stdout] | ^^^^^^^^^^^^^-----------^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 91 ~ match output_data.close().await { Err(e) => { [INFO] [stdout] 92 | error!("Error while closing data output stream {:?}", e); [INFO] [stdout] 93 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:109:28 [INFO] [stdout] | [INFO] [stdout] 109 | if let Err(e) = output_data.send(data).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:111:25 [INFO] [stdout] | [INFO] [stdout] 111 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 109 ~ match output_data.send(data).await { Err(e) => { [INFO] [stdout] 110 | error!("Error while releasing data {:?}", e); [INFO] [stdout] 111 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 138 | if let Err(e) = output_data.close().await { [INFO] [stdout] | ^^^^^^^^^^^^^-----------^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/socket/factory.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 138 ~ match output_data.close().await { Err(e) => { [INFO] [stdout] 139 | error!("Error while closing data output stream {:?}", e); [INFO] [stdout] 140 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stdout] warning: 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: ambiguous `+` in a type [INFO] [stderr] --> src/listener/mod.rs:91:40 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn incoming(&mut self) -> &mut impl Stream + use<> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] help: try adding parentheses [INFO] [stderr] | [INFO] [stderr] 91 | pub fn incoming(&mut self) -> &mut (impl Stream + use<>) { [INFO] [stderr] | + + [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stderr] Migrating examples/sender.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/keepalive.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/single_packet_tsbpd.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/high_bandwidth.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/no_timeout.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/multiplex_authenticating_server.rs from 2021 edition to 2024 [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> examples/multiplex_authenticating_server.rs:18:11 [INFO] [stdout] | [INFO] [stdout] 18 | while let Some(request) = incoming.incoming().next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> examples/multiplex_authenticating_server.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/message_splitting.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/bidirectional.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/multiplex.rs from 2021 edition to 2024 [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> examples/multiplex.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 19 | while let Some(request) = incoming.incoming().next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> examples/multiplex.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/stransmit_interop.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/accesscontrol.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `stransmit_interop` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * tests/stransmit_interop.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> tests/stransmit_interop.rs:33:6 [INFO] [stderr] | [INFO] [stderr] 33 | ($x:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> tests/stransmit_interop.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | ($x:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 33 | ($x:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `libloading::Library::get` is unsafe and requires unsafe block [INFO] [stdout] --> tests/stransmit_interop.rs:531:28 [INFO] [stdout] | [INFO] [stdout] 531 | create_socket: lib.get(b"srt_create_socket").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] note: an unsafe function restricts its caller, but its body is safe by default [INFO] [stdout] --> tests/stransmit_interop.rs:529:5 [INFO] [stdout] | [INFO] [stdout] 529 | unsafe fn new(lib: &'l Library) -> HaivisionSrt<'l> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `--force-warn unsafe-op-in-unsafe-fn` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `libloading::Library::get` is unsafe and requires unsafe block [INFO] [stdout] --> tests/stransmit_interop.rs:532:26 [INFO] [stdout] | [INFO] [stdout] 532 | setsockflag: lib.get(b"srt_setsockflag").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `libloading::Library::get` is unsafe and requires unsafe block [INFO] [stdout] --> tests/stransmit_interop.rs:533:22 [INFO] [stdout] | [INFO] [stdout] 533 | connect: lib.get(b"srt_connect").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `libloading::Library::get` is unsafe and requires unsafe block [INFO] [stdout] --> tests/stransmit_interop.rs:534:23 [INFO] [stdout] | [INFO] [stdout] 534 | sendmsg2: lib.get(b"srt_sendmsg2").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `libloading::Library::get` is unsafe and requires unsafe block [INFO] [stdout] --> tests/stransmit_interop.rs:535:23 [INFO] [stdout] | [INFO] [stdout] 535 | recvmsg2: lib.get(b"srt_recvmsg2").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `libloading::Library::get` is unsafe and requires unsafe block [INFO] [stdout] --> tests/stransmit_interop.rs:536:20 [INFO] [stdout] | [INFO] [stdout] 536 | close: lib.get(b"srt_close").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `libloading::Library::get` is unsafe and requires unsafe block [INFO] [stdout] --> tests/stransmit_interop.rs:537:22 [INFO] [stdout] | [INFO] [stdout] 537 | startup: lib.get(b"srt_startup").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `libloading::Library::get` is unsafe and requires unsafe block [INFO] [stdout] --> tests/stransmit_interop.rs:539:31 [INFO] [stdout] | [INFO] [stdout] 539 | getlasterror_str: lib.get(b"srt_getlasterror_str").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0133]: call to unsafe function `libloading::Library::get` is unsafe and requires unsafe block [INFO] [stdout] --> tests/stransmit_interop.rs:540:26 [INFO] [stdout] | [INFO] [stdout] 540 | setloglevel: lib.get(b"srt_setloglevel").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #71668 [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/stransmit_interop.rs:77:11 [INFO] [stdout] | [INFO] [stdout] 77 | while let Some(a) = stream.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/stransmit_interop.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/stransmit_interop.rs:142:19 [INFO] [stdout] | [INFO] [stdout] 142 | while let Some(p) = conn.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/stransmit_interop.rs:152:13 [INFO] [stdout] | [INFO] [stdout] 152 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/stransmit_interop.rs:596:12 [INFO] [stdout] | [INFO] [stdout] 596 | if let Ok(lib) = unsafe { Library::new(path) } { [INFO] [stdout] | ^^^^^^^^^^^^^^----------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/stransmit_interop.rs:598:9 [INFO] [stdout] | [INFO] [stdout] 598 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 596 ~ match unsafe { Library::new(path) } { Ok(lib) => { [INFO] [stdout] 597 | return Some(lib); [INFO] [stdout] 598 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] Fixed tests/accesscontrol.rs (1 fix) [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/accesscontrol.rs:55:15 [INFO] [stdout] | [INFO] [stdout] 55 | while let Some(request) = incoming.incoming().next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/accesscontrol.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/crypto.rs from 2021 edition to 2024 [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/accesscontrol.rs:125:15 [INFO] [stdout] | [INFO] [stdout] 125 | while let Some(request) = incoming.incoming().next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/accesscontrol.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/rendezvous.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/multiplexer.rs from 2021 edition to 2024 [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/multiplexer.rs:20:15 [INFO] [stdout] | [INFO] [stdout] 20 | while let Some(request) = futures::select!(res = incoming.incoming().next().fuse() => res, _ = fused_finish => None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^------------------------------------------------------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/multiplexer.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/latency_exchange.rs from 2021 edition to 2024 [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/invalid_packets.rs from 2021 edition to 2024 [INFO] [stderr] Fixed tests/invalid_packets.rs (1 fix) [INFO] [stderr] Migrating examples/accesscontrol_server.rs from 2021 edition to 2024 [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> examples/accesscontrol_server.rs:40:11 [INFO] [stdout] | [INFO] [stdout] 40 | while let Some(request) = incoming.incoming().next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> examples/accesscontrol_server.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/receiver.rs from 2021 edition to 2024 [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/ts_streamer.rs from 2021 edition to 2024 [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> examples/receiver.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 10 | while let Some((_instant, _bytes)) = srt_socket.try_next().await? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> examples/receiver.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/srt2dash_ffmpeg.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/simple.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/accesscontrol_client.rs from 2021 edition to 2024 [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> examples/accesscontrol_client.rs:25:11 [INFO] [stdout] | [INFO] [stdout] 25 | while let Some((_instant, bytes)) = srt_socket.try_next().await? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> examples/accesscontrol_client.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 35.13s [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking srt-tokio v0.4.4 (/tmp/fixit) [INFO] [stdout] error[E0605]: non-primitive cast: `Result<(), _>` as `Result` [INFO] [stdout] --> tests/message_splitting.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | Ok(()) as Result<_> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ an `as` expression can only be used to convert between primitive types or to coerce to a specific trait object [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0605`. [INFO] [stdout] [INFO] [stderr] error: could not compile `srt-tokio` (test "message_splitting") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error[E0499]: cannot borrow `sock` as mutable more than once at a time [INFO] [stdout] --> tests/high_bandwidth.rs:93:27 [INFO] [stdout] | [INFO] [stdout] 84 | let mut statistics = sock.get_mut().statistics().clone().fuse(); [INFO] [stdout] | ---- first mutable borrow occurs here [INFO] [stdout] ... [INFO] [stdout] 93 | message = sock.next() => Message(message.unwrap().unwrap()), [INFO] [stdout] | ^^^^ second mutable borrow occurs here [INFO] [stdout] 94 | statistics = statistics.next() => Statistics(statistics.unwrap()), [INFO] [stdout] | ---------- first borrow later used here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0499`. [INFO] [stdout] [INFO] [stderr] error: could not compile `srt-tokio` (test "high_bandwidth") due to 2 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "aa15c7999ff884292475459eddfc5769b4e2540a0034c30cac77fc2fdd25e195", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa15c7999ff884292475459eddfc5769b4e2540a0034c30cac77fc2fdd25e195", kill_on_drop: false }` [INFO] [stdout] aa15c7999ff884292475459eddfc5769b4e2540a0034c30cac77fc2fdd25e195