[INFO] fetching crate srt-protocol 0.4.4... [INFO] checking srt-protocol-0.4.4 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate srt-protocol 0.4.4 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate srt-protocol 0.4.4 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate srt-protocol 0.4.4 [INFO] finished tweaking crates.io crate srt-protocol 0.4.4 [INFO] tweaked toml for crates.io crate srt-protocol 0.4.4 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 103 packages to latest compatible versions [INFO] [stderr] Adding bit-set v0.5.3 (available: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (available: v0.8.0) [INFO] [stderr] Adding convert_case v0.4.0 (available: v0.6.0) [INFO] [stderr] Adding derive_more v0.99.18 (available: v1.0.0) [INFO] [stderr] Adding env_logger v0.10.2 (available: v0.11.5) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding quick-error v1.2.3 (available: v2.0.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 79fed39b2d8d9e53b80826fe932659c112f19c6251a3926385f4ece5d67add1f [INFO] running `Command { std: "docker" "start" "-a" "79fed39b2d8d9e53b80826fe932659c112f19c6251a3926385f4ece5d67add1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "79fed39b2d8d9e53b80826fe932659c112f19c6251a3926385f4ece5d67add1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "79fed39b2d8d9e53b80826fe932659c112f19c6251a3926385f4ece5d67add1f", kill_on_drop: false }` [INFO] [stdout] 79fed39b2d8d9e53b80826fe932659c112f19c6251a3926385f4ece5d67add1f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 690e62962320f7b072a0a9169b626f007d7bb95d417ea498fcc881bb0363827a [INFO] running `Command { std: "docker" "start" "-a" "690e62962320f7b072a0a9169b626f007d7bb95d417ea498fcc881bb0363827a", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking keyed_priority_queue v0.4.2 [INFO] [stderr] Checking arraydeque v0.5.1 [INFO] [stderr] Checking take-until v0.2.0 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking sha-1 v0.10.1 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking pretty_assertions v1.4.1 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Checking rustix v0.38.37 [INFO] [stderr] Checking streaming-stats v0.2.3 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stderr] Checking srt-protocol v0.4.4 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `srt_protocol` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/packet/modular_num.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/packet/modular_num.rs:16:32 [INFO] [stderr] | [INFO] [stderr] 16 | (pub $x:ident($type:ident, $num:expr_2021)) => { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/packet/modular_num.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | ($x:ident($type:ident, $num:expr_2021)) => { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/packet/modular_num.rs:63:38 [INFO] [stdout] | [INFO] [stdout] 63 | $x::new_truncate(rng.gen::<$type>()) [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/packet/modular_num.rs:16:37 [INFO] [stdout] | [INFO] [stdout] 16 | (pub $x:ident($type:ident, $num:expr)) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 16 | (pub $x:ident($type:ident, $num:expr_2021)) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/packet/modular_num.rs:19:33 [INFO] [stdout] | [INFO] [stdout] 19 | ($x:ident($type:ident, $num:expr)) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 19 | ($x:ident($type:ident, $num:expr_2021)) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/packet/modular_num.rs:28:55 [INFO] [stdout] | [INFO] [stdout] 28 | (($($publicity:tt)*), $x:ident, $type:ident, $num:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 28 | (($($publicity:tt)*), $x:ident, $type:ident, $num:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stdout] warning: field `variance` is never read [INFO] [stdout] --> src/protocol/sender/congestion_control.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct RateEstimate { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 12 | pub mean: u64, [INFO] [stdout] 13 | pub variance: u64, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RateEstimate` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] --> src/packet/modular_num.rs:28:50 [INFO] [stdout] warning: field `messages` is never read [INFO] [stdout] --> src/protocol/sender/congestion_control.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 56 | pub struct InputRateEstimate { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 57 | pub messages: RateEstimate, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `InputRateEstimate` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | [INFO] [stderr] 28 | (($($publicity:tt)*), $x:ident, $type:ident, $num:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/connection/mod.rs:149:19 [INFO] [stdout] | [INFO] [stdout] 149 | } else if let Some(packet) = self.next_packet(now) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 150 | Action::SendPacket(packet) [INFO] [stdout] 151 | } else if let Some(data) = self.next_data(now) { [INFO] [stdout] | ------------------- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/connection/mod.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | } else if let Some(data) = self.next_data(now) { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/connection/mod.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 149 ~ } else { match self.next_packet(now) { Some(packet) => { [INFO] [stdout] 150 | Action::SendPacket(packet) [INFO] [stdout] 151 ~ } _ => { match self.next_data(now) { Some(data) => { [INFO] [stdout] 152 | Action::ReleaseData(data) [INFO] [stdout] 153 ~ } _ => { [INFO] [stdout] 154 | Action::WaitForData(self.next_timer(now) - now) [INFO] [stdout] 155 ~ }}}}}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/protocol/receiver/mod.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 114 | if let Some(_adjustment) = self.receiver.arq.synchronize_clock(now, ts) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^-----------------^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/receiver/mod.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 114 ~ match self.receiver.arq.synchronize_clock(now, ts) { Some(_adjustment) => { [INFO] [stdout] 115 | //self.debug("clock sync", now, &adjustment); [INFO] [stdout] 116 | self.stats.rx_clock_adjustments += 1; [INFO] [stdout] 117 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/protocol/receiver/mod.rs:223:12 [INFO] [stdout] | [INFO] [stdout] 223 | if let Some(ack) = self.receiver.arq.on_full_ack_event(now) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^-----------------^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/receiver/mod.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 227 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 223 ~ match self.receiver.arq.on_full_ack_event(now) { Some(ack) => { [INFO] [stdout] 224 | // Pack the ACK packet with RTT, RTT Variance, and flow window size (available [INFO] [stdout] 225 | // receiver buffer size). [INFO] [stdout] 226 | self.output.send_control(now, ControlTypes::Ack(ack)); [INFO] [stdout] 227 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/protocol/receiver/mod.rs:231:12 [INFO] [stdout] | [INFO] [stdout] 231 | if let Some(loss_list) = self.receiver.arq.on_nak_event(now) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^-----------------^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/receiver/mod.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 231 ~ match self.receiver.arq.on_nak_event(now) { Some(loss_list) => { [INFO] [stdout] 232 | self.output.send_control(now, ControlTypes::Nak(loss_list)); [INFO] [stdout] 233 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/protocol/receiver/buffer.rs:527:12 [INFO] [stdout] | [INFO] [stdout] 527 | if let (Some(BufferPacket::Received(s)), Some(BufferPacket::Received(e))) = [INFO] [stdout] | ____________^ [INFO] [stdout] 528 | | (self.buffer.get(start_idx), self.buffer.get(end_idx)) [INFO] [stdout] | |______________-----------_________________________________________^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/receiver/buffer.rs:533:9 [INFO] [stdout] | [INFO] [stdout] 533 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 527 ~ match (self.buffer.get(start_idx), self.buffer.get(end_idx)) [INFO] [stdout] 528 ~ { (Some(BufferPacket::Received(s)), Some(BufferPacket::Received(e))) => { [INFO] [stdout] 529 | Duration::from_micros( [INFO] [stdout] 530 | u64::try_from((e.timestamp - s.timestamp).as_micros()).unwrap_or(0), [INFO] [stdout] 531 | ) [INFO] [stdout] 532 ~ } _ => { [INFO] [stdout] 533 | Duration::from_micros(0) [INFO] [stdout] 534 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/protocol/sender/mod.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 99 | if let Some((bytes_enc, packet, km)) = self.sender.encryption.encrypt(packet) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/sender/mod.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 99 ~ match self.sender.encryption.encrypt(packet) { Some((bytes_enc, packet, km)) => { [INFO] [stdout] 100 | packets += 1; [INFO] [stdout] ... [INFO] [stdout] 114 | } [INFO] [stdout] 115 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/protocol/sender/buffer.rs:69:19 [INFO] [stdout] | [INFO] [stdout] 69 | } else if let Some(entry) = self.buffer.pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/sender/buffer.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 69 ~ } else { match self.buffer.pop_front() { Some(entry) => { [INFO] [stdout] 70 | self.buffer_len_bytes -= entry.packet.wire_size(); [INFO] [stdout] ... [INFO] [stdout] 77 | Err((PacketCount(1), ByteCount(entry.packet.wire_size() as u64))) [INFO] [stdout] 78 ~ } _ => { [INFO] [stdout] 79 | Ok(()) [INFO] [stdout] 80 ~ }}}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/protocol/sender/buffer.rs:501:16 [INFO] [stdout] | [INFO] [stdout] 501 | if let Some(p) = self.buffer.send_next_16n_packet(self.ts_now) { [INFO] [stdout] | ^^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/sender/buffer.rs:503:13 [INFO] [stdout] | [INFO] [stdout] 503 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 501 ~ match self.buffer.send_next_16n_packet(self.ts_now) { Some(p) => { [INFO] [stdout] 502 | return self.send(p); [INFO] [stdout] 503 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/protocol/sender/buffer.rs:524:17 [INFO] [stdout] | [INFO] [stdout] 524 | else if let Some(p) = self.buffer.send_next_lost_packet(self.ts_now) { [INFO] [stdout] | ^^^^^^^^^^^^^^---------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 525 | self.retransmit_nak(p) [INFO] [stdout] 526 | } else if let Some(p) = self.buffer.send_next_rto_packet(self.ts_now) { [INFO] [stdout] | --------------------------------------------- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 536 | } else if let Some(p) = self.buffer.send_next_packet(self.ts_now) { [INFO] [stdout] | ----------------------------------------- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 546 | } else if let Some(p) = self.buffer.flush_on_close(self.should_drain) { [INFO] [stdout] | --------------------------------------------- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/sender/buffer.rs:526:9 [INFO] [stdout] | [INFO] [stdout] 526 | } else if let Some(p) = self.buffer.send_next_rto_packet(self.ts_now) { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/sender/buffer.rs:528:9 [INFO] [stdout] | [INFO] [stdout] 528 | } [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/sender/buffer.rs:546:9 [INFO] [stdout] | [INFO] [stdout] 546 | } else if let Some(p) = self.buffer.flush_on_close(self.should_drain) { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/sender/buffer.rs:548:9 [INFO] [stdout] | [INFO] [stdout] 548 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 524 ~ else { match self.buffer.send_next_lost_packet(self.ts_now) { Some(p) => { [INFO] [stdout] 525 | self.retransmit_nak(p) [INFO] [stdout] 526 ~ } _ => { match self.buffer.send_next_rto_packet(self.ts_now) { Some(p) => { [INFO] [stdout] 527 | self.retransmit_rto(p) [INFO] [stdout] 528 ~ } _ => if self.buffer.flow_window_exceeded() { [INFO] [stdout] 529 | self.wait_for_ack() [INFO] [stdout] 530 ~ } else { match self.buffer.send_next_packet(self.ts_now) { Some(p) => { [INFO] [stdout] 531 | // b. Pack a new data packet and send it out. [INFO] [stdout] ... [INFO] [stdout] 539 | self.send(p) [INFO] [stdout] 540 ~ } _ => { match self.buffer.flush_on_close(self.should_drain) { Some(p) => { [INFO] [stdout] 541 | self.send(p) [INFO] [stdout] 542 ~ } _ => { [INFO] [stdout] 543 | // NOTE: we wait the same amount regardless if we are waiting for packets or data [INFO] [stdout] ... [INFO] [stdout] 554 | self.wait_for_input() [INFO] [stdout] 555 ~ }}}}}}}}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/not_enough_latency.rs from 2021 edition to 2024 [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/packet/modular_num.rs:63:38 [INFO] [stdout] | [INFO] [stdout] 63 | $x::new_truncate(rng.gen::<$type>()) [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `srt_protocol` [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/packet/control/loss_compression.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | ($x:expr, $y:expr) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 156 | ($x:expr_2021, $y:expr) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/packet/control/loss_compression.rs:156:26 [INFO] [stdout] | [INFO] [stdout] 156 | ($x:expr, $y:expr) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 156 | ($x:expr, $y:expr_2021) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/packet/modular_num.rs:16:37 [INFO] [stdout] | [INFO] [stdout] 16 | (pub $x:ident($type:ident, $num:expr)) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 16 | (pub $x:ident($type:ident, $num:expr_2021)) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/packet/modular_num.rs:19:33 [INFO] [stdout] | [INFO] [stdout] 19 | ($x:ident($type:ident, $num:expr)) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 19 | ($x:ident($type:ident, $num:expr_2021)) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] * src/packet/control/loss_compression.rs [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/packet/modular_num.rs:28:55 [INFO] [stdout] | [INFO] [stdout] 28 | (($($publicity:tt)*), $x:ident, $type:ident, $num:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 28 | (($($publicity:tt)*), $x:ident, $type:ident, $num:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] * src/packet/modular_num.rs [INFO] [stdout] warning: field `variance` is never read [INFO] [stdout] --> src/protocol/sender/congestion_control.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct RateEstimate { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 12 | pub mean: u64, [INFO] [stdout] 13 | pub variance: u64, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RateEstimate` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: field `messages` is never read [INFO] [stdout] --> src/protocol/sender/congestion_control.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 56 | pub struct InputRateEstimate { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 57 | pub messages: RateEstimate, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `InputRateEstimate` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/connection/mod.rs:149:19 [INFO] [stdout] | [INFO] [stdout] 149 | } else if let Some(packet) = self.next_packet(now) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 150 | Action::SendPacket(packet) [INFO] [stdout] 151 | } else if let Some(data) = self.next_data(now) { [INFO] [stdout] | ------------------- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/connection/mod.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | } else if let Some(data) = self.next_data(now) { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/connection/mod.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 149 ~ } else { match self.next_packet(now) { Some(packet) => { [INFO] [stdout] 150 | Action::SendPacket(packet) [INFO] [stdout] 151 ~ } _ => { match self.next_data(now) { Some(data) => { [INFO] [stdout] 152 | Action::ReleaseData(data) [INFO] [stdout] 153 ~ } _ => { [INFO] [stdout] 154 | Action::WaitForData(self.next_timer(now) - now) [INFO] [stdout] 155 ~ }}}}}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/protocol/receiver/mod.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 114 | if let Some(_adjustment) = self.receiver.arq.synchronize_clock(now, ts) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^-----------------^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/receiver/mod.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 114 ~ match self.receiver.arq.synchronize_clock(now, ts) { Some(_adjustment) => { [INFO] [stdout] 115 | //self.debug("clock sync", now, &adjustment); [INFO] [stdout] 116 | self.stats.rx_clock_adjustments += 1; [INFO] [stdout] 117 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/protocol/receiver/mod.rs:223:12 [INFO] [stdout] | [INFO] [stdout] 223 | if let Some(ack) = self.receiver.arq.on_full_ack_event(now) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^-----------------^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/receiver/mod.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 227 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 223 ~ match self.receiver.arq.on_full_ack_event(now) { Some(ack) => { [INFO] [stdout] 224 | // Pack the ACK packet with RTT, RTT Variance, and flow window size (available [INFO] [stdout] 225 | // receiver buffer size). [INFO] [stdout] 226 | self.output.send_control(now, ControlTypes::Ack(ack)); [INFO] [stdout] 227 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/protocol/receiver/mod.rs:231:12 [INFO] [stdout] | [INFO] [stdout] 231 | if let Some(loss_list) = self.receiver.arq.on_nak_event(now) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^-----------------^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/receiver/mod.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 231 ~ match self.receiver.arq.on_nak_event(now) { Some(loss_list) => { [INFO] [stdout] 232 | self.output.send_control(now, ControlTypes::Nak(loss_list)); [INFO] [stdout] 233 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/protocol/receiver/buffer.rs:527:12 [INFO] [stdout] | [INFO] [stdout] 527 | if let (Some(BufferPacket::Received(s)), Some(BufferPacket::Received(e))) = [INFO] [stdout] | ____________^ [INFO] [stdout] 528 | | (self.buffer.get(start_idx), self.buffer.get(end_idx)) [INFO] [stdout] | |______________-----------_________________________________________^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/receiver/buffer.rs:533:9 [INFO] [stdout] | [INFO] [stdout] 533 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 527 ~ match (self.buffer.get(start_idx), self.buffer.get(end_idx)) [INFO] [stdout] 528 ~ { (Some(BufferPacket::Received(s)), Some(BufferPacket::Received(e))) => { [INFO] [stdout] 529 | Duration::from_micros( [INFO] [stdout] 530 | u64::try_from((e.timestamp - s.timestamp).as_micros()).unwrap_or(0), [INFO] [stdout] 531 | ) [INFO] [stdout] 532 ~ } _ => { [INFO] [stdout] 533 | Duration::from_micros(0) [INFO] [stdout] 534 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/protocol/sender/mod.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 99 | if let Some((bytes_enc, packet, km)) = self.sender.encryption.encrypt(packet) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/sender/mod.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 99 ~ match self.sender.encryption.encrypt(packet) { Some((bytes_enc, packet, km)) => { [INFO] [stdout] 100 | packets += 1; [INFO] [stdout] ... [INFO] [stdout] 114 | } [INFO] [stdout] 115 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/protocol/sender/buffer.rs:69:19 [INFO] [stdout] | [INFO] [stdout] 69 | } else if let Some(entry) = self.buffer.pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/sender/buffer.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 69 ~ } else { match self.buffer.pop_front() { Some(entry) => { [INFO] [stdout] 70 | self.buffer_len_bytes -= entry.packet.wire_size(); [INFO] [stdout] ... [INFO] [stdout] 77 | Err((PacketCount(1), ByteCount(entry.packet.wire_size() as u64))) [INFO] [stdout] 78 ~ } _ => { [INFO] [stdout] 79 | Ok(()) [INFO] [stdout] 80 ~ }}}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/protocol/sender/buffer.rs:501:16 [INFO] [stdout] | [INFO] [stdout] 501 | if let Some(p) = self.buffer.send_next_16n_packet(self.ts_now) { [INFO] [stdout] | ^^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/sender/buffer.rs:503:13 [INFO] [stdout] | [INFO] [stdout] 503 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 501 ~ match self.buffer.send_next_16n_packet(self.ts_now) { Some(p) => { [INFO] [stdout] 502 | return self.send(p); [INFO] [stdout] 503 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/protocol/sender/buffer.rs:524:17 [INFO] [stdout] | [INFO] [stdout] 524 | else if let Some(p) = self.buffer.send_next_lost_packet(self.ts_now) { [INFO] [stdout] | ^^^^^^^^^^^^^^---------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 525 | self.retransmit_nak(p) [INFO] [stdout] 526 | } else if let Some(p) = self.buffer.send_next_rto_packet(self.ts_now) { [INFO] [stdout] | --------------------------------------------- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 536 | } else if let Some(p) = self.buffer.send_next_packet(self.ts_now) { [INFO] [stdout] | ----------------------------------------- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] ... [INFO] [stdout] 546 | } else if let Some(p) = self.buffer.flush_on_close(self.should_drain) { [INFO] [stdout] | --------------------------------------------- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/sender/buffer.rs:526:9 [INFO] [stdout] | [INFO] [stdout] 526 | } else if let Some(p) = self.buffer.send_next_rto_packet(self.ts_now) { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/sender/buffer.rs:528:9 [INFO] [stdout] | [INFO] [stdout] 528 | } [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/sender/buffer.rs:546:9 [INFO] [stdout] | [INFO] [stdout] 546 | } else if let Some(p) = self.buffer.flush_on_close(self.should_drain) { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/protocol/sender/buffer.rs:548:9 [INFO] [stdout] | [INFO] [stdout] 548 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 524 ~ else { match self.buffer.send_next_lost_packet(self.ts_now) { Some(p) => { [INFO] [stdout] 525 | self.retransmit_nak(p) [INFO] [stdout] 526 ~ } _ => { match self.buffer.send_next_rto_packet(self.ts_now) { Some(p) => { [INFO] [stdout] 527 | self.retransmit_rto(p) [INFO] [stdout] 528 ~ } _ => if self.buffer.flow_window_exceeded() { [INFO] [stdout] 529 | self.wait_for_ack() [INFO] [stdout] 530 ~ } else { match self.buffer.send_next_packet(self.ts_now) { Some(p) => { [INFO] [stdout] 531 | // b. Pack a new data packet and send it out. [INFO] [stdout] ... [INFO] [stdout] 539 | self.send(p) [INFO] [stdout] 540 ~ } _ => { match self.buffer.flush_on_close(self.should_drain) { Some(p) => { [INFO] [stdout] 541 | self.send(p) [INFO] [stdout] 542 ~ } _ => { [INFO] [stdout] 543 | // NOTE: we wait the same amount regardless if we are waiting for packets or data [INFO] [stdout] ... [INFO] [stdout] 554 | self.wait_for_input() [INFO] [stdout] 555 ~ }}}}}}}}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] The following errors were reported: [INFO] [stdout] warning: 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/packet/modular_num.rs:16:32 [INFO] [stderr] | [INFO] [stderr] 16 | (pub $x:ident($type:ident, $num:expr_2021)) => { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/packet/modular_num.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | ($x:ident($type:ident, $num:expr_2021)) => { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/packet/modular_num.rs:28:50 [INFO] [stderr] | [INFO] [stderr] 28 | (($($publicity:tt)*), $x:ident, $type:ident, $num:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/packet/control/loss_compression.rs:156:14 [INFO] [stderr] | [INFO] [stderr] 156 | ($x:expr_2021, $y:expr_2021) => {{ [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/packet/control/loss_compression.rs:156:28 [INFO] [stderr] | [INFO] [stderr] 156 | ($x:expr_2021, $y:expr_2021) => {{ [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stderr] Fixed tests/simulator/mod.rs (4 fixes) [INFO] [stderr] Migrating tests/timestamp_rollover.rs from 2021 edition to 2024 [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/not_enough_latency.rs:61:19 [INFO] [stdout] | [INFO] [stdout] 61 | while let Some(packet) = sender.next_packet(now) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/not_enough_latency.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/not_enough_latency.rs:81:19 [INFO] [stdout] | [INFO] [stdout] 81 | while let Some((_, by)) = receiver.next_data(now) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/not_enough_latency.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 93 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/not_enough_latency.rs:95:19 [INFO] [stdout] | [INFO] [stdout] 95 | while let Some(packet) = receiver.next_packet(now) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/not_enough_latency.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/connect.rs from 2021 edition to 2024 [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/timestamp_rollover.rs:105:19 [INFO] [stdout] | [INFO] [stdout] 105 | while let Some(packet) = sender.next_packet(now) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/timestamp_rollover.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 107 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/timestamp_rollover.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 122 | while let Some((_, payload)) = receiver.next_data(now) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/timestamp_rollover.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/timestamp_rollover.rs:129:19 [INFO] [stdout] | [INFO] [stdout] 129 | while let Some(packet) = receiver.next_packet(now) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/timestamp_rollover.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 131 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed tests/connect.rs (3 fixes) [INFO] [stderr] Migrating tests/lossy_deterministic.rs from 2021 edition to 2024 [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/lossy_deterministic.rs:71:19 [INFO] [stdout] | [INFO] [stdout] 71 | while let Some(packet) = sender.next_packet(now) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/lossy_deterministic.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/lossy_deterministic.rs:91:19 [INFO] [stdout] | [INFO] [stdout] 91 | while let Some((ts, payload)) = receiver.next_data(now) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/lossy_deterministic.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/lossy_deterministic.rs:104:19 [INFO] [stdout] | [INFO] [stdout] 104 | while let Some(packet) = receiver.next_packet(now) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/lossy_deterministic.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 109 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/lossy_deterministic.rs:194:19 [INFO] [stdout] | [INFO] [stdout] 194 | while let Some(packet) = sender.next_packet(now) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/lossy_deterministic.rs:199:13 [INFO] [stdout] | [INFO] [stdout] 199 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/lossy_deterministic.rs:214:19 [INFO] [stdout] | [INFO] [stdout] 214 | while let Some((ts, payload)) = receiver.next_data(now) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/lossy_deterministic.rs:253:13 [INFO] [stdout] | [INFO] [stdout] 253 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/lossy_deterministic.rs:255:19 [INFO] [stdout] | [INFO] [stdout] 255 | while let Some(packet) = receiver.next_packet(now) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/lossy_deterministic.rs:260:13 [INFO] [stdout] | [INFO] [stdout] 260 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.92s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking srt-protocol v0.4.4 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/packet/modular_num.rs:63:38 [INFO] [stdout] | [INFO] [stdout] 63 | $x::new_truncate(rng.gen::<$type>()) [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] ::: src/packet/msg_number.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / modular_num! { [INFO] [stdout] 4 | | pub MsgNumber(u32, 26) [INFO] [stdout] 5 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this error originates in the macro `$crate::modular_num_impls` which comes from the expansion of the macro `modular_num` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 63 | $x::new_truncate(rng.r#gen::<$type>()) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/packet/modular_num.rs:63:38 [INFO] [stdout] | [INFO] [stdout] 63 | $x::new_truncate(rng.gen::<$type>()) [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] ::: src/packet/seq_number.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / modular_num! { [INFO] [stdout] 4 | | pub SeqNumber(u32, 31) [INFO] [stdout] 5 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this error originates in the macro `$crate::modular_num_impls` which comes from the expansion of the macro `modular_num` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 63 | $x::new_truncate(rng.r#gen::<$type>()) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/packet/modular_num.rs:63:38 [INFO] [stdout] | [INFO] [stdout] 63 | $x::new_truncate(rng.gen::<$type>()) [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] ... [INFO] [stdout] 164 | modular_num! { SeqNumber(u32, 31) } [INFO] [stdout] | ----------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this error originates in the macro `$crate::modular_num_impls` which comes from the expansion of the macro `modular_num` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 63 | $x::new_truncate(rng.r#gen::<$type>()) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/packet/modular_num.rs:63:38 [INFO] [stdout] | [INFO] [stdout] 63 | $x::new_truncate(rng.gen::<$type>()) [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] ::: src/packet/msg_number.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / modular_num! { [INFO] [stdout] 4 | | pub MsgNumber(u32, 26) [INFO] [stdout] 5 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this error originates in the macro `$crate::modular_num_impls` which comes from the expansion of the macro `modular_num` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 63 | $x::new_truncate(rng.r#gen::<$type>()) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/packet/modular_num.rs:63:38 [INFO] [stdout] | [INFO] [stdout] 63 | $x::new_truncate(rng.gen::<$type>()) [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] ::: src/packet/seq_number.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / modular_num! { [INFO] [stdout] 4 | | pub SeqNumber(u32, 31) [INFO] [stdout] 5 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this error originates in the macro `$crate::modular_num_impls` which comes from the expansion of the macro `modular_num` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 63 | $x::new_truncate(rng.r#gen::<$type>()) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `srt-protocol` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `srt-protocol` (lib test) due to 4 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "690e62962320f7b072a0a9169b626f007d7bb95d417ea498fcc881bb0363827a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "690e62962320f7b072a0a9169b626f007d7bb95d417ea498fcc881bb0363827a", kill_on_drop: false }` [INFO] [stdout] 690e62962320f7b072a0a9169b626f007d7bb95d417ea498fcc881bb0363827a