[INFO] fetching crate sn_membership 1.15.0... [INFO] checking sn_membership-1.15.0 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate sn_membership 1.15.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate sn_membership 1.15.0 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sn_membership 1.15.0 [INFO] finished tweaking crates.io crate sn_membership 1.15.0 [INFO] tweaked toml for crates.io crate sn_membership 1.15.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 92 packages to latest compatible versions [INFO] [stderr] Adding block-buffer v0.9.0 (available: v0.10.4) [INFO] [stderr] Adding blsttc v3.4.0 (available: v8.0.2) [INFO] [stderr] Adding curve25519-dalek v3.2.1 (available: v4.1.3) [INFO] [stderr] Adding digest v0.9.0 (available: v0.10.7) [INFO] [stderr] Adding ed25519 v1.5.3 (available: v2.2.3) [INFO] [stderr] Adding ed25519-dalek v1.0.1 (available: v2.1.1) [INFO] [stderr] Adding env_logger v0.8.4 (available: v0.11.5) [INFO] [stderr] Adding ff v0.6.0 (available: v0.13.0) [INFO] [stderr] Adding ff_derive v0.6.0 (available: v0.13.0) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (available: v0.2.15) [INFO] [stderr] Adding group v0.6.0 (available: v0.13.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding num-bigint v0.2.6 (available: v0.4.6) [INFO] [stderr] Adding pairing v0.16.0 (available: v0.23.0) [INFO] [stderr] Adding rand v0.7.3 (available: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (available: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (available: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (available: v0.3.2) [INFO] [stderr] Adding rand_xorshift v0.2.0 (available: v0.3.0) [INFO] [stderr] Adding sha2 v0.9.9 (available: v0.10.8) [INFO] [stderr] Adding signature v1.6.4 (available: v2.2.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding zeroize v1.3.0 (available: v1.8.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] facae4447ded95db558cf1a5f3fe13a3192638d2ec4f74b49cc3c88722989127 [INFO] running `Command { std: "docker" "start" "-a" "facae4447ded95db558cf1a5f3fe13a3192638d2ec4f74b49cc3c88722989127", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "facae4447ded95db558cf1a5f3fe13a3192638d2ec4f74b49cc3c88722989127", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "facae4447ded95db558cf1a5f3fe13a3192638d2ec4f74b49cc3c88722989127", kill_on_drop: false }` [INFO] [stdout] facae4447ded95db558cf1a5f3fe13a3192638d2ec4f74b49cc3c88722989127 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ab029ffe4778458797ab6df3d506f86374fc594206f62c484bd8db13f33f334d [INFO] running `Command { std: "docker" "start" "-a" "ab029ffe4778458797ab6df3d506f86374fc594206f62c484bd8db13f33f334d", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Fixed Cargo.toml (1 fix) [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Checking hex_fmt v0.3.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling blst v0.3.13 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Compiling quickcheck_macros v1.0.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_xorshift v0.2.0 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Compiling num-integer v0.1.46 [INFO] [stderr] Compiling ff_derive v0.6.0 [INFO] [stderr] Checking ff v0.6.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking zeroize v1.3.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking group v0.6.0 [INFO] [stderr] Checking pairing v0.16.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking blsttc v3.4.0 [INFO] [stderr] Checking sn_membership v1.15.0 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/error.rs (1 fix) [INFO] [stderr] Fixed src/vote.rs (4 fixes) [INFO] [stderr] Fixed src/sn_membership.rs (39 fixes) [INFO] [stderr] Fixed src/consensus.rs (21 fixes) [INFO] [stderr] Fixed src/sn_handover.rs (12 fixes) [INFO] [stderr] Migrating tests/membership_net.rs from 2021 edition to 2024 [INFO] [stderr] Fixed tests/membership_net.rs (18 fixes) [INFO] [stderr] Migrating tests/handover_net.rs from 2021 edition to 2024 [INFO] [stderr] Fixed tests/handover_net.rs (12 fixes) [INFO] [stderr] Migrating tests/sn_handover.rs from 2021 edition to 2024 [INFO] [stderr] Fixed tests/sn_handover.rs (10 fixes) [INFO] [stderr] Migrating tests/sn_membership.rs from 2021 edition to 2024 [INFO] [stdout] warning: field `proposals` is never read [INFO] [stdout] --> tests/handover_net.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct Net { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 22 | pub procs: Vec>, [INFO] [stdout] 23 | pub proposals: BTreeSet, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Net` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed tests/sn_membership.rs (106 fixes) [INFO] [stdout] warning: field `members_at_gen` is never read [INFO] [stdout] --> tests/membership_net.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct Net { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 26 | pub members_at_gen: BTreeMap>, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Net` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/sn_membership.rs:730:11 [INFO] [stdout] | [INFO] [stdout] 730 | while let Err(e) = net.drain_queued_packets() { [INFO] [stdout] | ^^^^^^^^^^^^^-------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/sn_membership.rs:732:5 [INFO] [stdout] | [INFO] [stdout] 732 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/sn_membership.rs:1119:11 [INFO] [stdout] | [INFO] [stdout] 1119 | while let Err(e) = net.drain_queued_packets() { [INFO] [stdout] | ^^^^^^^^^^^^^-------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/sn_membership.rs:1121:5 [INFO] [stdout] | [INFO] [stdout] 1121 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> tests/sn_membership.rs:1505:11 [INFO] [stdout] | [INFO] [stdout] 1505 | while let Err(e) = net.drain_queued_packets() { [INFO] [stdout] | ^^^^^^^^^^^^^-------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> tests/sn_membership.rs:1507:5 [INFO] [stdout] | [INFO] [stdout] 1507 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.03s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking sn_membership v1.15.0 (/tmp/fixit) [INFO] [stdout] error: expected expression, found reserved keyword `gen` [INFO] [stdout] --> src/error.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | #[error("Valid generation are between 1..=(gen={gen} + 1): requested gen = {requested_gen}, gen: {gen}")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected expression, found reserved keyword `gen` [INFO] [stdout] --> src/error.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | #[error("Valid generation are between 1..=(gen={gen} + 1): requested gen = {requested_gen}, gen: {gen}")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sn_membership` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `sn_membership` (lib test) due to 2 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "ab029ffe4778458797ab6df3d506f86374fc594206f62c484bd8db13f33f334d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ab029ffe4778458797ab6df3d506f86374fc594206f62c484bd8db13f33f334d", kill_on_drop: false }` [INFO] [stdout] ab029ffe4778458797ab6df3d506f86374fc594206f62c484bd8db13f33f334d