[INFO] fetching crate serie 0.4.0... [INFO] checking serie-0.4.0 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate serie 0.4.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate serie 0.4.0 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate serie 0.4.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate serie 0.4.0 [INFO] tweaked toml for crates.io crate serie 0.4.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate serie 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 19aef6c689ed30fac4f94138b143d3927b4f6a09a080ad76d949d5e9293ee728 [INFO] running `Command { std: "docker" "start" "-a" "19aef6c689ed30fac4f94138b143d3927b4f6a09a080ad76d949d5e9293ee728", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "19aef6c689ed30fac4f94138b143d3927b4f6a09a080ad76d949d5e9293ee728", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19aef6c689ed30fac4f94138b143d3927b4f6a09a080ad76d949d5e9293ee728", kill_on_drop: false }` [INFO] [stdout] 19aef6c689ed30fac4f94138b143d3927b4f6a09a080ad76d949d5e9293ee728 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 50acc2383205ee022aa53b942bbc307046e89828d2a4156072a1fec87905dbf7 [INFO] running `Command { std: "docker" "start" "-a" "50acc2383205ee022aa53b942bbc307046e89828d2a4156072a1fec87905dbf7", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking bytemuck v1.16.1 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling thiserror v1.0.62 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking aligned-vec v0.5.0 [INFO] [stderr] Compiling built v0.7.4 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking rgb v0.8.44 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling rav1e v0.7.1 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking bitstream-io v2.5.0 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Compiling unicode-general-category v0.4.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Checking v_frame v0.3.8 [INFO] [stderr] Compiling cc v1.1.2 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking imgref v1.10.1 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking compact_str v0.8.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking avif-serialize v0.8.1 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking ttf-parser v0.12.3 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking zune-jpeg v0.4.11 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking exr v1.72.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling backtrace v0.3.71 [INFO] [stderr] Checking av1-grain v0.2.3 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking unicode-bidi-mirroring v0.1.0 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking x11rb-protocol v0.13.1 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking unicode-ccc v0.1.2 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking unicode-script v0.5.6 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Checking xmlparser v0.13.6 [INFO] [stderr] Checking clap_builder v4.5.17 [INFO] [stderr] Checking rustybuzz v0.4.0 [INFO] [stderr] Checking svgtypes v0.8.2 [INFO] [stderr] Checking data-url v0.1.1 [INFO] [stderr] Checking roxmltree v0.14.1 [INFO] [stderr] Compiling rstest_macros v0.22.0 [INFO] [stderr] Checking color-spantrace v0.2.1 [INFO] [stderr] Checking fontdb v0.7.0 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking safe_arch v0.5.2 [INFO] [stderr] Checking kurbo v0.8.3 [INFO] [stderr] Checking simplecss v0.2.1 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking rctree v0.4.0 [INFO] [stderr] Checking xmlwriter v0.1.0 [INFO] [stderr] Checking unicode-vo v0.1.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking pico-args v0.4.2 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking tiny-skia v0.6.6 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling toml_edit v0.22.20 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking jwalk v0.8.1 [INFO] [stderr] Checking xml-rs v0.8.20 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking dircpy v0.3.19 [INFO] [stderr] Checking usvg v0.19.0 [INFO] [stderr] Compiling thiserror-impl v1.0.62 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling profiling-procmacros v1.0.15 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling instability v0.3.2 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking profiling v1.0.15 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking color-eyre v0.6.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling derive-new v0.5.9 [INFO] [stderr] Checking image-webp v0.1.2 [INFO] [stderr] Checking resvg v0.19.0 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Checking text-to-png v0.2.0 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking ratatui v0.28.1 [INFO] [stderr] Checking clap v4.5.17 [INFO] [stderr] Checking tui-input v0.10.1 [INFO] [stderr] Checking tui-tree-widget v0.22.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rstest v0.22.0 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking ravif v0.11.8 [INFO] [stderr] Checking image v0.25.2 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking arboard v3.4.0 [INFO] [stderr] Checking serie v0.4.0 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `serie` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/macros.rs [INFO] [stderr] * src/widget/commit_list.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/macros.rs:16:7 [INFO] [stderr] | [INFO] [stderr] 16 | ( $c:expr_2021 ) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/macros.rs:22:7 [INFO] [stderr] | [INFO] [stderr] 22 | ( $c:expr_2021, Ctrl ) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] warning: elided lifetime has a name [INFO] [stderr] --> src/widget/commit_list.rs:742:43 [INFO] [stderr] | [INFO] [stderr] 739 | fn rendering_commit_info_iter<'a>( [INFO] [stderr] | -- lifetime `'a` declared here [INFO] [stderr] ... [INFO] [stderr] 742 | ) -> impl Iterator { [INFO] [stderr] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/macros.rs:16:10 [INFO] [stdout] | [INFO] [stdout] 16 | ( $c:expr ) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 16 | ( $c:expr_2021 ) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/macros.rs:22:10 [INFO] [stdout] | [INFO] [stdout] 22 | ( $c:expr, Ctrl ) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 22 | ( $c:expr_2021, Ctrl ) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/widget/commit_list.rs:742:43 [INFO] [stdout] | [INFO] [stdout] 739 | fn rendering_commit_info_iter<'a>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 742 | ) -> impl Iterator { [INFO] [stdout] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/git.rs:558:21 [INFO] [stdout] | [INFO] [stdout] 558 | let branch = if let Some(line) = reader.lines().next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/git.rs:560:5 [INFO] [stdout] | [INFO] [stdout] 560 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 558 ~ let branch = match reader.lines().next() { Some(line) => { [INFO] [stdout] 559 | line.ok() [INFO] [stdout] 560 ~ } _ => { [INFO] [stdout] 561 | None [INFO] [stdout] 562 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:246:12 [INFO] [stdout] | [INFO] [stdout] 246 | if let View::List(ref mut view) = self.view { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:265:9 [INFO] [stdout] | [INFO] [stdout] 265 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 246 ~ match self.view { View::List(ref mut view) => { [INFO] [stdout] 247 | let commit_list_state = view.take_list_state(); [INFO] [stdout] ... [INFO] [stdout] 264 | ); [INFO] [stdout] 265 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:269:12 [INFO] [stdout] | [INFO] [stdout] 269 | if let View::Detail(ref mut view) = self.view { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:272:9 [INFO] [stdout] | [INFO] [stdout] 272 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 269 ~ match self.view { View::Detail(ref mut view) => { [INFO] [stdout] 270 | let commit_list_state = view.take_list_state(); [INFO] [stdout] 271 | self.view = View::of_list(commit_list_state, self.ui_config, self.tx.clone()); [INFO] [stdout] 272 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:276:12 [INFO] [stdout] | [INFO] [stdout] 276 | if let View::Detail(ref mut view) = self.view { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:278:9 [INFO] [stdout] | [INFO] [stdout] 278 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 276 ~ match self.view { View::Detail(ref mut view) => { [INFO] [stdout] 277 | view.clear(); [INFO] [stdout] 278 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:282:12 [INFO] [stdout] | [INFO] [stdout] 282 | if let View::List(ref mut view) = self.view { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:286:9 [INFO] [stdout] | [INFO] [stdout] 286 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 282 ~ match self.view { View::List(ref mut view) => { [INFO] [stdout] 283 | let commit_list_state = view.take_list_state(); [INFO] [stdout] 284 | let refs = self.repository.all_refs().into_iter().cloned().collect(); [INFO] [stdout] 285 | self.view = View::of_refs(commit_list_state, refs, self.ui_config, self.tx.clone()); [INFO] [stdout] 286 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:290:12 [INFO] [stdout] | [INFO] [stdout] 290 | if let View::Refs(ref mut view) = self.view { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:293:9 [INFO] [stdout] | [INFO] [stdout] 293 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 290 ~ match self.view { View::Refs(ref mut view) => { [INFO] [stdout] 291 | let commit_list_state = view.take_list_state(); [INFO] [stdout] 292 | self.view = View::of_list(commit_list_state, self.ui_config, self.tx.clone()); [INFO] [stdout] 293 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:307:12 [INFO] [stdout] | [INFO] [stdout] 307 | if let View::Help(ref mut view) = self.view { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:309:9 [INFO] [stdout] | [INFO] [stdout] 309 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 307 ~ match self.view { View::Help(ref mut view) => { [INFO] [stdout] 308 | self.view = view.take_before_view(); [INFO] [stdout] 309 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:313:12 [INFO] [stdout] | [INFO] [stdout] 313 | if let View::Help(ref mut view) = self.view { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:315:9 [INFO] [stdout] | [INFO] [stdout] 315 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 313 ~ match self.view { View::Help(ref mut view) => { [INFO] [stdout] 314 | view.clear(); [INFO] [stdout] 315 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/view/refs.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 115 | if let Some(selected) = self.ref_list_state.selected_ref_name() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^-------------------^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/view/refs.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 115 ~ match self.ref_list_state.selected_ref_name() { Some(selected) => { [INFO] [stdout] 116 | self.as_mut_list_state().select_ref(&selected) [INFO] [stdout] 117 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/view/refs.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 121 | if let Some(selected) = self.ref_list_state.selected_branch() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^-------------------^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 122 | self.copy_to_clipboard("Branch Name".into(), selected); [INFO] [stdout] 123 | } else if let Some(selected) = self.ref_list_state.selected_tag() { [INFO] [stdout] | ------------------- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/view/refs.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | } else if let Some(selected) = self.ref_list_state.selected_tag() { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/view/refs.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 121 ~ match self.ref_list_state.selected_branch() { Some(selected) => { [INFO] [stdout] 122 | self.copy_to_clipboard("Branch Name".into(), selected); [INFO] [stdout] 123 ~ } _ => { match self.ref_list_state.selected_tag() { Some(selected) => { [INFO] [stdout] 124 | self.copy_to_clipboard("Tag Name".into(), selected); [INFO] [stdout] 125 ~ } _ => {}}}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `serie` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/macros.rs [INFO] [stderr] * src/widget/commit_list.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/macros.rs:16:7 [INFO] [stderr] | [INFO] [stderr] 16 | ( $c:expr_2021 ) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/macros.rs:22:7 [INFO] [stderr] | [INFO] [stderr] 22 | ( $c:expr_2021, Ctrl ) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] warning: elided lifetime has a name [INFO] [stderr] --> src/widget/commit_list.rs:742:43 [INFO] [stderr] | [INFO] [stderr] 739 | fn rendering_commit_info_iter<'a>( [INFO] [stderr] | -- lifetime `'a` declared here [INFO] [stderr] ... [INFO] [stderr] 742 | ) -> impl Iterator { [INFO] [stderr] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/macros.rs:16:10 [INFO] [stdout] | [INFO] [stdout] 16 | ( $c:expr ) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 16 | ( $c:expr_2021 ) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/macros.rs:22:10 [INFO] [stdout] | [INFO] [stdout] 22 | ( $c:expr, Ctrl ) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 22 | ( $c:expr_2021, Ctrl ) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/widget/commit_list.rs:742:43 [INFO] [stdout] | [INFO] [stdout] 739 | fn rendering_commit_info_iter<'a>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 742 | ) -> impl Iterator { [INFO] [stdout] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/git.rs:558:21 [INFO] [stdout] | [INFO] [stdout] 558 | let branch = if let Some(line) = reader.lines().next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/git.rs:560:5 [INFO] [stdout] | [INFO] [stdout] 560 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 558 ~ let branch = match reader.lines().next() { Some(line) => { [INFO] [stdout] 559 | line.ok() [INFO] [stdout] 560 ~ } _ => { [INFO] [stdout] 561 | None [INFO] [stdout] 562 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:246:12 [INFO] [stdout] | [INFO] [stdout] 246 | if let View::List(ref mut view) = self.view { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:265:9 [INFO] [stdout] | [INFO] [stdout] 265 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 246 ~ match self.view { View::List(ref mut view) => { [INFO] [stdout] 247 | let commit_list_state = view.take_list_state(); [INFO] [stdout] ... [INFO] [stdout] 264 | ); [INFO] [stdout] 265 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:269:12 [INFO] [stdout] | [INFO] [stdout] 269 | if let View::Detail(ref mut view) = self.view { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:272:9 [INFO] [stdout] | [INFO] [stdout] 272 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 269 ~ match self.view { View::Detail(ref mut view) => { [INFO] [stdout] 270 | let commit_list_state = view.take_list_state(); [INFO] [stdout] 271 | self.view = View::of_list(commit_list_state, self.ui_config, self.tx.clone()); [INFO] [stdout] 272 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:276:12 [INFO] [stdout] | [INFO] [stdout] 276 | if let View::Detail(ref mut view) = self.view { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:278:9 [INFO] [stdout] | [INFO] [stdout] 278 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 276 ~ match self.view { View::Detail(ref mut view) => { [INFO] [stdout] 277 | view.clear(); [INFO] [stdout] 278 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:282:12 [INFO] [stdout] | [INFO] [stdout] 282 | if let View::List(ref mut view) = self.view { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:286:9 [INFO] [stdout] | [INFO] [stdout] 286 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 282 ~ match self.view { View::List(ref mut view) => { [INFO] [stdout] 283 | let commit_list_state = view.take_list_state(); [INFO] [stdout] 284 | let refs = self.repository.all_refs().into_iter().cloned().collect(); [INFO] [stdout] 285 | self.view = View::of_refs(commit_list_state, refs, self.ui_config, self.tx.clone()); [INFO] [stdout] 286 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:290:12 [INFO] [stdout] | [INFO] [stdout] 290 | if let View::Refs(ref mut view) = self.view { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:293:9 [INFO] [stdout] | [INFO] [stdout] 293 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 290 ~ match self.view { View::Refs(ref mut view) => { [INFO] [stdout] 291 | let commit_list_state = view.take_list_state(); [INFO] [stdout] 292 | self.view = View::of_list(commit_list_state, self.ui_config, self.tx.clone()); [INFO] [stdout] 293 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:307:12 [INFO] [stdout] | [INFO] [stdout] 307 | if let View::Help(ref mut view) = self.view { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:309:9 [INFO] [stdout] | [INFO] [stdout] 309 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 307 ~ match self.view { View::Help(ref mut view) => { [INFO] [stdout] 308 | self.view = view.take_before_view(); [INFO] [stdout] 309 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/app.rs:313:12 [INFO] [stdout] | [INFO] [stdout] 313 | if let View::Help(ref mut view) = self.view { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/app.rs:315:9 [INFO] [stdout] | [INFO] [stdout] 315 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 313 ~ match self.view { View::Help(ref mut view) => { [INFO] [stdout] 314 | view.clear(); [INFO] [stdout] 315 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/view/refs.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 115 | if let Some(selected) = self.ref_list_state.selected_ref_name() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^-------------------^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/view/refs.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 115 ~ match self.ref_list_state.selected_ref_name() { Some(selected) => { [INFO] [stdout] 116 | self.as_mut_list_state().select_ref(&selected) [INFO] [stdout] 117 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/view/refs.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 121 | if let Some(selected) = self.ref_list_state.selected_branch() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^-------------------^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 122 | self.copy_to_clipboard("Branch Name".into(), selected); [INFO] [stdout] 123 | } else if let Some(selected) = self.ref_list_state.selected_tag() { [INFO] [stdout] | ------------------- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/view/refs.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | } else if let Some(selected) = self.ref_list_state.selected_tag() { [INFO] [stdout] | ^ [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/view/refs.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 121 ~ match self.ref_list_state.selected_branch() { Some(selected) => { [INFO] [stdout] 122 | self.copy_to_clipboard("Branch Name".into(), selected); [INFO] [stdout] 123 ~ } _ => { match self.ref_list_state.selected_tag() { Some(selected) => { [INFO] [stdout] 124 | self.copy_to_clipboard("Tag Name".into(), selected); [INFO] [stdout] 125 ~ } _ => {}}}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/graph.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 18.29s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking serie v0.4.0 (/tmp/fixit) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/widget/commit_list.rs:742:43 [INFO] [stdout] | [INFO] [stdout] 739 | fn rendering_commit_info_iter<'a>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 742 | ) -> impl Iterator { [INFO] [stdout] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/widget/commit_list.rs:742:43 [INFO] [stdout] | [INFO] [stdout] 739 | fn rendering_commit_info_iter<'a>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 742 | ) -> impl Iterator { [INFO] [stdout] | ^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.09s [INFO] running `Command { std: "docker" "inspect" "50acc2383205ee022aa53b942bbc307046e89828d2a4156072a1fec87905dbf7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "50acc2383205ee022aa53b942bbc307046e89828d2a4156072a1fec87905dbf7", kill_on_drop: false }` [INFO] [stdout] 50acc2383205ee022aa53b942bbc307046e89828d2a4156072a1fec87905dbf7