[INFO] fetching crate s3s-fs 0.10.1... [INFO] checking s3s-fs-0.10.1 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate s3s-fs 0.10.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate s3s-fs 0.10.1 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate s3s-fs 0.10.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate s3s-fs 0.10.1 [INFO] tweaked toml for crates.io crate s3s-fs 0.10.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate s3s-fs 0.10.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 22e016524833a947010eef2753bc9c8a6498917d149583d25ad851a1238792b8 [INFO] running `Command { std: "docker" "start" "-a" "22e016524833a947010eef2753bc9c8a6498917d149583d25ad851a1238792b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "22e016524833a947010eef2753bc9c8a6498917d149583d25ad851a1238792b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "22e016524833a947010eef2753bc9c8a6498917d149583d25ad851a1238792b8", kill_on_drop: false }` [INFO] [stdout] 22e016524833a947010eef2753bc9c8a6498917d149583d25ad851a1238792b8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f5f33e19a398b4ae6448a8ca1599f6b68e7803673083684e3a9953361f21ef6c [INFO] running `Command { std: "docker" "start" "-a" "f5f33e19a398b4ae6448a8ca1599f6b68e7803673083684e3a9953361f21ef6c", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking vsimd v0.8.0 [INFO] [stderr] Checking outref v0.5.1 [INFO] [stderr] Compiling cc v1.1.7 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking base16ct v0.1.1 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling crc32c v0.6.8 [INFO] [stderr] Compiling aws-types v1.3.3 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking der v0.6.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking crypto-bigint v0.4.9 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking ff v0.12.1 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking group v0.12.1 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking base64-simd v0.8.0 [INFO] [stderr] Checking bytes-utils v0.1.4 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking xmlparser v0.13.6 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking regex-lite v0.1.6 [INFO] [stderr] Checking rfc6979 v0.3.1 [INFO] [stderr] Checking aws-smithy-xml v0.60.8 [INFO] [stderr] Checking simdutf8 v0.1.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking spki v0.6.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking hex-simd v0.8.0 [INFO] [stderr] Checking pkcs8 v0.9.0 [INFO] [stderr] Checking bytestring v1.3.1 [INFO] [stderr] Checking nugine-rust-utils v0.3.1 [INFO] [stderr] Checking sec1 v0.3.0 [INFO] [stderr] Checking transform-stream v0.3.0 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking numeric_cast v0.2.1 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking elliptic-curve v0.12.3 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking object v0.36.2 [INFO] [stderr] Checking path-dedot v3.1.1 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking path-absolutize v3.1.1 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking ecdsa v0.14.8 [INFO] [stderr] Checking p256 v0.11.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking aws-smithy-async v1.2.1 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking quick-xml v0.36.1 [INFO] [stderr] Checking aws-smithy-types v1.2.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking aws-smithy-runtime-api v1.7.1 [INFO] [stderr] Checking aws-smithy-eventstream v0.60.4 [INFO] [stderr] Checking aws-smithy-json v0.60.7 [INFO] [stderr] Checking aws-smithy-query v0.60.7 [INFO] [stderr] Checking aws-smithy-types-convert v0.60.8 [INFO] [stderr] Checking s3s v0.10.1 [INFO] [stderr] Checking aws-smithy-http v0.60.9 [INFO] [stderr] Checking aws-credential-types v1.2.0 [INFO] [stderr] Checking aws-sigv4 v1.2.3 [INFO] [stderr] Checking aws-smithy-checksums v0.60.11 [INFO] [stderr] Checking aws-runtime v1.3.1 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking aws-smithy-runtime v1.6.2 [INFO] [stderr] Checking s3s-fs v0.10.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Checking aws-sdk-sts v1.36.0 [INFO] [stderr] Checking aws-sdk-s3 v1.42.0 [INFO] [stderr] Checking aws-config v1.5.4 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `s3s_fs` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/error.rs [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/error.rs:64:14 [INFO] [stdout] | [INFO] [stdout] 64 | ($result:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 64 | ($result:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/error.rs:64:6 [INFO] [stderr] | [INFO] [stderr] 64 | ($result:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/s3.rs:298:15 [INFO] [stdout] | [INFO] [stdout] 298 | while let Some(entry) = try_!(iter.next_entry().await) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | / match $result { [INFO] [stdout] 66 | | Ok(val) => val, [INFO] [stdout] 67 | | Err(err) => { [INFO] [stdout] 68 | | $crate::error::log(&err); [INFO] [stdout] 69 | | return Err(::s3s::S3Error::internal_error(err)); [INFO] [stdout] 70 | | } [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/s3.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 321 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/s3.rs:360:19 [INFO] [stdout] | [INFO] [stdout] 360 | while let Some(entry) = try_!(iter.next_entry().await) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | / match $result { [INFO] [stdout] 66 | | Ok(val) => val, [INFO] [stdout] 67 | | Err(err) => { [INFO] [stdout] 68 | | $crate::error::log(&err); [INFO] [stdout] 69 | | return Err(::s3s::S3Error::internal_error(err)); [INFO] [stdout] 70 | | } [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/s3.rs:395:13 [INFO] [stdout] | [INFO] [stdout] 395 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/s3.rs:605:31 [INFO] [stdout] | [INFO] [stdout] 605 | let (start, end) = if let Some(copy_range) = &input.copy_source_range { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^-----^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/s3.rs:621:9 [INFO] [stdout] | [INFO] [stdout] 621 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 605 ~ let (start, end) = match &input.copy_source_range { Some(copy_range) => { [INFO] [stdout] 606 | if !copy_range.starts_with("bytes=") { [INFO] [stdout] ... [INFO] [stdout] 620 | (start, end) [INFO] [stdout] 621 ~ } _ => { [INFO] [stdout] 622 | (0, file_len - 1) [INFO] [stdout] 623 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/s3.rs:664:15 [INFO] [stdout] | [INFO] [stdout] 664 | while let Some(entry) = try_!(iter.next_entry().await) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | / match $result { [INFO] [stdout] 66 | | Ok(val) => val, [INFO] [stdout] 67 | | Err(err) => { [INFO] [stdout] 68 | | $crate::error::log(&err); [INFO] [stdout] 69 | | return Err(::s3s::S3Error::internal_error(err)); [INFO] [stdout] 70 | | } [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/s3.rs:688:9 [INFO] [stdout] | [INFO] [stdout] 688 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/s3.rs:782:15 [INFO] [stdout] | [INFO] [stdout] 782 | while let Some(entry) = try_!(iter.next_entry().await) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | / match $result { [INFO] [stdout] 66 | | Ok(val) => val, [INFO] [stdout] 67 | | Err(err) => { [INFO] [stdout] 68 | | $crate::error::log(&err); [INFO] [stdout] 69 | | return Err(::s3s::S3Error::internal_error(err)); [INFO] [stdout] 70 | | } [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/s3.rs:794:9 [INFO] [stdout] | [INFO] [stdout] 794 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/utils.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 19 | while let Some(result) = stream.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/utils.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/utils.rs:39:15 [INFO] [stdout] | [INFO] [stdout] 39 | while let Some(result) = stream.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/utils.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking s3s-aws v0.10.1 [INFO] [stderr] Migrating tests/it_aws.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `it_aws` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * tests/it_aws.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> tests/it_aws.rs:116:6 [INFO] [stderr] | [INFO] [stderr] 116 | ($result:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> tests/it_aws.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | unsafe { env::set_var("RUST_LOG", "it_aws=debug,s3s_fs=debug,s3s=debug") }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> tests/it_aws.rs:115:14 [INFO] [stdout] | [INFO] [stdout] 115 | ($result:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 115 | ($result:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] note: the lint level is defined here [INFO] [stderr] --> tests/it_aws.rs:1:11 [INFO] [stderr] | [INFO] [stderr] 1 | #![forbid(unsafe_code)] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> tests/it_aws.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | env::set_var("RUST_LOG", "it_aws=debug,s3s_fs=debug,s3s=debug"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 42 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 43 ~ unsafe { env::set_var("RUST_LOG", "it_aws=debug,s3s_fs=debug,s3s=debug") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `s3s_fs` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/error.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/error.rs:64:6 [INFO] [stderr] | [INFO] [stderr] 64 | ($result:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/error.rs:64:14 [INFO] [stdout] | [INFO] [stdout] 64 | ($result:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 64 | ($result:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/s3.rs:298:15 [INFO] [stdout] | [INFO] [stdout] 298 | while let Some(entry) = try_!(iter.next_entry().await) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | / match $result { [INFO] [stdout] 66 | | Ok(val) => val, [INFO] [stdout] 67 | | Err(err) => { [INFO] [stdout] 68 | | $crate::error::log(&err); [INFO] [stdout] 69 | | return Err(::s3s::S3Error::internal_error(err)); [INFO] [stdout] 70 | | } [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/s3.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 321 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/s3.rs:360:19 [INFO] [stdout] | [INFO] [stdout] 360 | while let Some(entry) = try_!(iter.next_entry().await) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | / match $result { [INFO] [stdout] 66 | | Ok(val) => val, [INFO] [stdout] 67 | | Err(err) => { [INFO] [stdout] 68 | | $crate::error::log(&err); [INFO] [stdout] 69 | | return Err(::s3s::S3Error::internal_error(err)); [INFO] [stdout] 70 | | } [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/s3.rs:395:13 [INFO] [stdout] | [INFO] [stdout] 395 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/s3.rs:605:31 [INFO] [stdout] | [INFO] [stdout] 605 | let (start, end) = if let Some(copy_range) = &input.copy_source_range { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^-----^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/s3.rs:621:9 [INFO] [stdout] | [INFO] [stdout] 621 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 605 ~ let (start, end) = match &input.copy_source_range { Some(copy_range) => { [INFO] [stdout] 606 | if !copy_range.starts_with("bytes=") { [INFO] [stdout] ... [INFO] [stdout] 620 | (start, end) [INFO] [stdout] 621 ~ } _ => { [INFO] [stdout] 622 | (0, file_len - 1) [INFO] [stdout] 623 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/s3.rs:664:15 [INFO] [stdout] | [INFO] [stdout] 664 | while let Some(entry) = try_!(iter.next_entry().await) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | / match $result { [INFO] [stdout] 66 | | Ok(val) => val, [INFO] [stdout] 67 | | Err(err) => { [INFO] [stdout] 68 | | $crate::error::log(&err); [INFO] [stdout] 69 | | return Err(::s3s::S3Error::internal_error(err)); [INFO] [stdout] 70 | | } [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/s3.rs:688:9 [INFO] [stdout] | [INFO] [stdout] 688 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/s3.rs:782:15 [INFO] [stdout] | [INFO] [stdout] 782 | while let Some(entry) = try_!(iter.next_entry().await) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | / match $result { [INFO] [stdout] 66 | | Ok(val) => val, [INFO] [stdout] 67 | | Err(err) => { [INFO] [stdout] 68 | | $crate::error::log(&err); [INFO] [stdout] 69 | | return Err(::s3s::S3Error::internal_error(err)); [INFO] [stdout] 70 | | } [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________- this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/s3.rs:794:9 [INFO] [stdout] | [INFO] [stdout] 794 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/utils.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 19 | while let Some(result) = stream.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/utils.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/utils.rs:39:15 [INFO] [stdout] | [INFO] [stdout] 39 | while let Some(result) = stream.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/utils.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 31.30s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking s3s-fs v0.10.1 (/tmp/fixit) [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> tests/it_aws.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | env::set_var("RUST_LOG", "it_aws=debug,s3s_fs=debug,s3s=debug"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `s3s-fs` (test "it_aws") due to 2 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "f5f33e19a398b4ae6448a8ca1599f6b68e7803673083684e3a9953361f21ef6c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5f33e19a398b4ae6448a8ca1599f6b68e7803673083684e3a9953361f21ef6c", kill_on_drop: false }` [INFO] [stdout] f5f33e19a398b4ae6448a8ca1599f6b68e7803673083684e3a9953361f21ef6c