[INFO] fetching crate s3s 0.10.1... [INFO] checking s3s-0.10.1 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate s3s 0.10.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate s3s 0.10.1 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate s3s 0.10.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate s3s 0.10.1 [INFO] tweaked toml for crates.io crate s3s 0.10.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 125 packages to latest compatible versions [INFO] [stderr] Adding foreign-types v0.3.2 (available: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (available: v0.3.1) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding tower v0.4.13 (available: v0.5.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 464347b395587a060128b835dce9d3251e4efbd86169b84f0636c1f92a3f8ceb [INFO] running `Command { std: "docker" "start" "-a" "464347b395587a060128b835dce9d3251e4efbd86169b84f0636c1f92a3f8ceb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "464347b395587a060128b835dce9d3251e4efbd86169b84f0636c1f92a3f8ceb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "464347b395587a060128b835dce9d3251e4efbd86169b84f0636c1f92a3f8ceb", kill_on_drop: false }` [INFO] [stdout] 464347b395587a060128b835dce9d3251e4efbd86169b84f0636c1f92a3f8ceb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 69b68d80aee38c15253f6b1b40393aed376a8cd012b8a3e380e70b246028ad2a [INFO] running `Command { std: "docker" "start" "-a" "69b68d80aee38c15253f6b1b40393aed376a8cd012b8a3e380e70b246028ad2a", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking vsimd v0.8.0 [INFO] [stderr] Checking outref v0.5.1 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling crc32c v0.6.8 [INFO] [stderr] Checking cpufeatures v0.2.14 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking simdutf8 v0.1.5 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking bytestring v1.3.1 [INFO] [stderr] Checking nugine-rust-utils v0.3.1 [INFO] [stderr] Checking transform-stream v0.3.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking numeric_cast v0.2.1 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking base64-simd v0.8.0 [INFO] [stderr] Checking hex-simd v0.8.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking quick-xml v0.36.2 [INFO] [stderr] Checking s3s v0.10.1 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `s3s` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/error/mod.rs [INFO] [stderr] * src/sig_v4/amz_date.rs [INFO] [stderr] * src/utils/mod.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/http/multipart.rs:254:18 [INFO] [stdout] | [INFO] [stdout] 254 | async fn gen( [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/utils/mod.rs:30:6 [INFO] [stderr] | [INFO] [stderr] 30 | ($source:expr_2021, $($arg:tt)+) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/error/mod.rs:197:6 [INFO] [stderr] | [INFO] [stderr] 197 | ($source:expr_2021, $code:ident) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/error/mod.rs:202:6 [INFO] [stderr] | [INFO] [stderr] 202 | ($source:expr_2021, $code:ident, $($arg:tt)+) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/sig_v4/amz_date.rs:71:10 [INFO] [stderr] | [INFO] [stderr] 71 | ($cond:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/http/multipart.rs:342:26 [INFO] [stdout] | [INFO] [stdout] 342 | Box::pin(gen(y, body, crlf_pat, prev_bytes)) [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/utils/mod.rs:30:14 [INFO] [stdout] | [INFO] [stdout] 30 | ($source:expr, $($arg:tt)+) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 30 | ($source:expr_2021, $($arg:tt)+) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/error/mod.rs:197:14 [INFO] [stdout] | [INFO] [stdout] 197 | ($source:expr, $code:ident) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 197 | ($source:expr_2021, $code:ident) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/error/mod.rs:202:14 [INFO] [stdout] | [INFO] [stdout] 202 | ($source:expr, $code:ident, $($arg:tt)+) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 202 | ($source:expr_2021, $code:ident, $($arg:tt)+) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/sig_v4/amz_date.rs:71:16 [INFO] [stdout] | [INFO] [stdout] 71 | ($cond:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 71 | ($cond:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl AsRef<[u8; 32]>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/utils/crypto.rs:45:27 [INFO] [stdout] | [INFO] [stdout] 45 | fn sha256(data: &[u8]) -> impl AsRef<[u8; 32]> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/utils/crypto.rs:45:17 [INFO] [stdout] | [INFO] [stdout] 45 | fn sha256(data: &[u8]) -> impl AsRef<[u8; 32]> { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 45 | fn sha256(data: &[u8]) -> impl AsRef<[u8; 32]> + use<> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl AsRef<[u8; 32]>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/utils/crypto.rs:59:37 [INFO] [stdout] | [INFO] [stdout] 59 | fn sha256_chunk(chunk: &[Bytes]) -> impl AsRef<[u8; 32]> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/utils/crypto.rs:59:24 [INFO] [stdout] | [INFO] [stdout] 59 | fn sha256_chunk(chunk: &[Bytes]) -> impl AsRef<[u8; 32]> { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 59 | fn sha256_chunk(chunk: &[Bytes]) -> impl AsRef<[u8; 32]> + use<> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl Iterator` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/http/ordered_qs.rs:48:42 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn get_all(&self, name: &str) -> impl Iterator { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/http/ordered_qs.rs:48:33 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn get_all(&self, name: &str) -> impl Iterator { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 48 | pub fn get_all(&self, name: &str) -> impl Iterator + use<'_> { [INFO] [stdout] | +++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl Iterator + '_` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/http/ordered_headers.rs:49:44 [INFO] [stdout] | [INFO] [stdout] 49 | fn get_all_pairs(&self, name: &str) -> impl Iterator + '_ { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/http/ordered_headers.rs:49:35 [INFO] [stdout] | [INFO] [stdout] 49 | fn get_all_pairs(&self, name: &str) -> impl Iterator + '_ { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 49 | fn get_all_pairs(&self, name: &str) -> impl Iterator + '_ + use<'a, '_> { [INFO] [stdout] | +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/http/aws_chunked_stream.rs:200:24 [INFO] [stdout] | [INFO] [stdout] 200 | if let Some(remaining_bytes) = push_meta_bytes(bytes) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/http/aws_chunked_stream.rs:202:21 [INFO] [stdout] | [INFO] [stdout] 202 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 200 ~ match push_meta_bytes(bytes) { Some(remaining_bytes) => { [INFO] [stdout] 201 | return Some(Ok(remaining_bytes)); [INFO] [stdout] 202 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/http/aws_chunked_stream.rs:243:28 [INFO] [stdout] | [INFO] [stdout] 243 | if let Some(remaining_bytes) = push_data_bytes(bytes) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/http/aws_chunked_stream.rs:245:25 [INFO] [stdout] | [INFO] [stdout] 245 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 243 ~ match push_data_bytes(bytes) { Some(remaining_bytes) => { [INFO] [stdout] 244 | break 'outer remaining_bytes; [INFO] [stdout] 245 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/http/multipart.rs:268:16 [INFO] [stdout] | [INFO] [stdout] 268 | if let Some(b) = prev_bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/http/multipart.rs:271:13 [INFO] [stdout] | [INFO] [stdout] 271 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 268 ~ match prev_bytes { Some(b) => { [INFO] [stdout] 269 | state = 2; [INFO] [stdout] 270 | bytes = b; [INFO] [stdout] 271 ~ } _ => { [INFO] [stdout] 272 | state = 1; [INFO] [stdout] 273 | bytes = Bytes::new(); [INFO] [stdout] 274 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/ops/mod.rs:315:12 [INFO] [stdout] | [INFO] [stdout] 315 | if let Some(qs) = req.s3ext.qs.as_ref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/ops/mod.rs:319:9 [INFO] [stdout] | [INFO] [stdout] 319 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 315 ~ match req.s3ext.qs.as_ref() { Some(qs) => { [INFO] [stdout] 316 | if qs.has("events") { [INFO] [stdout] 317 | return Err(s3_error!(NotImplemented, "listenBucketNotification only works on MinIO")); [INFO] [stdout] 318 | } [INFO] [stdout] 319 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/ops/get_object.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | if let Some(val) = resp.headers.get(TRANSFER_ENCODING) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^------------^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/ops/get_object.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 53 ~ match resp.headers.get(TRANSFER_ENCODING) { Some(val) => { [INFO] [stdout] 54 | if val.as_bytes() == b"chunked" { [INFO] [stdout] 55 | resp.headers.remove(CONTENT_LENGTH); [INFO] [stdout] 56 | } [INFO] [stdout] 57 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/stream.rs:142:11 [INFO] [stdout] | [INFO] [stdout] 142 | while let Some(result) = stream.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/stream.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/dto.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `s3s` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/error/mod.rs [INFO] [stderr] * src/ops/tests.rs [INFO] [stderr] * src/sig_v4/amz_date.rs [INFO] [stderr] * src/utils/mod.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/utils/mod.rs:30:6 [INFO] [stderr] | [INFO] [stderr] 30 | ($source:expr_2021, $($arg:tt)+) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/http/multipart.rs:254:18 [INFO] [stdout] | [INFO] [stdout] 254 | async fn gen( [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/error/mod.rs:197:6 [INFO] [stderr] | [INFO] [stderr] 197 | ($source:expr_2021, $code:ident) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/http/multipart.rs:342:26 [INFO] [stdout] | [INFO] [stdout] 342 | Box::pin(gen(y, body, crlf_pat, prev_bytes)) [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] --> src/error/mod.rs:202:6 [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/utils/mod.rs:30:14 [INFO] [stdout] | [INFO] [stdout] 30 | ($source:expr, $($arg:tt)+) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 30 | ($source:expr_2021, $($arg:tt)+) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | [INFO] [stderr] 202 | ($source:expr_2021, $code:ident, $($arg:tt)+) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/error/mod.rs:197:14 [INFO] [stdout] | [INFO] [stdout] 197 | ($source:expr, $code:ident) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 197 | ($source:expr_2021, $code:ident) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/sig_v4/amz_date.rs:71:10 [INFO] [stderr] | [INFO] [stderr] 71 | ($cond:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/ops/tests.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | ($f:path, $v:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/error/mod.rs:202:14 [INFO] [stdout] | [INFO] [stdout] 202 | ($source:expr, $code:ident, $($arg:tt)+) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 202 | ($source:expr_2021, $code:ident, $($arg:tt)+) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/ops/tests.rs:11:22 [INFO] [stdout] | [INFO] [stdout] 11 | ($f:path, $v:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 11 | ($f:path, $v:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/sig_v4/amz_date.rs:71:16 [INFO] [stdout] | [INFO] [stdout] 71 | ($cond:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 71 | ($cond:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl AsRef<[u8; 32]>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/utils/crypto.rs:45:27 [INFO] [stdout] | [INFO] [stdout] 45 | fn sha256(data: &[u8]) -> impl AsRef<[u8; 32]> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/utils/crypto.rs:45:17 [INFO] [stdout] | [INFO] [stdout] 45 | fn sha256(data: &[u8]) -> impl AsRef<[u8; 32]> { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 45 | fn sha256(data: &[u8]) -> impl AsRef<[u8; 32]> + use<> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl AsRef<[u8; 32]>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/utils/crypto.rs:59:37 [INFO] [stdout] | [INFO] [stdout] 59 | fn sha256_chunk(chunk: &[Bytes]) -> impl AsRef<[u8; 32]> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/utils/crypto.rs:59:24 [INFO] [stdout] | [INFO] [stdout] 59 | fn sha256_chunk(chunk: &[Bytes]) -> impl AsRef<[u8; 32]> { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 59 | fn sha256_chunk(chunk: &[Bytes]) -> impl AsRef<[u8; 32]> + use<> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl Iterator` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/http/ordered_qs.rs:48:42 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn get_all(&self, name: &str) -> impl Iterator { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/http/ordered_qs.rs:48:33 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn get_all(&self, name: &str) -> impl Iterator { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 48 | pub fn get_all(&self, name: &str) -> impl Iterator + use<'_> { [INFO] [stdout] | +++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl Iterator + '_` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/http/ordered_headers.rs:49:44 [INFO] [stdout] | [INFO] [stdout] 49 | fn get_all_pairs(&self, name: &str) -> impl Iterator + '_ { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/http/ordered_headers.rs:49:35 [INFO] [stdout] | [INFO] [stdout] 49 | fn get_all_pairs(&self, name: &str) -> impl Iterator + '_ { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 49 | fn get_all_pairs(&self, name: &str) -> impl Iterator + '_ + use<'a, '_> { [INFO] [stdout] | +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/http/aws_chunked_stream.rs:200:24 [INFO] [stdout] | [INFO] [stdout] 200 | if let Some(remaining_bytes) = push_meta_bytes(bytes) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/http/aws_chunked_stream.rs:202:21 [INFO] [stdout] | [INFO] [stdout] 202 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 200 ~ match push_meta_bytes(bytes) { Some(remaining_bytes) => { [INFO] [stdout] 201 | return Some(Ok(remaining_bytes)); [INFO] [stdout] 202 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/http/aws_chunked_stream.rs:243:28 [INFO] [stdout] | [INFO] [stdout] 243 | if let Some(remaining_bytes) = push_data_bytes(bytes) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/http/aws_chunked_stream.rs:245:25 [INFO] [stdout] | [INFO] [stdout] 245 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 243 ~ match push_data_bytes(bytes) { Some(remaining_bytes) => { [INFO] [stdout] 244 | break 'outer remaining_bytes; [INFO] [stdout] 245 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/http/multipart.rs:268:16 [INFO] [stdout] | [INFO] [stdout] 268 | if let Some(b) = prev_bytes { [INFO] [stdout] | ^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/http/multipart.rs:271:13 [INFO] [stdout] | [INFO] [stdout] 271 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 268 ~ match prev_bytes { Some(b) => { [INFO] [stdout] 269 | state = 2; [INFO] [stdout] 270 | bytes = b; [INFO] [stdout] 271 ~ } _ => { [INFO] [stdout] 272 | state = 1; [INFO] [stdout] 273 | bytes = Bytes::new(); [INFO] [stdout] 274 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/http/multipart.rs:465:15 [INFO] [stdout] | [INFO] [stdout] 465 | while let Some(bytes) = file_stream.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/http/multipart.rs:467:9 [INFO] [stdout] | [INFO] [stdout] 467 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/ops/mod.rs:315:12 [INFO] [stdout] | [INFO] [stdout] 315 | if let Some(qs) = req.s3ext.qs.as_ref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^---------^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/ops/mod.rs:319:9 [INFO] [stdout] | [INFO] [stdout] 319 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 315 ~ match req.s3ext.qs.as_ref() { Some(qs) => { [INFO] [stdout] 316 | if qs.has("events") { [INFO] [stdout] 317 | return Err(s3_error!(NotImplemented, "listenBucketNotification only works on MinIO")); [INFO] [stdout] 318 | } [INFO] [stdout] 319 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/ops/get_object.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | if let Some(val) = resp.headers.get(TRANSFER_ENCODING) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^------------^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/ops/get_object.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 53 ~ match resp.headers.get(TRANSFER_ENCODING) { Some(val) => { [INFO] [stdout] 54 | if val.as_bytes() == b"chunked" { [INFO] [stdout] 55 | resp.headers.remove(CONTENT_LENGTH); [INFO] [stdout] 56 | } [INFO] [stdout] 57 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/stream.rs:142:11 [INFO] [stdout] | [INFO] [stdout] 142 | while let Some(result) = stream.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/stream.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 20.51s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking s3s v0.10.1 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/http/multipart.rs:254:18 [INFO] [stdout] | [INFO] [stdout] 254 | async fn gen( [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/http/multipart.rs:254:18 [INFO] [stdout] | [INFO] [stdout] 254 | async fn gen( [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected expression, found reserved keyword `gen` [INFO] [stdout] --> src/http/multipart.rs:342:26 [INFO] [stdout] | [INFO] [stdout] 342 | Box::pin(gen(y, body, crlf_pat, prev_bytes)) [INFO] [stdout] | ^^^ expected expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected expression, found reserved keyword `gen` [INFO] [stdout] --> src/http/multipart.rs:342:26 [INFO] [stdout] | [INFO] [stdout] 342 | Box::pin(gen(y, body, crlf_pat, prev_bytes)) [INFO] [stdout] | ^^^ expected expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `name` does not live long enough [INFO] [stdout] --> src/http/ordered_headers.rs:59:28 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn get_all(&self, name: impl AsRef) -> impl Iterator + '_ { [INFO] [stdout] | - ---- binding `name` declared here [INFO] [stdout] | | [INFO] [stdout] | let's call the lifetime of this reference `'1` [INFO] [stdout] 59 | self.get_all_pairs(name.as_ref()).map(|x| x.1) [INFO] [stdout] | -------------------^^^^---------- [INFO] [stdout] | | | [INFO] [stdout] | | borrowed value does not live long enough [INFO] [stdout] | argument requires that `name` is borrowed for `'1` [INFO] [stdout] 60 | } [INFO] [stdout] | - `name` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0311]: the parameter type `impl AsRef` may not live long enough [INFO] [stdout] --> src/http/ordered_headers.rs:59:28 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn get_all(&self, name: impl AsRef) -> impl Iterator + '_ { [INFO] [stdout] | ----- the parameter type `impl AsRef` must be valid for the anonymous lifetime defined here... [INFO] [stdout] 59 | self.get_all_pairs(name.as_ref()).map(|x| x.1) [INFO] [stdout] | ^^^^^^^^^^^^^ ...so that the type `impl AsRef` will meet its required lifetime bounds [INFO] [stdout] | [INFO] [stdout] help: consider adding an explicit lifetime bound [INFO] [stdout] | [INFO] [stdout] 58 | pub fn get_all<'b>(&'b self, name: impl AsRef + 'b) -> impl Iterator + 'b { [INFO] [stdout] | ++++ ++ ++++ ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0597]: `name` does not live long enough [INFO] [stdout] --> src/http/ordered_headers.rs:59:28 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn get_all(&self, name: impl AsRef) -> impl Iterator + '_ { [INFO] [stdout] | - ---- binding `name` declared here [INFO] [stdout] | | [INFO] [stdout] | let's call the lifetime of this reference `'1` [INFO] [stdout] 59 | self.get_all_pairs(name.as_ref()).map(|x| x.1) [INFO] [stdout] | -------------------^^^^---------- [INFO] [stdout] | | | [INFO] [stdout] | | borrowed value does not live long enough [INFO] [stdout] | argument requires that `name` is borrowed for `'1` [INFO] [stdout] 60 | } [INFO] [stdout] | - `name` dropped here while still borrowed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0311]: the parameter type `impl AsRef` may not live long enough [INFO] [stdout] --> src/http/ordered_headers.rs:59:28 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn get_all(&self, name: impl AsRef) -> impl Iterator + '_ { [INFO] [stdout] | ----- the parameter type `impl AsRef` must be valid for the anonymous lifetime defined here... [INFO] [stdout] 59 | self.get_all_pairs(name.as_ref()).map(|x| x.1) [INFO] [stdout] | ^^^^^^^^^^^^^ ...so that the type `impl AsRef` will meet its required lifetime bounds [INFO] [stdout] | [INFO] [stdout] help: consider adding an explicit lifetime bound [INFO] [stdout] | [INFO] [stdout] 58 | pub fn get_all<'b>(&'b self, name: impl AsRef + 'b) -> impl Iterator + 'b { [INFO] [stdout] | ++++ ++ ++++ ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] Some errors have detailed explanations: E0311, E0597. [INFO] [stdout] [INFO] [stdout] For more information about an error, try `rustc --explain E0311`. [INFO] [stdout] [INFO] [stderr] error: could not compile `s3s` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] Some errors have detailed explanations: E0311, E0597. [INFO] [stdout] [INFO] [stdout] For more information about an error, try `rustc --explain E0311`. [INFO] [stdout] [INFO] [stderr] error: could not compile `s3s` (lib test) due to 5 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "69b68d80aee38c15253f6b1b40393aed376a8cd012b8a3e380e70b246028ad2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "69b68d80aee38c15253f6b1b40393aed376a8cd012b8a3e380e70b246028ad2a", kill_on_drop: false }` [INFO] [stdout] 69b68d80aee38c15253f6b1b40393aed376a8cd012b8a3e380e70b246028ad2a