[INFO] fetching crate s390_pv 0.10.0... [INFO] checking s390_pv-0.10.0 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate s390_pv 0.10.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate s390_pv 0.10.0 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate s390_pv 0.10.0 [INFO] finished tweaking crates.io crate s390_pv 0.10.0 [INFO] tweaked toml for crates.io crate s390_pv 0.10.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 44 packages to latest compatible versions [INFO] [stderr] Adding foreign-types v0.3.2 (available: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (available: v0.3.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1d3146711f82bb2b5a62627c93f684d5d74fe7f4df564b34a473d4910e3f3705 [INFO] running `Command { std: "docker" "start" "-a" "1d3146711f82bb2b5a62627c93f684d5d74fe7f4df564b34a473d4910e3f3705", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1d3146711f82bb2b5a62627c93f684d5d74fe7f4df564b34a473d4910e3f3705", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d3146711f82bb2b5a62627c93f684d5d74fe7f4df564b34a473d4910e3f3705", kill_on_drop: false }` [INFO] [stdout] 1d3146711f82bb2b5a62627c93f684d5d74fe7f4df564b34a473d4910e3f3705 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 40ac2fb2f696961e70239afa657ec5a40e2775cdd3b4b3a3484dbe60f04911c0 [INFO] running `Command { std: "docker" "start" "-a" "40ac2fb2f696961e70239afa657ec5a40e2775cdd3b4b3a3484dbe60f04911c0", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling curl v0.4.46 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling curl-sys v0.4.76+curl-8.10.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking openssl v0.10.66 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking s390_pv_core v0.10.0 [INFO] [stderr] Checking serde_test v1.0.177 [INFO] [stderr] Checking s390_pv v0.10.0 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `s390_pv` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/test_utils.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/test_utils.rs:27:6 [INFO] [stderr] | [INFO] [stderr] 27 | ($file:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/openssl_extensions/akid.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | extern "C" { [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | _____help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | | [INFO] [stdout] 13 | | pub fn X509_check_akid( [INFO] [stdout] 14 | | issuer: *const openssl_sys::X509, [INFO] [stdout] 15 | | akid: *const openssl_sys::AUTHORITY_KEYID, [INFO] [stdout] 16 | | ) -> super::c_int; [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] = note: `--force-warn missing-unsafe-on-extern` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/openssl_extensions/crl.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | extern "C" { [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | _____help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | | [INFO] [stdout] 24 | | pub fn X509_STORE_CTX_get1_crls( [INFO] [stdout] 25 | | ctx: *mut openssl_sys::X509_STORE_CTX, [INFO] [stdout] 26 | | nm: *mut openssl_sys::X509_NAME, [INFO] [stdout] ... | [INFO] [stdout] 31 | | ) -> std::ffi::c_int; [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/test_utils.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | ($file:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 27 | ($file:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/verify.rs:123:16 [INFO] [stdout] | [INFO] [stdout] 123 | if let Ok(locality_ordered_subject) = helper::reorder_x509_names(&locality_subject) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/verify.rs:128:13 [INFO] [stdout] | [INFO] [stdout] 128 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 123 ~ match helper::reorder_x509_names(&locality_subject) { Ok(locality_ordered_subject) => { [INFO] [stdout] 124 | match ctx.crls(&locality_ordered_subject) { [INFO] [stdout] ... [INFO] [stdout] 127 | } [INFO] [stdout] 128 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/verify.rs:156:16 [INFO] [stdout] | [INFO] [stdout] 156 | if let Some(crl) = download_first_crl_from_x509(hkd)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^---------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/verify.rs:158:13 [INFO] [stdout] | [INFO] [stdout] 158 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 156 ~ match download_first_crl_from_x509(hkd)? { Some(crl) => { [INFO] [stdout] 157 | crl.into_iter().try_for_each(|c| crls.push(c.into()))?; [INFO] [stdout] 158 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/verify.rs:193:24 [INFO] [stdout] | [INFO] [stdout] 193 | if let Some(crl) = download_first_crl_from_x509(c)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/verify.rs:195:21 [INFO] [stdout] | [INFO] [stdout] 195 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 193 ~ match download_first_crl_from_x509(c)? { Some(crl) => { [INFO] [stdout] 194 | crl.iter().try_for_each(|c| store.add_crl(c))?; [INFO] [stdout] 195 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/cert_verifier.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `s390_pv` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/test_utils.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/test_utils.rs:27:6 [INFO] [stderr] | [INFO] [stderr] 27 | ($file:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/openssl_extensions/akid.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | extern "C" { [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | _____help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | | [INFO] [stdout] 13 | | pub fn X509_check_akid( [INFO] [stdout] 14 | | issuer: *const openssl_sys::X509, [INFO] [stdout] 15 | | akid: *const openssl_sys::AUTHORITY_KEYID, [INFO] [stdout] 16 | | ) -> super::c_int; [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] = note: `--force-warn missing-unsafe-on-extern` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: extern blocks should be unsafe [INFO] [stdout] --> src/openssl_extensions/crl.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | extern "C" { [INFO] [stdout] | ^ [INFO] [stdout] | | [INFO] [stdout] | _____help: needs `unsafe` before the extern keyword: `unsafe` [INFO] [stdout] | | [INFO] [stdout] 24 | | pub fn X509_STORE_CTX_get1_crls( [INFO] [stdout] 25 | | ctx: *mut openssl_sys::X509_STORE_CTX, [INFO] [stdout] 26 | | nm: *mut openssl_sys::X509_NAME, [INFO] [stdout] ... | [INFO] [stdout] 31 | | ) -> std::ffi::c_int; [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #123743 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/test_utils.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | ($file:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 27 | ($file:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/verify.rs:123:16 [INFO] [stdout] | [INFO] [stdout] 123 | if let Ok(locality_ordered_subject) = helper::reorder_x509_names(&locality_subject) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/verify.rs:128:13 [INFO] [stdout] | [INFO] [stdout] 128 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 123 ~ match helper::reorder_x509_names(&locality_subject) { Ok(locality_ordered_subject) => { [INFO] [stdout] 124 | match ctx.crls(&locality_ordered_subject) { [INFO] [stdout] ... [INFO] [stdout] 127 | } [INFO] [stdout] 128 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/verify.rs:156:16 [INFO] [stdout] | [INFO] [stdout] 156 | if let Some(crl) = download_first_crl_from_x509(hkd)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^---------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/verify.rs:158:13 [INFO] [stdout] | [INFO] [stdout] 158 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 156 ~ match download_first_crl_from_x509(hkd)? { Some(crl) => { [INFO] [stdout] 157 | crl.into_iter().try_for_each(|c| crls.push(c.into()))?; [INFO] [stdout] 158 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/verify.rs:193:24 [INFO] [stdout] | [INFO] [stdout] 193 | if let Some(crl) = download_first_crl_from_x509(c)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/verify.rs:195:21 [INFO] [stdout] | [INFO] [stdout] 195 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 193 ~ match download_first_crl_from_x509(c)? { Some(crl) => { [INFO] [stdout] 194 | crl.iter().try_for_each(|c| store.add_crl(c))?; [INFO] [stdout] 195 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/verify/test.rs:23:27 [INFO] [stdout] | [INFO] [stdout] 23 | let crls = if let Ok(buf) = mock_download(&path) { [INFO] [stdout] | ^^^^^^^^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/verify/test.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 23 ~ let crls = match mock_download(&path) { Ok(buf) => { [INFO] [stdout] 24 | buf [INFO] [stdout] 25 ~ } _ => { [INFO] [stdout] 26 | continue; [INFO] [stdout] 27 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/add_secret_request.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.30s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking s390_pv v0.10.0 (/tmp/fixit) [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/openssl_extensions/akid.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / extern "C" { [INFO] [stdout] 13 | | pub fn X509_check_akid( [INFO] [stdout] 14 | | issuer: *const openssl_sys::X509, [INFO] [stdout] 15 | | akid: *const openssl_sys::AUTHORITY_KEYID, [INFO] [stdout] 16 | | ) -> super::c_int; [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/openssl_extensions/crl.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / extern "C" { [INFO] [stdout] 24 | | pub fn X509_STORE_CTX_get1_crls( [INFO] [stdout] 25 | | ctx: *mut openssl_sys::X509_STORE_CTX, [INFO] [stdout] 26 | | nm: *mut openssl_sys::X509_NAME, [INFO] [stdout] ... | [INFO] [stdout] 31 | | ) -> std::ffi::c_int; [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/openssl_extensions/akid.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / extern "C" { [INFO] [stdout] 13 | | pub fn X509_check_akid( [INFO] [stdout] 14 | | issuer: *const openssl_sys::X509, [INFO] [stdout] 15 | | akid: *const openssl_sys::AUTHORITY_KEYID, [INFO] [stdout] 16 | | ) -> super::c_int; [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: extern blocks must be unsafe [INFO] [stdout] --> src/openssl_extensions/crl.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / extern "C" { [INFO] [stdout] 24 | | pub fn X509_STORE_CTX_get1_crls( [INFO] [stdout] 25 | | ctx: *mut openssl_sys::X509_STORE_CTX, [INFO] [stdout] 26 | | nm: *mut openssl_sys::X509_NAME, [INFO] [stdout] ... | [INFO] [stdout] 31 | | ) -> std::ffi::c_int; [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `s390_pv` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `s390_pv` (lib test) due to 3 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "40ac2fb2f696961e70239afa657ec5a40e2775cdd3b4b3a3484dbe60f04911c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "40ac2fb2f696961e70239afa657ec5a40e2775cdd3b4b3a3484dbe60f04911c0", kill_on_drop: false }` [INFO] [stdout] 40ac2fb2f696961e70239afa657ec5a40e2775cdd3b4b3a3484dbe60f04911c0