[INFO] fetching crate rust-parallel 1.18.1... [INFO] checking rust-parallel-1.18.1 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate rust-parallel 1.18.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate rust-parallel 1.18.1 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rust-parallel 1.18.1 [INFO] finished tweaking crates.io crate rust-parallel 1.18.1 [INFO] tweaked toml for crates.io crate rust-parallel 1.18.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate rust-parallel 1.18.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f2471907a68a778efbaab91a39e54ef0653851a84ad114158c7b4b1faf9b3be3 [INFO] running `Command { std: "docker" "start" "-a" "f2471907a68a778efbaab91a39e54ef0653851a84ad114158c7b4b1faf9b3be3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f2471907a68a778efbaab91a39e54ef0653851a84ad114158c7b4b1faf9b3be3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f2471907a68a778efbaab91a39e54ef0653851a84ad114158c7b4b1faf9b3be3", kill_on_drop: false }` [INFO] [stdout] f2471907a68a778efbaab91a39e54ef0653851a84ad114158c7b4b1faf9b3be3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1034ec22166ff1df0c476171c7b6fc6ba9bb691b8fe7001973a4e21c32cfcc9f [INFO] running `Command { std: "docker" "start" "-a" "1034ec22166ff1df0c476171c7b6fc6ba9bb691b8fe7001973a4e21c32cfcc9f", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Compiling thiserror v1.0.59 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking which v6.0.1 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking rust-parallel v1.18.1 (/tmp/fixit) [INFO] [stderr] Migrating tests/integration_tests.rs from 2021 edition to 2024 [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/parser/regex.rs (1 fix) [INFO] [stderr] Fixed src/main.rs (1 fix) [INFO] [stderr] Fixed src/input/task.rs (2 fixes) [INFO] [stderr] Fixed src/progress.rs (3 fixes) [INFO] [stderr] Fixed src/output.rs (1 fix) [INFO] [stdout] warning: field `style_name` is never read [INFO] [stdout] --> src/progress/style.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 26 | pub struct ProgressStyleInfo { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 27 | pub style_name: &'static str, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/command.rs:188:15 [INFO] [stdout] | [INFO] [stdout] 188 | while let Some(input_message) = input_producer.receiver().recv().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/command.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/output/task.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 30 | while let Some(output_message) = receiver.recv().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/output/task.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `rust_parallel` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/command.rs [INFO] [stderr] * src/output/task.rs [INFO] [stderr] * src/progress/style.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/progress/style.rs:78:36 [INFO] [stderr] | [INFO] [stderr] 78 | Ok(ref var) => unsafe { env::set_var(PROGRESS_STYLE, var) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-F unsafe-code` [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/progress/style.rs:80:31 [INFO] [stderr] | [INFO] [stderr] 80 | Err(_) => unsafe { env::remove_var(PROGRESS_STYLE) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/progress/style.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | unsafe { env::remove_var(PROGRESS_STYLE) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/progress/style.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | unsafe { env::set_var(PROGRESS_STYLE, DEFAULT_PROGRESS_STYLE) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/progress/style.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | unsafe { env::set_var(PROGRESS_STYLE, LIGHT_BG_PROGRESS_STYLE) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/progress/style.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | unsafe { env::set_var(PROGRESS_STYLE, DARK_BG_PROGRESS_STYLE) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/progress/style.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | unsafe { env::set_var(PROGRESS_STYLE, SIMPLE_PROGRESS_STYLE) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: usage of an `unsafe` block [INFO] [stderr] --> src/progress/style.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | unsafe { env::set_var(PROGRESS_STYLE, "unknown") }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stderr] --> src/command.rs:188:15 [INFO] [stderr] | [INFO] [stderr] 188 | while let Some(input_message) = input_producer.receiver().recv().await { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stderr] | [INFO] [stderr] = warning: this changes meaning in Rust 2024 [INFO] [stderr] = note: for more information, see issue #124085 [INFO] [stderr] help: the value is now dropped here in Edition 2024 [INFO] [stderr] --> src/command.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | } [INFO] [stderr] | ^ [INFO] [stderr] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stderr] [INFO] [stderr] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stderr] --> src/output/task.rs:30:15 [INFO] [stderr] | [INFO] [stderr] 30 | while let Some(output_message) = receiver.recv().await { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stderr] | [INFO] [stderr] = warning: this changes meaning in Rust 2024 [INFO] [stderr] = note: for more information, see issue #124085 [INFO] [stderr] help: the value is now dropped here in Edition 2024 [INFO] [stderr] --> src/output/task.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | } [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors; 2 warnings emitted [INFO] [stderr] [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: call to deprecated safe function `std::env::remove_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/progress/style.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | env::remove_var(PROGRESS_STYLE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 85 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 86 ~ unsafe { env::remove_var(PROGRESS_STYLE) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/progress/style.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | env::set_var(PROGRESS_STYLE, DEFAULT_PROGRESS_STYLE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 92 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 93 ~ unsafe { env::set_var(PROGRESS_STYLE, DEFAULT_PROGRESS_STYLE) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/progress/style.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | env::set_var(PROGRESS_STYLE, LIGHT_BG_PROGRESS_STYLE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 99 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 100~ unsafe { env::set_var(PROGRESS_STYLE, LIGHT_BG_PROGRESS_STYLE) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/progress/style.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | env::set_var(PROGRESS_STYLE, DARK_BG_PROGRESS_STYLE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 106 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 107 ~ unsafe { env::set_var(PROGRESS_STYLE, DARK_BG_PROGRESS_STYLE) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/progress/style.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | env::set_var(PROGRESS_STYLE, SIMPLE_PROGRESS_STYLE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 113 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 114 ~ unsafe { env::set_var(PROGRESS_STYLE, SIMPLE_PROGRESS_STYLE) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/progress/style.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | env::set_var(PROGRESS_STYLE, "unknown"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 120 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 121 ~ unsafe { env::set_var(PROGRESS_STYLE, "unknown") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/progress/style.rs:77:36 [INFO] [stdout] | [INFO] [stdout] 77 | Ok(ref var) => env::set_var(PROGRESS_STYLE, var), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 77 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 78 ~ Ok(ref var) => unsafe { env::set_var(PROGRESS_STYLE, var) }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::remove_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/progress/style.rs:78:31 [INFO] [stdout] | [INFO] [stdout] 78 | Err(_) => env::remove_var(PROGRESS_STYLE), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 78 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 79 ~ Err(_) => unsafe { env::remove_var(PROGRESS_STYLE) }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/command.rs:188:15 [INFO] [stdout] | [INFO] [stdout] 188 | while let Some(input_message) = input_producer.receiver().recv().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/command.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/output/task.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 30 | while let Some(output_message) = receiver.recv().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/output/task.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.88s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking rust-parallel v1.18.1 (/tmp/fixit) [INFO] [stdout] warning: field `style_name` is never read [INFO] [stdout] --> src/progress/style.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 26 | pub struct ProgressStyleInfo { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 27 | pub style_name: &'static str, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `remove_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/progress/style.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | env::remove_var(PROGRESS_STYLE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/progress/style.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | env::set_var(PROGRESS_STYLE, DEFAULT_PROGRESS_STYLE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/progress/style.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | env::set_var(PROGRESS_STYLE, LIGHT_BG_PROGRESS_STYLE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/progress/style.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | env::set_var(PROGRESS_STYLE, DARK_BG_PROGRESS_STYLE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/progress/style.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | env::set_var(PROGRESS_STYLE, SIMPLE_PROGRESS_STYLE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/progress/style.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | env::set_var(PROGRESS_STYLE, "unknown"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/progress/style.rs:77:36 [INFO] [stdout] | [INFO] [stdout] 77 | Ok(ref var) => env::set_var(PROGRESS_STYLE, var), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `remove_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/progress/style.rs:78:31 [INFO] [stdout] | [INFO] [stdout] 78 | Err(_) => env::remove_var(PROGRESS_STYLE), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-parallel` (bin "rust-parallel" test) due to 9 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "1034ec22166ff1df0c476171c7b6fc6ba9bb691b8fe7001973a4e21c32cfcc9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1034ec22166ff1df0c476171c7b6fc6ba9bb691b8fe7001973a4e21c32cfcc9f", kill_on_drop: false }` [INFO] [stdout] 1034ec22166ff1df0c476171c7b6fc6ba9bb691b8fe7001973a4e21c32cfcc9f