[INFO] fetching crate rtpeeker 0.1.0... [INFO] checking rtpeeker-0.1.0 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate rtpeeker 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate rtpeeker 0.1.0 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rtpeeker 0.1.0 [INFO] finished tweaking crates.io crate rtpeeker 0.1.0 [INFO] tweaked toml for crates.io crate rtpeeker 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate rtpeeker 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ca585b84c5c1cf260c0bbf887f8b894d5d32d26fcc2a2698d75def8e810179c2 [INFO] running `Command { std: "docker" "start" "-a" "ca585b84c5c1cf260c0bbf887f8b894d5d32d26fcc2a2698d75def8e810179c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ca585b84c5c1cf260c0bbf887f8b894d5d32d26fcc2a2698d75def8e810179c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca585b84c5c1cf260c0bbf887f8b894d5d32d26fcc2a2698d75def8e810179c2", kill_on_drop: false }` [INFO] [stdout] ca585b84c5c1cf260c0bbf887f8b894d5d32d26fcc2a2698d75def8e810179c2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e9c04b05e2e3f85375b9c9bd5a1bb6dce2e2ebecc6a105e98826783825ffd80b [INFO] running `Command { std: "docker" "start" "-a" "e9c04b05e2e3f85375b9c9bd5a1bb6dce2e2ebecc6a105e98826783825ffd80b", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling futures-core v0.3.29 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking futures-sink v0.3.29 [INFO] [stderr] Compiling futures-channel v0.3.29 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling futures-task v0.3.29 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling futures-util v0.3.29 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking futures-io v0.3.29 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking cpufeatures v0.2.11 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Compiling serde v1.0.190 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking mio v0.8.9 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling async-trait v0.1.74 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling aho-corasick v1.1.2 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking url v2.4.1 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling webrtc-util v0.8.0 [INFO] [stderr] Compiling libloading v0.6.7 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Compiling walkdir v2.4.0 [INFO] [stderr] Compiling regex-automata v0.4.3 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Compiling multer v2.1.0 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking base64 v0.21.5 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking data-encoding v2.4.0 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling futures-macro v0.3.29 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling serde_derive v1.0.190 [INFO] [stderr] Checking tokio v1.33.0 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Compiling regex v1.10.2 [INFO] [stderr] Checking tungstenite v0.20.1 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling rust-embed-utils v8.0.0 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking errno v0.2.8 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking termcolor v1.3.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking clap_builder v4.4.7 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Compiling pcap v1.1.0 [INFO] [stderr] Checking etherparse v0.13.0 [INFO] [stderr] Checking headers v0.3.9 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Compiling rust-embed-impl v8.0.0 [INFO] [stderr] Checking futures-executor v0.3.29 [INFO] [stderr] Checking futures v0.3.29 [INFO] [stderr] Checking rustls-pemfile v1.0.3 [INFO] [stderr] Checking webrtc-sdp v0.3.10 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking rust-embed v8.0.0 [INFO] [stderr] Checking clap v4.4.7 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking tokio-tungstenite v0.20.1 [INFO] [stderr] Checking h2 v0.3.21 [INFO] [stderr] Checking rtcp v0.10.0 [INFO] [stderr] Checking rtp v0.9.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking rtpeeker_common v0.1.0 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking warp v0.3.6 [INFO] [stderr] Checking rtpeeker v0.1.0 (/tmp/fixit) [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/server.rs:115:15 [INFO] [stdout] | [INFO] [stdout] 115 | while let Some(message) = rx.recv().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/server.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/server.rs:156:11 [INFO] [stdout] | [INFO] [stdout] 156 | while let Some(result) = sniffer.next_packet().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/server.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/server.rs:304:11 [INFO] [stdout] | [INFO] [stdout] 304 | while let Some(result) = ws_rx.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/server.rs:363:5 [INFO] [stdout] | [INFO] [stdout] 363 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/server.rs:115:15 [INFO] [stdout] | [INFO] [stdout] 115 | while let Some(message) = rx.recv().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/server.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/server.rs:156:11 [INFO] [stdout] | [INFO] [stdout] 156 | while let Some(result) = sniffer.next_packet().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/server.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/server.rs:304:11 [INFO] [stdout] | [INFO] [stdout] 304 | while let Some(result) = ws_rx.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/server.rs:363:5 [INFO] [stdout] | [INFO] [stdout] 363 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.07s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking rtpeeker v0.1.0 (/tmp/fixit) [INFO] [stdout] error[E0515]: cannot return value referencing local variable `path` [INFO] [stdout] --> src/server.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | serve_impl(path.as_str()).await [INFO] [stdout] | ^^^^^^^^^^^----^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `path` is borrowed here [INFO] [stdout] | returns a value referencing data owned by the current function [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0515]: cannot return value referencing local variable `path` [INFO] [stdout] --> src/server.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | serve_impl(path.as_str()).await [INFO] [stdout] | ^^^^^^^^^^^----^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `path` is borrowed here [INFO] [stdout] | returns a value referencing data owned by the current function [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0515`. [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0515`. [INFO] [stdout] [INFO] [stderr] error: could not compile `rtpeeker` (bin "rtpeeker" test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rtpeeker` (bin "rtpeeker") due to 2 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "e9c04b05e2e3f85375b9c9bd5a1bb6dce2e2ebecc6a105e98826783825ffd80b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9c04b05e2e3f85375b9c9bd5a1bb6dce2e2ebecc6a105e98826783825ffd80b", kill_on_drop: false }` [INFO] [stdout] e9c04b05e2e3f85375b9c9bd5a1bb6dce2e2ebecc6a105e98826783825ffd80b