[INFO] fetching crate rpk 0.2.0... [INFO] checking rpk-0.2.0 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate rpk 0.2.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate rpk 0.2.0 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate rpk 0.2.0 [INFO] finished tweaking crates.io crate rpk 0.2.0 [INFO] tweaked toml for crates.io crate rpk 0.2.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate rpk 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 21d7aff15194baeb5dc47b604fecba60a75d7773cd94ac05857c8ce82d326ca0 [INFO] running `Command { std: "docker" "start" "-a" "21d7aff15194baeb5dc47b604fecba60a75d7773cd94ac05857c8ce82d326ca0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "21d7aff15194baeb5dc47b604fecba60a75d7773cd94ac05857c8ce82d326ca0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21d7aff15194baeb5dc47b604fecba60a75d7773cd94ac05857c8ce82d326ca0", kill_on_drop: false }` [INFO] [stdout] 21d7aff15194baeb5dc47b604fecba60a75d7773cd94ac05857c8ce82d326ca0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cabf3a859081f0c9b427c62701d6b6b795b9bb9c8019503579b599673426bfd7 [INFO] running `Command { std: "docker" "start" "-a" "cabf3a859081f0c9b427c62701d6b6b795b9bb9c8019503579b599673426bfd7", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling serde v1.0.206 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling syn v2.0.74 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Compiling cc v1.1.10 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling serde_json v1.0.124 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking flate2 v1.0.31 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling zip v2.1.6 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking bytecount v0.6.8 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking lockfree-object-pool v0.1.6 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking papergrid v0.12.0 [INFO] [stderr] Checking zopfli v0.8.1 [INFO] [stderr] Checking newline-converter v0.3.0 [INFO] [stderr] Compiling rpk v0.2.0 (/tmp/fixit) [INFO] [stderr] Migrating build.rs from 2021 edition to 2024 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Compiling tabled_derive v0.8.0 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Compiling serde_derive v1.0.206 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking rustls-webpki v0.102.6 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking lzma-rs v0.3.0 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking webpki-roots v0.26.3 [INFO] [stderr] Checking filetime v0.2.24 [INFO] [stderr] Checking socks v0.3.4 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking deflate64 v0.1.9 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking inquire v0.7.5 [INFO] [stderr] Checking tar v0.4.41 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking emojis v0.6.3 [INFO] [stderr] Checking tabled v0.16.0 [INFO] [stderr] Checking clap v4.5.15 [INFO] [stderr] Checking clap_complete v4.5.14 [INFO] [stderr] Checking fmutex v0.1.0 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking constcat v0.5.0 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking ureq v2.10.1 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/util/build.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 6 | ($key:expr, $default:expr $(,)?) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 6 | ($key:expr_2021, $default:expr $(,)?) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `rpk` [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/util/build.rs:6:26 [INFO] [stdout] | [INFO] [stdout] 6 | ($key:expr, $default:expr $(,)?) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 6 | ($key:expr, $default:expr_2021 $(,)?) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/util/build.rs:12:11 [INFO] [stdout] | [INFO] [stdout] 12 | ($key:expr $(,)?) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 12 | ($key:expr_2021 $(,)?) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/main.rs:57:19 [INFO] [stdout] | [INFO] [stdout] 57 | ($command:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 57 | ($command:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/main.rs:97:24 [INFO] [stdout] | [INFO] [stdout] 97 | ($name:expr, $path:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 97 | ($name:expr_2021, $path:expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] * src/main.rs [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/main.rs:97:36 [INFO] [stdout] | [INFO] [stdout] 97 | ($name:expr, $path:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 97 | ($name:expr, $path:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] * src/util/build.rs [INFO] [stdout] warning: call to deprecated safe function `std::env::remove_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/cli.rs:168:21 [INFO] [stdout] | [INFO] [stdout] 168 | true => env::remove_var("NO_COLOR"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 168 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 169 ~ true => unsafe { env::remove_var("NO_COLOR") }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/cli.rs:169:22 [INFO] [stdout] | [INFO] [stdout] 169 | false => env::set_var("NO_COLOR", "1"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 169 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 170 ~ false => unsafe { env::set_var("NO_COLOR", "1") }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/main.rs:138:8 [INFO] [stdout] | [INFO] [stdout] 138 | if let Err(e) = try_main() { [INFO] [stdout] | ^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/main.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 141 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 138 ~ match try_main() { Err(e) => { [INFO] [stdout] 139 | log_error(true, &e); [INFO] [stdout] 140 | process::exit(1); [INFO] [stdout] 141 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/config/mod.rs:103:15 [INFO] [stdout] | [INFO] [stdout] 103 | while let Some(key) = map.next_key()? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^--------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/config/mod.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/util/build.rs:6:6 [INFO] [stderr] | [INFO] [stderr] 6 | ($key:expr_2021, $default:expr_2021 $(,)?) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/util/build.rs:6:22 [INFO] [stderr] | [INFO] [stderr] 6 | ($key:expr_2021, $default:expr_2021 $(,)?) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/util/build.rs:12:6 [INFO] [stderr] | [INFO] [stderr] 12 | ($key:expr_2021 $(,)?) => { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/main.rs:57:10 [INFO] [stderr] | [INFO] [stderr] 57 | ($command:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/main.rs:97:18 [INFO] [stderr] | [INFO] [stderr] 97 | ($name:expr_2021, $path:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/main.rs:97:35 [INFO] [stderr] | [INFO] [stderr] 97 | ($name:expr_2021, $path:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/util/build.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 6 | ($key:expr, $default:expr $(,)?) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 6 | ($key:expr_2021, $default:expr $(,)?) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `rpk` [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/util/build.rs:6:26 [INFO] [stdout] | [INFO] [stdout] 6 | ($key:expr, $default:expr $(,)?) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 6 | ($key:expr, $default:expr_2021 $(,)?) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/util/build.rs:12:11 [INFO] [stdout] | [INFO] [stdout] 12 | ($key:expr $(,)?) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 12 | ($key:expr_2021 $(,)?) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/main.rs:57:19 [INFO] [stdout] | [INFO] [stdout] 57 | ($command:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 57 | ($command:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/main.rs:97:24 [INFO] [stdout] | [INFO] [stdout] 97 | ($name:expr, $path:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 97 | ($name:expr_2021, $path:expr) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] * src/main.rs [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/main.rs:97:36 [INFO] [stdout] | [INFO] [stdout] 97 | ($name:expr, $path:expr) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 97 | ($name:expr, $path:expr_2021) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] * src/util/build.rs [INFO] [stdout] warning: call to deprecated safe function `std::env::remove_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/cli.rs:168:21 [INFO] [stdout] | [INFO] [stdout] 168 | true => env::remove_var("NO_COLOR"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 168 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 169 ~ true => unsafe { env::remove_var("NO_COLOR") }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/cli.rs:169:22 [INFO] [stdout] | [INFO] [stdout] 169 | false => env::set_var("NO_COLOR", "1"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 169 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 170 ~ false => unsafe { env::set_var("NO_COLOR", "1") }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/main.rs:138:8 [INFO] [stdout] | [INFO] [stdout] 138 | if let Err(e) = try_main() { [INFO] [stdout] | ^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/main.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 141 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 138 ~ match try_main() { Err(e) => { [INFO] [stdout] 139 | log_error(true, &e); [INFO] [stdout] 140 | process::exit(1); [INFO] [stdout] 141 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/config/mod.rs:103:15 [INFO] [stdout] | [INFO] [stdout] 103 | while let Some(key) = map.next_key()? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^--------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/config/mod.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stdout] warning: 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/util/build.rs:6:6 [INFO] [stderr] | [INFO] [stderr] 6 | ($key:expr_2021, $default:expr_2021 $(,)?) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/util/build.rs:6:22 [INFO] [stderr] | [INFO] [stderr] 6 | ($key:expr_2021, $default:expr_2021 $(,)?) => {{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/util/build.rs:12:6 [INFO] [stderr] | [INFO] [stderr] 12 | ($key:expr_2021 $(,)?) => { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/main.rs:57:10 [INFO] [stderr] | [INFO] [stderr] 57 | ($command:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/main.rs:97:18 [INFO] [stderr] | [INFO] [stderr] 97 | ($name:expr_2021, $path:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/main.rs:97:35 [INFO] [stderr] | [INFO] [stderr] 97 | ($name:expr_2021, $path:expr_2021) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 54.23s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Compiling rpk v0.2.0 (/tmp/fixit) [INFO] [stdout] error[E0133]: call to unsafe function `remove_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/cli.rs:168:21 [INFO] [stdout] | [INFO] [stdout] 168 | true => env::remove_var("NO_COLOR"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/cli.rs:169:22 [INFO] [stdout] | [INFO] [stdout] 169 | false => env::set_var("NO_COLOR", "1"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `remove_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/cli.rs:168:21 [INFO] [stdout] | [INFO] [stdout] 168 | true => env::remove_var("NO_COLOR"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/cli.rs:169:22 [INFO] [stdout] | [INFO] [stdout] 169 | false => env::set_var("NO_COLOR", "1"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `rpk` (bin "rpk" test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rpk` (bin "rpk") due to 3 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "cabf3a859081f0c9b427c62701d6b6b795b9bb9c8019503579b599673426bfd7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cabf3a859081f0c9b427c62701d6b6b795b9bb9c8019503579b599673426bfd7", kill_on_drop: false }` [INFO] [stdout] cabf3a859081f0c9b427c62701d6b6b795b9bb9c8019503579b599673426bfd7