[INFO] fetching crate rocketmq-common 0.2.0... [INFO] checking rocketmq-common-0.2.0 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate rocketmq-common 0.2.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate rocketmq-common 0.2.0 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rocketmq-common 0.2.0 [INFO] finished tweaking crates.io crate rocketmq-common 0.2.0 [INFO] tweaked toml for crates.io crate rocketmq-common 0.2.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 182 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (available: v0.22.1) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding hashbrown v0.13.2 (available: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding mockall v0.12.1 (available: v0.13.0) [INFO] [stderr] Adding mockall_derive v0.12.1 (available: v0.13.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (available: v0.50.1) [INFO] [stderr] Adding ordered-multimap v0.6.0 (available: v0.7.3) [INFO] [stderr] Adding rust-ini v0.19.0 (available: v0.21.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding termtree v0.4.1 (available: v0.5.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (available: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (available: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d22107f28c3d54a376dde22bf3fd87106ca402b7162b8f9121ca62b8cac4f908 [INFO] running `Command { std: "docker" "start" "-a" "d22107f28c3d54a376dde22bf3fd87106ca402b7162b8f9121ca62b8cac4f908", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d22107f28c3d54a376dde22bf3fd87106ca402b7162b8f9121ca62b8cac4f908", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d22107f28c3d54a376dde22bf3fd87106ca402b7162b8f9121ca62b8cac4f908", kill_on_drop: false }` [INFO] [stdout] d22107f28c3d54a376dde22bf3fd87106ca402b7162b8f9121ca62b8cac4f908 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 42c5772861b1bd28ff02b34b045d00f7f1b63ccc4f0418ccdf730aff91a86cea [INFO] running `Command { std: "docker" "start" "-a" "42c5772861b1bd28ff02b34b045d00f7f1b63ccc4f0418ccdf730aff91a86cea", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling cc v1.1.21 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking winnow v0.6.20 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Compiling pest v2.7.13 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Checking ordered-multimap v0.6.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking predicates-core v1.0.8 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling anyhow v1.0.89 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking rust-ini v0.19.0 [INFO] [stderr] Compiling pest_meta v2.7.13 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Compiling pest_generator v2.7.13 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking predicates v3.1.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking predicates-tree v1.0.11 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking flate2 v1.0.34 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling pest_derive v2.7.13 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Compiling mockall_derive v0.12.1 [INFO] [stderr] Compiling trait-variant v0.1.2 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Checking lz4_flex v0.11.3 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.8 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking toml_edit v0.22.22 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Compiling neli-proc-macros v0.1.3 [INFO] [stderr] Checking neli v0.6.4 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking config v0.14.0 [INFO] [stderr] Checking mockall v0.12.1 [INFO] [stderr] Checking local-ip-address v0.6.3 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking rocketmq-common v0.2.0 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `rocketmq_common` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/common/macros.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/common/macros.rs:10:6 [INFO] [stderr] | [INFO] [stderr] 10 | ($elem:expr_2021 $(, $tail:expr_2021)*) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/common/macros.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | ($elem:expr_2021 $(, $tail:expr_2021)*) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/common/macros.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | ($elem:expr $(, $tail:expr)*) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 10 | ($elem:expr_2021 $(, $tail:expr)*) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/common/macros.rs:10:27 [INFO] [stdout] | [INFO] [stdout] 10 | ($elem:expr $(, $tail:expr)*) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 10 | ($elem:expr $(, $tail:expr_2021)*) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/utils/env_utils.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | std::env::set_var(ROCKETMQ_HOME_ENV, rocketmq_home_dir.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 59 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 60 ~ unsafe { std::env::set_var(ROCKETMQ_HOME_ENV, rocketmq_home_dir.clone()) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/utils/env_utils.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | std::env::set_var(key, expected_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 75 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 76 ~ unsafe { std::env::set_var(key, expected_value) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/utils/env_utils.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | std::env::set_var(ROCKETMQ_HOME_ENV, expected_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 101 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 102 ~ unsafe { std::env::set_var(ROCKETMQ_HOME_ENV, expected_value) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::remove_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/utils/env_utils.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | std::env::remove_var(ROCKETMQ_HOME_ENV); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 113 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 114 ~ unsafe { std::env::remove_var(ROCKETMQ_HOME_ENV) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/config.rs:135:20 [INFO] [stdout] | [INFO] [stdout] 135 | if let Ok(attrs) = serde_json::from_str(parts[5]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/config.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 135 ~ match serde_json::from_str(parts[5]) { Ok(attrs) => { [INFO] [stdout] 136 | self.attributes = attrs [INFO] [stdout] 137 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/config_manager.rs:65:19 [INFO] [stdout] | [INFO] [stdout] 65 | return if let Ok(ref content) = [INFO] [stdout] | ___________________^ [INFO] [stdout] 66 | | FileUtils::file_to_string(format!("{}{}", file_name, ".bak").as_str()) [INFO] [stdout] | |_____________---------------------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/config_manager.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 65 ~ return match FileUtils::file_to_string(format!("{}{}", file_name, ".bak").as_str()) [INFO] [stdout] 66 ~ { Ok(ref content) => { [INFO] [stdout] 67 | if !content.is_empty() { [INFO] [stdout] ... [INFO] [stdout] 71 | true [INFO] [stdout] 72 ~ } _ => { [INFO] [stdout] 73 | error!("load Config file: {}.bak -----Failed", file_name); [INFO] [stdout] 74 | false [INFO] [stdout] 75 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/future.rs:77:16 [INFO] [stdout] | [INFO] [stdout] 77 | if let Some(data) = rx.recv().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^--------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/future.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 77 ~ match rx.recv().await { Some(data) => { [INFO] [stdout] 78 | let mut state = arc.lock().unwrap(); [INFO] [stdout] ... [INFO] [stdout] 84 | rx.close(); [INFO] [stdout] 85 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/future.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 104 | if let Some(waker) = state.waker.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/future.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 104 ~ match state.waker.take() { Some(waker) => { [INFO] [stdout] 105 | waker.wake(); [INFO] [stdout] 106 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/future.rs:113:12 [INFO] [stdout] | [INFO] [stdout] 113 | if let Some(waker) = state.waker.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/future.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 113 ~ match state.waker.take() { Some(waker) => { [INFO] [stdout] 114 | waker.wake(); [INFO] [stdout] 115 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_std.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 54 | if let Ok(value) = [INFO] [stdout] | ____________^ [INFO] [stdout] 55 | | self.started [INFO] [stdout] | | ------------ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 56 | | .compare_exchange(false, true, Ordering::SeqCst, Ordering::Relaxed) [INFO] [stdout] | |___________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_std.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 54 ~ match self.started [INFO] [stdout] 55 | .compare_exchange(false, true, Ordering::SeqCst, Ordering::Relaxed) [INFO] [stdout] 56 ~ { Ok(value) => { [INFO] [stdout] 57 | if value { [INFO] [stdout] 58 | return; [INFO] [stdout] 59 | } [INFO] [stdout] 60 ~ } _ => { [INFO] [stdout] 61 | return; [INFO] [stdout] 62 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_std.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 86 | if let Ok(value) = [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | self.started [INFO] [stdout] | | ------------ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 88 | | .compare_exchange(true, false, Ordering::SeqCst, Ordering::Relaxed) [INFO] [stdout] | |___________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_std.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 86 ~ match self.started [INFO] [stdout] 87 | .compare_exchange(true, false, Ordering::SeqCst, Ordering::Relaxed) [INFO] [stdout] 88 ~ { Ok(value) => { [INFO] [stdout] 89 | if !value { [INFO] [stdout] 90 | return; [INFO] [stdout] 91 | } [INFO] [stdout] 92 ~ } _ => { [INFO] [stdout] 93 | return; [INFO] [stdout] 94 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_std.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 98 | if let Some(thread) = self.thread.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_std.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 98 ~ match self.thread.take() { Some(thread) => { [INFO] [stdout] 99 | if interrupt { [INFO] [stdout] ... [INFO] [stdout] 103 | } [INFO] [stdout] 104 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_tokio.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 58 | if let Ok(value) = [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | started.compare_exchange(false, true, Ordering::SeqCst, Ordering::Relaxed) [INFO] [stdout] | |_____________-------__________________________________________________________________^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_tokio.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 58 ~ match started.compare_exchange(false, true, Ordering::SeqCst, Ordering::Relaxed) [INFO] [stdout] 59 ~ { Ok(value) => { [INFO] [stdout] 60 | if value { [INFO] [stdout] 61 | return; [INFO] [stdout] 62 | } [INFO] [stdout] 63 ~ } _ => { [INFO] [stdout] 64 | return; [INFO] [stdout] 65 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_tokio.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 91 | if let Ok(value) = [INFO] [stdout] | ____________^ [INFO] [stdout] 92 | | self.started [INFO] [stdout] | | ------------ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 93 | | .compare_exchange(true, false, Ordering::SeqCst, Ordering::Relaxed) [INFO] [stdout] | |___________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_tokio.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 91 ~ match self.started [INFO] [stdout] 92 | .compare_exchange(true, false, Ordering::SeqCst, Ordering::Relaxed) [INFO] [stdout] 93 ~ { Ok(value) => { [INFO] [stdout] 94 | if !value { [INFO] [stdout] 95 | return; [INFO] [stdout] 96 | } [INFO] [stdout] 97 ~ } _ => { [INFO] [stdout] 98 | return; [INFO] [stdout] 99 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_tokio.rs:102:12 [INFO] [stdout] | [INFO] [stdout] 102 | if let Some(thread) = self.thread.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_tokio.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 102 ~ match self.thread.take() { Some(thread) => { [INFO] [stdout] 103 | log::info!("Shutting down service thread: {}", self.name); [INFO] [stdout] ... [INFO] [stdout] 108 | } [INFO] [stdout] 109 ~ } _ => { [INFO] [stdout] 110 | log::warn!("Service thread not started: {}", self.name); [INFO] [stdout] 111 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/thread_pool.rs:63:38 [INFO] [stdout] | [INFO] [stdout] 63 | let thread_prefix_inner = if let Some(thread_prefix) = thread_prefix { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/thread_pool.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 63 ~ let thread_prefix_inner = match thread_prefix { Some(thread_prefix) => { [INFO] [stdout] 64 | thread_prefix.into() [INFO] [stdout] 65 ~ } _ => { [INFO] [stdout] 66 | "rocketmq-thread-".to_string() [INFO] [stdout] 67 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/thread_pool.rs:182:38 [INFO] [stdout] | [INFO] [stdout] 182 | let thread_prefix_inner = if let Some(thread_prefix) = thread_prefix { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/thread_pool.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 182 ~ let thread_prefix_inner = match thread_prefix { Some(thread_prefix) => { [INFO] [stdout] 183 | thread_prefix.into() [INFO] [stdout] 184 ~ } _ => { [INFO] [stdout] 185 | "rocketmq-thread-".to_string() [INFO] [stdout] 186 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 19 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `rocketmq_common` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/common/macros.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/common/macros.rs:10:6 [INFO] [stderr] | [INFO] [stderr] 10 | ($elem:expr_2021 $(, $tail:expr_2021)*) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/common/macros.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | ($elem:expr_2021 $(, $tail:expr_2021)*) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/common/macros.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | ($elem:expr $(, $tail:expr)*) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 10 | ($elem:expr_2021 $(, $tail:expr)*) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/common/macros.rs:10:27 [INFO] [stdout] | [INFO] [stdout] 10 | ($elem:expr $(, $tail:expr)*) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 10 | ($elem:expr $(, $tail:expr_2021)*) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/utils/env_utils.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | std::env::set_var(ROCKETMQ_HOME_ENV, rocketmq_home_dir.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 59 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 60 ~ unsafe { std::env::set_var(ROCKETMQ_HOME_ENV, rocketmq_home_dir.clone()) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/config.rs:135:20 [INFO] [stdout] | [INFO] [stdout] 135 | if let Ok(attrs) = serde_json::from_str(parts[5]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/config.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 135 ~ match serde_json::from_str(parts[5]) { Ok(attrs) => { [INFO] [stdout] 136 | self.attributes = attrs [INFO] [stdout] 137 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/config_manager.rs:65:19 [INFO] [stdout] | [INFO] [stdout] 65 | return if let Ok(ref content) = [INFO] [stdout] | ___________________^ [INFO] [stdout] 66 | | FileUtils::file_to_string(format!("{}{}", file_name, ".bak").as_str()) [INFO] [stdout] | |_____________---------------------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/config_manager.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 65 ~ return match FileUtils::file_to_string(format!("{}{}", file_name, ".bak").as_str()) [INFO] [stdout] 66 ~ { Ok(ref content) => { [INFO] [stdout] 67 | if !content.is_empty() { [INFO] [stdout] ... [INFO] [stdout] 71 | true [INFO] [stdout] 72 ~ } _ => { [INFO] [stdout] 73 | error!("load Config file: {}.bak -----Failed", file_name); [INFO] [stdout] 74 | false [INFO] [stdout] 75 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/future.rs:77:16 [INFO] [stdout] | [INFO] [stdout] 77 | if let Some(data) = rx.recv().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^--------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/future.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 77 ~ match rx.recv().await { Some(data) => { [INFO] [stdout] 78 | let mut state = arc.lock().unwrap(); [INFO] [stdout] ... [INFO] [stdout] 84 | rx.close(); [INFO] [stdout] 85 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/future.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 104 | if let Some(waker) = state.waker.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/future.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 104 ~ match state.waker.take() { Some(waker) => { [INFO] [stdout] 105 | waker.wake(); [INFO] [stdout] 106 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/future.rs:113:12 [INFO] [stdout] | [INFO] [stdout] 113 | if let Some(waker) = state.waker.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/future.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 113 ~ match state.waker.take() { Some(waker) => { [INFO] [stdout] 114 | waker.wake(); [INFO] [stdout] 115 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_std.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 54 | if let Ok(value) = [INFO] [stdout] | ____________^ [INFO] [stdout] 55 | | self.started [INFO] [stdout] | | ------------ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 56 | | .compare_exchange(false, true, Ordering::SeqCst, Ordering::Relaxed) [INFO] [stdout] | |___________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_std.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 54 ~ match self.started [INFO] [stdout] 55 | .compare_exchange(false, true, Ordering::SeqCst, Ordering::Relaxed) [INFO] [stdout] 56 ~ { Ok(value) => { [INFO] [stdout] 57 | if value { [INFO] [stdout] 58 | return; [INFO] [stdout] 59 | } [INFO] [stdout] 60 ~ } _ => { [INFO] [stdout] 61 | return; [INFO] [stdout] 62 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_std.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 86 | if let Ok(value) = [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | self.started [INFO] [stdout] | | ------------ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 88 | | .compare_exchange(true, false, Ordering::SeqCst, Ordering::Relaxed) [INFO] [stdout] | |___________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_std.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 86 ~ match self.started [INFO] [stdout] 87 | .compare_exchange(true, false, Ordering::SeqCst, Ordering::Relaxed) [INFO] [stdout] 88 ~ { Ok(value) => { [INFO] [stdout] 89 | if !value { [INFO] [stdout] 90 | return; [INFO] [stdout] 91 | } [INFO] [stdout] 92 ~ } _ => { [INFO] [stdout] 93 | return; [INFO] [stdout] 94 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_std.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 98 | if let Some(thread) = self.thread.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_std.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 98 ~ match self.thread.take() { Some(thread) => { [INFO] [stdout] 99 | if interrupt { [INFO] [stdout] ... [INFO] [stdout] 103 | } [INFO] [stdout] 104 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_tokio.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 58 | if let Ok(value) = [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | started.compare_exchange(false, true, Ordering::SeqCst, Ordering::Relaxed) [INFO] [stdout] | |_____________-------__________________________________________________________________^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_tokio.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 58 ~ match started.compare_exchange(false, true, Ordering::SeqCst, Ordering::Relaxed) [INFO] [stdout] 59 ~ { Ok(value) => { [INFO] [stdout] 60 | if value { [INFO] [stdout] 61 | return; [INFO] [stdout] 62 | } [INFO] [stdout] 63 ~ } _ => { [INFO] [stdout] 64 | return; [INFO] [stdout] 65 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_tokio.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 91 | if let Ok(value) = [INFO] [stdout] | ____________^ [INFO] [stdout] 92 | | self.started [INFO] [stdout] | | ------------ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] 93 | | .compare_exchange(true, false, Ordering::SeqCst, Ordering::Relaxed) [INFO] [stdout] | |___________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_tokio.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 91 ~ match self.started [INFO] [stdout] 92 | .compare_exchange(true, false, Ordering::SeqCst, Ordering::Relaxed) [INFO] [stdout] 93 ~ { Ok(value) => { [INFO] [stdout] 94 | if !value { [INFO] [stdout] 95 | return; [INFO] [stdout] 96 | } [INFO] [stdout] 97 ~ } _ => { [INFO] [stdout] 98 | return; [INFO] [stdout] 99 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_tokio.rs:102:12 [INFO] [stdout] | [INFO] [stdout] 102 | if let Some(thread) = self.thread.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/common/thread/thread_service_tokio.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 102 ~ match self.thread.take() { Some(thread) => { [INFO] [stdout] 103 | log::info!("Shutting down service thread: {}", self.name); [INFO] [stdout] ... [INFO] [stdout] 108 | } [INFO] [stdout] 109 ~ } _ => { [INFO] [stdout] 110 | log::warn!("Service thread not started: {}", self.name); [INFO] [stdout] 111 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/thread_pool.rs:63:38 [INFO] [stdout] | [INFO] [stdout] 63 | let thread_prefix_inner = if let Some(thread_prefix) = thread_prefix { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/thread_pool.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 63 ~ let thread_prefix_inner = match thread_prefix { Some(thread_prefix) => { [INFO] [stdout] 64 | thread_prefix.into() [INFO] [stdout] 65 ~ } _ => { [INFO] [stdout] 66 | "rocketmq-thread-".to_string() [INFO] [stdout] 67 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/thread_pool.rs:182:38 [INFO] [stdout] | [INFO] [stdout] 182 | let thread_prefix_inner = if let Some(thread_prefix) = thread_prefix { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/thread_pool.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 182 ~ let thread_prefix_inner = match thread_prefix { Some(thread_prefix) => { [INFO] [stdout] 183 | thread_prefix.into() [INFO] [stdout] 184 ~ } _ => { [INFO] [stdout] 185 | "rocketmq-thread-".to_string() [INFO] [stdout] 186 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 28.94s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking rocketmq-common v0.2.0 (/tmp/fixit) [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/utils/env_utils.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | std::env::set_var(ROCKETMQ_HOME_ENV, rocketmq_home_dir.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/utils/env_utils.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | std::env::set_var(key, expected_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/utils/env_utils.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | std::env::set_var(ROCKETMQ_HOME_ENV, expected_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0133]: call to unsafe function `remove_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/utils/env_utils.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | std::env::remove_var(ROCKETMQ_HOME_ENV); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `rocketmq-common` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/utils/env_utils.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | std::env::set_var(ROCKETMQ_HOME_ENV, rocketmq_home_dir.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stderr] error: could not compile `rocketmq-common` (lib) due to 2 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "42c5772861b1bd28ff02b34b045d00f7f1b63ccc4f0418ccdf730aff91a86cea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "42c5772861b1bd28ff02b34b045d00f7f1b63ccc4f0418ccdf730aff91a86cea", kill_on_drop: false }` [INFO] [stdout] 42c5772861b1bd28ff02b34b045d00f7f1b63ccc4f0418ccdf730aff91a86cea