[INFO] fetching crate redis-async 0.17.2... [INFO] checking redis-async-0.17.2 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate redis-async 0.17.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate redis-async 0.17.2 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate redis-async 0.17.2 [INFO] finished tweaking crates.io crate redis-async 0.17.2 [INFO] tweaked toml for crates.io crate redis-async 0.17.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate redis-async 0.17.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7dec970257036b18a638847bbb09b22105b7a6224246ca59540c1f75efc09e03 [INFO] running `Command { std: "docker" "start" "-a" "7dec970257036b18a638847bbb09b22105b7a6224246ca59540c1f75efc09e03", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7dec970257036b18a638847bbb09b22105b7a6224246ca59540c1f75efc09e03", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7dec970257036b18a638847bbb09b22105b7a6224246ca59540c1f75efc09e03", kill_on_drop: false }` [INFO] [stdout] 7dec970257036b18a638847bbb09b22105b7a6224246ca59540c1f75efc09e03 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bd5022931a246769c8faa7d845507cdf4c76cef7dd17feab5d8f928365d89de4 [INFO] running `Command { std: "docker" "start" "-a" "bd5022931a246769c8faa7d845507cdf4c76cef7dd17feab5d8f928365d89de4", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Fixed Cargo.toml (4 fixes) [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.63 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking redis-async v0.17.2 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `redis_async` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/resp.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/resp.rs:386:8 [INFO] [stderr] | [INFO] [stderr] 386 | ($($e:expr_2021),* $(,)?) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/resp.rs:386:11 [INFO] [stdout] | [INFO] [stdout] 386 | ($($e:expr),* $(,)?) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 386 | ($($e:expr_2021),* $(,)?) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures_util::Future>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/client/paired.rs:236:37 [INFO] [stdout] | [INFO] [stdout] 236 | pub fn paired_connect(&self) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/client/paired.rs:236:27 [INFO] [stdout] | [INFO] [stdout] 236 | pub fn paired_connect(&self) -> impl Future> { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 236 | pub fn paired_connect(&self) -> impl Future> + use<> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/paired.rs:327:16 [INFO] [stdout] | [INFO] [stdout] 327 | if let Err(e) = send_f.await { [INFO] [stdout] | ^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/paired.rs:329:13 [INFO] [stdout] | [INFO] [stdout] 329 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 327 ~ match send_f.await { Err(e) => { [INFO] [stdout] 328 | log::error!("Error in send_and_forget: {}", e); [INFO] [stdout] 329 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures_util::Future>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/client/pubsub/mod.rs:90:37 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn pubsub_connect(&self) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/client/pubsub/mod.rs:90:27 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn pubsub_connect(&self) -> impl Future> { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 90 | pub fn pubsub_connect(&self) -> impl Future> + use<> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/pubsub/inner.rs:203:24 [INFO] [stdout] | [INFO] [stdout] 203 | if let Err(error) = sender.unbounded_send(Ok(msg)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/pubsub/inner.rs:207:21 [INFO] [stdout] | [INFO] [stdout] 207 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 203 ~ match sender.unbounded_send(Ok(msg)) { Err(error) => { [INFO] [stdout] 204 | if !error.is_disconnected() { [INFO] [stdout] 205 | return Err(error::internal(format!("Cannot send message: {}", error))); [INFO] [stdout] 206 | } [INFO] [stdout] 207 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/pubsub/inner.rs:218:24 [INFO] [stdout] | [INFO] [stdout] 218 | if let Err(error) = sender.unbounded_send(Ok(msg)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/pubsub/inner.rs:222:21 [INFO] [stdout] | [INFO] [stdout] 222 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 218 ~ match sender.unbounded_send(Ok(msg)) { Err(error) => { [INFO] [stdout] 219 | if !error.is_disconnected() { [INFO] [stdout] 220 | return Err(error::internal(format!("Cannot send message: {}", error))); [INFO] [stdout] 221 | } [INFO] [stdout] 222 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/reconnect.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 119 | if let Err(e) = (self.0.work_fn)(t, a) { [INFO] [stdout] | ^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/reconnect.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 119 ~ match (self.0.work_fn)(t, a) { Err(e) => { [INFO] [stdout] 120 | match e { [INFO] [stdout] ... [INFO] [stdout] 127 | Err(e) [INFO] [stdout] 128 ~ } _ => { [INFO] [stdout] 129 | Ok(true) [INFO] [stdout] 130 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures_util::Future> + std::marker::Send` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/reconnect.rs:169:10 [INFO] [stdout] | [INFO] [stdout] 169 | ) -> impl Future> + Send { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/reconnect.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | &self, [INFO] [stdout] | ^ [INFO] [stdout] 168 | mut state: MutexGuard>, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 169 | ) -> impl Future> + Send + use { [INFO] [stdout] | +++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `redis_async` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/resp.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/resp.rs:386:8 [INFO] [stderr] | [INFO] [stderr] 386 | ($($e:expr_2021),* $(,)?) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/resp.rs:386:11 [INFO] [stdout] | [INFO] [stdout] 386 | ($($e:expr),* $(,)?) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 386 | ($($e:expr_2021),* $(,)?) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `impl futures_util::Future>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/client/paired.rs:236:37 [INFO] [stdout] | [INFO] [stdout] 236 | pub fn paired_connect(&self) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/client/paired.rs:236:27 [INFO] [stdout] | [INFO] [stdout] 236 | pub fn paired_connect(&self) -> impl Future> { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 236 | pub fn paired_connect(&self) -> impl Future> + use<> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/paired.rs:327:16 [INFO] [stdout] | [INFO] [stdout] 327 | if let Err(e) = send_f.await { [INFO] [stdout] | ^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/paired.rs:329:13 [INFO] [stdout] | [INFO] [stdout] 329 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 327 ~ match send_f.await { Err(e) => { [INFO] [stdout] 328 | log::error!("Error in send_and_forget: {}", e); [INFO] [stdout] 329 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures_util::Future>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/client/pubsub/mod.rs:90:37 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn pubsub_connect(&self) -> impl Future> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/client/pubsub/mod.rs:90:27 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn pubsub_connect(&self) -> impl Future> { [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 90 | pub fn pubsub_connect(&self) -> impl Future> + use<> { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/pubsub/inner.rs:203:24 [INFO] [stdout] | [INFO] [stdout] 203 | if let Err(error) = sender.unbounded_send(Ok(msg)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/pubsub/inner.rs:207:21 [INFO] [stdout] | [INFO] [stdout] 207 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 203 ~ match sender.unbounded_send(Ok(msg)) { Err(error) => { [INFO] [stdout] 204 | if !error.is_disconnected() { [INFO] [stdout] 205 | return Err(error::internal(format!("Cannot send message: {}", error))); [INFO] [stdout] 206 | } [INFO] [stdout] 207 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/client/pubsub/inner.rs:218:24 [INFO] [stdout] | [INFO] [stdout] 218 | if let Err(error) = sender.unbounded_send(Ok(msg)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/client/pubsub/inner.rs:222:21 [INFO] [stdout] | [INFO] [stdout] 222 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 218 ~ match sender.unbounded_send(Ok(msg)) { Err(error) => { [INFO] [stdout] 219 | if !error.is_disconnected() { [INFO] [stdout] 220 | return Err(error::internal(format!("Cannot send message: {}", error))); [INFO] [stdout] 221 | } [INFO] [stdout] 222 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/reconnect.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 119 | if let Err(e) = (self.0.work_fn)(t, a) { [INFO] [stdout] | ^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/reconnect.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 119 ~ match (self.0.work_fn)(t, a) { Err(e) => { [INFO] [stdout] 120 | match e { [INFO] [stdout] ... [INFO] [stdout] 127 | Err(e) [INFO] [stdout] 128 ~ } _ => { [INFO] [stdout] 129 | Ok(true) [INFO] [stdout] 130 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `impl futures_util::Future> + std::marker::Send` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/reconnect.rs:169:10 [INFO] [stdout] | [INFO] [stdout] 169 | ) -> impl Future> + Send { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, these lifetimes are in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/reconnect.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | &self, [INFO] [stdout] | ^ [INFO] [stdout] 168 | mut state: MutexGuard>, [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] help: use the precise capturing `use<...>` syntax to make the captures explicit [INFO] [stdout] | [INFO] [stdout] 169 | ) -> impl Future> + Send + use { [INFO] [stdout] | +++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/psubscribe.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/subscribe.rs from 2021 edition to 2024 [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> examples/psubscribe.rs:33:11 [INFO] [stdout] | [INFO] [stdout] 33 | while let Some(message) = msgs.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> examples/psubscribe.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/monitor.rs from 2021 edition to 2024 [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> examples/subscribe.rs:35:11 [INFO] [stdout] | [INFO] [stdout] 35 | while let Some(message) = msgs.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^----------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> examples/subscribe.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/realistic.rs from 2021 edition to 2024 [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> examples/monitor.rs:39:11 [INFO] [stdout] | [INFO] [stdout] 39 | while let Some(incoming) = skip_one.next().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^--------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> examples/monitor.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.72s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking redis-async v0.17.2 (/tmp/fixit) [INFO] [stdout] error[E0521]: borrowed data escapes outside of method [INFO] [stdout] --> src/reconnect.rs:226:27 [INFO] [stdout] | [INFO] [stdout] 225 | fn reconnect_spawn(&self, state: MutexGuard>) { [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `self` is a reference that is only valid in the method body [INFO] [stdout] | let's call the lifetime of this reference `'1` [INFO] [stdout] 226 | let reconnect_f = self [INFO] [stdout] | ___________________________^ [INFO] [stdout] 227 | | .reconnect(state) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_____________________________`self` escapes the method body here [INFO] [stdout] | argument requires that `'1` must outlive `'static` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0521]: borrowed data escapes outside of method [INFO] [stdout] --> src/reconnect.rs:226:27 [INFO] [stdout] | [INFO] [stdout] 225 | fn reconnect_spawn(&self, state: MutexGuard>) { [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `state` is a reference that is only valid in the method body [INFO] [stdout] | has type `std::sync::MutexGuard<'2, ReconnectState>` [INFO] [stdout] 226 | let reconnect_f = self [INFO] [stdout] | ___________________________^ [INFO] [stdout] 227 | | .reconnect(state) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_____________________________`state` escapes the method body here [INFO] [stdout] | argument requires that `'2` must outlive `'static` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0521`. [INFO] [stdout] [INFO] [stderr] error: could not compile `redis-async` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error[E0521]: borrowed data escapes outside of method [INFO] [stdout] --> src/reconnect.rs:226:27 [INFO] [stdout] | [INFO] [stdout] 225 | fn reconnect_spawn(&self, state: MutexGuard>) { [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `self` is a reference that is only valid in the method body [INFO] [stdout] | let's call the lifetime of this reference `'1` [INFO] [stdout] 226 | let reconnect_f = self [INFO] [stdout] | ___________________________^ [INFO] [stdout] 227 | | .reconnect(state) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_____________________________`self` escapes the method body here [INFO] [stdout] | argument requires that `'1` must outlive `'static` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0521]: borrowed data escapes outside of method [INFO] [stdout] --> src/reconnect.rs:226:27 [INFO] [stdout] | [INFO] [stdout] 225 | fn reconnect_spawn(&self, state: MutexGuard>) { [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | `state` is a reference that is only valid in the method body [INFO] [stdout] | has type `std::sync::MutexGuard<'2, ReconnectState>` [INFO] [stdout] 226 | let reconnect_f = self [INFO] [stdout] | ___________________________^ [INFO] [stdout] 227 | | .reconnect(state) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_____________________________`state` escapes the method body here [INFO] [stdout] | argument requires that `'2` must outlive `'static` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0521`. [INFO] [stdout] [INFO] [stderr] error: could not compile `redis-async` (lib test) due to 3 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "bd5022931a246769c8faa7d845507cdf4c76cef7dd17feab5d8f928365d89de4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd5022931a246769c8faa7d845507cdf4c76cef7dd17feab5d8f928365d89de4", kill_on_drop: false }` [INFO] [stdout] bd5022931a246769c8faa7d845507cdf4c76cef7dd17feab5d8f928365d89de4