[INFO] fetching crate parity-db 0.4.13... [INFO] checking parity-db-0.4.13 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate parity-db 0.4.13 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate parity-db 0.4.13 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate parity-db 0.4.13 [INFO] finished tweaking crates.io crate parity-db 0.4.13 [INFO] tweaked toml for crates.io crate parity-db 0.4.13 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 102 packages to latest compatible versions [INFO] [stderr] Adding env_logger v0.10.2 (available: v0.11.5) [INFO] [stderr] Adding fdlimit v0.2.1 (available: v0.3.0) [INFO] [stderr] Adding generator v0.7.5 (available: v0.8.3) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding loom v0.5.6 (available: v0.7.2) [INFO] [stderr] Adding matchers v0.1.0 (available: v0.2.0) [INFO] [stderr] Adding memmap2 v0.5.10 (available: v0.9.5) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (available: v0.50.1) [INFO] [stderr] Adding regex-automata v0.1.10 (available: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding siphasher v0.3.11 (available: v1.0.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows v0.48.0 (available: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (available: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3bdfd0216817cd9b91284b6b80f5f2aab3e7b84035f9eaa8a0eab8b15fcf423f [INFO] running `Command { std: "docker" "start" "-a" "3bdfd0216817cd9b91284b6b80f5f2aab3e7b84035f9eaa8a0eab8b15fcf423f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3bdfd0216817cd9b91284b6b80f5f2aab3e7b84035f9eaa8a0eab8b15fcf423f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3bdfd0216817cd9b91284b6b80f5f2aab3e7b84035f9eaa8a0eab8b15fcf423f", kill_on_drop: false }` [INFO] [stdout] 3bdfd0216817cd9b91284b6b80f5f2aab3e7b84035f9eaa8a0eab8b15fcf423f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 02c525e14dfbf0f8dff310ab03a2638b473bae8dd090e084b4e5dd1ec6032bbf [INFO] running `Command { std: "docker" "start" "-a" "02c525e14dfbf0f8dff310ab03a2638b473bae8dd090e084b4e5dd1ec6032bbf", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Fixed Cargo.toml (1 fix) [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling cc v1.1.21 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking fdlimit v0.2.1 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling lz4-sys v1.11.1+lz4-1.10.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking lz4 v1.28.0 [INFO] [stderr] Checking parity-db v0.4.13 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `parity_db` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/error.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/error.rs:92:3 [INFO] [stderr] | [INFO] [stderr] 92 | ($e:expr_2021) => {{ [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/db.rs:2078:33 [INFO] [stdout] | [INFO] [stdout] 2078 | let mut prev_run: bool = rng.gen(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/index.rs:684:18 [INFO] [stdout] | [INFO] [stdout] 684 | keys[i] = rng.gen(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/index.rs:768:18 [INFO] [stdout] | [INFO] [stdout] 768 | keys[i] = rng.gen(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/options.rs:218:65 [INFO] [stdout] | [INFO] [stdout] 218 | let s: Salt = self.salt.unwrap_or_else(|| rand::thread_rng().gen()); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/error.rs:92:6 [INFO] [stdout] | [INFO] [stdout] 92 | ($e:expr) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 92 | ($e:expr_2021) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/mod.rs:212:6 [INFO] [stdout] | [INFO] [stdout] 212 | if let Some((_tier, value)) = Column::get_value(key_query, at, tables, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/mod.rs:214:3 [INFO] [stdout] | [INFO] [stdout] 214 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 212 ~ match Column::get_value(key_query, at, tables, log)? { Some((_tier, value)) => { [INFO] [stdout] 213 | Ok(value) [INFO] [stdout] 214 ~ } _ => { [INFO] [stdout] 215 | Err(Error::Corruption(format!("Missing btree entry at {at}"))) [INFO] [stdout] 216 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/mod.rs:344:7 [INFO] [stdout] | [INFO] [stdout] 344 | if let (_, Some(new_index)) = Column::write_existing_value_plan( [INFO] [stdout] | ________________^ - [INFO] [stdout] | |___________________________________________| [INFO] [stdout] 345 | || &k, [INFO] [stdout] 346 | || tables, [INFO] [stdout] 347 | || existing, [INFO] [stdout] ... || [INFO] [stdout] 351 | || false, [INFO] [stdout] 352 | || )? { [INFO] [stdout] | ||______________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/mod.rs:354:4 [INFO] [stdout] | [INFO] [stdout] 354 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 344 ~ match Column::write_existing_value_plan( [INFO] [stdout] 345 | &k, [INFO] [stdout] ... [INFO] [stdout] 351 | false, [INFO] [stdout] 352 ~ )? { (_, Some(new_index)) => { [INFO] [stdout] 353 | Some(new_index) [INFO] [stdout] 354 ~ } _ => { [INFO] [stdout] 355 | None [INFO] [stdout] 356 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/btree.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | if let Some((node_index, node)) = root.need_remove_root(btree, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/btree.rs:67:6 [INFO] [stdout] | [INFO] [stdout] 67 | }, [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 60 ~ match root.need_remove_root(btree, log)? { Some((node_index, node)) => { [INFO] [stdout] 61 | self.depth -= 1; [INFO] [stdout] ... [INFO] [stdout] 66 | root = node; [INFO] [stdout] 67 ~ } _ => {}}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/btree.rs:96:6 [INFO] [stdout] | [INFO] [stdout] 96 | if let Some(address) = root.get(key, values, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^--------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/btree.rs:100:3 [INFO] [stdout] | [INFO] [stdout] 100 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 96 ~ match root.get(key, values, log)? { Some(address) => { [INFO] [stdout] 97 | let key_query = TableKeyQuery::Fetch(None); [INFO] [stdout] 98 | let r = Column::get_value(key_query, address, values, log)?; [INFO] [stdout] 99 | Ok(r.map(|r| r.1)) [INFO] [stdout] 100 ~ } _ => { [INFO] [stdout] 101 | Ok(None) [INFO] [stdout] 102 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/iter.rs:157:11 [INFO] [stdout] | [INFO] [stdout] 157 | ... if let Some(value) = commit_value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/iter.rs:159:8 [INFO] [stdout] | [INFO] [stdout] 159 | ... } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 157 ~ match commit_value { Some(value) => { [INFO] [stdout] 158 | Some((commit_key.value().clone(), value.value().clone())) [INFO] [stdout] 159 ~ } _ => { [INFO] [stdout] 160 | self.last_key = LastKey::At(commit_key.value().clone()); [INFO] [stdout] 161 | continue [INFO] [stdout] 162 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/iter.rs:167:11 [INFO] [stdout] | [INFO] [stdout] 167 | ... if let Some(value) = commit_value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/iter.rs:169:8 [INFO] [stdout] | [INFO] [stdout] 169 | ... } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 167 ~ match commit_value { Some(value) => { [INFO] [stdout] 168 | Some((backend_key, value.value().clone())) [INFO] [stdout] 169 ~ } _ => { [INFO] [stdout] 170 | self.last_key = LastKey::At(commit_key.value().clone()); [INFO] [stdout] 171 | continue [INFO] [stdout] 172 ~ }}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/iter.rs:372:10 [INFO] [stdout] | [INFO] [stdout] 372 | if let Some(child) = [INFO] [stdout] | ____________________________^ [INFO] [stdout] 373 | | col.with_locked(|btree| state.1.fetch_child(child_ix, btree, log))? [INFO] [stdout] | |_____________________________------------------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/iter.rs:380:7 [INFO] [stdout] | [INFO] [stdout] 380 | } else if self.exit(direction) { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 372 ~ match col.with_locked(|btree| state.1.fetch_child(child_ix, btree, log))? [INFO] [stdout] 373 ~ { Some(child) => { [INFO] [stdout] 374 | if let Some((ix, _)) = self.state.last_mut() { [INFO] [stdout] ... [INFO] [stdout] 378 | self.state.push((node_start(&child, direction, is_child_leaf), child)) [INFO] [stdout] 379 ~ } _ => if self.exit(direction) { [INFO] [stdout] 380 | break [INFO] [stdout] 381 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/node.rs:119:18 [INFO] [stdout] | [INFO] [stdout] 119 | return Ok(if let Some(mut child) = self.fetch_child(i, btree, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/node.rs:133:5 [INFO] [stdout] | [INFO] [stdout] 133 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 119 ~ return Ok(match self.fetch_child(i, btree, log)? { Some(mut child) => { [INFO] [stdout] 120 | let r = child.change(Some((self, i)), depth - 1, changes, btree, log)?; [INFO] [stdout] ... [INFO] [stdout] 132 | } [INFO] [stdout] 133 ~ } _ => { [INFO] [stdout] 134 | (None, false) [INFO] [stdout] 135 ~ }}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/node.rs:265:10 [INFO] [stdout] | [INFO] [stdout] 265 | if let Some(mut child) = self.fetch_child(i, values, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^--------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/node.rs:274:7 [INFO] [stdout] | [INFO] [stdout] 274 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 265 ~ match self.fetch_child(i, values, log)? { Some(mut child) => { [INFO] [stdout] 266 | let (need_balance, sep) = child.remove_last(depth - 1, values, log)?; [INFO] [stdout] ... [INFO] [stdout] 273 | } [INFO] [stdout] 274 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/node.rs:284:14 [INFO] [stdout] | [INFO] [stdout] 284 | return if let Some(mut child) = self.fetch_child(i, values, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^--------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/node.rs:298:4 [INFO] [stdout] | [INFO] [stdout] 298 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 284 ~ return match self.fetch_child(i, values, log)? { Some(mut child) => { [INFO] [stdout] 285 | let r = child.change(Some((self, i)), depth - 1, changes, values, log)?; [INFO] [stdout] ... [INFO] [stdout] 297 | }) [INFO] [stdout] 298 ~ } _ => { [INFO] [stdout] 299 | Ok((None, false)) [INFO] [stdout] 300 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/node.rs:437:7 [INFO] [stdout] | [INFO] [stdout] 437 | if let Some(node) = self.fetch_child(0, values, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^--------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/node.rs:440:4 [INFO] [stdout] | [INFO] [stdout] 440 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 437 ~ match self.fetch_child(0, values, log)? { Some(node) => { [INFO] [stdout] 438 | let child = self.remove_child(0); [INFO] [stdout] 439 | return Ok(Some((child.entry_index, node))) [INFO] [stdout] 440 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/node.rs:461:13 [INFO] [stdout] | [INFO] [stdout] 461 | } else if let Some(mut child) = self.fetch_child(i + 1, values, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/node.rs:470:3 [INFO] [stdout] | [INFO] [stdout] 470 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 461 ~ } else { match self.fetch_child(i + 1, values, log)? { Some(mut child) => { [INFO] [stdout] 462 | let result = child.remove_last(depth - 1, values, log)?; [INFO] [stdout] ... [INFO] [stdout] 469 | } [INFO] [stdout] 470 ~ } _ => { [INFO] [stdout] 471 | Ok((false, None)) [INFO] [stdout] 472 ~ }}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/node.rs:520:7 [INFO] [stdout] | [INFO] [stdout] 520 | if let Some(child) = from.fetch_child(i, values, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^--------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/node.rs:524:4 [INFO] [stdout] | [INFO] [stdout] 524 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 520 ~ match from.fetch_child(i, values, log)? { Some(child) => { [INFO] [stdout] 521 | stack.push((LastIndex::Descend(i), from)); [INFO] [stdout] 522 | from = child; [INFO] [stdout] 523 | depth -= 1 [INFO] [stdout] 524 ~ } _ => { [INFO] [stdout] 525 | return Err(Error::Corruption(format!("A btree node is missing a child at {i:?}"))) [INFO] [stdout] 526 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/node.rs:607:7 [INFO] [stdout] | [INFO] [stdout] 607 | if let Some(sep) = entry.read_separator()? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/node.rs:610:4 [INFO] [stdout] | [INFO] [stdout] 610 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 607 ~ match entry.read_separator()? { Some(sep) => { [INFO] [stdout] 608 | node.separators.as_mut()[i_separator].separator = Some(sep); [INFO] [stdout] 609 | i_separator += 1 [INFO] [stdout] 610 ~ } _ => { [INFO] [stdout] 611 | break [INFO] [stdout] 612 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/mod.rs:438:8 [INFO] [stdout] | [INFO] [stdout] 438 | if let Entry::Occupied(e) = overlay.entry(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/mod.rs:442:5 [INFO] [stdout] | [INFO] [stdout] 442 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 438 ~ match overlay.entry(key) { Entry::Occupied(e) => { [INFO] [stdout] 439 | if e.get().0 == record_id { [INFO] [stdout] 440 | e.remove_entry(); [INFO] [stdout] 441 | } [INFO] [stdout] 442 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:212:7 [INFO] [stdout] | [INFO] [stdout] 212 | if let Some((tier, value)) = self.get_in_index(key, r, values, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:217:4 [INFO] [stdout] | [INFO] [stdout] 217 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 212 ~ match self.get_in_index(key, r, values, log)? { Some((tier, value)) => { [INFO] [stdout] 213 | if self.collect_stats { [INFO] [stdout] ... [INFO] [stdout] 216 | return Ok(Some(value)) [INFO] [stdout] 217 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:346:7 [INFO] [stdout] | [INFO] [stdout] 346 | if let Some(file) = entry.path().file_name().and_then(|f| f.to_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^-----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:352:4 [INFO] [stdout] | [INFO] [stdout] 352 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 346 ~ match entry.path().file_name().and_then(|f| f.to_str()) { Some(file) => { [INFO] [stdout] 347 | if crate::index::TableId::is_file_name(column, file) || [INFO] [stdout] ... [INFO] [stdout] 351 | } [INFO] [stdout] 352 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:421:7 [INFO] [stdout] | [INFO] [stdout] 421 | if let Some(table) = IndexTable::open_existing(path, id)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:430:4 [INFO] [stdout] | [INFO] [stdout] 430 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 421 ~ match IndexTable::open_existing(path, id)? { Some(table) => { [INFO] [stdout] 422 | if top.is_none() { [INFO] [stdout] ... [INFO] [stdout] 429 | } [INFO] [stdout] 430 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:487:9 [INFO] [stdout] | [INFO] [stdout] 487 | while let PlanOutcome::NeedReindex = [INFO] [stdout] | _______________^ [INFO] [stdout] 488 | | tables.index.write_insert_plan(key, address, None, log)? [INFO] [stdout] | |_____________-------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:493:3 [INFO] [stdout] | [INFO] [stdout] 493 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:554:7 [INFO] [stdout] | [INFO] [stdout] 554 | if let Some(r) = Self::search_index(key, index, tables, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^-------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:556:4 [INFO] [stdout] | [INFO] [stdout] 556 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 554 ~ match Self::search_index(key, index, tables, log)? { Some(r) => { [INFO] [stdout] 555 | return Ok(Some(r)) [INFO] [stdout] 556 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:656:9 [INFO] [stdout] | [INFO] [stdout] 656 | while let PlanOutcome::NeedReindex = [INFO] [stdout] | _______________^ [INFO] [stdout] 657 | | tables.index.write_insert_plan(key, address, None, log)? [INFO] [stdout] | |_____________-------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:662:3 [INFO] [stdout] | [INFO] [stdout] 662 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:673:15 [INFO] [stdout] | [INFO] [stdout] 673 | } else if let Some(table) = reindex.queue.iter().find(|r| r.id == record.table) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^-------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:675:5 [INFO] [stdout] | [INFO] [stdout] 675 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 673 ~ } else { match reindex.queue.iter().find(|r| r.id == record.table) { Some(table) => { [INFO] [stdout] 674 | table.enact_plan(record.index, log)?; [INFO] [stdout] 675 ~ } _ => { [INFO] [stdout] 676 | // This may happen when removal is planed for an old index when reindexing. [INFO] [stdout] ... [INFO] [stdout] 684 | IndexTable::skip_plan(log)?; [INFO] [stdout] 685 ~ }}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:705:15 [INFO] [stdout] | [INFO] [stdout] 705 | } else if let Some(table) = reindex.queue.iter().find(|r| r.id == record.table) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^-------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:707:5 [INFO] [stdout] | [INFO] [stdout] 707 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 705 ~ } else { match reindex.queue.iter().find(|r| r.id == record.table) { Some(table) => { [INFO] [stdout] 706 | table.validate_plan(record.index, log)?; [INFO] [stdout] 707 ~ } _ => { [INFO] [stdout] 708 | if record.table.index_bits() < tables.index.id.index_bits() { [INFO] [stdout] ... [INFO] [stdout] 722 | return self.validate_plan(LogAction::InsertIndex(record), log) [INFO] [stdout] 723 ~ }}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:777:9 [INFO] [stdout] | [INFO] [stdout] 777 | if let Ok(value) = self.compression.decompress(&value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^----------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:779:6 [INFO] [stdout] | [INFO] [stdout] 779 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 777 ~ match self.compression.decompress(&value) { Ok(value) => { [INFO] [stdout] 778 | value [INFO] [stdout] 779 ~ } _ => { [INFO] [stdout] 780 | return false [INFO] [stdout] 781 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:840:28 [INFO] [stdout] | [INFO] [stdout] 840 | let value_entry = if let Error::Corruption(_) = &e { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:842:7 [INFO] [stdout] | [INFO] [stdout] 842 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 840 ~ let value_entry = match &e { Error::Corruption(_) => { [INFO] [stdout] 841 | tables.value[size_tier as usize].dump_entry(offset).ok() [INFO] [stdout] 842 ~ } _ => { [INFO] [stdout] 843 | None [INFO] [stdout] 844 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:918:27 [INFO] [stdout] | [INFO] [stdout] 918 | let value_entry = if let Error::Corruption(_) = &e { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:920:6 [INFO] [stdout] | [INFO] [stdout] 920 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 918 ~ let value_entry = match &e { Error::Corruption(_) => { [INFO] [stdout] 919 | tables.value[size_tier as usize].dump_entry(offset).ok() [INFO] [stdout] 920 ~ } _ => { [INFO] [stdout] 921 | None [INFO] [stdout] 922 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:359:7 [INFO] [stdout] | [INFO] [stdout] 359 | if let Some(err) = &*bg_err { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:361:4 [INFO] [stdout] | [INFO] [stdout] 361 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 359 ~ match &*bg_err { Some(err) => { [INFO] [stdout] 360 | return Err(Error::Background(err.clone())) [INFO] [stdout] 361 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:417:7 [INFO] [stdout] | [INFO] [stdout] 417 | if let Some(commit) = queue.commits.pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:436:4 [INFO] [stdout] | [INFO] [stdout] 436 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 417 ~ match queue.commits.pop_front() { Some(commit) => { [INFO] [stdout] 418 | queue.bytes -= commit.bytes; [INFO] [stdout] ... [INFO] [stdout] 435 | Some(commit) [INFO] [stdout] 436 ~ } _ => { [INFO] [stdout] 437 | None [INFO] [stdout] 438 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:441:6 [INFO] [stdout] | [INFO] [stdout] 441 | if let Some(mut commit) = commit { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:512:3 [INFO] [stdout] | [INFO] [stdout] 512 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 441 ~ match commit { Some(mut commit) => { [INFO] [stdout] 442 | let mut reindex = false; [INFO] [stdout] ... [INFO] [stdout] 511 | Ok(true) [INFO] [stdout] 512 ~ } _ => { [INFO] [stdout] 513 | Ok(false) [INFO] [stdout] 514 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:540:9 [INFO] [stdout] | [INFO] [stdout] 540 | if let PlanOutcome::NeedReindex = [INFO] [stdout] | ________________________^ [INFO] [stdout] 541 | | column.write_reindex_plan(&key, address, &mut writer)? [INFO] [stdout] | |_________________________-----------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:544:6 [INFO] [stdout] | [INFO] [stdout] 544 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 540 ~ match column.write_reindex_plan(&key, address, &mut writer)? [INFO] [stdout] 541 ~ { PlanOutcome::NeedReindex => { [INFO] [stdout] 542 | next_reindex = true [INFO] [stdout] 543 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:584:7 [INFO] [stdout] | [INFO] [stdout] 584 | if let Some(mut reader) = reader { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:700:4 [INFO] [stdout] | [INFO] [stdout] 700 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 584 ~ match reader { Some(mut reader) => { [INFO] [stdout] 585 | log::debug!( [INFO] [stdout] ... [INFO] [stdout] 699 | Some((record_id, cleared, bytes)) [INFO] [stdout] 700 ~ } _ => { [INFO] [stdout] 701 | log::debug!(target: "parity-db", "End of log"); [INFO] [stdout] 702 | None [INFO] [stdout] 703 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:621:12 [INFO] [stdout] | [INFO] [stdout] 621 | ... if let Err(e) = self.columns.get(col).map_or_else( [INFO] [stdout] | __________________________^ - [INFO] [stdout] | |_______________________________________| [INFO] [stdout] 622 | || ... || Err(Error::Corruption(format!("Invalid column id {col}"))), [INFO] [stdout] 623 | || ... |col| { [INFO] [stdout] 624 | || ... col.validate_plan( [INFO] [stdout] ... || [INFO] [stdout] 628 | || ... }, [INFO] [stdout] 629 | || ... ) { [INFO] [stdout] | ||_______________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |_______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:634:9 [INFO] [stdout] | [INFO] [stdout] 634 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 621 ~ match self.columns.get(col).map_or_else( [INFO] [stdout] 622 | || Err(Error::Corruption(format!("Invalid column id {col}"))), [INFO] [stdout] ... [INFO] [stdout] 628 | }, [INFO] [stdout] 629 ~ ) { Err(e) => { [INFO] [stdout] 630 | log::warn!(target: "parity-db", "Error validating log: {:?}.", e); [INFO] [stdout] ... [INFO] [stdout] 633 | return Ok(false) [INFO] [stdout] 634 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:638:12 [INFO] [stdout] | [INFO] [stdout] 638 | ... if let Err(e) = self.columns.get(col).map_or_else( [INFO] [stdout] | __________________________^ - [INFO] [stdout] | |_______________________________________| [INFO] [stdout] 639 | || ... || Err(Error::Corruption(format!("Invalid column id {col}"))), [INFO] [stdout] 640 | || ... |col| { [INFO] [stdout] 641 | || ... col.validate_plan( [INFO] [stdout] ... || [INFO] [stdout] 645 | || ... }, [INFO] [stdout] 646 | || ... ) { [INFO] [stdout] | ||_______________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |_______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:651:9 [INFO] [stdout] | [INFO] [stdout] 651 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 638 ~ match self.columns.get(col).map_or_else( [INFO] [stdout] 639 | || Err(Error::Corruption(format!("Invalid column id {col}"))), [INFO] [stdout] ... [INFO] [stdout] 645 | }, [INFO] [stdout] 646 ~ ) { Err(e) => { [INFO] [stdout] 647 | log::warn!(target: "parity-db", "Error validating log: {:?}.", e); [INFO] [stdout] ... [INFO] [stdout] 650 | return Ok(false) [INFO] [stdout] 651 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:780:9 [INFO] [stdout] | [INFO] [stdout] 780 | while let Some(id) = self.log.replay_next()? { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:783:3 [INFO] [stdout] | [INFO] [stdout] 783 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:804:7 [INFO] [stdout] | [INFO] [stdout] 804 | if let Some(err) = self.bg_err.lock().as_ref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^------------------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:810:4 [INFO] [stdout] | [INFO] [stdout] 810 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 804 ~ match self.bg_err.lock().as_ref() { Some(err) => { [INFO] [stdout] 805 | // On error the log reader may be left in inconsistent state. So it is important [INFO] [stdout] ... [INFO] [stdout] 809 | return Ok(()) [INFO] [stdout] 810 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:828:9 [INFO] [stdout] | [INFO] [stdout] 828 | if let Err(e) = self.write_stats_text(&mut writer, None) { [INFO] [stdout] | ^^^^^^^^^^^^^---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:830:6 [INFO] [stdout] | [INFO] [stdout] 830 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 828 ~ match self.write_stats_text(&mut writer, None) { Err(e) => { [INFO] [stdout] 829 | log::warn!(target: "parity-db", "Error writing stats file: {:?}", e) [INFO] [stdout] 830 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:865:6 [INFO] [stdout] | [INFO] [stdout] 865 | if let Err(e) = result { [INFO] [stdout] | ^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:873:3 [INFO] [stdout] | [INFO] [stdout] 873 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 865 ~ match result { Err(e) => { [INFO] [stdout] 866 | log::warn!(target: "parity-db", "Background worker error: {}", e); [INFO] [stdout] ... [INFO] [stdout] 872 | self.commit_queue_full_cv.notify_all(); [INFO] [stdout] 873 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:931:6 [INFO] [stdout] | [INFO] [stdout] 931 | if let Err(e) = db.replay_all_logs() { [INFO] [stdout] | ^^^^^^^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:934:3 [INFO] [stdout] | [INFO] [stdout] 934 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 931 ~ match db.replay_all_logs() { Err(e) => { [INFO] [stdout] 932 | log::debug!(target: "parity-db", "Error during log replay."); [INFO] [stdout] 933 | return Err(e) [INFO] [stdout] 934 ~ } _ => { [INFO] [stdout] 935 | db.log.clear_replay_logs(); [INFO] [stdout] 936 | db.clean_all_logs()?; [INFO] [stdout] 937 | db.log.kill_logs()?; [INFO] [stdout] 938 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:1237:7 [INFO] [stdout] | [INFO] [stdout] 1237 | if let Err(e) = t.join() { [INFO] [stdout] | ^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:1239:4 [INFO] [stdout] | [INFO] [stdout] 1239 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1237 ~ match t.join() { Err(e) => { [INFO] [stdout] 1238 | log::warn!(target: "parity-db", "Log thread shutdown error: {:?}", e); [INFO] [stdout] 1239 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:1242:7 [INFO] [stdout] | [INFO] [stdout] 1242 | if let Err(e) = t.join() { [INFO] [stdout] | ^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:1244:4 [INFO] [stdout] | [INFO] [stdout] 1244 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1242 ~ match t.join() { Err(e) => { [INFO] [stdout] 1243 | log::warn!(target: "parity-db", "Flush thread shutdown error: {:?}", e); [INFO] [stdout] 1244 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:1247:7 [INFO] [stdout] | [INFO] [stdout] 1247 | if let Err(e) = t.join() { [INFO] [stdout] | ^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:1249:4 [INFO] [stdout] | [INFO] [stdout] 1249 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1247 ~ match t.join() { Err(e) => { [INFO] [stdout] 1248 | log::warn!(target: "parity-db", "Commit thread shutdown error: {:?}", e); [INFO] [stdout] 1249 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:1252:7 [INFO] [stdout] | [INFO] [stdout] 1252 | if let Err(e) = t.join() { [INFO] [stdout] | ^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:1254:4 [INFO] [stdout] | [INFO] [stdout] 1254 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1252 ~ match t.join() { Err(e) => { [INFO] [stdout] 1253 | log::warn!(target: "parity-db", "Cleanup thread shutdown error: {:?}", e); [INFO] [stdout] 1254 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:1259:6 [INFO] [stdout] | [INFO] [stdout] 1259 | if let Err(e) = self.inner.lock_file.unlock() { [INFO] [stdout] | ^^^^^^^^^^^^^----------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:1261:3 [INFO] [stdout] | [INFO] [stdout] 1261 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1259 ~ match self.inner.lock_file.unlock() { Err(e) => { [INFO] [stdout] 1260 | log::debug!(target: "parity-db", "Error removing file lock: {:?}", e); [INFO] [stdout] 1261 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:1510:9 [INFO] [stdout] | [INFO] [stdout] 1510 | if let Entry::Occupied(e) = overlay.indexed.entry(*k) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^---------------^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:1514:6 [INFO] [stdout] | [INFO] [stdout] 1514 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1510 ~ match overlay.indexed.entry(*k) { Entry::Occupied(e) => { [INFO] [stdout] 1511 | if e.get().0 == record_id { [INFO] [stdout] 1512 | e.remove_entry(); [INFO] [stdout] 1513 | } [INFO] [stdout] 1514 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/index.rs:235:6 [INFO] [stdout] | [INFO] [stdout] 235 | if let Some(map) = &*self.map.read() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^---------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/index.rs:239:3 [INFO] [stdout] | [INFO] [stdout] 239 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 235 ~ match &*self.map.read() { Some(map) => { [INFO] [stdout] 236 | Ok(ColumnStats::from_slice(try_io!(Ok( [INFO] [stdout] 237 | &map[HEADER_SIZE..HEADER_SIZE + stats::TOTAL_SIZE] [INFO] [stdout] 238 | )))) [INFO] [stdout] 239 ~ } _ => { [INFO] [stdout] 240 | Ok(ColumnStats::empty()) [INFO] [stdout] 241 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/log.rs:570:7 [INFO] [stdout] | [INFO] [stdout] 570 | if let Some(name) = entry.file_name().as_os_str().to_str() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^-----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/log.rs:588:4 [INFO] [stdout] | [INFO] [stdout] 588 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 570 ~ match entry.file_name().as_os_str().to_str() { Some(name) => { [INFO] [stdout] 571 | if try_io!(entry.metadata()).is_file() && name.starts_with("log") { [INFO] [stdout] ... [INFO] [stdout] 587 | } [INFO] [stdout] 588 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/log.rs:682:24 [INFO] [stdout] | [INFO] [stdout] 682 | let (id, file) = if let Some((id, file)) = self.log_pool.write().pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^--------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/log.rs:685:4 [INFO] [stdout] | [INFO] [stdout] 685 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 682 ~ let (id, file) = match self.log_pool.write().pop_front() { Some((id, file)) => { [INFO] [stdout] 683 | log::debug!(target: "parity-db", "Flush: Activated pool writer {}", id); [INFO] [stdout] 684 | (id, file) [INFO] [stdout] 685 ~ } _ => { [INFO] [stdout] 686 | // find a free id [INFO] [stdout] ... [INFO] [stdout] 695 | (id, file) [INFO] [stdout] 696 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/log.rs:732:7 [INFO] [stdout] | [INFO] [stdout] 732 | if let Some(ref mut overlay) = overlays.index.get_mut(table.log_index()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/log.rs:738:4 [INFO] [stdout] | [INFO] [stdout] 738 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 732 ~ match overlays.index.get_mut(table.log_index()) { Some(ref mut overlay) => { [INFO] [stdout] 733 | if let std::collections::hash_map::Entry::Occupied(e) = overlay.map.entry(index) { [INFO] [stdout] ... [INFO] [stdout] 737 | } [INFO] [stdout] 738 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/log.rs:741:7 [INFO] [stdout] | [INFO] [stdout] 741 | if let Some(ref mut overlay) = overlays.value.get_mut(table.log_index()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/log.rs:747:4 [INFO] [stdout] | [INFO] [stdout] 747 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 741 ~ match overlays.value.get_mut(table.log_index()) { Some(ref mut overlay) => { [INFO] [stdout] 742 | if let std::collections::hash_map::Entry::Occupied(e) = overlay.map.entry(index) { [INFO] [stdout] ... [INFO] [stdout] 746 | } [INFO] [stdout] 747 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/log.rs:797:7 [INFO] [stdout] | [INFO] [stdout] 797 | if let Some(reading) = reading.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/log.rs:801:4 [INFO] [stdout] | [INFO] [stdout] 801 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 797 ~ match reading.take() { Some(reading) => { [INFO] [stdout] 798 | log::debug!(target: "parity-db", "Replay: Activated log cleanup {}", reading.id); [INFO] [stdout] 799 | let file = reading.file.into_inner(); [INFO] [stdout] 800 | self.cleanup_queue.write().push_back((reading.id, file)); [INFO] [stdout] 801 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/log.rs:803:6 [INFO] [stdout] | [INFO] [stdout] 803 | if let Some((id, _record_id, file)) = self.replay_queue.write().pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/log.rs:807:3 [INFO] [stdout] | [INFO] [stdout] 807 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 803 ~ match self.replay_queue.write().pop_front() { Some((id, _record_id, file)) => { [INFO] [stdout] 804 | log::debug!(target: "parity-db", "Replay: Activated log reader {}", id); [INFO] [stdout] 805 | *reading = Some(Reading { id, file: std::io::BufReader::new(file) }); [INFO] [stdout] 806 | Ok(Some(id)) [INFO] [stdout] 807 ~ } _ => { [INFO] [stdout] 808 | Ok(None) [INFO] [stdout] 809 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/log.rs:846:7 [INFO] [stdout] | [INFO] [stdout] 846 | if let Some((id, mut file)) = self.read_queue.write().pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/log.rs:849:4 [INFO] [stdout] | [INFO] [stdout] 849 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 846 ~ match self.read_queue.write().pop_front() { Some((id, mut file)) => { [INFO] [stdout] 847 | try_io!(file.rewind()); [INFO] [stdout] 848 | *reading = Some(Reading { id, file: std::io::BufReader::new(file) }); [INFO] [stdout] 849 ~ } _ => { [INFO] [stdout] 850 | log::trace!(target: "parity-db", "No active reader"); [INFO] [stdout] 851 | return Ok(None) [INFO] [stdout] 852 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/migration.rs:182:6 [INFO] [stdout] | [INFO] [stdout] 182 | if let Some(file) = entry.path().file_name().and_then(|f| f.to_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^-----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/migration.rs:196:3 [INFO] [stdout] | [INFO] [stdout] 196 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 182 ~ match entry.path().file_name().and_then(|f| f.to_str()) { Some(file) => { [INFO] [stdout] 183 | if crate::index::TableId::is_file_name(c, file) || [INFO] [stdout] ... [INFO] [stdout] 195 | } [INFO] [stdout] 196 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/table.rs:475:36 [INFO] [stdout] | [INFO] [stdout] 475 | let buf: LockedSlice<_, _> = if let Some(buf) = vbuf.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/table.rs:483:4 [INFO] [stdout] | [INFO] [stdout] 483 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 475 ~ let buf: LockedSlice<_, _> = match vbuf.as_deref() { Some(buf) => { [INFO] [stdout] 476 | log::trace!( [INFO] [stdout] ... [INFO] [stdout] 482 | LockedSlice::FromOverlay(buf) [INFO] [stdout] 483 ~ } _ => { [INFO] [stdout] 484 | log::trace!( [INFO] [stdout] ... [INFO] [stdout] 491 | LockedSlice::FromFile(vbuf) [INFO] [stdout] 492 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/table.rs:572:6 [INFO] [stdout] | [INFO] [stdout] 572 | if let Some((value, compressed, _)) = [INFO] [stdout] | ____________^ [INFO] [stdout] 573 | | self.query(&mut TableKeyQuery::Check(key), index, log)? [INFO] [stdout] | |_____________------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/table.rs:576:3 [INFO] [stdout] | [INFO] [stdout] 576 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 572 ~ match self.query(&mut TableKeyQuery::Check(key), index, log)? [INFO] [stdout] 573 ~ { Some((value, compressed, _)) => { [INFO] [stdout] 574 | Ok(Some((value, compressed))) [INFO] [stdout] 575 ~ } _ => { [INFO] [stdout] 576 | Ok(None) [INFO] [stdout] 577 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 60 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/loom.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `parity_db` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/error.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/error.rs:92:3 [INFO] [stderr] | [INFO] [stderr] 92 | ($e:expr_2021) => {{ [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/db.rs:2078:33 [INFO] [stdout] | [INFO] [stdout] 2078 | let mut prev_run: bool = rng.gen(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] = note: `--force-warn keyword-idents-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/index.rs:684:18 [INFO] [stdout] | [INFO] [stdout] 684 | keys[i] = rng.gen(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/index.rs:768:18 [INFO] [stdout] | [INFO] [stdout] 768 | keys[i] = rng.gen(); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `gen` is a keyword in the 2024 edition [INFO] [stdout] --> src/options.rs:218:65 [INFO] [stdout] | [INFO] [stdout] 218 | let s: Salt = self.salt.unwrap_or_else(|| rand::thread_rng().gen()); [INFO] [stdout] | ^^^ help: you can use a raw identifier to stay compatible: `r#gen` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #49716 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/error.rs:92:6 [INFO] [stdout] | [INFO] [stdout] 92 | ($e:expr) => {{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 92 | ($e:expr_2021) => {{ [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/mod.rs:212:6 [INFO] [stdout] | [INFO] [stdout] 212 | if let Some((_tier, value)) = Column::get_value(key_query, at, tables, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/mod.rs:214:3 [INFO] [stdout] | [INFO] [stdout] 214 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 212 ~ match Column::get_value(key_query, at, tables, log)? { Some((_tier, value)) => { [INFO] [stdout] 213 | Ok(value) [INFO] [stdout] 214 ~ } _ => { [INFO] [stdout] 215 | Err(Error::Corruption(format!("Missing btree entry at {at}"))) [INFO] [stdout] 216 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/mod.rs:344:7 [INFO] [stdout] | [INFO] [stdout] 344 | if let (_, Some(new_index)) = Column::write_existing_value_plan( [INFO] [stdout] | ________________^ - [INFO] [stdout] | |___________________________________________| [INFO] [stdout] 345 | || &k, [INFO] [stdout] 346 | || tables, [INFO] [stdout] 347 | || existing, [INFO] [stdout] ... || [INFO] [stdout] 351 | || false, [INFO] [stdout] 352 | || )? { [INFO] [stdout] | ||______________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/mod.rs:354:4 [INFO] [stdout] | [INFO] [stdout] 354 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 344 ~ match Column::write_existing_value_plan( [INFO] [stdout] 345 | &k, [INFO] [stdout] ... [INFO] [stdout] 351 | false, [INFO] [stdout] 352 ~ )? { (_, Some(new_index)) => { [INFO] [stdout] 353 | Some(new_index) [INFO] [stdout] 354 ~ } _ => { [INFO] [stdout] 355 | None [INFO] [stdout] 356 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/btree.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | if let Some((node_index, node)) = root.need_remove_root(btree, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/btree.rs:67:6 [INFO] [stdout] | [INFO] [stdout] 67 | }, [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 60 ~ match root.need_remove_root(btree, log)? { Some((node_index, node)) => { [INFO] [stdout] 61 | self.depth -= 1; [INFO] [stdout] ... [INFO] [stdout] 66 | root = node; [INFO] [stdout] 67 ~ } _ => {}}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/btree.rs:96:6 [INFO] [stdout] | [INFO] [stdout] 96 | if let Some(address) = root.get(key, values, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^--------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/btree.rs:100:3 [INFO] [stdout] | [INFO] [stdout] 100 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 96 ~ match root.get(key, values, log)? { Some(address) => { [INFO] [stdout] 97 | let key_query = TableKeyQuery::Fetch(None); [INFO] [stdout] 98 | let r = Column::get_value(key_query, address, values, log)?; [INFO] [stdout] 99 | Ok(r.map(|r| r.1)) [INFO] [stdout] 100 ~ } _ => { [INFO] [stdout] 101 | Ok(None) [INFO] [stdout] 102 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/iter.rs:157:11 [INFO] [stdout] | [INFO] [stdout] 157 | ... if let Some(value) = commit_value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/iter.rs:159:8 [INFO] [stdout] | [INFO] [stdout] 159 | ... } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 157 ~ match commit_value { Some(value) => { [INFO] [stdout] 158 | Some((commit_key.value().clone(), value.value().clone())) [INFO] [stdout] 159 ~ } _ => { [INFO] [stdout] 160 | self.last_key = LastKey::At(commit_key.value().clone()); [INFO] [stdout] 161 | continue [INFO] [stdout] 162 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/iter.rs:167:11 [INFO] [stdout] | [INFO] [stdout] 167 | ... if let Some(value) = commit_value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/iter.rs:169:8 [INFO] [stdout] | [INFO] [stdout] 169 | ... } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 167 ~ match commit_value { Some(value) => { [INFO] [stdout] 168 | Some((backend_key, value.value().clone())) [INFO] [stdout] 169 ~ } _ => { [INFO] [stdout] 170 | self.last_key = LastKey::At(commit_key.value().clone()); [INFO] [stdout] 171 | continue [INFO] [stdout] 172 ~ }}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/iter.rs:372:10 [INFO] [stdout] | [INFO] [stdout] 372 | if let Some(child) = [INFO] [stdout] | ____________________________^ [INFO] [stdout] 373 | | col.with_locked(|btree| state.1.fetch_child(child_ix, btree, log))? [INFO] [stdout] | |_____________________________------------------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/iter.rs:380:7 [INFO] [stdout] | [INFO] [stdout] 380 | } else if self.exit(direction) { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 372 ~ match col.with_locked(|btree| state.1.fetch_child(child_ix, btree, log))? [INFO] [stdout] 373 ~ { Some(child) => { [INFO] [stdout] 374 | if let Some((ix, _)) = self.state.last_mut() { [INFO] [stdout] ... [INFO] [stdout] 378 | self.state.push((node_start(&child, direction, is_child_leaf), child)) [INFO] [stdout] 379 ~ } _ => if self.exit(direction) { [INFO] [stdout] 380 | break [INFO] [stdout] 381 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/node.rs:119:18 [INFO] [stdout] | [INFO] [stdout] 119 | return Ok(if let Some(mut child) = self.fetch_child(i, btree, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/node.rs:133:5 [INFO] [stdout] | [INFO] [stdout] 133 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 119 ~ return Ok(match self.fetch_child(i, btree, log)? { Some(mut child) => { [INFO] [stdout] 120 | let r = child.change(Some((self, i)), depth - 1, changes, btree, log)?; [INFO] [stdout] ... [INFO] [stdout] 132 | } [INFO] [stdout] 133 ~ } _ => { [INFO] [stdout] 134 | (None, false) [INFO] [stdout] 135 ~ }}) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/node.rs:265:10 [INFO] [stdout] | [INFO] [stdout] 265 | if let Some(mut child) = self.fetch_child(i, values, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^--------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/node.rs:274:7 [INFO] [stdout] | [INFO] [stdout] 274 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 265 ~ match self.fetch_child(i, values, log)? { Some(mut child) => { [INFO] [stdout] 266 | let (need_balance, sep) = child.remove_last(depth - 1, values, log)?; [INFO] [stdout] ... [INFO] [stdout] 273 | } [INFO] [stdout] 274 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/node.rs:284:14 [INFO] [stdout] | [INFO] [stdout] 284 | return if let Some(mut child) = self.fetch_child(i, values, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^--------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/node.rs:298:4 [INFO] [stdout] | [INFO] [stdout] 298 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 284 ~ return match self.fetch_child(i, values, log)? { Some(mut child) => { [INFO] [stdout] 285 | let r = child.change(Some((self, i)), depth - 1, changes, values, log)?; [INFO] [stdout] ... [INFO] [stdout] 297 | }) [INFO] [stdout] 298 ~ } _ => { [INFO] [stdout] 299 | Ok((None, false)) [INFO] [stdout] 300 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/node.rs:437:7 [INFO] [stdout] | [INFO] [stdout] 437 | if let Some(node) = self.fetch_child(0, values, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^--------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/node.rs:440:4 [INFO] [stdout] | [INFO] [stdout] 440 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 437 ~ match self.fetch_child(0, values, log)? { Some(node) => { [INFO] [stdout] 438 | let child = self.remove_child(0); [INFO] [stdout] 439 | return Ok(Some((child.entry_index, node))) [INFO] [stdout] 440 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/node.rs:461:13 [INFO] [stdout] | [INFO] [stdout] 461 | } else if let Some(mut child) = self.fetch_child(i + 1, values, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/node.rs:470:3 [INFO] [stdout] | [INFO] [stdout] 470 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 461 ~ } else { match self.fetch_child(i + 1, values, log)? { Some(mut child) => { [INFO] [stdout] 462 | let result = child.remove_last(depth - 1, values, log)?; [INFO] [stdout] ... [INFO] [stdout] 469 | } [INFO] [stdout] 470 ~ } _ => { [INFO] [stdout] 471 | Ok((false, None)) [INFO] [stdout] 472 ~ }}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/node.rs:520:7 [INFO] [stdout] | [INFO] [stdout] 520 | if let Some(child) = from.fetch_child(i, values, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^--------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/node.rs:524:4 [INFO] [stdout] | [INFO] [stdout] 524 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 520 ~ match from.fetch_child(i, values, log)? { Some(child) => { [INFO] [stdout] 521 | stack.push((LastIndex::Descend(i), from)); [INFO] [stdout] 522 | from = child; [INFO] [stdout] 523 | depth -= 1 [INFO] [stdout] 524 ~ } _ => { [INFO] [stdout] 525 | return Err(Error::Corruption(format!("A btree node is missing a child at {i:?}"))) [INFO] [stdout] 526 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/node.rs:607:7 [INFO] [stdout] | [INFO] [stdout] 607 | if let Some(sep) = entry.read_separator()? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/node.rs:610:4 [INFO] [stdout] | [INFO] [stdout] 610 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 607 ~ match entry.read_separator()? { Some(sep) => { [INFO] [stdout] 608 | node.separators.as_mut()[i_separator].separator = Some(sep); [INFO] [stdout] 609 | i_separator += 1 [INFO] [stdout] 610 ~ } _ => { [INFO] [stdout] 611 | break [INFO] [stdout] 612 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/btree/mod.rs:438:8 [INFO] [stdout] | [INFO] [stdout] 438 | if let Entry::Occupied(e) = overlay.entry(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/btree/mod.rs:442:5 [INFO] [stdout] | [INFO] [stdout] 442 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 438 ~ match overlay.entry(key) { Entry::Occupied(e) => { [INFO] [stdout] 439 | if e.get().0 == record_id { [INFO] [stdout] 440 | e.remove_entry(); [INFO] [stdout] 441 | } [INFO] [stdout] 442 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:212:7 [INFO] [stdout] | [INFO] [stdout] 212 | if let Some((tier, value)) = self.get_in_index(key, r, values, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:217:4 [INFO] [stdout] | [INFO] [stdout] 217 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 212 ~ match self.get_in_index(key, r, values, log)? { Some((tier, value)) => { [INFO] [stdout] 213 | if self.collect_stats { [INFO] [stdout] ... [INFO] [stdout] 216 | return Ok(Some(value)) [INFO] [stdout] 217 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:346:7 [INFO] [stdout] | [INFO] [stdout] 346 | if let Some(file) = entry.path().file_name().and_then(|f| f.to_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^-----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:352:4 [INFO] [stdout] | [INFO] [stdout] 352 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 346 ~ match entry.path().file_name().and_then(|f| f.to_str()) { Some(file) => { [INFO] [stdout] 347 | if crate::index::TableId::is_file_name(column, file) || [INFO] [stdout] ... [INFO] [stdout] 351 | } [INFO] [stdout] 352 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:421:7 [INFO] [stdout] | [INFO] [stdout] 421 | if let Some(table) = IndexTable::open_existing(path, id)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:430:4 [INFO] [stdout] | [INFO] [stdout] 430 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 421 ~ match IndexTable::open_existing(path, id)? { Some(table) => { [INFO] [stdout] 422 | if top.is_none() { [INFO] [stdout] ... [INFO] [stdout] 429 | } [INFO] [stdout] 430 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:487:9 [INFO] [stdout] | [INFO] [stdout] 487 | while let PlanOutcome::NeedReindex = [INFO] [stdout] | _______________^ [INFO] [stdout] 488 | | tables.index.write_insert_plan(key, address, None, log)? [INFO] [stdout] | |_____________-------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:493:3 [INFO] [stdout] | [INFO] [stdout] 493 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:554:7 [INFO] [stdout] | [INFO] [stdout] 554 | if let Some(r) = Self::search_index(key, index, tables, log)? { [INFO] [stdout] | ^^^^^^^^^^^^^^-------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:556:4 [INFO] [stdout] | [INFO] [stdout] 556 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 554 ~ match Self::search_index(key, index, tables, log)? { Some(r) => { [INFO] [stdout] 555 | return Ok(Some(r)) [INFO] [stdout] 556 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:656:9 [INFO] [stdout] | [INFO] [stdout] 656 | while let PlanOutcome::NeedReindex = [INFO] [stdout] | _______________^ [INFO] [stdout] 657 | | tables.index.write_insert_plan(key, address, None, log)? [INFO] [stdout] | |_____________-------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:662:3 [INFO] [stdout] | [INFO] [stdout] 662 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:673:15 [INFO] [stdout] | [INFO] [stdout] 673 | } else if let Some(table) = reindex.queue.iter().find(|r| r.id == record.table) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^-------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:675:5 [INFO] [stdout] | [INFO] [stdout] 675 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 673 ~ } else { match reindex.queue.iter().find(|r| r.id == record.table) { Some(table) => { [INFO] [stdout] 674 | table.enact_plan(record.index, log)?; [INFO] [stdout] 675 ~ } _ => { [INFO] [stdout] 676 | // This may happen when removal is planed for an old index when reindexing. [INFO] [stdout] ... [INFO] [stdout] 684 | IndexTable::skip_plan(log)?; [INFO] [stdout] 685 ~ }}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:705:15 [INFO] [stdout] | [INFO] [stdout] 705 | } else if let Some(table) = reindex.queue.iter().find(|r| r.id == record.table) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^-------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:707:5 [INFO] [stdout] | [INFO] [stdout] 707 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 705 ~ } else { match reindex.queue.iter().find(|r| r.id == record.table) { Some(table) => { [INFO] [stdout] 706 | table.validate_plan(record.index, log)?; [INFO] [stdout] 707 ~ } _ => { [INFO] [stdout] 708 | if record.table.index_bits() < tables.index.id.index_bits() { [INFO] [stdout] ... [INFO] [stdout] 722 | return self.validate_plan(LogAction::InsertIndex(record), log) [INFO] [stdout] 723 ~ }}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:777:9 [INFO] [stdout] | [INFO] [stdout] 777 | if let Ok(value) = self.compression.decompress(&value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^----------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:779:6 [INFO] [stdout] | [INFO] [stdout] 779 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 777 ~ match self.compression.decompress(&value) { Ok(value) => { [INFO] [stdout] 778 | value [INFO] [stdout] 779 ~ } _ => { [INFO] [stdout] 780 | return false [INFO] [stdout] 781 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:840:28 [INFO] [stdout] | [INFO] [stdout] 840 | let value_entry = if let Error::Corruption(_) = &e { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:842:7 [INFO] [stdout] | [INFO] [stdout] 842 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 840 ~ let value_entry = match &e { Error::Corruption(_) => { [INFO] [stdout] 841 | tables.value[size_tier as usize].dump_entry(offset).ok() [INFO] [stdout] 842 ~ } _ => { [INFO] [stdout] 843 | None [INFO] [stdout] 844 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/column.rs:918:27 [INFO] [stdout] | [INFO] [stdout] 918 | let value_entry = if let Error::Corruption(_) = &e { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/column.rs:920:6 [INFO] [stdout] | [INFO] [stdout] 920 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 918 ~ let value_entry = match &e { Error::Corruption(_) => { [INFO] [stdout] 919 | tables.value[size_tier as usize].dump_entry(offset).ok() [INFO] [stdout] 920 ~ } _ => { [INFO] [stdout] 921 | None [INFO] [stdout] 922 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:359:7 [INFO] [stdout] | [INFO] [stdout] 359 | if let Some(err) = &*bg_err { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:361:4 [INFO] [stdout] | [INFO] [stdout] 361 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 359 ~ match &*bg_err { Some(err) => { [INFO] [stdout] 360 | return Err(Error::Background(err.clone())) [INFO] [stdout] 361 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:417:7 [INFO] [stdout] | [INFO] [stdout] 417 | if let Some(commit) = queue.commits.pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:436:4 [INFO] [stdout] | [INFO] [stdout] 436 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 417 ~ match queue.commits.pop_front() { Some(commit) => { [INFO] [stdout] 418 | queue.bytes -= commit.bytes; [INFO] [stdout] ... [INFO] [stdout] 435 | Some(commit) [INFO] [stdout] 436 ~ } _ => { [INFO] [stdout] 437 | None [INFO] [stdout] 438 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:441:6 [INFO] [stdout] | [INFO] [stdout] 441 | if let Some(mut commit) = commit { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:512:3 [INFO] [stdout] | [INFO] [stdout] 512 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 441 ~ match commit { Some(mut commit) => { [INFO] [stdout] 442 | let mut reindex = false; [INFO] [stdout] ... [INFO] [stdout] 511 | Ok(true) [INFO] [stdout] 512 ~ } _ => { [INFO] [stdout] 513 | Ok(false) [INFO] [stdout] 514 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:540:9 [INFO] [stdout] | [INFO] [stdout] 540 | if let PlanOutcome::NeedReindex = [INFO] [stdout] | ________________________^ [INFO] [stdout] 541 | | column.write_reindex_plan(&key, address, &mut writer)? [INFO] [stdout] | |_________________________-----------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:544:6 [INFO] [stdout] | [INFO] [stdout] 544 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 540 ~ match column.write_reindex_plan(&key, address, &mut writer)? [INFO] [stdout] 541 ~ { PlanOutcome::NeedReindex => { [INFO] [stdout] 542 | next_reindex = true [INFO] [stdout] 543 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:584:7 [INFO] [stdout] | [INFO] [stdout] 584 | if let Some(mut reader) = reader { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:700:4 [INFO] [stdout] | [INFO] [stdout] 700 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 584 ~ match reader { Some(mut reader) => { [INFO] [stdout] 585 | log::debug!( [INFO] [stdout] ... [INFO] [stdout] 699 | Some((record_id, cleared, bytes)) [INFO] [stdout] 700 ~ } _ => { [INFO] [stdout] 701 | log::debug!(target: "parity-db", "End of log"); [INFO] [stdout] 702 | None [INFO] [stdout] 703 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:621:12 [INFO] [stdout] | [INFO] [stdout] 621 | ... if let Err(e) = self.columns.get(col).map_or_else( [INFO] [stdout] | __________________________^ - [INFO] [stdout] | |_______________________________________| [INFO] [stdout] 622 | || ... || Err(Error::Corruption(format!("Invalid column id {col}"))), [INFO] [stdout] 623 | || ... |col| { [INFO] [stdout] 624 | || ... col.validate_plan( [INFO] [stdout] ... || [INFO] [stdout] 628 | || ... }, [INFO] [stdout] 629 | || ... ) { [INFO] [stdout] | ||_______________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |_______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:634:9 [INFO] [stdout] | [INFO] [stdout] 634 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 621 ~ match self.columns.get(col).map_or_else( [INFO] [stdout] 622 | || Err(Error::Corruption(format!("Invalid column id {col}"))), [INFO] [stdout] ... [INFO] [stdout] 628 | }, [INFO] [stdout] 629 ~ ) { Err(e) => { [INFO] [stdout] 630 | log::warn!(target: "parity-db", "Error validating log: {:?}.", e); [INFO] [stdout] ... [INFO] [stdout] 633 | return Ok(false) [INFO] [stdout] 634 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:638:12 [INFO] [stdout] | [INFO] [stdout] 638 | ... if let Err(e) = self.columns.get(col).map_or_else( [INFO] [stdout] | __________________________^ - [INFO] [stdout] | |_______________________________________| [INFO] [stdout] 639 | || ... || Err(Error::Corruption(format!("Invalid column id {col}"))), [INFO] [stdout] 640 | || ... |col| { [INFO] [stdout] 641 | || ... col.validate_plan( [INFO] [stdout] ... || [INFO] [stdout] 645 | || ... }, [INFO] [stdout] 646 | || ... ) { [INFO] [stdout] | ||_______________________^ this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | |_______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:651:9 [INFO] [stdout] | [INFO] [stdout] 651 | ... } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 638 ~ match self.columns.get(col).map_or_else( [INFO] [stdout] 639 | || Err(Error::Corruption(format!("Invalid column id {col}"))), [INFO] [stdout] ... [INFO] [stdout] 645 | }, [INFO] [stdout] 646 ~ ) { Err(e) => { [INFO] [stdout] 647 | log::warn!(target: "parity-db", "Error validating log: {:?}.", e); [INFO] [stdout] ... [INFO] [stdout] 650 | return Ok(false) [INFO] [stdout] 651 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:780:9 [INFO] [stdout] | [INFO] [stdout] 780 | while let Some(id) = self.log.replay_next()? { [INFO] [stdout] | ^^^^^^^^^^^^^^^----------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:783:3 [INFO] [stdout] | [INFO] [stdout] 783 | } [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:804:7 [INFO] [stdout] | [INFO] [stdout] 804 | if let Some(err) = self.bg_err.lock().as_ref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^------------------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:810:4 [INFO] [stdout] | [INFO] [stdout] 810 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 804 ~ match self.bg_err.lock().as_ref() { Some(err) => { [INFO] [stdout] 805 | // On error the log reader may be left in inconsistent state. So it is important [INFO] [stdout] ... [INFO] [stdout] 809 | return Ok(()) [INFO] [stdout] 810 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:828:9 [INFO] [stdout] | [INFO] [stdout] 828 | if let Err(e) = self.write_stats_text(&mut writer, None) { [INFO] [stdout] | ^^^^^^^^^^^^^---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:830:6 [INFO] [stdout] | [INFO] [stdout] 830 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 828 ~ match self.write_stats_text(&mut writer, None) { Err(e) => { [INFO] [stdout] 829 | log::warn!(target: "parity-db", "Error writing stats file: {:?}", e) [INFO] [stdout] 830 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:865:6 [INFO] [stdout] | [INFO] [stdout] 865 | if let Err(e) = result { [INFO] [stdout] | ^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:873:3 [INFO] [stdout] | [INFO] [stdout] 873 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 865 ~ match result { Err(e) => { [INFO] [stdout] 866 | log::warn!(target: "parity-db", "Background worker error: {}", e); [INFO] [stdout] ... [INFO] [stdout] 872 | self.commit_queue_full_cv.notify_all(); [INFO] [stdout] 873 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:931:6 [INFO] [stdout] | [INFO] [stdout] 931 | if let Err(e) = db.replay_all_logs() { [INFO] [stdout] | ^^^^^^^^^^^^^-------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:934:3 [INFO] [stdout] | [INFO] [stdout] 934 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 931 ~ match db.replay_all_logs() { Err(e) => { [INFO] [stdout] 932 | log::debug!(target: "parity-db", "Error during log replay."); [INFO] [stdout] 933 | return Err(e) [INFO] [stdout] 934 ~ } _ => { [INFO] [stdout] 935 | db.log.clear_replay_logs(); [INFO] [stdout] 936 | db.clean_all_logs()?; [INFO] [stdout] 937 | db.log.kill_logs()?; [INFO] [stdout] 938 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:1237:7 [INFO] [stdout] | [INFO] [stdout] 1237 | if let Err(e) = t.join() { [INFO] [stdout] | ^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:1239:4 [INFO] [stdout] | [INFO] [stdout] 1239 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1237 ~ match t.join() { Err(e) => { [INFO] [stdout] 1238 | log::warn!(target: "parity-db", "Log thread shutdown error: {:?}", e); [INFO] [stdout] 1239 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:1242:7 [INFO] [stdout] | [INFO] [stdout] 1242 | if let Err(e) = t.join() { [INFO] [stdout] | ^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:1244:4 [INFO] [stdout] | [INFO] [stdout] 1244 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1242 ~ match t.join() { Err(e) => { [INFO] [stdout] 1243 | log::warn!(target: "parity-db", "Flush thread shutdown error: {:?}", e); [INFO] [stdout] 1244 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:1247:7 [INFO] [stdout] | [INFO] [stdout] 1247 | if let Err(e) = t.join() { [INFO] [stdout] | ^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:1249:4 [INFO] [stdout] | [INFO] [stdout] 1249 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1247 ~ match t.join() { Err(e) => { [INFO] [stdout] 1248 | log::warn!(target: "parity-db", "Commit thread shutdown error: {:?}", e); [INFO] [stdout] 1249 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:1252:7 [INFO] [stdout] | [INFO] [stdout] 1252 | if let Err(e) = t.join() { [INFO] [stdout] | ^^^^^^^^^^^^^-------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:1254:4 [INFO] [stdout] | [INFO] [stdout] 1254 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1252 ~ match t.join() { Err(e) => { [INFO] [stdout] 1253 | log::warn!(target: "parity-db", "Cleanup thread shutdown error: {:?}", e); [INFO] [stdout] 1254 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:1259:6 [INFO] [stdout] | [INFO] [stdout] 1259 | if let Err(e) = self.inner.lock_file.unlock() { [INFO] [stdout] | ^^^^^^^^^^^^^----------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:1261:3 [INFO] [stdout] | [INFO] [stdout] 1261 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1259 ~ match self.inner.lock_file.unlock() { Err(e) => { [INFO] [stdout] 1260 | log::debug!(target: "parity-db", "Error removing file lock: {:?}", e); [INFO] [stdout] 1261 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:1510:9 [INFO] [stdout] | [INFO] [stdout] 1510 | if let Entry::Occupied(e) = overlay.indexed.entry(*k) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^---------------^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:1514:6 [INFO] [stdout] | [INFO] [stdout] 1514 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1510 ~ match overlay.indexed.entry(*k) { Entry::Occupied(e) => { [INFO] [stdout] 1511 | if e.get().0 == record_id { [INFO] [stdout] 1512 | e.remove_entry(); [INFO] [stdout] 1513 | } [INFO] [stdout] 1514 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/db.rs:1645:9 [INFO] [stdout] | [INFO] [stdout] 1645 | if let Some(overlay) = db.commit_overlay.read().get(col as usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^------------------------^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/db.rs:1661:6 [INFO] [stdout] | [INFO] [stdout] 1661 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1645 ~ match db.commit_overlay.read().get(col as usize) { Some(overlay) => { [INFO] [stdout] 1646 | if !overlay.is_empty() { [INFO] [stdout] ... [INFO] [stdout] 1660 | } [INFO] [stdout] 1661 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/index.rs:235:6 [INFO] [stdout] | [INFO] [stdout] 235 | if let Some(map) = &*self.map.read() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^---------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/index.rs:239:3 [INFO] [stdout] | [INFO] [stdout] 239 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 235 ~ match &*self.map.read() { Some(map) => { [INFO] [stdout] 236 | Ok(ColumnStats::from_slice(try_io!(Ok( [INFO] [stdout] 237 | &map[HEADER_SIZE..HEADER_SIZE + stats::TOTAL_SIZE] [INFO] [stdout] 238 | )))) [INFO] [stdout] 239 ~ } _ => { [INFO] [stdout] 240 | Ok(ColumnStats::empty()) [INFO] [stdout] 241 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/log.rs:570:7 [INFO] [stdout] | [INFO] [stdout] 570 | if let Some(name) = entry.file_name().as_os_str().to_str() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^-----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/log.rs:588:4 [INFO] [stdout] | [INFO] [stdout] 588 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 570 ~ match entry.file_name().as_os_str().to_str() { Some(name) => { [INFO] [stdout] 571 | if try_io!(entry.metadata()).is_file() && name.starts_with("log") { [INFO] [stdout] ... [INFO] [stdout] 587 | } [INFO] [stdout] 588 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/log.rs:682:24 [INFO] [stdout] | [INFO] [stdout] 682 | let (id, file) = if let Some((id, file)) = self.log_pool.write().pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^--------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/log.rs:685:4 [INFO] [stdout] | [INFO] [stdout] 685 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 682 ~ let (id, file) = match self.log_pool.write().pop_front() { Some((id, file)) => { [INFO] [stdout] 683 | log::debug!(target: "parity-db", "Flush: Activated pool writer {}", id); [INFO] [stdout] 684 | (id, file) [INFO] [stdout] 685 ~ } _ => { [INFO] [stdout] 686 | // find a free id [INFO] [stdout] ... [INFO] [stdout] 695 | (id, file) [INFO] [stdout] 696 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/log.rs:732:7 [INFO] [stdout] | [INFO] [stdout] 732 | if let Some(ref mut overlay) = overlays.index.get_mut(table.log_index()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/log.rs:738:4 [INFO] [stdout] | [INFO] [stdout] 738 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 732 ~ match overlays.index.get_mut(table.log_index()) { Some(ref mut overlay) => { [INFO] [stdout] 733 | if let std::collections::hash_map::Entry::Occupied(e) = overlay.map.entry(index) { [INFO] [stdout] ... [INFO] [stdout] 737 | } [INFO] [stdout] 738 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/log.rs:741:7 [INFO] [stdout] | [INFO] [stdout] 741 | if let Some(ref mut overlay) = overlays.value.get_mut(table.log_index()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/log.rs:747:4 [INFO] [stdout] | [INFO] [stdout] 747 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 741 ~ match overlays.value.get_mut(table.log_index()) { Some(ref mut overlay) => { [INFO] [stdout] 742 | if let std::collections::hash_map::Entry::Occupied(e) = overlay.map.entry(index) { [INFO] [stdout] ... [INFO] [stdout] 746 | } [INFO] [stdout] 747 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/log.rs:797:7 [INFO] [stdout] | [INFO] [stdout] 797 | if let Some(reading) = reading.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/log.rs:801:4 [INFO] [stdout] | [INFO] [stdout] 801 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 797 ~ match reading.take() { Some(reading) => { [INFO] [stdout] 798 | log::debug!(target: "parity-db", "Replay: Activated log cleanup {}", reading.id); [INFO] [stdout] 799 | let file = reading.file.into_inner(); [INFO] [stdout] 800 | self.cleanup_queue.write().push_back((reading.id, file)); [INFO] [stdout] 801 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/log.rs:803:6 [INFO] [stdout] | [INFO] [stdout] 803 | if let Some((id, _record_id, file)) = self.replay_queue.write().pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/log.rs:807:3 [INFO] [stdout] | [INFO] [stdout] 807 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 803 ~ match self.replay_queue.write().pop_front() { Some((id, _record_id, file)) => { [INFO] [stdout] 804 | log::debug!(target: "parity-db", "Replay: Activated log reader {}", id); [INFO] [stdout] 805 | *reading = Some(Reading { id, file: std::io::BufReader::new(file) }); [INFO] [stdout] 806 | Ok(Some(id)) [INFO] [stdout] 807 ~ } _ => { [INFO] [stdout] 808 | Ok(None) [INFO] [stdout] 809 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/log.rs:846:7 [INFO] [stdout] | [INFO] [stdout] 846 | if let Some((id, mut file)) = self.read_queue.write().pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/log.rs:849:4 [INFO] [stdout] | [INFO] [stdout] 849 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 846 ~ match self.read_queue.write().pop_front() { Some((id, mut file)) => { [INFO] [stdout] 847 | try_io!(file.rewind()); [INFO] [stdout] 848 | *reading = Some(Reading { id, file: std::io::BufReader::new(file) }); [INFO] [stdout] 849 ~ } _ => { [INFO] [stdout] 850 | log::trace!(target: "parity-db", "No active reader"); [INFO] [stdout] 851 | return Ok(None) [INFO] [stdout] 852 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/migration.rs:182:6 [INFO] [stdout] | [INFO] [stdout] 182 | if let Some(file) = entry.path().file_name().and_then(|f| f.to_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^-----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/migration.rs:196:3 [INFO] [stdout] | [INFO] [stdout] 196 | } [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 182 ~ match entry.path().file_name().and_then(|f| f.to_str()) { Some(file) => { [INFO] [stdout] 183 | if crate::index::TableId::is_file_name(c, file) || [INFO] [stdout] ... [INFO] [stdout] 195 | } [INFO] [stdout] 196 ~ } _ => {}} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/table.rs:475:36 [INFO] [stdout] | [INFO] [stdout] 475 | let buf: LockedSlice<_, _> = if let Some(buf) = vbuf.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/table.rs:483:4 [INFO] [stdout] | [INFO] [stdout] 483 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 475 ~ let buf: LockedSlice<_, _> = match vbuf.as_deref() { Some(buf) => { [INFO] [stdout] 476 | log::trace!( [INFO] [stdout] ... [INFO] [stdout] 482 | LockedSlice::FromOverlay(buf) [INFO] [stdout] 483 ~ } _ => { [INFO] [stdout] 484 | log::trace!( [INFO] [stdout] ... [INFO] [stdout] 491 | LockedSlice::FromFile(vbuf) [INFO] [stdout] 492 ~ }}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/table.rs:572:6 [INFO] [stdout] | [INFO] [stdout] 572 | if let Some((value, compressed, _)) = [INFO] [stdout] | ____________^ [INFO] [stdout] 573 | | self.query(&mut TableKeyQuery::Check(key), index, log)? [INFO] [stdout] | |_____________------------------------------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/table.rs:576:3 [INFO] [stdout] | [INFO] [stdout] 576 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 572 ~ match self.query(&mut TableKeyQuery::Check(key), index, log)? [INFO] [stdout] 573 ~ { Some((value, compressed, _)) => { [INFO] [stdout] 574 | Ok(Some((value, compressed))) [INFO] [stdout] 575 ~ } _ => { [INFO] [stdout] 576 | Ok(None) [INFO] [stdout] 577 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 61 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 18.79s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking parity-db v0.4.13 (/tmp/fixit) [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/db.rs:2078:33 [INFO] [stdout] | [INFO] [stdout] 2078 | let mut prev_run: bool = rng.gen(); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 2078 | let mut prev_run: bool = rng.r#gen(); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/db.rs:2078:33 [INFO] [stdout] | [INFO] [stdout] 2078 | let mut prev_run: bool = rng.gen(); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 2078 | let mut prev_run: bool = rng.r#gen(); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/index.rs:684:18 [INFO] [stdout] | [INFO] [stdout] 684 | keys[i] = rng.gen(); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 684 | keys[i] = rng.r#gen(); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/index.rs:684:18 [INFO] [stdout] | [INFO] [stdout] 684 | keys[i] = rng.gen(); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 684 | keys[i] = rng.r#gen(); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/index.rs:768:18 [INFO] [stdout] | [INFO] [stdout] 768 | keys[i] = rng.gen(); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 768 | keys[i] = rng.r#gen(); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/index.rs:768:18 [INFO] [stdout] | [INFO] [stdout] 768 | keys[i] = rng.gen(); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 768 | keys[i] = rng.r#gen(); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/options.rs:218:65 [INFO] [stdout] | [INFO] [stdout] 218 | let s: Salt = self.salt.unwrap_or_else(|| rand::thread_rng().gen()); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 218 | let s: Salt = self.salt.unwrap_or_else(|| rand::thread_rng().r#gen()); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: expected identifier, found reserved keyword `gen` [INFO] [stdout] --> src/options.rs:218:65 [INFO] [stdout] | [INFO] [stdout] 218 | let s: Salt = self.salt.unwrap_or_else(|| rand::thread_rng().gen()); [INFO] [stdout] | ^^^ expected identifier, found reserved keyword [INFO] [stdout] | [INFO] [stdout] help: escape `gen` to use it as an identifier [INFO] [stdout] | [INFO] [stdout] 218 | let s: Salt = self.salt.unwrap_or_else(|| rand::thread_rng().r#gen()); [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parity-db` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parity-db` (lib test) due to 5 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "02c525e14dfbf0f8dff310ab03a2638b473bae8dd090e084b4e5dd1ec6032bbf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "02c525e14dfbf0f8dff310ab03a2638b473bae8dd090e084b4e5dd1ec6032bbf", kill_on_drop: false }` [INFO] [stdout] 02c525e14dfbf0f8dff310ab03a2638b473bae8dd090e084b4e5dd1ec6032bbf