[INFO] fetching crate pallas-hardano 0.30.2... [INFO] checking pallas-hardano-0.30.2 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate pallas-hardano 0.30.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate pallas-hardano 0.30.2 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pallas-hardano 0.30.2 [INFO] finished tweaking crates.io crate pallas-hardano 0.30.2 [INFO] tweaked toml for crates.io crate pallas-hardano 0.30.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 86 packages to latest compatible versions [INFO] [stderr] Adding bech32 v0.9.1 (available: v0.11.0) [INFO] [stderr] Adding binary-layout v3.3.0 (available: v4.0.2) [INFO] [stderr] Adding half v1.8.3 (available: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding minicbor v0.20.0 (available: v0.25.1) [INFO] [stderr] Adding minicbor-derive v0.13.0 (available: v0.15.3) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (available: v0.50.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3e57f0967f1698bad773abeb521be3bc17124dd2f57573cb391e8c794c042c8b [INFO] running `Command { std: "docker" "start" "-a" "3e57f0967f1698bad773abeb521be3bc17124dd2f57573cb391e8c794c042c8b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3e57f0967f1698bad773abeb521be3bc17124dd2f57573cb391e8c794c042c8b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e57f0967f1698bad773abeb521be3bc17124dd2f57573cb391e8c794c042c8b", kill_on_drop: false }` [INFO] [stdout] 3e57f0967f1698bad773abeb521be3bc17124dd2f57573cb391e8c794c042c8b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b4a21d80b0b4231528e445190478b53a3435179bb9ff8ebbecebe71a87f82d07 [INFO] running `Command { std: "docker" "start" "-a" "b4a21d80b0b4231528e445190478b53a3435179bb9ff8ebbecebe71a87f82d07", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling minicbor v0.20.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking cryptoxide v0.4.4 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling minicbor-derive v0.13.0 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Checking base58 v0.2.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking binary-layout v3.3.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking pallas-codec v0.30.2 [INFO] [stderr] Checking pallas-crypto v0.30.2 [INFO] [stderr] Checking pallas-primitives v0.30.2 [INFO] [stderr] Checking pallas-addresses v0.30.2 [INFO] [stderr] Checking pallas-network v0.30.2 [INFO] [stderr] Checking pallas-traverse v0.30.2 [INFO] [stderr] Checking pallas-hardano v0.30.2 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/storage/immutable/mod.rs (2 fixes) [INFO] [stdout] warning: `impl Iterator, chunk::Error>>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/storage/immutable/mod.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | ) -> Result, Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/storage/immutable/mod.rs:88:17 [INFO] [stdout] | [INFO] [stdout] 88 | block_hash: &[u8], [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed src/storage/immutable/mod.rs (1 fix) [INFO] [stdout] warning: `impl Iterator, chunk::Error>>` will capture more lifetimes than possibly intended in edition 2024 [INFO] [stdout] --> src/storage/immutable/mod.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | ) -> Result, Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] note: specifically, this lifetime is in scope but not mentioned in the type's bounds [INFO] [stdout] --> src/storage/immutable/mod.rs:88:17 [INFO] [stdout] | [INFO] [stdout] 88 | block_hash: &[u8], [INFO] [stdout] | ^ [INFO] [stdout] = note: all lifetimes in scope will be captured by `impl Trait`s in edition 2024 [INFO] [stdout] = note: `--force-warn impl-trait-overcaptures` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/storage/immutable/primary.rs:190:15 [INFO] [stdout] | [INFO] [stdout] 190 | while let Some(entry) = reader.next_occupied() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^---------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/storage/immutable/primary.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 194 | } [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.50s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking pallas-hardano v0.30.2 (/tmp/fixit) [INFO] [stdout] error[E0515]: cannot return value referencing local variable `block_hash` [INFO] [stdout] --> src/storage/immutable/mod.rs:300:13 [INFO] [stdout] | [INFO] [stdout] 300 | Ok(iterate_till_point(iter, slot, block_hash.as_slice()).map(Box::new)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `block_hash` is borrowed here [INFO] [stdout] | returns a value referencing data owned by the current function [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0515`. [INFO] [stdout] [INFO] [stderr] error: could not compile `pallas-hardano` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error[E0515]: cannot return value referencing local variable `block_hash` [INFO] [stdout] --> src/storage/immutable/mod.rs:300:13 [INFO] [stdout] | [INFO] [stdout] 300 | Ok(iterate_till_point(iter, slot, block_hash.as_slice()).map(Box::new)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `block_hash` is borrowed here [INFO] [stdout] | returns a value referencing data owned by the current function [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0716]: temporary value dropped while borrowed [INFO] [stdout] --> src/storage/immutable/mod.rs:406:13 [INFO] [stdout] | [INFO] [stdout] 406 | / hex::decode("3dcf4b00e32099b20c598fd90aed0060e77b1899e58645b9fe7b95a7ca9b306c") [INFO] [stdout] 407 | | .unwrap() [INFO] [stdout] | |_________________________^ creates a temporary value which is freed while still in use [INFO] [stdout] ... [INFO] [stdout] 410 | .unwrap(); [INFO] [stdout] | - temporary value is freed at the end of this statement [INFO] [stdout] 411 | let block = reader.next().unwrap().unwrap(); [INFO] [stdout] | ------ borrow later used here [INFO] [stdout] | [INFO] [stdout] help: consider using a `let` binding to create a longer lived value [INFO] [stdout] | [INFO] [stdout] 403 ~ let binding = hex::decode("3dcf4b00e32099b20c598fd90aed0060e77b1899e58645b9fe7b95a7ca9b306c") [INFO] [stdout] 404 + .unwrap(); [INFO] [stdout] 405 ~ let mut reader = iterate_till_point( [INFO] [stdout] 406 | reader, [INFO] [stdout] 407 | 27756199, [INFO] [stdout] 408 ~ binding [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] Some errors have detailed explanations: E0515, E0716. [INFO] [stdout] [INFO] [stdout] For more information about an error, try `rustc --explain E0515`. [INFO] [stdout] [INFO] [stderr] error: could not compile `pallas-hardano` (lib test) due to 3 previous errors [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "b4a21d80b0b4231528e445190478b53a3435179bb9ff8ebbecebe71a87f82d07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b4a21d80b0b4231528e445190478b53a3435179bb9ff8ebbecebe71a87f82d07", kill_on_drop: false }` [INFO] [stdout] b4a21d80b0b4231528e445190478b53a3435179bb9ff8ebbecebe71a87f82d07