[INFO] fetching crate oni-comb-parser-rs 0.0.558... [INFO] checking oni-comb-parser-rs-0.0.558 against try#ccf408f4326a858c00dd845a64a86b16f360a801 for pr-129466-2 [INFO] extracting crate oni-comb-parser-rs 0.0.558 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate oni-comb-parser-rs 0.0.558 on toolchain ccf408f4326a858c00dd845a64a86b16f360a801 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate oni-comb-parser-rs 0.0.558 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate oni-comb-parser-rs 0.0.558 [INFO] tweaked toml for crates.io crate oni-comb-parser-rs 0.0.558 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate oni-comb-parser-rs 0.0.558 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ff4c2f113a6c1766893ad5dbacf1864b545f0295f53e848cf4667e1f1bda5cff [INFO] running `Command { std: "docker" "start" "-a" "ff4c2f113a6c1766893ad5dbacf1864b545f0295f53e848cf4667e1f1bda5cff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ff4c2f113a6c1766893ad5dbacf1864b545f0295f53e848cf4667e1f1bda5cff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff4c2f113a6c1766893ad5dbacf1864b545f0295f53e848cf4667e1f1bda5cff", kill_on_drop: false }` [INFO] [stdout] ff4c2f113a6c1766893ad5dbacf1864b545f0295f53e848cf4667e1f1bda5cff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+ccf408f4326a858c00dd845a64a86b16f360a801" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aa98156642f44919a69d2ecc43c372f21066c14b210a770e6497195e03d14274 [INFO] running `Command { std: "docker" "start" "-a" "aa98156642f44919a69d2ecc43c372f21066c14b210a770e6497195e03d14274", kill_on_drop: false }` [INFO] [stderr] Copying to /tmp/fixit [INFO] [stderr] Running `cargo fix --edition` [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling cpp_demangle v0.4.4 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling cc v1.1.19 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking clap_builder v4.5.17 [INFO] [stderr] Compiling bigdecimal v0.4.5 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling symbolic-demangle v12.11.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking debugid v0.8.0 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking gimli v0.31.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling anyhow v1.0.89 [INFO] [stderr] Checking rgb v0.8.50 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking num-format v0.4.4 [INFO] [stderr] Checking quick-xml v0.26.0 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Compiling pprof v0.13.0 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Compiling rust_decimal v1.36.0 [INFO] [stderr] Checking str_stack v0.1.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking iso-4217 v0.1.0 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling findshlibs v0.10.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking memmap2 v0.9.5 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking clap v4.5.17 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking symbolic-common v12.11.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking addr2line v0.24.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling ctor v0.2.8 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking oni-comb-parser-rs v0.0.558 (/tmp/fixit) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking pom v3.4.0 [INFO] [stderr] Checking inferno v0.11.21 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `oni_comb_parser_rs` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/utils/set.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/utils/set.rs:79:6 [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/utils/set.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | ( $($n:expr),+ ) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 79 | ( $($n:expr_2021),+ ) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] | [INFO] [stderr] 79 | ( $($n:expr_2021),+ ) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/internal/parsers_impl/elements_parsers_impl.rs:93:10 [INFO] [stdout] | [INFO] [stdout] 93 | if let Some(captures) = regex.captures(&str).as_ref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^--------------------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/internal/parsers_impl/elements_parsers_impl.rs:102:7 [INFO] [stdout] | [INFO] [stdout] 102 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 93 ~ match regex.captures(&str).as_ref() { Some(captures) => { [INFO] [stdout] 94 | if let Some(m) = captures.get(0) { [INFO] [stdout] ... [INFO] [stdout] 101 | } [INFO] [stdout] 102 ~ } _ => { [INFO] [stdout] 103 | return ParseResult::failed_with_uncommitted(ParseError::of_in_complete()); [INFO] [stdout] 104 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/internal/parsers_impl/repeat_parsers_impl.rs:41:16 [INFO] [stdout] | [INFO] [stdout] 41 | if let ParseResult::Success { length, .. } = sep.run(¤t_parse_state) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/internal/parsers_impl/repeat_parsers_impl.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 41 ~ match sep.run(¤t_parse_state) { ParseResult::Success { length, .. } => { [INFO] [stdout] 42 | current_parse_state = current_parse_state.add_offset(length); [INFO] [stdout] 43 | all_length += length; [INFO] [stdout] 44 ~ } _ => { [INFO] [stdout] 45 | break; [INFO] [stdout] 46 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/internal/parsers_impl/repeat_parsers_impl.rs:48:14 [INFO] [stdout] | [INFO] [stdout] 48 | if let ParseResult::Success { value, length } = parser.run(¤t_parse_state) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/internal/parsers_impl/repeat_parsers_impl.rs:52:11 [INFO] [stdout] | [INFO] [stdout] 52 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 48 ~ match parser.run(¤t_parse_state) { ParseResult::Success { value, length } => { [INFO] [stdout] 49 | current_parse_state = current_parse_state.add_offset(length); [INFO] [stdout] 50 | items.push(value); [INFO] [stdout] 51 | all_length += length; [INFO] [stdout] 52 ~ } _ => { [INFO] [stdout] 53 | break; [INFO] [stdout] 54 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking prop-check-rs v0.0.699 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Migrating benches/nom_json.rs from 2021 edition to 2024 [INFO] [stdout] warning: function `sp` is never used [INFO] [stdout] --> benches/nom_json.rs:30:4 [INFO] [stdout] | [INFO] [stdout] 30 | fn sp<'a, E: ParseError<&'a str>>(i: &'a str) -> IResult<&'a str, &'a str, E> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating benches/oni_comb_json.rs from 2021 edition to 2024 [INFO] [stdout] warning: function `parse_str` is never used [INFO] [stdout] --> benches/nom_json.rs:53:4 [INFO] [stdout] | [INFO] [stdout] 53 | fn parse_str<'a, E: ParseError<&'a str>>(i: &'a str) -> IResult<&'a str, &'a str, E> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `null` is never used [INFO] [stdout] --> benches/nom_json.rs:79:4 [INFO] [stdout] | [INFO] [stdout] 79 | fn null<'a, E: ParseError<&'a str>>(input: &'a str) -> IResult<&'a str, (), E> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `string` is never used [INFO] [stdout] --> benches/nom_json.rs:94:4 [INFO] [stdout] | [INFO] [stdout] 94 | fn string<'a, E: ParseError<&'a str> + ContextError<&'a str>>(i: &'a str) -> IResult<&'a str, &'a str, E> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `array` is never used [INFO] [stdout] --> benches/nom_json.rs:102:4 [INFO] [stdout] | [INFO] [stdout] 102 | fn array<'a, E: ParseError<&'a str> + ContextError<&'a str>>(i: &'a str) -> IResult<&'a str, Vec, E> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `key_value` is never used [INFO] [stdout] --> benches/nom_json.rs:115:4 [INFO] [stdout] | [INFO] [stdout] 115 | fn key_value<'a, E: ParseError<&'a str> + ContextError<&'a str>>( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `hash` is never used [INFO] [stdout] --> benches/nom_json.rs:121:4 [INFO] [stdout] | [INFO] [stdout] 121 | fn hash<'a, E: ParseError<&'a str> + ContextError<&'a str>>( [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `json_value` is never used [INFO] [stdout] --> benches/nom_json.rs:139:4 [INFO] [stdout] | [INFO] [stdout] 139 | fn json_value<'a, E: ParseError<&'a str> + ContextError<&'a str>>(i: &'a str) -> IResult<&'a str, JsonValue, E> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `root` is never used [INFO] [stdout] --> benches/nom_json.rs:154:4 [INFO] [stdout] | [INFO] [stdout] 154 | fn root<'a, E: ParseError<&'a str> + ContextError<&'a str>>(i: &'a str) -> IResult<&'a str, JsonValue, E> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/json_char.rs from 2021 edition to 2024 [INFO] [stderr] Migrating benches/bench_main.rs from 2021 edition to 2024 [INFO] [stderr] warning: failed to automatically apply fixes suggested by rustc to crate `oni_comb_parser_rs` [INFO] [stderr] [INFO] [stderr] after fixes were automatically applied the compiler reported errors within these files: [INFO] [stderr] [INFO] [stderr] * src/utils/set.rs [INFO] [stderr] [INFO] [stderr] This likely indicates a bug in either rustc or cargo itself, [INFO] [stderr] and we would appreciate a bug report! You're likely to see [INFO] [stderr] a number of compiler warnings after this message which cargo [INFO] [stderr] attempted to fix but failed. If you could open an issue at [INFO] [stderr] https://github.com/rust-lang/rust/issues [INFO] [stderr] quoting the full output of this command we'd be very appreciative! [INFO] [stderr] Note that you may be able to make some more progress in the near-term [INFO] [stderr] fixing code with the `--broken-code` flag [INFO] [stderr] [INFO] [stderr] The following errors were reported: [INFO] [stderr] error[E0658]: fragment specifier `expr_2021` is unstable [INFO] [stderr] --> src/utils/set.rs:79:6 [INFO] [stderr] | [INFO] [stderr] 79 | ( $($n:expr_2021),+ ) => { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: see issue #123742 for more information [INFO] [stderr] = help: add `#![feature(expr_fragment_specifier_2024)]` to the crate attributes to enable [INFO] [stderr] = note: this compiler was built on 2024-09-17; consider upgrading it if it is out of date [INFO] [stderr] [INFO] [stderr] error: aborting due to 1 previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0658`. [INFO] [stderr] Original diagnostics will follow. [INFO] [stderr] [INFO] [stdout] warning: the `expr` fragment specifier will accept more expressions in the 2024 edition [INFO] [stdout] --> src/utils/set.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | ( $($n:expr),+ ) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see Migration Guide [INFO] [stdout] = note: `--force-warn edition-2024-expr-fragment-specifier` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: to keep the existing behavior, use the `expr_2021` fragment specifier [INFO] [stdout] | [INFO] [stdout] 79 | ( $($n:expr_2021),+ ) => { [INFO] [stdout] | ~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to deprecated safe function `std::env::set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:1548:5 [INFO] [stdout] | [INFO] [stdout] 1548 | env::set_var("RUST_LOG", "debug"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2021) but is a hard error in Rust 2024! [INFO] [stdout] = note: for more information, see issue #27970 [INFO] [stdout] = note: `--force-warn deprecated-safe-2024` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: you can wrap the call in an `unsafe` block if you can guarantee that the environment access only happens in single-threaded code [INFO] [stdout] | [INFO] [stdout] 1548 + // TODO: Audit that the environment access only happens in single-threaded code. [INFO] [stdout] 1549 ~ unsafe { env::set_var("RUST_LOG", "debug") }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/internal/parsers_impl/elements_parsers_impl.rs:93:10 [INFO] [stdout] | [INFO] [stdout] 93 | if let Some(captures) = regex.captures(&str).as_ref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^--------------------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/internal/parsers_impl/elements_parsers_impl.rs:102:7 [INFO] [stdout] | [INFO] [stdout] 102 | } else { [INFO] [stdout] | ^ [INFO] [stdout] = note: `--force-warn if-let-rescope` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 93 ~ match regex.captures(&str).as_ref() { Some(captures) => { [INFO] [stdout] 94 | if let Some(m) = captures.get(0) { [INFO] [stdout] ... [INFO] [stdout] 101 | } [INFO] [stdout] 102 ~ } _ => { [INFO] [stdout] 103 | return ParseResult::failed_with_uncommitted(ParseError::of_in_complete()); [INFO] [stdout] 104 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/internal/parsers_impl/repeat_parsers_impl.rs:41:16 [INFO] [stdout] | [INFO] [stdout] 41 | if let ParseResult::Success { length, .. } = sep.run(¤t_parse_state) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/internal/parsers_impl/repeat_parsers_impl.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 41 ~ match sep.run(¤t_parse_state) { ParseResult::Success { length, .. } => { [INFO] [stdout] 42 | current_parse_state = current_parse_state.add_offset(length); [INFO] [stdout] 43 | all_length += length; [INFO] [stdout] 44 ~ } _ => { [INFO] [stdout] 45 | break; [INFO] [stdout] 46 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/internal/parsers_impl/repeat_parsers_impl.rs:48:14 [INFO] [stdout] | [INFO] [stdout] 48 | if let ParseResult::Success { value, length } = parser.run(¤t_parse_state) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/internal/parsers_impl/repeat_parsers_impl.rs:52:11 [INFO] [stdout] | [INFO] [stdout] 52 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 48 ~ match parser.run(¤t_parse_state) { ParseResult::Success { value, length } => { [INFO] [stdout] 49 | current_parse_state = current_parse_state.add_offset(length); [INFO] [stdout] 50 | items.push(value); [INFO] [stdout] 51 | all_length += length; [INFO] [stdout] 52 ~ } _ => { [INFO] [stdout] 53 | break; [INFO] [stdout] 54 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let` assigns a shorter lifetime since Edition 2024 [INFO] [stdout] --> src/lib.rs:1780:8 [INFO] [stdout] | [INFO] [stdout] 1780 | if let Some(b) = p.parse_as_result(b"abc").unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^-------------------------^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value has a significant drop implementation which may observe a major change in drop order and requires your discretion [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #124085 [INFO] [stdout] help: the value is now dropped here in Edition 2024 [INFO] [stdout] --> src/lib.rs:1782:5 [INFO] [stdout] | [INFO] [stdout] 1782 | } else { [INFO] [stdout] | ^ [INFO] [stdout] help: a `match` with a single arm can preserve the drop order up to Edition 2021 [INFO] [stdout] | [INFO] [stdout] 1780 ~ match p.parse_as_result(b"abc").unwrap() { Some(b) => { [INFO] [stdout] 1781 | assert_eq!(b, b"abc"); [INFO] [stdout] 1782 ~ } _ => { [INFO] [stdout] 1783 | panic!() [INFO] [stdout] 1784 ~ }} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Fixed benches/bench_main.rs (2 fixes) [INFO] [stderr] Migrating examples/hello_world.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/calculator.rs from 2021 edition to 2024 [INFO] [stderr] Fixed examples/calculator.rs (1 fix) [INFO] [stdout] warning: function `add` is never used [INFO] [stdout] --> examples/calculator.rs:47:4 [INFO] [stdout] | [INFO] [stdout] 47 | fn add<'a>() -> Parser<'a, char, &'a char> { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/json_byte.rs from 2021 edition to 2024 [INFO] [stdout] warning: function `sub` is never used [INFO] [stdout] --> examples/calculator.rs:51:4 [INFO] [stdout] | [INFO] [stdout] 51 | fn sub<'a>() -> Parser<'a, char, &'a char> { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mul` is never used [INFO] [stdout] --> examples/calculator.rs:55:4 [INFO] [stdout] | [INFO] [stdout] 55 | fn mul<'a>() -> Parser<'a, char, &'a char> { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `div` is never used [INFO] [stdout] --> examples/calculator.rs:59:4 [INFO] [stdout] | [INFO] [stdout] 59 | fn div<'a>() -> Parser<'a, char, &'a char> { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating benches/pom_json.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.40s [INFO] [stderr] Running `cargo check` to verify 2024 [INFO] [stderr] Checking oni-comb-parser-rs v0.0.558 (/tmp/fixit) [INFO] [stdout] error[E0133]: call to unsafe function `set_var` is unsafe and requires unsafe block [INFO] [stdout] --> src/lib.rs:1548:5 [INFO] [stdout] | [INFO] [stdout] 1548 | env::set_var("RUST_LOG", "debug"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call to unsafe function [INFO] [stdout] | [INFO] [stdout] = note: consult the function's documentation for information on how to avoid undefined behavior [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `add` is never used [INFO] [stdout] --> examples/calculator.rs:47:4 [INFO] [stdout] | [INFO] [stdout] 47 | fn add<'a>() -> Parser<'a, char, &'a char> { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `sub` is never used [INFO] [stdout] --> examples/calculator.rs:51:4 [INFO] [stdout] | [INFO] [stdout] 51 | fn sub<'a>() -> Parser<'a, char, &'a char> { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mul` is never used [INFO] [stdout] --> examples/calculator.rs:55:4 [INFO] [stdout] | [INFO] [stdout] 55 | fn mul<'a>() -> Parser<'a, char, &'a char> { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `div` is never used [INFO] [stdout] --> examples/calculator.rs:59:4 [INFO] [stdout] | [INFO] [stdout] 59 | fn div<'a>() -> Parser<'a, char, &'a char> { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0133`. [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oni-comb-parser-rs` (lib test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `sp` is never used [INFO] [stdout] --> benches/nom_json.rs:30:4 [INFO] [stdout] | [INFO] [stdout] 30 | fn sp<'a, E: ParseError<&'a str>>(i: &'a str) -> IResult<&'a str, &'a str, E> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_str` is never used [INFO] [stdout] --> benches/nom_json.rs:53:4 [INFO] [stdout] | [INFO] [stdout] 53 | fn parse_str<'a, E: ParseError<&'a str>>(i: &'a str) -> IResult<&'a str, &'a str, E> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `null` is never used [INFO] [stdout] --> benches/nom_json.rs:79:4 [INFO] [stdout] | [INFO] [stdout] 79 | fn null<'a, E: ParseError<&'a str>>(input: &'a str) -> IResult<&'a str, (), E> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `string` is never used [INFO] [stdout] --> benches/nom_json.rs:94:4 [INFO] [stdout] | [INFO] [stdout] 94 | fn string<'a, E: ParseError<&'a str> + ContextError<&'a str>>(i: &'a str) -> IResult<&'a str, &'a str, E> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `array` is never used [INFO] [stdout] --> benches/nom_json.rs:102:4 [INFO] [stdout] | [INFO] [stdout] 102 | fn array<'a, E: ParseError<&'a str> + ContextError<&'a str>>(i: &'a str) -> IResult<&'a str, Vec, E> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `key_value` is never used [INFO] [stdout] --> benches/nom_json.rs:115:4 [INFO] [stdout] | [INFO] [stdout] 115 | fn key_value<'a, E: ParseError<&'a str> + ContextError<&'a str>>( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `hash` is never used [INFO] [stdout] --> benches/nom_json.rs:121:4 [INFO] [stdout] | [INFO] [stdout] 121 | fn hash<'a, E: ParseError<&'a str> + ContextError<&'a str>>( [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `json_value` is never used [INFO] [stdout] --> benches/nom_json.rs:139:4 [INFO] [stdout] | [INFO] [stdout] 139 | fn json_value<'a, E: ParseError<&'a str> + ContextError<&'a str>>(i: &'a str) -> IResult<&'a str, JsonValue, E> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `root` is never used [INFO] [stdout] --> benches/nom_json.rs:154:4 [INFO] [stdout] | [INFO] [stdout] 154 | fn root<'a, E: ParseError<&'a str> + ContextError<&'a str>>(i: &'a str) -> IResult<&'a str, JsonValue, E> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: failed to check after updating to 2024 [INFO] [stderr] [INFO] [stderr] Caused by: [INFO] [stderr] process didn't exit successfully: `cargo check --frozen --all --all-targets --message-format=json` (exit status: 101) [INFO] running `Command { std: "docker" "inspect" "aa98156642f44919a69d2ecc43c372f21066c14b210a770e6497195e03d14274", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa98156642f44919a69d2ecc43c372f21066c14b210a770e6497195e03d14274", kill_on_drop: false }` [INFO] [stdout] aa98156642f44919a69d2ecc43c372f21066c14b210a770e6497195e03d14274